start-command 0.22.0 → 0.23.0

package/CHANGELOG.md

@@ -1,5 +1,23 @@
 # start-command
 
+## 0.23.0
+
+### Minor Changes
+
+- b85d3cb: feat: Add shell auto-detection and --shell option for isolation environments
+
+  In docker and ssh isolation environments, the shell is now automatically
+  selected in order of preference: bash, zsh, sh (auto mode). A new `--shell`
+  option allows explicitly specifying the shell to use.
+  - Auto mode (default): probes the environment for the best available shell
+  - `--shell bash/zsh/sh`: forces a specific shell
+  - `--shell auto`: explicitly selects auto-detection mode
+
+  This enables tools like `nvm` to work correctly in Docker containers where
+  bash is available but sh does not source the necessary profile scripts.
+
+  Fixes #79
+
 ## 0.22.0
 
 ### Minor Changes

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "start-command",
-  "version": "0.22.0",
+  "version": "0.23.0",
   "description": "Gamification of coding, execute any command with ability to auto-report issues on GitHub",
   "main": "src/bin/cli.js",
   "exports": {

package/src/bin/cli.js

@@ -331,6 +331,7 @@ Options:
   --keep-user           Keep isolated user after command completes
   --keep-alive, -k      Keep isolation environment alive after command exits
   --auto-remove-docker-container  Auto-remove docker container after exit
+  --shell <shell>       Shell to use in isolation environments: auto, bash, zsh, sh (default: auto)
   --use-command-stream  Use command-stream library for execution (experimental)
   --status <uuid>       Show status of execution by UUID (--output-format: links-notation|json|text)
   --cleanup             Clean up stale "executing" records (crashed/killed processes)
@@ -575,6 +576,7 @@ async function runWithIsolation(
       user: createdUser,
       keepAlive: options.keepAlive,
       autoRemoveDockerContainer: options.autoRemoveDockerContainer,
+      shell: options.shell,
     });
   } else if (createdUser) {
     // Run directly as the created user (no isolation environment)

package/test/isolation.test.js

@@ -824,4 +824,75 @@ describe('detectShellInEnvironment', () => {
     );
     console.log(`  Detected shell in alpine:latest: ${result}`);
   });
+
+  it('should read shell preference from options.shell', () => {
+    // Test that detectShellInEnvironment respects options.shell field
+    const result = detectShellInEnvironment(
+      'docker',
+      { image: 'alpine:latest', shell: 'bash' },
+      'bash'
+    );
+    assert.strictEqual(result, 'bash');
+  });
+});
+
+describe('Shell option forwarding to isolation runners', () => {
+  // These tests verify that the shell option is properly forwarded
+  // through the call chain: cli.js -> runIsolated -> runInDocker/runInSsh
+
+  const { runInDocker, runInSsh } = require('../src/lib/isolation');
+
+  describe('runInDocker shell option', () => {
+    it('should accept shell option in options object', async () => {
+      if (!isCommandAvailable('docker')) {
+        console.log('  Skipping: docker not installed');
+        return;
+      }
+
+      // Test with explicit shell option - just verify the option is accepted
+      // and the function runs (it may fail if image is not available)
+      const result = await runInDocker('echo test', {
+        image: 'alpine:latest',
+        detached: true,
+        shell: 'sh',
+      });
+      // If docker is available, verify the result
+      console.log(`  runInDocker with --shell sh result: ${result.success}`);
+      // The result can be success or failure depending on docker availability
+      // The important thing is no crash due to missing shell option
+      assert.ok(typeof result.success === 'boolean');
+    });
+  });
+
+  describe('runInSsh shell option', () => {
+    it('should accept shell option in options object', async () => {
+      // SSH requires endpoint, so without it we get expected error
+      const result = await runInSsh('echo test', {
+        detached: true,
+        shell: 'bash',
+      });
+      assert.strictEqual(result.success, false);
+      // Should fail with endpoint error, not shell option error
+      assert.ok(
+        result.message.includes('endpoint') ||
+          result.message.includes('--endpoint') ||
+          result.message.includes('SSH isolation requires')
+      );
+    });
+
+    it('should use auto mode when shell option is auto', async () => {
+      // Verify auto mode doesn't crash
+      const result = await runInSsh('echo test', {
+        detached: true,
+        shell: 'auto',
+      });
+      assert.strictEqual(result.success, false);
+      // Should fail with endpoint error in auto mode
+      assert.ok(
+        result.message.includes('endpoint') ||
+          result.message.includes('--endpoint') ||
+          result.message.includes('SSH isolation requires')
+      );
+    });
+  });
 });