start-command 0.20.2 → 0.20.4

package/CHANGELOG.md

@@ -1,5 +1,62 @@
 # start-command
 
+## 0.20.4
+
+### Patch Changes
+
+- 688f1f5: fix: Add empty line before result marker for visual continuity
+  - Added empty line before result marker (✓/✗) after command output
+  - Ensures consistent visual formatting: command → empty line → output → empty line → result marker
+  - Applied to both docker pull virtual commands and user commands
+  - Tests document the expected visual format
+
+  Expected format:
+
+  ```
+  │
+  $ docker pull alpine:latest
+
+  latest: Pulling from library/alpine
+  ...
+
+  ✓
+  │
+  $ echo hi
+
+  hi
+
+  ✓
+  ```
+
+  Fixes #73
+
+## 0.20.3
+
+### Patch Changes
+
+- 3598f38: Fix visual continuity in docker isolation mode (#73)
+
+  The empty line is now properly placed after the command line (e.g., `$ docker pull alpine:latest`)
+  instead of before it, maintaining consistent visual structure in the timeline output.
+
+  Before:
+
+  ```
+  │
+
+  $ docker pull alpine:latest
+  latest: Pulling from library/alpine
+  ```
+
+  After:
+
+  ```
+  │
+  $ docker pull alpine:latest
+
+  latest: Pulling from library/alpine
+  ```
+
 ## 0.20.2
 
 ### Patch Changes

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "start-command",
-  "version": "0.20.2",
+  "version": "0.20.4",
   "description": "Gamification of coding, execute any command with ability to auto-report issues on GitHub",
   "main": "src/bin/cli.js",
   "exports": {

package/src/bin/cli.js

@@ -523,7 +523,10 @@ async function runWithIsolation(
       deferCommand,
     })
   );
-  console.log('');
+  // Only print empty line when not deferring command (docker isolation handles its own spacing)
+  if (!deferCommand) {
+    console.log('');
+  }
 
   // Save initial execution record and set global reference for signal cleanup
   if (executionRecord && store) {

package/src/lib/docker-utils.js

@@ -115,8 +115,9 @@ function dockerPullImage(image) {
     createTimelineSeparator,
   } = require('./output-blocks');
 
-  // Print the virtual command line
+  // Print the virtual command line followed by empty line for visual separation
   console.log(createVirtualCommandBlock(`docker pull ${image}`));
+  console.log();
 
   let output = '';
   let success = false;
@@ -141,7 +142,8 @@ function dockerPullImage(image) {
     success = false;
   }
 
-  // Print result marker and separator
+  // Print empty line before result marker for visual separation (issue #73)
+  // This ensures output is visually separated from the result marker
   console.log();
   console.log(createVirtualCommandResult(success));
   console.log(createTimelineSeparator());

package/test/output-blocks.test.js

@@ -458,6 +458,116 @@ describe('output-blocks module', () => {
       });
       expect(block).not.toContain('$ echo hello');
     });
+
+    it('should end with empty timeline line when deferCommand is true (issue #73)', () => {
+      // Issue #73: Visual continuity - when deferCommand is true,
+      // the start block should end with │ (empty timeline line)
+      // and no trailing empty line should be added by the CLI
+      const block = createStartBlock({
+        sessionId: 'test-uuid',
+        timestamp: '2025-01-01 00:00:00',
+        command: 'echo hello',
+        extraLines: [
+          '[Isolation] Environment: docker, Mode: attached',
+          '[Isolation] Image: alpine:latest',
+          '[Isolation] Session: docker-container-123',
+        ],
+        deferCommand: true,
+      });
+      const lines = block.split('\n');
+      // Last line should be empty timeline line (│)
+      expect(lines[lines.length - 1]).toBe('│');
+      // Should not contain the command
+      expect(block).not.toContain('$ echo hello');
+    });
+  });
+
+  describe('Visual Continuity (issue #73)', () => {
+    it('virtual command block should be followed by empty line for visual separation', () => {
+      // Issue #73: The empty line should come AFTER the command
+      // ($ docker pull ...), not BEFORE it
+      // This test verifies the expected format: command line followed by
+      // empty line before output
+      const virtualCommand = createVirtualCommandBlock(
+        'docker pull alpine:latest'
+      );
+      expect(virtualCommand).toBe('$ docker pull alpine:latest');
+      // The empty line is added by the caller (dockerPullImage)
+      // after the command and before running docker pull
+    });
+
+    it('timeline separator should be empty timeline line for visual structure', () => {
+      // After virtual command output, we print result marker and separator
+      const separator = createTimelineSeparator();
+      expect(separator).toBe('│');
+    });
+
+    it('start block with docker isolation should end cleanly for virtual commands', () => {
+      // When using docker isolation with defer_command, the block ends with │
+      // The virtual command (docker pull) starts immediately after
+      const block = createStartBlock({
+        sessionId: 'uuid-abc',
+        timestamp: '2026-01-08 12:00:00',
+        command: 'echo hi',
+        extraLines: [
+          '[Isolation] Environment: docker, Mode: attached',
+          '[Isolation] Image: alpine:latest',
+          '[Isolation] Session: docker-1234',
+        ],
+        deferCommand: true,
+      });
+
+      // Expected structure:
+      // │ session   uuid-abc
+      // │ start     2026-01-08 12:00:00
+      // │
+      // │ isolation docker
+      // │ mode      attached
+      // │ image     alpine:latest
+      // │ container docker-1234
+      // │   <-- ends here with empty timeline line
+      const lines = block.split('\n');
+      expect(lines[lines.length - 1]).toBe('│');
+
+      // Next should be virtual command (added separately by docker-utils):
+      // $ docker pull alpine:latest
+      // <empty line>
+      // <docker output>
+      // <empty line>
+      // ✓
+      // │
+      // $ echo hi
+      // <empty line>
+      // hi
+      // <empty line>
+      // ✓
+    });
+
+    it('output formatting follows visual continuity pattern', () => {
+      // Issue #73: All commands should have consistent formatting:
+      // 1. Command line ($ ...)
+      // 2. Empty line (visual separation)
+      // 3. Command output
+      // 4. Empty line (visual separation)
+      // 5. Result marker (✓ or ✗)
+      //
+      // This test documents the expected output structure that
+      // dockerPullImage and runInDocker should produce.
+
+      // Verify createCommandLine produces the correct format
+      const commandLine = createCommandLine('docker pull alpine:latest');
+      expect(commandLine).toBe('$ docker pull alpine:latest');
+
+      // Verify createVirtualCommandBlock matches
+      const virtualCommandLine = createVirtualCommandBlock(
+        'docker pull alpine:latest'
+      );
+      expect(virtualCommandLine).toBe(commandLine);
+
+      // Verify result markers
+      expect(createVirtualCommandResult(true)).toBe('✓');
+      expect(createVirtualCommandResult(false)).toBe('✗');
+    });
   });
 });