start-command 0.17.4 → 0.18.0

package/CHANGELOG.md

@@ -1,5 +1,27 @@
 # start-command
 
+## 0.18.0
+
+### Minor Changes
+
+- c918e82: feat: Use OS-matched default Docker image when --image is not specified
+
+  When using `$ --isolated docker -- command`, instead of requiring the `--image` option,
+  the system now automatically selects an appropriate default Docker image based on the
+  host operating system:
+  - macOS/Windows: `alpine:latest` (lightweight, portable)
+  - Ubuntu: `ubuntu:latest`
+  - Debian: `debian:latest`
+  - Arch Linux: `archlinux:latest`
+  - Fedora: `fedora:latest`
+  - CentOS/RHEL: `centos:latest`
+  - Other Linux/Fallback: `alpine:latest`
+
+  This allows users to use Docker isolation with a simple command like:
+  `$ --isolated docker -- echo 'hi'`
+
+  Fixes #62
+
 ## 0.17.4
 
 ### Patch Changes

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "start-command",
-  "version": "0.17.4",
+  "version": "0.18.0",
   "description": "Gamification of coding, execute any command with ability to auto-report issues on GitHub",
   "main": "src/bin/cli.js",
   "exports": {

package/src/lib/args-parser.js

@@ -10,7 +10,7 @@
  * --attached, -a                   Run in attached mode (foreground)
  * --detached, -d                   Run in detached mode (background)
  * --session, -s <name>             Session name for isolation
- * --image <image>                  Docker image (required for docker isolation)
+ * --image <image>                  Docker image (optional, defaults to OS-matched image)
  * --endpoint <endpoint>            SSH endpoint (required for ssh isolation, e.g., user@host)
  * --isolated-user, -u [username]   Create isolated user with same permissions (auto-generated name if not specified)
  * --keep-user                      Keep isolated user after command completes (don't delete)
@@ -23,6 +23,8 @@
  * --cleanup-dry-run                Show stale records that would be cleaned up (without actually cleaning)
  */
 
+const { getDefaultDockerImage } = require('./docker-utils');
+
 // Debug mode from environment
 const DEBUG =
   process.env.START_DEBUG === '1' || process.env.START_DEBUG === 'true';
@@ -381,11 +383,9 @@ function validateOptions(options) {
       );
     }
 
-    // Docker requires --image
+    // Docker uses --image or defaults to OS-matched image
     if (options.isolated === 'docker' && !options.image) {
-      throw new Error(
-        'Docker isolation requires --image option to specify the container image'
-      );
+      options.image = getDefaultDockerImage();
     }
 
     // SSH requires --endpoint

package/test/args-parser.test.js

@@ -199,10 +199,26 @@ describe('parseArgs', () => {
       assert.strictEqual(result.wrapperOptions.image, 'alpine:latest');
     });
 
-    it('should throw error for docker without image', () => {
-      assert.throws(() => {
-        parseArgs(['--isolated', 'docker', '--', 'npm', 'test']);
-      }, /Docker isolation requires --image option/);
+    it('should use default OS-matched image for docker without --image', () => {
+      const result = parseArgs(['--isolated', 'docker', '--', 'npm', 'test']);
+      // Should have a default image set (OS-matched)
+      assert.ok(
+        result.wrapperOptions.image,
+        'Expected default image to be set'
+      );
+      // Should be one of the known default images
+      const knownDefaults = [
+        'alpine:latest',
+        'ubuntu:latest',
+        'debian:latest',
+        'archlinux:latest',
+        'fedora:latest',
+        'centos:latest',
+      ];
+      assert.ok(
+        knownDefaults.includes(result.wrapperOptions.image),
+        `Expected image to be one of ${knownDefaults.join(', ')}, got ${result.wrapperOptions.image}`
+      );
     });
 
     it('should throw error for image with non-docker backend', () => {

package/test/isolation.test.js

@@ -714,13 +714,19 @@ describe('Isolation Runner with Available Backends', () => {
     });
 
     it('should pass options to backend', async () => {
-      // Test docker without image - should fail with specific error
-      const result = await runIsolated('docker', 'echo test', {});
-      assert.strictEqual(result.success, false);
-      // Either docker not installed or image required
-      assert.ok(
-        result.message.includes('docker') || result.message.includes('image')
-      );
+      // Test docker with explicit image - should work if docker is installed
+      // or fail with docker-not-installed error (not image-required error)
+      const result = await runIsolated('docker', 'echo test', {
+        image: 'alpine:latest',
+      });
+      // If docker is not installed, we get a docker-related error
+      // If docker is installed, it might succeed or fail for other reasons
+      if (!result.success) {
+        assert.ok(
+          result.message.toLowerCase().includes('docker'),
+          `Expected docker-related error, got: ${result.message}`
+        );
+      }
     });
   });
 });