starpc 0.27.1 → 0.27.2

package/go.mod

@@ -9,7 +9,7 @@ require (
 )
 
 require (
-	github.com/aperturerobotics/util v1.14.2 // latest
+	github.com/aperturerobotics/util v1.14.3 // latest
 	github.com/libp2p/go-libp2p v0.33.0 // latest
 	github.com/libp2p/go-yamux/v4 v4.0.2-0.20240206065824-7222fbc3459d // master
 	github.com/sirupsen/logrus v1.9.3 // latest

package/go.sum

@@ -1,5 +1,7 @@
 github.com/aperturerobotics/util v1.14.2 h1:AghqzGgZoufsdQstY6cCssHHMB/uCv8+BjysAE55S98=
 github.com/aperturerobotics/util v1.14.2/go.mod h1:1+G2THhT7VCmR7xeRlqDnyEtRFvONWoPft19xTHvbyk=
+github.com/aperturerobotics/util v1.14.3 h1:tn8eET9vlFwnveFY+rt4VbbMertQW8dcd+V5fK7SyHo=
+github.com/aperturerobotics/util v1.14.3/go.mod h1:1+G2THhT7VCmR7xeRlqDnyEtRFvONWoPft19xTHvbyk=
 github.com/davecgh/go-spew v1.1.0/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
 github.com/davecgh/go-spew v1.1.1 h1:vj9j/u1bqnvCEfJOwUhtlOARqs3+rkHYY13jYWTU97c=
 github.com/davecgh/go-spew v1.1.1/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "starpc",
-  "version": "0.27.1",
+  "version": "0.27.2",
   "description": "Streaming protobuf RPC service protocol over any two-way channel.",
   "license": "MIT",
   "author": {

package/srpc/client-prefix.go

@@ -54,12 +54,5 @@ func (i *PrefixClient) stripCheckServiceIDPrefix(service string) (string, error)
 	return service, nil
 }
 
-// NewRawStream opens a new raw stream with the remote.
-// Implements OpenStreamFunc.
-// msgHandler must not be called concurrently.
-func (i *PrefixClient) NewRawStream(ctx context.Context, msgHandler PacketDataHandler, closeHandler CloseHandler) (PacketWriter, error) {
-	return i.client.NewRawStream(ctx, msgHandler, closeHandler)
-}
-
 // _ is a type assertion
 var _ Client = ((*PrefixClient)(nil))

package/srpc/client-set.go

@@ -41,23 +41,6 @@ func (c *ClientSet) NewStream(
 	return strm, err
 }
 
-// NewRawStream opens a new raw stream with the remote.
-// Implements OpenStreamFunc.
-// msgHandler must not be called concurrently.
-func (c *ClientSet) NewRawStream(
-	ctx context.Context,
-	msgHandler PacketDataHandler,
-	closeHandler CloseHandler,
-) (PacketWriter, error) {
-	for _, client := range c.clients {
-		if client == nil {
-			continue
-		}
-		return client.NewRawStream(ctx, msgHandler, closeHandler)
-	}
-	return nil, ErrNoAvailableClients
-}
-
 // execCall executes the call conditionally retrying against subsequent client handles.
 func (c *ClientSet) execCall(ctx context.Context, doCall func(client Client) error) error {
 	var any bool

package/srpc/client-verbose.go

@@ -61,21 +61,3 @@ func (c *VClient) NewStream(ctx context.Context, service, method string, firstMs
 	stream, err = c.client.NewStream(ctx, service, method, firstMsg)
 	return stream, err
 }
-
-// NewRawStream opens a new raw stream with the remote.
-// Implements OpenStreamFunc.
-// msgHandler must not be called concurrently.
-func (c *VClient) NewRawStream(ctx context.Context, msgHandler PacketDataHandler, closeHandler CloseHandler) (writer PacketWriter, err error) {
-	t1 := time.Now()
-
-	defer func() {
-		c.le.Debugf(
-			"NewRawStream() => dur(%v) writer(%v) err(%v)",
-			time.Since(t1).String(),
-			writer,
-			err,
-		)
-	}()
-	writer, err = c.client.NewRawStream(ctx, msgHandler, closeHandler)
-	return writer, err
-}

package/srpc/client.go

@@ -14,11 +14,6 @@ type Client interface {
 	// NewStream starts a streaming RPC with the remote & returns the stream.
 	// firstMsg is optional.
 	NewStream(ctx context.Context, service, method string, firstMsg Message) (Stream, error)
-
-	// NewRawStream opens a new raw stream with the remote.
-	// Implements OpenStreamFunc.
-	// msgHandler must not be called concurrently.
-	NewRawStream(ctx context.Context, msgHandler PacketDataHandler, closeHandler CloseHandler) (PacketWriter, error)
 }
 
 // OpenStreamFunc opens a stream with a remote.
@@ -95,16 +90,5 @@ func (c *client) NewStream(ctx context.Context, service, method string, firstMsg
 	return NewMsgStream(ctx, clientRPC, clientRPC.ctxCancel), nil
 }
 
-// NewRawStream opens a new raw stream with the remote.
-// Implements OpenStreamFunc.
-// msgHandler must not be called concurrently.
-func (c *client) NewRawStream(
-	ctx context.Context,
-	msgHandler PacketDataHandler,
-	closeHandler CloseHandler,
-) (PacketWriter, error) {
-	return c.openStream(ctx, msgHandler, closeHandler)
-}
-
 // _ is a type assertion
 var _ Client = ((*client)(nil))

package/srpc/writer.go

@@ -7,3 +7,27 @@ type PacketWriter interface {
 	// Close closes the writer.
 	Close() error
 }
+
+// packetWriterWithClose is a PacketWriter with a wrapped Close function.
+type packetWriterWithClose struct {
+	PacketWriter
+	closeFn func() error
+}
+
+// NewPacketWriterWithClose wraps a PacketWriter with a close function to call when Close is called.
+func NewPacketWriterWithClose(prw PacketWriter, close func() error) PacketWriter {
+	return &packetWriterWithClose{PacketWriter: prw, closeFn: close}
+}
+
+// Close closes the stream for reading and writing.
+func (s *packetWriterWithClose) Close() error {
+	err := s.PacketWriter.Close()
+	err2 := s.closeFn()
+	if err != nil {
+		return err
+	}
+	return err2
+}
+
+// _ is a type assertion
+var _ PacketWriter = (*packetWriterWithClose)(nil)