standard-tsx 0.0.4 → 0.0.6

package/HISTORY.md

@@ -1,3 +1,9 @@
+## 0.0.6
+* [Disable duplicate ts rules (#14)](https://github.com/extremeheat/standard-tsx/commit/625d956de1b1f98e57af040d7284d1fec0b93274) (thanks @extremeheat)
+
+## 0.0.5
+* [Update .gitignore handling (#12)](https://github.com/extremeheat/standard-tsx/commit/29b2286623bf5145ec6c8b3d112136f9d0b7ccac) (thanks @extremeheat)
+
 ## 0.0.4
 * [Fix tsconfig lookup (#9)](https://github.com/extremeheat/standard-tsx/commit/4f28fc3798d52a35d86126c29a7e5d3d341b1578) (thanks @extremeheat)
 * [Fix .gitignore handling in eslint.config.js](https://github.com/extremeheat/standard-tsx/commit/a8d88a03742b02b7138d9b653026eb33a74ce829) (thanks @extremeheat)

package/README.md

@@ -4,7 +4,7 @@
 [![Gitpod ready-to-code](https://img.shields.io/badge/Gitpod-ready--to--code-blue?logo=gitpod)](https://gitpod.io/#https://github.com/extremeheat/standard-tsx)
 
 A drop-in replacement for the `standard` JavaScript linter that supports both TypeScript and JavaScript code with and without JSX. This package does not
-add any new rules. Instead, it applies standard's eslint config (https://github.com/standard/eslint-config-standard) to both `*.ts` and `*.js`/`.cjs`/`.mjs` files as well as `.tsx`/`.jsx` React files. This is on top of ESLint's default TypeScript reccomendations (which are mostly non-style related):
+add any new JavaScript rules. Instead, it applies standard's eslint config (https://github.com/standard/eslint-config-standard) to both `*.ts` and `*.js`/`.cjs`/`.mjs` files as well as `.tsx`/`.jsx` React files. This is on top of ESLint's default TypeScript reccomendations (which are mostly non-style related) and add some `--fix`-able TypeScript rules to mirror standard's JavaScript behavior (semicolons, spacing):
 
 >Recommended rules for code correctness that you can drop in without additional configuration. These rules are those whose reports are almost always for a bad practice and/or likely bug. recommended also disables core ESLint rules known to conflict with typescript-eslint rules or cause issues in TypeScript codebases.
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "standard-tsx",
-  "version": "0.0.4",
+  "version": "0.0.6",
   "description": "standardjs lint with TypeScript and JSX file support (with no new typescript rules)",
   "main": "src/index.js",
   "bin": {

package/src/eslint.config.js

@@ -1,7 +1,3 @@
-// ./eslint.config.js
-const path = require('node:path')
-const fs = require('node:fs')
-
 const globals = require('globals')
 const pluginJs = require('@eslint/js').configs
 const tseslint = require('typescript-eslint')
@@ -12,52 +8,18 @@ const promisePlugin = require('eslint-plugin-promise')
 const eslintEnvRestorePlugin = require('eslint-plugin-eslint-env-restore')
 const reactPlugin = require('eslint-plugin-react')
 const reactHooksPlugin = require('eslint-plugin-react-hooks')
-const glob = require('glob')
-
-// Find all .gitignore files in the project
-const gitignoreFiles = glob.sync('**/.gitignore', { cwd: process.cwd() })
-
-// Sort by directory depth (root to leaves) to match Git's override behavior
-const sortedGitignoreFiles = gitignoreFiles.sort((a, b) => {
-  const depthA = a.split(path.sep).length
-  const depthB = b.split(path.sep).length
-  return depthA - depthB
-})
-
-// Merge ignore patterns from all .gitignore files
-const ignorePatterns = []
-for (const file of sortedGitignoreFiles) {
-  const dir = path.dirname(file)
-  const content = fs.readFileSync(file, 'utf8')
-  const lines = content.split('\n').map(line => line.trim()).filter(line => line && !line.startsWith('#'))
-  for (const line of lines) {
-    if (line.startsWith('!')) {
-      ignorePatterns.push('!' + path.join(dir, line.slice(1)))
-    } else {
-      ignorePatterns.push(path.join(dir, line))
-    }
-  }
-}
 
-function findNearestTsconfigDir (startDir = process.cwd()) {
-  let currentDir = path.resolve(startDir)
-
-  while (true) {
-    const tsconfigPath = path.join(currentDir, 'tsconfig.json')
-    if (fs.existsSync(tsconfigPath)) {
-      return currentDir
-    }
+const { collectIgnores, findNearestTsconfigDir } = require('./utils.js')
+const ignorePatterns = collectIgnores()
+const tsconfigRootDir = findNearestTsconfigDir()
 
-    const parentDir = path.dirname(currentDir)
-    if (parentDir === currentDir) {
-      // Reached filesystem root
-      break
-    }
-    currentDir = parentDir
-  }
-  return null
+const tsRules = {
+  // TODO: Need stylistic
+  // '@typescript-eslint/indent': ['error', 2],
+  // '@typescript-eslint/semi': ['error', 'never'],
+  // '@typescript-eslint/quotes': ['error', 'single'],
+  // '@typescript-eslint/type-annotation-spacing': ['error']
 }
-const tsconfigRootDir = findNearestTsconfigDir()
 
 module.exports = [
   { ignores: ignorePatterns },
@@ -151,7 +113,8 @@ module.exports = [
       ...tseslint.configs.recommended.rules,
       ...standard.rules,
       'no-unused-vars': ['error', { vars: 'local', args: 'none', caughtErrors: 'none', ignoreRestSiblings: true }],
-      '@typescript-eslint/no-unused-vars': ['error', { vars: 'local', args: 'none', caughtErrors: 'none', ignoreRestSiblings: true }]
+      // '@typescript-eslint/no-unused-vars': ['error', { vars: 'local', args: 'none', caughtErrors: 'none', ignoreRestSiblings: true }],
+      ...tsRules
     }
   },
   // TSX (Browser environment)
@@ -186,10 +149,11 @@ module.exports = [
       ...reactPlugin.configs.recommended.rules,
       ...reactHooksPlugin.configs.recommended.rules,
       'no-unused-vars': ['error', { vars: 'local', args: 'none', caughtErrors: 'none', ignoreRestSiblings: true }],
-      '@typescript-eslint/no-unused-vars': ['error', { vars: 'local', args: 'none', caughtErrors: 'none', ignoreRestSiblings: true }],
+      // '@typescript-eslint/no-unused-vars': ['error', { vars: 'local', args: 'none', caughtErrors: 'none', ignoreRestSiblings: true }],
       'react/jsx-uses-react': 'off',
       'react/jsx-uses-vars': 'error',
-      'react/react-in-jsx-scope': 'off'
+      'react/react-in-jsx-scope': 'off',
+      ...tsRules
     }
   }
 ]

package/src/utils.js

@@ -0,0 +1,63 @@
+const path = require('node:path')
+const fs = require('node:fs')
+const glob = require('glob')
+
+function collectIgnores () {
+  // Find all .gitignore files in the project (upto 2 levels up for monorepo support)
+  const gitignoreFiles = glob.sync('**/.gitignore', { cwd: process.cwd() })
+  if (gitignoreFiles.length === 0) {
+    gitignoreFiles.push(...glob.sync('**/.gitignore', { cwd: path.join(process.cwd(), '..') }).map(file => path.join('..', file)))
+    if (gitignoreFiles.length === 0) {
+      gitignoreFiles.push(...glob.sync('**/.gitignore', { cwd: path.join(process.cwd(), '../..') }).map(file => path.join('..', '..', file)))
+    }
+  }
+
+  // Sort by directory depth (root to leaves) to match Git's override behavior
+  const sortedGitignoreFiles = gitignoreFiles.sort((a, b) => {
+    const depthA = a.split(path.sep).length
+    const depthB = b.split(path.sep).length
+    return depthA - depthB
+  })
+
+  // Merge ignore patterns from all .gitignore files
+  const ignorePatterns = []
+  for (const file of sortedGitignoreFiles) {
+    const dir = path.dirname(file)
+    const content = fs.readFileSync(file, 'utf8')
+    const lines = content.split('\n').map(line => line.trim()).filter(line => line && !line.startsWith('#'))
+    for (const line of lines) {
+      let rule = path.join(dir, line).replaceAll('\\', '/')
+      if (rule.startsWith('..//')) continue // a rule intended for a parent directory
+      // rules that don't start with slash apply to all directories
+      rule = rule.replaceAll('../', '')
+      // mimic .gitignore behavior as ESlint is a bit different and doesn't recursively apply rules
+      if (!rule.startsWith('/') || !rule.startsWith('./') || !rule.startsWith('*')) rule = '**/' + rule
+      // Restore ordering of ! to front after above transformation
+      if (line.startsWith('!')) rule = '!' + rule.replaceAll('!', '')
+      ignorePatterns.push(rule)
+    }
+  }
+
+  return ignorePatterns
+}
+
+function findNearestTsconfigDir (startDir = process.cwd()) {
+  let currentDir = path.resolve(startDir)
+
+  while (true) {
+    const tsconfigPath = path.join(currentDir, 'tsconfig.json')
+    if (fs.existsSync(tsconfigPath)) {
+      return currentDir
+    }
+
+    const parentDir = path.dirname(currentDir)
+    if (parentDir === currentDir) {
+      // Reached filesystem root
+      break
+    }
+    currentDir = parentDir
+  }
+  return null
+}
+
+module.exports = { collectIgnores, findNearestTsconfigDir }