stagent 0.9.6 → 0.11.0

package/src/components/notifications/__tests__/notification-item.test.tsx

@@ -0,0 +1,106 @@
+import { render, screen } from "@testing-library/react";
+import { describe, expect, it, vi } from "vitest";
+
+import { NotificationItem } from "@/components/notifications/notification-item";
+
+const { push, contextReviewSpy, batchReviewSpy } = vi.hoisted(() => ({
+  push: vi.fn(),
+  contextReviewSpy: vi.fn(),
+  batchReviewSpy: vi.fn(),
+}));
+
+vi.mock("next/navigation", () => ({
+  useRouter: () => ({ push }),
+}));
+
+vi.mock("@/components/profiles/context-proposal-review", () => ({
+  ContextProposalReview: (props: {
+    notificationId: string;
+    profileId: string;
+    proposedAdditions: string;
+    onResponded: () => void;
+  }) => {
+    contextReviewSpy(props);
+    return <div>Context proposal review</div>;
+  },
+}));
+
+vi.mock("@/components/notifications/batch-proposal-review", () => ({
+  BatchProposalReview: (props: {
+    proposalIds: string[];
+    profileIds: string[];
+    body: string;
+    onResponded?: () => void;
+  }) => {
+    batchReviewSpy(props);
+    return <div>Batch proposal review</div>;
+  },
+}));
+
+describe("notification item", () => {
+  it("renders context proposal review actions using the full additions payload", () => {
+    render(
+      <NotificationItem
+        notification={{
+          id: "notif-1",
+          taskId: null,
+          type: "context_proposal",
+          title: "Context proposal",
+          body: "truncated body",
+          read: false,
+          toolName: "general",
+          toolInput: JSON.stringify({
+            profileId: "general",
+            additions: "Full learned additions",
+          }),
+          response: null,
+          respondedAt: null,
+          createdAt: "2026-04-10T00:00:00.000Z",
+        }}
+        onUpdated={vi.fn()}
+      />
+    );
+
+    expect(screen.getByText("Context proposal review")).toBeInTheDocument();
+    expect(contextReviewSpy).toHaveBeenCalledWith(
+      expect.objectContaining({
+        notificationId: "notif-1",
+        profileId: "general",
+        proposedAdditions: "Full learned additions",
+      })
+    );
+  });
+
+  it("renders batch proposal review actions for workflow learning notifications", () => {
+    render(
+      <NotificationItem
+        notification={{
+          id: "notif-2",
+          taskId: null,
+          type: "context_proposal_batch",
+          title: "Workflow learning batch",
+          body: "Batch summary",
+          read: false,
+          toolName: "workflow-context-batch",
+          toolInput: JSON.stringify({
+            proposalIds: ["p1", "p2"],
+            profileIds: ["general", "researcher"],
+          }),
+          response: null,
+          respondedAt: null,
+          createdAt: "2026-04-10T00:00:00.000Z",
+        }}
+        onUpdated={vi.fn()}
+      />
+    );
+
+    expect(screen.getByText("Batch proposal review")).toBeInTheDocument();
+    expect(batchReviewSpy).toHaveBeenCalledWith(
+      expect.objectContaining({
+        proposalIds: ["p1", "p2"],
+        profileIds: ["general", "researcher"],
+        body: "Batch summary",
+      })
+    );
+  });
+});

package/src/components/notifications/__tests__/permission-response-actions.test.tsx

@@ -62,6 +62,76 @@ describe("permission response actions", () => {
     });
   });
 
+  it("renders option cards for AskUserQuestion with options and posts { answer } on click", async () => {
+    const onResponded = vi.fn();
+    render(
+      <PermissionResponseActions
+        taskId="task-42"
+        notificationId="notif-q1"
+        toolName="AskUserQuestion"
+        toolInput={{
+          question: "Which version?",
+          options: [
+            { label: "Keep my version", description: "Use your changes" },
+            { label: "Take main's version", description: "Use main's changes" },
+          ],
+        }}
+        responded={false}
+        response={null}
+        onResponded={onResponded}
+      />
+    );
+
+    const group = screen.getByRole("radiogroup");
+    expect(group).toBeInTheDocument();
+    fireEvent.click(screen.getByText("Take main's version"));
+
+    await waitFor(() => {
+      expect(fetch).toHaveBeenCalledWith("/api/tasks/task-42/respond", {
+        method: "POST",
+        headers: { "Content-Type": "application/json" },
+        body: JSON.stringify({
+          notificationId: "notif-q1",
+          behavior: "allow",
+          updatedInput: { answer: "Take main's version" },
+        }),
+      });
+      expect(onResponded).toHaveBeenCalled();
+    });
+  });
+
+  it("renders a textarea for AskUserQuestion without options and posts the typed answer", async () => {
+    const onResponded = vi.fn();
+    render(
+      <PermissionResponseActions
+        taskId="task-42"
+        notificationId="notif-q2"
+        toolName="AskUserQuestion"
+        toolInput={{ question: "Move commits to local or abort?" }}
+        responded={false}
+        response={null}
+        onResponded={onResponded}
+      />
+    );
+
+    const textarea = screen.getByPlaceholderText("Type your reply…");
+    fireEvent.change(textarea, { target: { value: "move them to local" } });
+    fireEvent.click(screen.getByRole("button", { name: /Send/i }));
+
+    await waitFor(() => {
+      expect(fetch).toHaveBeenCalledWith("/api/tasks/task-42/respond", {
+        method: "POST",
+        headers: { "Content-Type": "application/json" },
+        body: JSON.stringify({
+          notificationId: "notif-q2",
+          behavior: "allow",
+          updatedInput: { answer: "move them to local" },
+        }),
+      });
+      expect(onResponded).toHaveBeenCalled();
+    });
+  });
+
   it("renders the resolved state label when a response already exists", () => {
     render(
       <PermissionResponseActions

package/src/components/notifications/batch-proposal-review.tsx

@@ -1,6 +1,7 @@
 "use client";
 
 import { useState } from "react";
+import { toast } from "sonner";
 import { Button } from "@/components/ui/button";
 import { Badge } from "@/components/ui/badge";
 import { Card, CardContent, CardHeader, CardTitle } from "@/components/ui/card";
@@ -12,6 +13,7 @@ interface BatchProposalReviewProps {
   profileIds: string[];
   body: string;
   onResponded?: () => void;
+  onRequestFailed?: () => void;
   compact?: boolean;
 }
 
@@ -20,6 +22,7 @@ export function BatchProposalReview({
   profileIds,
   body,
   onResponded,
+  onRequestFailed,
   compact = false,
 }: BatchProposalReviewProps) {
   const [loading, setLoading] = useState<"approve" | "reject" | null>(null);
@@ -31,18 +34,30 @@ export function BatchProposalReview({
 
   async function handleBatchAction(action: "approve" | "reject") {
     setLoading(action);
+    setResponded(true);
+    onResponded?.();
+
     try {
       const res = await fetch("/api/context/batch", {
         method: "POST",
         headers: { "Content-Type": "application/json" },
         body: JSON.stringify({ proposalIds, action }),
       });
-      if (res.ok) {
-        const data = await res.json();
-        setResult({ action: data.action, count: data.count });
-        setResponded(true);
-        onResponded?.();
+
+      if (!res.ok) {
+        const data = await res.json().catch(() => null);
+        throw new Error(data?.error ?? `Failed to ${action} batch proposal`);
       }
+
+      const data = await res.json();
+      setResult({ action: data.action, count: data.count });
+    } catch (error) {
+      setResponded(false);
+      setResult(null);
+      toast.error(
+        error instanceof Error ? error.message : "Batch approval failed"
+      );
+      onRequestFailed?.();
     } finally {
       setLoading(null);
     }

package/src/components/notifications/inbox-list.tsx

@@ -7,6 +7,7 @@ import { Eye, Inbox, RefreshCw, Trash2 } from "lucide-react";
 import { toast } from "sonner";
 import { NotificationItem } from "./notification-item";
 import { EmptyState } from "@/components/shared/empty-state";
+import { filterDefaultVisibleNotifications } from "@/lib/notifications/visibility";
 
 interface Notification {
   id: string;
@@ -28,12 +29,15 @@ export function InboxList({
   initialNotifications: Notification[];
 }) {
   const [notifications, setNotifications] =
-    useState<Notification[]>(initialNotifications);
+    useState<Notification[]>(() => filterDefaultVisibleNotifications(initialNotifications));
   const [tab, setTab] = useState("all");
 
   const refresh = useCallback(async () => {
     const res = await fetch("/api/notifications");
-    if (res.ok) setNotifications(await res.json());
+    if (res.ok) {
+      const next = (await res.json()) as Notification[];
+      setNotifications(filterDefaultVisibleNotifications(next));
+    }
   }, []);
 
   // Poll every 10 seconds (consolidated from 3s inbox + 5s badge)
@@ -154,6 +158,11 @@ export function InboxList({
             <NotificationItem
               key={n.id}
               notification={n}
+              onRemoved={(notificationId) =>
+                setNotifications((current) =>
+                  current.filter((item) => item.id !== notificationId)
+                )
+              }
               onUpdated={refresh}
             />
           ))

package/src/components/notifications/notification-item.tsx

@@ -18,6 +18,8 @@ import {
   parseNotificationToolInput,
   type PermissionToolInput,
 } from "@/lib/notifications/permissions";
+import { ContextProposalReview } from "@/components/profiles/context-proposal-review";
+import { BatchProposalReview } from "./batch-proposal-review";
 
 interface Notification {
   id: string;
@@ -35,6 +37,7 @@ interface Notification {
 
 interface NotificationItemProps {
   notification: Notification;
+  onRemoved?: (notificationId: string) => void;
   onUpdated: () => void;
 }
 
@@ -104,7 +107,25 @@ function formatToolInput(
 
 const navigableTypes = new Set(["task_completed", "task_failed", "permission_required", "agent_message"]);
 
-export function NotificationItem({ notification, onUpdated }: NotificationItemProps) {
+function parseBatchToolInput(toolInput: PermissionToolInput | null): {
+  proposalIds: string[];
+  profileIds: string[];
+} {
+  return {
+    proposalIds: Array.isArray(toolInput?.proposalIds)
+      ? toolInput.proposalIds.filter((id): id is string => typeof id === "string")
+      : [],
+    profileIds: Array.isArray(toolInput?.profileIds)
+      ? toolInput.profileIds.filter((id): id is string => typeof id === "string")
+      : [],
+  };
+}
+
+export function NotificationItem({
+  notification,
+  onRemoved,
+  onUpdated,
+}: NotificationItemProps) {
   const router = useRouter();
   const [toggling, setToggling] = useState(false);
   const [dismissing, setDismissing] = useState(false);
@@ -212,7 +233,9 @@ export function NotificationItem({ notification, onUpdated }: NotificationItemPr
           {/* Body for non-tool notifications */}
           {notification.body &&
             notification.type !== "permission_required" &&
-            notification.type !== "agent_message" && (
+            notification.type !== "agent_message" &&
+            notification.type !== "context_proposal" &&
+            notification.type !== "context_proposal_batch" && (
               <div className="mt-1" onClick={(e) => e.stopPropagation()}>
                 <div
                   className={`${PROSE_NOTIFICATION} ${
@@ -270,6 +293,37 @@ export function NotificationItem({ notification, onUpdated }: NotificationItemPr
             <FailureAction taskId={notification.taskId} onRetried={onUpdated} />
           )}
 
+          {notification.type === "context_proposal" && (
+            <div className="mt-3" onClick={(e) => e.stopPropagation()}>
+              <ContextProposalReview
+                notificationId={notification.id}
+                profileId={
+                  typeof parsedToolInput?.profileId === "string"
+                    ? parsedToolInput.profileId
+                    : (notification.toolName ?? "")
+                }
+                proposedAdditions={
+                  typeof parsedToolInput?.additions === "string"
+                    ? parsedToolInput.additions
+                    : (notification.body ?? "")
+                }
+                onResponded={onUpdated}
+              />
+            </div>
+          )}
+
+          {notification.type === "context_proposal_batch" && (
+            <div className="mt-3" onClick={(e) => e.stopPropagation()}>
+              <BatchProposalReview
+                proposalIds={parseBatchToolInput(parsedToolInput).proposalIds}
+                profileIds={parseBatchToolInput(parsedToolInput).profileIds}
+                body={notification.body ?? ""}
+                onResponded={() => onRemoved?.(notification.id)}
+                onRequestFailed={onUpdated}
+              />
+            </div>
+          )}
+
           <p className="text-xs text-muted-foreground mt-2">
             {formatTimestamp(notification.createdAt)}
             {notification.respondedAt && (

package/src/components/notifications/pending-approval-host.tsx

@@ -2,7 +2,7 @@
 
 import Link from "next/link";
 import { usePathname, useRouter } from "next/navigation";
-import { useEffect, useMemo, useRef, useState } from "react";
+import { useCallback, useEffect, useMemo, useRef, useState } from "react";
 import {
   ArrowUpRight,
   Inbox,
@@ -108,12 +108,14 @@ function PendingApprovalDetail({
   selected,
   overflow,
   onResponded,
+  onRequestFailed,
   onOpenInbox,
   onSelect,
 }: {
   selected: PendingApprovalPayload;
   overflow: PendingApprovalPayload[];
   onResponded: () => void;
+  onRequestFailed: () => void;
   onOpenInbox: () => void;
   onSelect: (notificationId: string) => void;
 }) {
@@ -172,6 +174,7 @@ function PendingApprovalDetail({
               profileIds={parsed.profileIds}
               body={selected.body ?? ""}
               onResponded={onResponded}
+              onRequestFailed={onRequestFailed}
             />
           );
         })()
@@ -264,6 +267,33 @@ export function PendingApprovalHost() {
   const router = useRouter();
   const pathname = usePathname();
 
+  const applySnapshot = useCallback((snapshot: PendingApprovalPayload[]) => {
+    const nextItems = dedupePendingApprovals(snapshot);
+    const previousIds = new Set(knownIdsRef.current);
+    const newestNew = nextItems.find(
+      (item) => !previousIds.has(item.notificationId)
+    );
+
+    if (newestNew) {
+      setAnnouncement(
+        `Permission required for ${buildContextLabel(newestNew)}. ${newestNew.compactSummary}`
+      );
+    }
+
+    knownIdsRef.current = nextItems.map((item) => item.notificationId);
+    setItems(nextItems);
+  }, []);
+
+  const refreshApprovals = useCallback(async () => {
+    const res = await fetch("/api/notifications/pending-approvals", {
+      cache: "no-store",
+    });
+    if (!res.ok) return;
+
+    const snapshot = (await res.json()) as PendingApprovalPayload[];
+    applySnapshot(snapshot);
+  }, [applySnapshot]);
+
   const primary = items[0] ?? null;
   const selected = useMemo(() => {
     if (!items.length) return null;
@@ -287,51 +317,25 @@ export function PendingApprovalHost() {
     let pollId: ReturnType<typeof setInterval> | null = null;
     let eventSource: EventSource | null = null;
 
-    function applySnapshot(snapshot: PendingApprovalPayload[]) {
-      if (cancelled) return;
-
-      const nextItems = dedupePendingApprovals(snapshot);
-      const previousIds = new Set(knownIdsRef.current);
-      const newestNew = nextItems.find(
-        (item) => !previousIds.has(item.notificationId)
-      );
-
-      if (newestNew) {
-        setAnnouncement(
-          `Permission required for ${buildContextLabel(newestNew)}. ${newestNew.compactSummary}`
-        );
-      }
-
-      knownIdsRef.current = nextItems.map((item) => item.notificationId);
-      setItems(nextItems);
-    }
-
-    async function refresh() {
-      try {
-        const res = await fetch("/api/notifications/pending-approvals", {
-          cache: "no-store",
-        });
-        if (!res.ok) return;
-
-        const snapshot = (await res.json()) as PendingApprovalPayload[];
-        applySnapshot(snapshot);
-      } catch {
-        // Fallback refresh should fail quietly.
-      }
-    }
-
     const startPolling = () => {
       if (pollId) return;
-      pollId = setInterval(refresh, 15_000);
+      pollId = setInterval(() => {
+        refreshApprovals().catch(() => {
+          // Fallback refresh should fail quietly.
+        });
+      }, 15_000);
     };
 
-    refresh();
+    refreshApprovals().catch(() => {
+      // Initial refresh should fail quietly.
+    });
 
     try {
       eventSource = new EventSource("/api/notifications/pending-approvals/stream");
       eventSource.onmessage = (event) => {
         try {
           const snapshot = JSON.parse(event.data) as PendingApprovalPayload[];
+          if (cancelled) return;
           applySnapshot(snapshot);
         } catch {
           startPolling();
@@ -351,7 +355,7 @@ export function PendingApprovalHost() {
       if (pollId) clearInterval(pollId);
       eventSource?.close();
     };
-  }, []);
+  }, [applySnapshot, refreshApprovals]);
 
   function removeNotification(notificationId: string) {
     setItems((current) =>
@@ -453,6 +457,11 @@ export function PendingApprovalHost() {
                     profileIds={parsed.profileIds}
                     body={primary.body ?? ""}
                     onResponded={() => removeNotification(primary.notificationId)}
+                    onRequestFailed={() => {
+                      refreshApprovals().catch(() => {
+                        // Refresh failures are surfaced by the batch review toast.
+                      });
+                    }}
                     compact
                   />
                 );
@@ -518,6 +527,11 @@ export function PendingApprovalHost() {
                   selected={selected}
                   overflow={overflowItems}
                   onResponded={() => removeNotification(selected.notificationId)}
+                  onRequestFailed={() => {
+                    refreshApprovals().catch(() => {
+                      // Refresh failures are surfaced by the batch review toast.
+                    });
+                  }}
                   onOpenInbox={handleOpenInbox}
                   onSelect={setSelectedId}
                 />
@@ -545,6 +559,11 @@ export function PendingApprovalHost() {
                   selected={selected}
                   overflow={overflowItems}
                   onResponded={() => removeNotification(selected.notificationId)}
+                  onRequestFailed={() => {
+                    refreshApprovals().catch(() => {
+                      // Refresh failures are surfaced by the batch review toast.
+                    });
+                  }}
                   onOpenInbox={handleOpenInbox}
                   onSelect={setSelectedId}
                 />