stagent 0.9.5 → 0.10.0

package/src/components/notifications/pending-approval-host.tsx

@@ -2,7 +2,7 @@
 
 import Link from "next/link";
 import { usePathname, useRouter } from "next/navigation";
-import { useEffect, useMemo, useRef, useState } from "react";
+import { useCallback, useEffect, useMemo, useRef, useState } from "react";
 import {
   ArrowUpRight,
   Inbox,
@@ -108,12 +108,14 @@ function PendingApprovalDetail({
   selected,
   overflow,
   onResponded,
+  onRequestFailed,
   onOpenInbox,
   onSelect,
 }: {
   selected: PendingApprovalPayload;
   overflow: PendingApprovalPayload[];
   onResponded: () => void;
+  onRequestFailed: () => void;
   onOpenInbox: () => void;
   onSelect: (notificationId: string) => void;
 }) {
@@ -172,6 +174,7 @@ function PendingApprovalDetail({
               profileIds={parsed.profileIds}
               body={selected.body ?? ""}
               onResponded={onResponded}
+              onRequestFailed={onRequestFailed}
             />
           );
         })()
@@ -264,6 +267,33 @@ export function PendingApprovalHost() {
   const router = useRouter();
   const pathname = usePathname();
 
+  const applySnapshot = useCallback((snapshot: PendingApprovalPayload[]) => {
+    const nextItems = dedupePendingApprovals(snapshot);
+    const previousIds = new Set(knownIdsRef.current);
+    const newestNew = nextItems.find(
+      (item) => !previousIds.has(item.notificationId)
+    );
+
+    if (newestNew) {
+      setAnnouncement(
+        `Permission required for ${buildContextLabel(newestNew)}. ${newestNew.compactSummary}`
+      );
+    }
+
+    knownIdsRef.current = nextItems.map((item) => item.notificationId);
+    setItems(nextItems);
+  }, []);
+
+  const refreshApprovals = useCallback(async () => {
+    const res = await fetch("/api/notifications/pending-approvals", {
+      cache: "no-store",
+    });
+    if (!res.ok) return;
+
+    const snapshot = (await res.json()) as PendingApprovalPayload[];
+    applySnapshot(snapshot);
+  }, [applySnapshot]);
+
   const primary = items[0] ?? null;
   const selected = useMemo(() => {
     if (!items.length) return null;
@@ -287,51 +317,25 @@ export function PendingApprovalHost() {
     let pollId: ReturnType<typeof setInterval> | null = null;
     let eventSource: EventSource | null = null;
 
-    function applySnapshot(snapshot: PendingApprovalPayload[]) {
-      if (cancelled) return;
-
-      const nextItems = dedupePendingApprovals(snapshot);
-      const previousIds = new Set(knownIdsRef.current);
-      const newestNew = nextItems.find(
-        (item) => !previousIds.has(item.notificationId)
-      );
-
-      if (newestNew) {
-        setAnnouncement(
-          `Permission required for ${buildContextLabel(newestNew)}. ${newestNew.compactSummary}`
-        );
-      }
-
-      knownIdsRef.current = nextItems.map((item) => item.notificationId);
-      setItems(nextItems);
-    }
-
-    async function refresh() {
-      try {
-        const res = await fetch("/api/notifications/pending-approvals", {
-          cache: "no-store",
-        });
-        if (!res.ok) return;
-
-        const snapshot = (await res.json()) as PendingApprovalPayload[];
-        applySnapshot(snapshot);
-      } catch {
-        // Fallback refresh should fail quietly.
-      }
-    }
-
     const startPolling = () => {
       if (pollId) return;
-      pollId = setInterval(refresh, 15_000);
+      pollId = setInterval(() => {
+        refreshApprovals().catch(() => {
+          // Fallback refresh should fail quietly.
+        });
+      }, 15_000);
     };
 
-    refresh();
+    refreshApprovals().catch(() => {
+      // Initial refresh should fail quietly.
+    });
 
     try {
       eventSource = new EventSource("/api/notifications/pending-approvals/stream");
       eventSource.onmessage = (event) => {
         try {
           const snapshot = JSON.parse(event.data) as PendingApprovalPayload[];
+          if (cancelled) return;
           applySnapshot(snapshot);
         } catch {
           startPolling();
@@ -351,7 +355,7 @@ export function PendingApprovalHost() {
       if (pollId) clearInterval(pollId);
       eventSource?.close();
     };
-  }, []);
+  }, [applySnapshot, refreshApprovals]);
 
   function removeNotification(notificationId: string) {
     setItems((current) =>
@@ -453,6 +457,11 @@ export function PendingApprovalHost() {
                     profileIds={parsed.profileIds}
                     body={primary.body ?? ""}
                     onResponded={() => removeNotification(primary.notificationId)}
+                    onRequestFailed={() => {
+                      refreshApprovals().catch(() => {
+                        // Refresh failures are surfaced by the batch review toast.
+                      });
+                    }}
                     compact
                   />
                 );
@@ -518,6 +527,11 @@ export function PendingApprovalHost() {
                   selected={selected}
                   overflow={overflowItems}
                   onResponded={() => removeNotification(selected.notificationId)}
+                  onRequestFailed={() => {
+                    refreshApprovals().catch(() => {
+                      // Refresh failures are surfaced by the batch review toast.
+                    });
+                  }}
                   onOpenInbox={handleOpenInbox}
                   onSelect={setSelectedId}
                 />
@@ -545,6 +559,11 @@ export function PendingApprovalHost() {
                   selected={selected}
                   overflow={overflowItems}
                   onResponded={() => removeNotification(selected.notificationId)}
+                  onRequestFailed={() => {
+                    refreshApprovals().catch(() => {
+                      // Refresh failures are surfaced by the batch review toast.
+                    });
+                  }}
                   onOpenInbox={handleOpenInbox}
                   onSelect={setSelectedId}
                 />

package/src/components/schedules/schedule-create-sheet.tsx

@@ -11,6 +11,7 @@ import {
 import { Calendar } from "lucide-react";
 import { toast } from "sonner";
 import { ScheduleForm, type ScheduleFormValues } from "./schedule-form";
+import type { CronCollisionWarning } from "@/lib/schedules/collision-check";
 
 interface ScheduleCreateSheetProps {
   projects: { id: string; name: string }[];
@@ -27,6 +28,7 @@ export function ScheduleCreateSheet({
 }: ScheduleCreateSheetProps) {
   const [loading, setLoading] = useState(false);
   const [error, setError] = useState<string | null>(null);
+  const [warnings, setWarnings] = useState<CronCollisionWarning[]>([]);
 
   async function handleSubmit(values: ScheduleFormValues) {
     setLoading(true);
@@ -58,10 +60,15 @@ export function ScheduleCreateSheet({
       });
 
       if (res.ok) {
+        const { warnings: newWarnings } = await res.json();
         setError(null);
-        onOpenChange(false);
+        setWarnings(newWarnings ?? []);
         toast.success("Schedule created");
         onCreated();
+        if (!newWarnings || newWarnings.length === 0) {
+          onOpenChange(false);
+        }
+        // Keep sheet open if there are warnings so the user sees the banner
       } else {
         const data = await res.json().catch(() => null);
         setError(data?.error ?? `Failed to create schedule (${res.status})`);
@@ -89,6 +96,17 @@ export function ScheduleCreateSheet({
 
         {/* Body — px-6 pb-6 per project convention (SheetContent has NO body padding) */}
         <div className="px-6 pb-6 overflow-y-auto">
+          {warnings.length > 0 && (
+            <div className="mb-4 rounded-lg border border-amber-500/40 bg-amber-50 p-3 text-sm">
+              <p className="font-medium text-amber-900">
+                Overlap detected with: {warnings[0].overlappingSchedules.join(", ")}
+              </p>
+              <p className="text-amber-800">
+                Combined load: ~{warnings[0].estimatedConcurrentSteps} agent steps.
+                Schedules will take turns; the last to run may be delayed.
+              </p>
+            </div>
+          )}
           <ScheduleForm
             projects={projects}
             onSubmit={handleSubmit}

package/src/components/schedules/schedule-edit-sheet.tsx

@@ -16,6 +16,7 @@ import {
   type ScheduleFormValues,
   type ScheduleFormInitialValues,
 } from "./schedule-form";
+import type { CronCollisionWarning } from "@/lib/schedules/collision-check";
 
 interface ScheduleEditSheetProps {
   scheduleId: string | null;
@@ -49,6 +50,7 @@ export function ScheduleEditSheet({
   const [loaded, setLoaded] = useState(false);
   const [loading, setLoading] = useState(false);
   const [error, setError] = useState<string | null>(null);
+  const [warnings, setWarnings] = useState<CronCollisionWarning[]>([]);
 
   const fetchSchedule = useCallback(async () => {
     if (!scheduleId) return;
@@ -63,6 +65,7 @@ export function ScheduleEditSheet({
       setSchedule(null);
       setLoaded(false);
       setError(null);
+      setWarnings([]);
       return;
     }
     fetchSchedule();
@@ -102,9 +105,14 @@ export function ScheduleEditSheet({
       });
 
       if (res.ok) {
+        const { warnings: newWarnings } = await res.json();
+        setWarnings(newWarnings ?? []);
         toast.success("Schedule updated");
-        onOpenChange(false);
         onUpdated();
+        if (!newWarnings || newWarnings.length === 0) {
+          onOpenChange(false);
+        }
+        // Keep sheet open if there are warnings so the user sees the banner
       } else {
         const data = await res.json().catch(() => null);
         setError(data?.error ?? `Failed to update schedule (${res.status})`);
@@ -131,6 +139,17 @@ export function ScheduleEditSheet({
 
         {/* Body — px-6 pb-6 per project convention (SheetContent has NO body padding) */}
         <div className="px-6 pb-6 overflow-y-auto">
+          {warnings.length > 0 && (
+            <div className="mb-4 rounded-lg border border-amber-500/40 bg-amber-50 p-3 text-sm">
+              <p className="font-medium text-amber-900">
+                Overlap detected with: {warnings[0].overlappingSchedules.join(", ")}
+              </p>
+              <p className="text-amber-800">
+                Combined load: ~{warnings[0].estimatedConcurrentSteps} agent steps.
+                Schedules will take turns; the last to run may be delayed.
+              </p>
+            </div>
+          )}
           {!loaded ? (
             <div className="space-y-4">
               <Skeleton className="h-8 w-full" />

package/src/components/schedules/schedule-form.tsx

@@ -63,6 +63,7 @@ export interface ScheduleFormValues {
   activeTimezone: string;
   heartbeatBudgetPerDay: number | "";
   documentIds: string[];
+  maxTurns: number | null;
 }
 
 export interface ScheduleFormInitialValues {
@@ -76,6 +77,7 @@ export interface ScheduleFormInitialValues {
   recurs: boolean;
   maxFirings: number | null;
   expiresAt: string | null;
+  maxTurns?: number | null;
 }
 
 interface ScheduleFormProps {
@@ -140,6 +142,7 @@ export function ScheduleForm({
   const [expiresInHours, setExpiresInHours] = useState<number | "">(
     initialValues ? "" : ""
   );
+  const [maxTurns, setMaxTurns] = useState<number | null>(initialValues?.maxTurns ?? null);
   const [profiles, setProfiles] = useState<ProfileOption[]>([]);
 
   // NL schedule input state
@@ -279,6 +282,7 @@ export function ScheduleForm({
       activeTimezone,
       heartbeatBudgetPerDay,
       documentIds: [...selectedDocIds],
+      maxTurns,
     });
   }
 
@@ -507,6 +511,13 @@ export function ScheduleForm({
             ? "Extra instructions appended to the heartbeat evaluation"
             : "Instructions for each execution"}
         </p>
+        {scheduleType === "scheduled" && (
+          <p className="text-muted-foreground text-xs">
+            Note: writing &quot;MAX N turns&quot; in your prompt is a hint to the model,
+            not a runtime limit. Use <strong>Max agent steps</strong> below to enforce
+            a budget.
+          </p>
+        )}
       </div>
 
       {/* Natural Language Schedule Input */}
@@ -640,6 +651,26 @@ export function ScheduleForm({
         )}
       </div>
 
+      {/* Max agent steps */}
+      <div className="space-y-2">
+        <Label htmlFor="max-turns">Max agent steps per run</Label>
+        <Input
+          id="max-turns"
+          type="number"
+          min={1}
+          max={10000}
+          placeholder="Inherits global default"
+          value={maxTurns ?? ""}
+          onChange={(e) =>
+            setMaxTurns(e.target.value ? parseInt(e.target.value, 10) : null)
+          }
+        />
+        <p className="text-muted-foreground text-xs">
+          One step = one agent action (message, tool call, or sub-response). Most
+          schedules use 50–500 steps; heavy research runs 2,000+.
+        </p>
+      </div>
+
       {/* Project */}
       {projects.length > 0 && (
         <div className="space-y-2">

package/src/components/settings/__tests__/providers-runtimes-section.test.tsx

@@ -0,0 +1,149 @@
+import { render, screen, waitFor } from "@testing-library/react";
+import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
+
+import { ProvidersAndRuntimesSection } from "@/components/settings/providers-runtimes-section";
+
+describe("providers and runtimes section", () => {
+  beforeEach(() => {
+    vi.clearAllMocks();
+    vi.stubGlobal("open", vi.fn());
+    vi.stubGlobal(
+      "fetch",
+      vi.fn(async (input: RequestInfo | URL, init?: RequestInit) => {
+        const url = String(input);
+        const method = init?.method ?? "GET";
+
+        if (url === "/api/settings/providers" && method === "GET") {
+          return {
+            ok: true,
+            json: async () => ({
+              providers: {
+                anthropic: {
+                  configured: false,
+                  authMethod: "api_key",
+                  hasKey: false,
+                  apiKeySource: "unknown",
+                  dualBilling: false,
+                  runtimes: [
+                    {
+                      runtimeId: "claude-code",
+                      label: "Claude Code",
+                      providerId: "anthropic",
+                      configured: false,
+                      authMethod: "none",
+                      apiKeySource: "unknown",
+                      billingMode: "usage",
+                    },
+                    {
+                      runtimeId: "anthropic-direct",
+                      label: "Anthropic Direct API",
+                      providerId: "anthropic",
+                      configured: false,
+                      authMethod: "none",
+                      apiKeySource: "unknown",
+                      billingMode: "usage",
+                    },
+                  ],
+                },
+                openai: {
+                  configured: true,
+                  authMethod: "oauth",
+                  hasKey: true,
+                  apiKeySource: "env",
+                  oauthConnected: false,
+                  account: null,
+                  rateLimits: null,
+                  login: {
+                    phase: "idle",
+                    loginId: null,
+                    authUrl: null,
+                    account: null,
+                    rateLimits: null,
+                    error: null,
+                    startedAt: null,
+                    updatedAt: new Date("2026-04-10T15:00:00.000Z").toISOString(),
+                  },
+                  dualBilling: false,
+                  runtimes: [
+                    {
+                      runtimeId: "openai-codex-app-server",
+                      label: "OpenAI Codex App Server",
+                      providerId: "openai",
+                      configured: false,
+                      authMethod: "oauth",
+                      apiKeySource: "oauth",
+                      billingMode: "usage",
+                    },
+                    {
+                      runtimeId: "openai-direct",
+                      label: "OpenAI Direct API",
+                      providerId: "openai",
+                      configured: true,
+                      authMethod: "api_key",
+                      apiKeySource: "env",
+                      billingMode: "usage",
+                    },
+                  ],
+                },
+              },
+              routingPreference: "quality",
+              configuredProviderCount: 1,
+            }),
+          };
+        }
+
+        if (url === "/api/settings/openai/login" && method === "POST") {
+          return {
+            ok: true,
+            json: async () => ({
+              phase: "pending",
+              loginId: "login-1",
+              authUrl: "https://auth.openai.com/log-in",
+              account: null,
+              rateLimits: null,
+              error: null,
+              startedAt: new Date("2026-04-10T15:01:00.000Z").toISOString(),
+              updatedAt: new Date("2026-04-10T15:01:00.000Z").toISOString(),
+            }),
+          };
+        }
+
+        throw new Error(`Unexpected fetch: ${url}`);
+      })
+    );
+  });
+
+  afterEach(() => {
+    vi.unstubAllGlobals();
+  });
+
+  it("shows partial OpenAI setup state when ChatGPT auth is selected but not connected", async () => {
+    render(<ProvidersAndRuntimesSection />);
+
+    await waitFor(() => {
+      expect(screen.getByText("Direct API only")).toBeInTheDocument();
+    });
+
+    expect(
+      screen.getByText("Codex App Server needs ChatGPT sign-in. OpenAI Direct API remains active.")
+    ).toBeInTheDocument();
+    expect(screen.getAllByText("Sign in with ChatGPT")).toHaveLength(2);
+  });
+
+  it("updates the provider row immediately when ChatGPT sign-in starts", async () => {
+    render(<ProvidersAndRuntimesSection />);
+
+    const signInButton = await screen.findByRole("button", {
+      name: "Sign in with ChatGPT",
+    });
+    signInButton.click();
+
+    await waitFor(() => {
+      expect(
+        screen.getByText("Waiting for ChatGPT sign-in. OpenAI Direct API remains active.")
+      ).toBeInTheDocument();
+    });
+
+    expect(screen.getAllByText("Waiting for ChatGPT sign-in")).toHaveLength(2);
+  });
+});

package/src/components/settings/auth-method-selector.tsx

@@ -4,13 +4,22 @@ import { Key, Shield } from "lucide-react";
 import { cn } from "@/lib/utils";
 import type { AuthMethod } from "@/lib/constants/settings";
 
+interface AuthMethodOption {
+  id: AuthMethod;
+  icon: typeof Key;
+  title: string;
+  description: string;
+}
+
 interface AuthMethodSelectorProps {
   value: AuthMethod;
   onChange: (method: AuthMethod) => void;
   recommendedMethod?: AuthMethod | null;
+  label?: string;
+  options?: AuthMethodOption[];
 }
 
-const methods = [
+const defaultMethods = [
   {
     id: "api_key" as const,
     icon: Key,
@@ -25,12 +34,18 @@ const methods = [
   },
 ];
 
-export function AuthMethodSelector({ value, onChange, recommendedMethod }: AuthMethodSelectorProps) {
+export function AuthMethodSelector({
+  value,
+  onChange,
+  recommendedMethod,
+  label = "Authentication Method",
+  options = defaultMethods,
+}: AuthMethodSelectorProps) {
   return (
     <div className="space-y-2">
-      <p className="text-sm font-medium">Authentication Method</p>
+      <p className="text-sm font-medium">{label}</p>
       <div className="grid grid-cols-2 gap-3">
-        {methods.map((method) => {
+        {options.map((method) => {
           const Icon = method.icon;
           const isSelected = value === method.id;
           return (

package/src/components/settings/auth-status-badge.tsx

@@ -1,21 +1,30 @@
 "use client";
 
 import { Badge } from "@/components/ui/badge";
-import type { ApiKeySource } from "@/lib/constants/settings";
+import type { ApiKeySource, AuthMethod } from "@/lib/constants/settings";
 
 interface AuthStatusBadgeProps {
   connected: boolean;
   apiKeySource: ApiKeySource;
+  authMethod?: AuthMethod | "none";
+  oauthLabel?: string;
+  oauthConnected?: boolean;
 }
 
 const sourceLabels: Record<ApiKeySource, string> = {
   db: "Managed API Key",
   env: "Environment Variable",
-  oauth: "OAuth (Claude Max/Pro)",
+  oauth: "OAuth",
   unknown: "Unknown",
 };
 
-export function AuthStatusBadge({ connected, apiKeySource }: AuthStatusBadgeProps) {
+export function AuthStatusBadge({
+  connected,
+  apiKeySource,
+  authMethod,
+  oauthLabel = "OAuth",
+  oauthConnected,
+}: AuthStatusBadgeProps) {
   if (!connected && apiKeySource === "unknown") {
     return (
       <Badge variant="outline" className="border-warning/50 text-warning">
@@ -32,6 +41,22 @@ export function AuthStatusBadge({ connected, apiKeySource }: AuthStatusBadgeProp
     );
   }
 
+  if (connected && authMethod === "oauth" && oauthConnected === false) {
+    return (
+      <Badge variant="outline" className="border-status-warning/50 text-status-warning">
+        Direct API only
+      </Badge>
+    );
+  }
+
+  if (connected && authMethod === "oauth" && (oauthConnected ?? true)) {
+    return (
+      <Badge variant="outline" className="border-success/50 text-success">
+        Connected via {oauthLabel}
+      </Badge>
+    );
+  }
+
   if (apiKeySource === "unknown") {
     return (
       <Badge variant="outline" className="border-success/50 text-success">