ssh2-sftp-client 9.0.2 → 9.0.3

package/README.md

@@ -1,66 +1,66 @@
-- [Overview](#org50de852)
-  - [Version 9.x Changes](#orgaeda8f1)
-- [Installation](#orgf01877e)
-- [Basic Usage](#org5950004)
-- [Documentation](#org5057006)
-  - [Specifying Paths](#org4ef62d6)
-  - [Methods](#org197917e)
-    - [new SftpClient(name) ===> SFTP client object](#orge668bfa)
-    - [connect(config) ===> SFTP object](#orgcf80c45)
-    - [list(path, filter) ==> Array[object]](#org329ff56)
-    - [exists(path) ==> boolean](#orgc52d8a8)
-    - [stat(path) ==> object](#orgcfa8682)
-    - [get(path, dst, options) ==> String|Stream|Buffer](#orgbe46842)
-    - [fastGet(remotePath, localPath, options) ===> string](#org740cf5c)
-    - [put(src, remotePath, options) ==> string](#org429e96a)
-    - [fastPut(localPath, remotePath, options) ==> string](#orgcab50c6)
-    - [append(input, remotePath, options) ==> string](#orgc15d676)
-    - [mkdir(path, recursive) ==> string](#org6fab860)
-    - [rmdir(path, recursive) ==> string](#org520f6bc)
-    - [delete(path, noErrorOK) ==> string](#org1be8ca9)
-    - [rename(fromPath, toPath) ==> string](#org3d89131)
-    - [posixRename(fromPath, toPath) ==> string](#org58dfee5)
-    - [chmod(path, mode) ==> string](#orgb319965)
-    - [realPath(path) ===> string](#orgf665476)
-    - [cwd() ==> string](#org409acd1)
-    - [uploadDir(srcDir, dstDir, options) ==> string](#org668b085)
-    - [downloadDir(srcDir, dstDir, options) ==> string](#org395ac4e)
-    - [createReadStream(remotePath, options)) ==> stream object](#org8a73b83)
-    - [createWriteStream(remotePath, options) ==> stream object](#orgb71fb72)
-    - [rcopy(srcPath, dstPath) ==> string](#org936f530)
-    - [end() ==> boolean](#org62a8323)
-    - [Add and Remove Listeners](#orgd1ebc36)
-- [Platform Quirks & Warnings](#orgdfff943)
-  - [Server Capabilities](#org886fe2e)
-  - [Issues with `fastPut()` and `fastGet()` Methods](#org1719a52)
-  - [Promises, Events & Managing Exceptions](#org42a51fc)
-    - [Adding Custom Handlers](#orgd50a35a)
-  - [Windows Based Servers](#org7b0987f)
-  - [Don't Re-use SftpClient Objects](#orgbe548c2)
-- [FAQ](#orgfddb94b)
-  - [Remote server drops connections with only an end event](#orgbd2a31e)
-  - [How can I pass writable stream as dst for get method?](#org9d72a61)
-  - [How can I upload files without having to specify a password?](#org9fda086)
-  - [How can I connect through a Socks Proxy](#org2ccc5e8)
-  - [Timeout while waiting for handshake or handshake errors](#org5306b6f)
-  - [How can I limit upload/download speed](#org3a77529)
-  - [Connection hangs or fails for larger files](#org68eedc7)
-- [Examples](#orgd436fa7)
-- [Troubleshooting](#orge21d870)
-  - [Common Errors](#org287b86f)
-    - [Not returning the promise in a `then()` block](#org20a99bb)
-    - [Mixing Promise Chains and Async/Await](#org51482b4)
-    - [Try/catch and Error Handlers](#orgb9a556a)
-    - [Server Differences](#org0d148f0)
-    - [Avoid Concurrent Operations](#orgf115391)
-  - [Debugging Support](#orgc7c437f)
-- [Logging Issues](#orgc79ef28)
-- [Pull Requests](#org64bd2a2)
-- [Contributors](#org709b0f9)
-
-
-
-<a id="org50de852"></a>
+- [Overview](#orgd38e3db)
+  - [Version 9.x Changes](#orgbc6dbf7)
+- [Installation](#org8538ac8)
+- [Basic Usage](#org0e586d6)
+- [Documentation](#org8b956c0)
+  - [Specifying Paths](#orge4d511d)
+  - [Methods](#org54a5a5f)
+    - [new SftpClient(name) ===> SFTP client object](#org7e1be88)
+    - [connect(config) ===> SFTP object](#org4d439ac)
+    - [list(path, filter) ==> Array[object]](#org1cdf979)
+    - [exists(path) ==> boolean](#org27dfbbb)
+    - [stat(path) ==> object](#org989df3b)
+    - [get(path, dst, options) ==> String|Stream|Buffer](#orgc4730e8)
+    - [fastGet(remotePath, localPath, options) ===> string](#org2f58141)
+    - [put(src, remotePath, options) ==> string](#org6859ddc)
+    - [fastPut(localPath, remotePath, options) ==> string](#org62993ea)
+    - [append(input, remotePath, options) ==> string](#orgbac60b5)
+    - [mkdir(path, recursive) ==> string](#orgf266033)
+    - [rmdir(path, recursive) ==> string](#orgcb249fd)
+    - [delete(path, noErrorOK) ==> string](#orgfef0bf5)
+    - [rename(fromPath, toPath) ==> string](#org916cc1f)
+    - [posixRename(fromPath, toPath) ==> string](#org590854d)
+    - [chmod(path, mode) ==> string](#orgf437cd4)
+    - [realPath(path) ===> string](#org22161d6)
+    - [cwd() ==> string](#orgdba7a3a)
+    - [uploadDir(srcDir, dstDir, options) ==> string](#org583c51e)
+    - [downloadDir(srcDir, dstDir, options) ==> string](#orgc06694a)
+    - [createReadStream(remotePath, options)) ==> stream object](#org5163593)
+    - [createWriteStream(remotePath, options) ==> stream object](#orgbeba46f)
+    - [rcopy(srcPath, dstPath) ==> string](#orgfab48e5)
+    - [end() ==> boolean](#org9ffad87)
+    - [Add and Remove Listeners](#org5c294b3)
+- [Platform Quirks & Warnings](#org6e33ff1)
+  - [Server Capabilities](#org0b56fde)
+  - [Issues with `fastPut()` and `fastGet()` Methods](#org7c6eba4)
+  - [Promises, Events & Managing Exceptions](#org38e15f9)
+    - [Adding Custom Handlers](#org10f1f65)
+  - [Windows Based Servers](#org7057905)
+  - [Don't Re-use SftpClient Objects](#org1775ff2)
+- [FAQ](#org683ae73)
+  - [Remote server drops connections with only an end event](#org7e12a90)
+  - [How can I pass writable stream as dst for get method?](#org7f93e7e)
+  - [How can I upload files without having to specify a password?](#org6f24d1a)
+  - [How can I connect through a Socks Proxy](#org59a22c0)
+  - [Timeout while waiting for handshake or handshake errors](#org0439a3c)
+  - [How can I limit upload/download speed](#orge773153)
+  - [Connection hangs or fails for larger files](#orgf14374e)
+- [Examples](#orge58bfb0)
+- [Troubleshooting](#org5c3ee29)
+  - [Common Errors](#orgd46a3a1)
+    - [Not returning the promise in a `then()` block](#org41486a0)
+    - [Mixing Promise Chains and Async/Await](#org36f96d6)
+    - [Try/catch and Error Handlers](#org367d856)
+    - [Server Differences](#org180dea0)
+    - [Avoid Concurrent Operations](#org2bfd976)
+  - [Debugging Support](#org9590bf5)
+- [Logging Issues](#orga4f395e)
+- [Pull Requests](#orgbed06d9)
+- [Contributors](#org7b575e4)
+
+
+
+<a id="orgd38e3db"></a>
 
 # Overview
 
@@ -75,10 +75,12 @@ Code has been tested against Node versions 14.19.1, 16.15.0 and 18.1.0
 Node versions < 14.x are not supported.
 
 
-<a id="orgaeda8f1"></a>
+<a id="orgbc6dbf7"></a>
 
 ## Version 9.x Changes
 
+-   Fix bug in `end()` method where it was possible for the module to attempt calling the underlying ssh2 `end()` method when ssh2 has not been initialised. This could lead to undefined reference errors.
+-   Fix bug in `get()` method where supplied destination streams were not close, creating a possible resource leak. If the remote file did not exist, the method would return an error, but failed to close any passed in stream supplied as the destination for the data in the `get()` call.
 -   Change the default end and close handlers not to throw error or reject promises. Previously, an end or close event would cause an error to be raised or a promise to be rejected if the event was deemed to be *unexpected*. However, classification of events as being unexpected was unreliable and didn't add much real value. Both these handlers will now invalidate the sftp connection object and log that the event fired and nothing else.
 -   Changed when event handled flags are reset. Now they are reset after a new set of temporary listeners are added.
 -   Don't throw an error when calling end() if there is no active sftp connection. It does no harm to call end() when there is no connection, so no need to raise an error.
@@ -94,7 +96,7 @@ Node versions < 14.x are not supported.
 -   Bumped ssh2 version to 1.11.0
 
 
-<a id="orgf01877e"></a>
+<a id="org8538ac8"></a>
 
 # Installation
 
@@ -103,7 +105,7 @@ npm install ssh2-sftp-client
 ```
 
 
-<a id="org5950004"></a>
+<a id="org0e586d6"></a>
 
 # Basic Usage
 
@@ -126,7 +128,7 @@ sftp.connect({
 ```
 
 
-<a id="org5057006"></a>
+<a id="org8b956c0"></a>
 
 # Documentation
 
@@ -135,7 +137,7 @@ The connection options are the same as those offered by the underlying SSH2 modu
 All the methods will return a Promise, except for `on()` and `removeListener()`, which are typically only used in special use cases.
 
 
-<a id="org4ef62d6"></a>
+<a id="orge4d511d"></a>
 
 ## Specifying Paths
 
@@ -168,12 +170,12 @@ client.put('/home/fred/test.txt', '/remote/dir/test-copy.txt');
 This will copy the local file `test.txt` to the remote file `test-copy.txt` in the directory `/remote/dir`.
 
 
-<a id="org197917e"></a>
+<a id="org54a5a5f"></a>
 
 ## Methods
 
 
-<a id="orge668bfa"></a>
+<a id="org7e1be88"></a>
 
 ### new SftpClient(name) ===> SFTP client object
 
@@ -212,7 +214,7 @@ Constructor to create a new `ssh2-sftp-client` object. An optional `name` string
     ```
 
 
-<a id="orgcf80c45"></a>
+<a id="org4d439ac"></a>
 
 ### connect(config) ===> SFTP object
 
@@ -278,7 +280,7 @@ Connect to an sftp server. Full documentation for connection options is availabl
     ```
 
 
-<a id="org329ff56"></a>
+<a id="org1cdf979"></a>
 
 ### list(path, filter) ==> Array[object]
 
@@ -338,18 +340,8 @@ Retrieves a directory listing. This method returns a Promise, which once realise
     }
     ```
 
-3.  Pattern Filter
 
-    The filter options can be a regular expression (most powerful option) or a simple *glob*-like string where \* will match any number of characters, e.g.
-    
-        foo* => foo, foobar, foobaz
-        *bar => bar, foobar, tabbar
-        *oo* => foo, foobar, look, book
-    
-    The *glob*-style matching is very simple. In most cases, you are best off using a real regular expression which will allow you to do more powerful matching and anchor matches to the beginning/end of the string etc.
-
-
-<a id="orgc52d8a8"></a>
+<a id="org27dfbbb"></a>
 
 ### exists(path) ==> boolean
 
@@ -385,7 +377,7 @@ Tests to see if remote file or directory exists. Returns type of remote object i
     ```
 
 
-<a id="orgcfa8682"></a>
+<a id="org989df3b"></a>
 
 ### stat(path) ==> object
 
@@ -436,7 +428,7 @@ Returns the attributes associated with the object pointed to by `path`.
     ```
 
 
-<a id="orgbe46842"></a>
+<a id="orgc4730e8"></a>
 
 ### get(path, dst, options) ==> String|Stream|Buffer
 
@@ -492,7 +484,7 @@ In general, if you're going to pass in a string as the destination, you are bett
     -   **Tip:** See examples file in the Git repository for more examples. You can pass any writeable stream in as the destination. For example, if you pass in `zlib.createGunzip()` writeable stream, you can both download and decompress a gzip file 'on the fly'.
 
 
-<a id="org740cf5c"></a>
+<a id="org2f58141"></a>
 
 ### fastGet(remotePath, localPath, options) ===> string
 
@@ -535,7 +527,7 @@ Downloads a file at remotePath to localPath using parallel reads for faster thro
     ```
 
 
-<a id="org429e96a"></a>
+<a id="org6859ddc"></a>
 
 ### put(src, remotePath, options) ==> string
 
@@ -585,7 +577,7 @@ Upload data from local system to remote server. If the `src` argument is a strin
     -   **Tip:** If the src argument is a path string, consider just using `fastPut()`.
 
 
-<a id="orgcab50c6"></a>
+<a id="org62993ea"></a>
 
 ### fastPut(localPath, remotePath, options) ==> string
 
@@ -629,7 +621,7 @@ Uploads the data in file at `localPath` to a new file on remote server at `remot
     ```
 
 
-<a id="orgc15d676"></a>
+<a id="orgbac60b5"></a>
 
 ### append(input, remotePath, options) ==> string
 
@@ -673,7 +665,7 @@ Append the `input` data to an existing remote file. There is no integrity checki
     ```
 
 
-<a id="org6fab860"></a>
+<a id="orgf266033"></a>
 
 ### mkdir(path, recursive) ==> string
 
@@ -701,7 +693,7 @@ Create a new directory. If the recursive flag is set to true, the method will cr
     ```
 
 
-<a id="org520f6bc"></a>
+<a id="orgcb249fd"></a>
 
 ### rmdir(path, recursive) ==> string
 
@@ -731,7 +723,7 @@ Remove a directory. If removing a directory and recursive flag is set to `true`,
     ```
 
 
-<a id="org1be8ca9"></a>
+<a id="orgfef0bf5"></a>
 
 ### delete(path, noErrorOK) ==> string
 
@@ -760,7 +752,7 @@ Delete a file on the remote server.
     ```
 
 
-<a id="org3d89131"></a>
+<a id="org916cc1f"></a>
 
 ### rename(fromPath, toPath) ==> string
 
@@ -789,7 +781,7 @@ Rename a file or directory from `fromPath` to `toPath`. You must have the necess
     ```
 
 
-<a id="org58dfee5"></a>
+<a id="org590854d"></a>
 
 ### posixRename(fromPath, toPath) ==> string
 
@@ -816,7 +808,7 @@ client.connect(config)
 ```
 
 
-<a id="orgb319965"></a>
+<a id="orgf437cd4"></a>
 
 ### chmod(path, mode) ==> string
 
@@ -845,7 +837,7 @@ Change the mode (read, write or execute permissions) of a remote file or directo
     ```
 
 
-<a id="orgf665476"></a>
+<a id="org22161d6"></a>
 
 ### realPath(path) ===> string
 
@@ -856,14 +848,14 @@ Converts a relative path to an absolute path on the remote server. This method i
 -   **path:** A file path, either relative or absolute. Can handle '.' and '..', but does not expand '~'.
 
 
-<a id="org409acd1"></a>
+<a id="orgdba7a3a"></a>
 
 ### cwd() ==> string
 
 Returns what the server believes is the current remote working directory.
 
 
-<a id="org668b085"></a>
+<a id="org583c51e"></a>
 
 ### uploadDir(srcDir, dstDir, options) ==> string
 
@@ -932,7 +924,7 @@ The `useFastput` option is a boolean option. If `true`, the method will use the
     ```
 
 
-<a id="org395ac4e"></a>
+<a id="orgc06694a"></a>
 
 ### downloadDir(srcDir, dstDir, options) ==> string
 
@@ -997,7 +989,7 @@ If the `useFastget` property is set to `true`, the method will use `fastGet()` t
     ```
 
 
-<a id="org8a73b83"></a>
+<a id="org5163593"></a>
 
 ### createReadStream(remotePath, options)) ==> stream object
 
@@ -1014,7 +1006,7 @@ Returns a read stream object which is attached to the remote file specified by t
     -   **end:** Postion to stop reading bytes (inclusive).
 
 
-<a id="orgb71fb72"></a>
+<a id="orgbeba46f"></a>
 
 ### createWriteStream(remotePath, options) ==> stream object
 
@@ -1029,7 +1021,7 @@ Returns a write stream object which is attached to the remote file specified in
     -   **start:** Byte position to start writing from (inclusive). May require changing flag to 'r+'.
 
 
-<a id="org936f530"></a>
+<a id="orgfab48e5"></a>
 
 ### rcopy(srcPath, dstPath) ==> string
 
@@ -1039,7 +1031,7 @@ Perfrom a remote file copy. The file identified by the `srcPath` argument will b
 -   **dstPath:** Path to where the copy will be creaeted specified as a string
 
 
-<a id="org62a8323"></a>
+<a id="org9ffad87"></a>
 
 ### end() ==> boolean
 
@@ -1063,7 +1055,7 @@ Ends the current client session, releasing the client socket and associated reso
     ```
 
 
-<a id="orgd1ebc36"></a>
+<a id="org5c294b3"></a>
 
 ### Add and Remove Listeners
 
@@ -1084,12 +1076,12 @@ Although normally not required, you can add and remove custom listeners on the s
     Removes the specified listener from the event specified in eventType. Note that the `end()` method automatically removes all listeners from the client object.
 
 
-<a id="orgdfff943"></a>
+<a id="org6e33ff1"></a>
 
 # Platform Quirks & Warnings
 
 
-<a id="org886fe2e"></a>
+<a id="org0b56fde"></a>
 
 ## Server Capabilities
 
@@ -1098,7 +1090,7 @@ All SFTP servers and platforms are not equal. Some facilities provided by `ssh2-
 One way to determine whether an issue you are encountering is due to `ssh2-sftp-client` or due to the remote server or server platform is to use a simple CLI sftp program, such as openSSH's sftp command. If you observe the same behaviour using plain `sftp` on the command line, the issue is likely due to server or remote platform limitations. Note that you should not use a GUI sftp client, like `Filezilla` or `winSCP` as such GUI programs often attempt to hide these server and platform incompatibilities and will take additional steps to simulate missing functionality etc. You want to use a CLI program which does as little as possible.
 
 
-<a id="org1719a52"></a>
+<a id="org7c6eba4"></a>
 
 ## Issues with `fastPut()` and `fastGet()` Methods
 
@@ -1107,7 +1099,7 @@ The `fastPut()` and `fastGet()` methods are known to be somewhat dependent on SF
 To see an example of the type of issues you can observe with `fastPut()` or `fastGet()`, have a look at [issue 407](https://github.com/theophilusx/ssh2-sftp-client/issues/407), which describes the experiences of one user. Bottom line, when it works, it tends to work well and be significantly faster than using just `get()` or `put()`. However, when developing code to run against different SFTP servers, especially where you are unable to test against each server, you are likely better off just using `get()` and `put()` or structuring your code so that users can select which method to use (this is what `ssh2-sftp-client` does - for example, see the `!downloadDir()` and `uploadDir()` methods.
 
 
-<a id="org42a51fc"></a>
+<a id="org38e15f9"></a>
 
 ## Promises, Events & Managing Exceptions
 
@@ -1126,14 +1118,14 @@ The other area where additional events are fired is during the end() call. To de
 In addition to the promise based event handlers, `ssh2-sftp-client` also implements global event handlers which will catch any `error`, `end` or `close` events. Essentially, these global handlers only reset the `sftp` property of the client object, effectively ensuring any subsequent calls are rejected and in the case of an error, send the error to the console.
 
 
-<a id="orgd50a35a"></a>
+<a id="org10f1f65"></a>
 
 ### Adding Custom Handlers
 
 While the above strategies appear to work for the majority of use cases, there are always going to be edge cases which require more flexible or powerful event handling. To support this, the `on()` and `removeListener()` methods are provided. Any event listener added using the `on()` method will be added at the beginning of the list of handlers for that event, ensuring it will be called before any global or promise local events. See the documentation for the `on()` method for details.
 
 
-<a id="org7b0987f"></a>
+<a id="org7057905"></a>
 
 ## Windows Based Servers
 
@@ -1142,7 +1134,7 @@ It appears that when the sftp server is running on Windows, a *ECONNRESET* error
 The best way to avoid this issue is to not re-use client objects. Always generate a new sftp client object for each new connection.
 
 
-<a id="orgbe548c2"></a>
+<a id="org1775ff2"></a>
 
 ## Don't Re-use SftpClient Objects
 
@@ -1151,12 +1143,12 @@ Due to an issue with *ECONNRESET* error signals when connecting to Windows based
 To avoid this problem, don't re-use SftpClient objects. Generate a new SftpClient object for each connection. You can perform multiple actions with a single connection e.g. upload multiple files, download multiple files etc, but after you have called end(), you should not try to re-use the object with a further connect() call. Create a new object instead.
 
 
-<a id="orgfddb94b"></a>
+<a id="org683ae73"></a>
 
 # FAQ
 
 
-<a id="orgbd2a31e"></a>
+<a id="org7e12a90"></a>
 
 ## Remote server drops connections with only an end event
 
@@ -1167,7 +1159,7 @@ Clients first make an unauthenticated connection to the SFTP server to begin neg
 One way to avoid this type of issue is to add a delay between connection attempts. It does not need to be a very long delay - just sufficient to permit the previous connection to be authenticated. In fact, the default setting for openSSH is `10:30:60`, so you really just need to have enough delay to ensure that the 1st connection has completed authentication before the 11th connection is attempted.
 
 
-<a id="org9d72a61"></a>
+<a id="org7f93e7e"></a>
 
 ## How can I pass writable stream as dst for get method?
 
@@ -1226,7 +1218,7 @@ sftp
 ```
 
 
-<a id="org9fda086"></a>
+<a id="org6f24d1a"></a>
 
 ## How can I upload files without having to specify a password?
 
@@ -1261,7 +1253,7 @@ sftp.connect({
 ```
 
 
-<a id="org2ccc5e8"></a>
+<a id="org59a22c0"></a>
 
 ## How can I connect through a Socks Proxy
 
@@ -1297,7 +1289,7 @@ client.connect({
 ```
 
 
-<a id="org5306b6f"></a>
+<a id="org0439a3c"></a>
 
 ## Timeout while waiting for handshake or handshake errors
 
@@ -1306,7 +1298,7 @@ Some users have encountered the error 'Timeout while waiting for handshake' or '
 When encountering this type of problem, one worthwhile approach is to use openSSH's CLI sftp program with the `-v` switch to raise loggin levels. This will show you what algorithms the CLI is using. You can then use this information to match the names with the accepted algorithm names documented in the `ssh2` README to set the properties in the `algorithms` object.
 
 
-<a id="org3a77529"></a>
+<a id="orge773153"></a>
 
 ## How can I limit upload/download speed
 
@@ -1346,7 +1338,7 @@ try {
 ```
 
 
-<a id="org68eedc7"></a>
+<a id="orgf14374e"></a>
 
 ## Connection hangs or fails for larger files
 
@@ -1357,14 +1349,14 @@ A symptom of this issue is that you are able to upload small files, but uploadin
 For more explanation, see [issue #342](https://github.com/theophilusx/ssh2-sftp-client/issues/342).
 
 
-<a id="orgd436fa7"></a>
+<a id="orge58bfb0"></a>
 
 # Examples
 
 I have started collecting example scripts in the example directory of the repository. These are mainly scripts I have put together in order to investigate issues or provide samples for users. They are not robust, lack adequate error handling and may contain errors. However, I think they are still useful for helping developers see how the module and API can be used.
 
 
-<a id="orge21d870"></a>
+<a id="org5c3ee29"></a>
 
 # Troubleshooting
 
@@ -1379,14 +1371,14 @@ Note also that in the repository there are two useful directories. The first is
 The second directory is the validation directory. I have some very simple scripts in this directory which perform basic tasks using only the `ssh2` modules (no `ssh2-sftp-client` module). These can be useful when trying to determine if the issue is with the underlying `ssh2` module or the `ssh2-sftp-client` wrapper module.
 
 
-<a id="org287b86f"></a>
+<a id="orgd46a3a1"></a>
 
 ## Common Errors
 
 There are some common errors people tend to make when using Promises or Asyc/Await. These are by far the most common problem found in issues logged against this module. Please check for some of these before logging your issue.
 
 
-<a id="org20a99bb"></a>
+<a id="org41486a0"></a>
 
 ### Not returning the promise in a `then()` block
 
@@ -1423,7 +1415,7 @@ Note the `return` statements. These ensure that the Promise returned by the clie
 A common symptom of this type of error is for file uploads or download to fail to complete or for data in those files to be truncated. What is happening is that the connection is being ended before the transfer has completed.
 
 
-<a id="org51482b4"></a>
+<a id="org36f96d6"></a>
 
 ### Mixing Promise Chains and Async/Await
 
@@ -1483,7 +1475,7 @@ async function doSftp() {
 ```
 
 
-<a id="orgb9a556a"></a>
+<a id="org367d856"></a>
 
 ### Try/catch and Error Handlers
 
@@ -1494,14 +1486,14 @@ The basic problem is that the try/catch block will have completed execution befo
 Error events are essentially asynchronous code. You don't know when such events will fire. Therefore, you cannot use a try/catch block to catch such event errors. Even creating an error handler which then throws an exception won't help as the key problem is that your try/catch block has already executed. There are a number of alternative ways to deal with this situation. However, the key symptom is that you see occasional uncaught error exceptions that cause your script to exit abnormally despite having try/catch blocks in your script. What you need to do is look at your code and find where errors are raised asynchronously and use an event handler or some other mechanism to manage any errors raised.
 
 
-<a id="org0d148f0"></a>
+<a id="org180dea0"></a>
 
 ### Server Differences
 
 Not all SFTP servers are the same. Like most standards, the SFTP protocol has some level of interpretation and allows different levels of compliance. This means there can be differences in behaviour between different servers and code which works with one server will not work the same with another. For example, the value returned by *realpath* for non-existent objects can differ significantly. Some servers will throw an error for a particular operation while others will just return null, some servers support concurrent operations (such as used by fastGet/fastPut) while others will not and of course, the text of error messages can vary significantly. In particular, we have noticed significant differences across different platforms. It is therefore advisable to do comprehensive testing when the SFTP server is moved to a new platform. This includes moving from to a cloud based service even if the underlying platform remains the same. I have noticed that some cloud platforms can generate unexpected events, possibly related to additional functionality or features associated with the cloud implementation. For example, it appears SFTP servers running under Azure will generate an error event when the connection is closed even when the client has requested the connection be terminated. The same SFTP server running natively on Windows does not appear to exhibit such behaviour.
 
 
-<a id="orgf115391"></a>
+<a id="org2bfd976"></a>
 
 ### Avoid Concurrent Operations
 
@@ -1510,7 +1502,7 @@ Technically, SFTP should be able to perform multiple operations concurrently. As
 If you are going to try and perform concurrent operations, you need to test extensively and ensure you are using data which is large enough that context switching does occur (i.e. the request is not completed in a single run). Some SFTP servers will handle concurrent operations better than others.
 
 
-<a id="orgc7c437f"></a>
+<a id="org9590bf5"></a>
 
 ## Debugging Support
 
@@ -1543,7 +1535,7 @@ If you just want to see debug messages from `ssh2-sftp-client` and exclude debug
 ```
 
 
-<a id="orgc79ef28"></a>
+<a id="orga4f395e"></a>
 
 # Logging Issues
 
@@ -1560,7 +1552,7 @@ I am happy to try and help diagnose and fix any issues you encounter while using
 Perhaps the best assistance is a minimal reproducible example of the issue. Once the issue can be readily reproduced, it can usually be fixed very quickly.
 
 
-<a id="org64bd2a2"></a>
+<a id="orgbed06d9"></a>
 
 # Pull Requests
 
@@ -1575,7 +1567,7 @@ This module will adopt a standard semantic versioning policy. Please indicate in
 -   **Bug Fix:** No change to functionality or features. Simple fix of an existing bug.
 
 
-<a id="org709b0f9"></a>
+<a id="org7b575e4"></a>
 
 # Contributors
 

package/README.org

@@ -16,6 +16,13 @@ Code has been tested against Node versions 14.19.1, 16.15.0 and 18.1.0
 Node versions < 14.x are not supported. 
 
 ** Version 9.x Changes
+  - Fix bug in ~end()~ method where it was possible for the module to attempt calling
+    the underlying ssh2 ~end()~ method when ssh2 has not been initialised. This could
+    lead to undefined reference errors.
+  - Fix bug in ~get()~ method where supplied destination streams were not close, creating
+    a possible resource leak. If the remote file did not exist, the method would return
+    an error, but failed to close any passed in stream supplied as the destination for
+    the data in the ~get()~ call.    
   - Change the default end and close handlers not to throw error or reject
     promises. Previously, an end or close event would cause an error to be raised or a
     promise to be rejected if the event was deemed to be /unexpected/. However,
@@ -342,21 +349,6 @@ The objects in the array returned by ~list()~ have the following properties;
   }
 #+end_src
 
-**** Pattern Filter
-
-The filter options can be a regular expression (most powerful option) or a
-simple /glob/-like string where * will match any number of characters, e.g.
-
-#+begin_example
-  foo* => foo, foobar, foobaz
-  ,*bar => bar, foobar, tabbar
-  ,*oo* => foo, foobar, look, book
-#+end_example
-
-The /glob/-style matching is very simple. In most cases, you are best off using
-a real regular expression which will allow you to do more powerful matching and
-anchor matches to the beginning/end of the string etc.
-
 *** exists(path) ==> boolean
 
 Tests to see if remote file or directory exists. Returns type of remote object

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "ssh2-sftp-client",
-  "version": "9.0.2",
+  "version": "9.0.3",
   "description": "ssh2 sftp client for node",
   "main": "src/index.js",
   "repository": {
@@ -40,7 +40,7 @@
     "eslint-plugin-mocha": "^10.0.3",
     "eslint-plugin-node": "^11.1.0",
     "eslint-plugin-promise": "^6.0.0",
-    "eslint-plugin-unicorn": "^42.0.0",
+    "eslint-plugin-unicorn": "^43.0.2",
     "mocha": "^10.0.0",
     "moment": "^2.29.1",
     "nyc": "^15.1.0",

package/src/index.js

@@ -221,16 +221,16 @@ class SftpClient {
             case 'ENOTFOUND':
             case 'ECONNREFUSED':
             case 'ERR_SOCKET_BAD_PORT':
-            throw err;
-          case undefined: {
-            if (err.message.endsWith('All configured authentication methods failed')) {
-              throw this.fmtError(err.message, 'getConnection', errorCode.badAuth);
+              throw err;
+            case undefined: {
+              if (err.message.endsWith('All configured authentication methods failed')) {
+                throw this.fmtError(err.message, 'getConnection', errorCode.badAuth);
+              }
+              retry(err);
+              break;
             }
-            retry(err);
-            break;
-          }
-          default:
-            retry(err);
+            default:
+              retry(err);
           }
         }
       });
@@ -414,7 +414,7 @@ class SftpClient {
    * List contents of a remote directory. If a pattern is provided,
    * filter the results to only include files with names that match
    * the supplied pattern. Return value is an array of file entry
-   * objects that include properties for type, name, size, modifiyTime,
+   * objects that include properties for type, name, size, modifyTime,
    * accessTime, rights {user, group other}, owner and group.
    *
    * @param {String} remotePath - path to remote directory
@@ -498,6 +498,9 @@ class SftpClient {
       };
       rdr = this.sftp.createReadStream(rPath, opts.readStreamOptions);
       rdr.once('error', (err) => {
+        if (dst && typeof dst !== 'string' && !dst.destroyed) {
+          dst.destroy();
+        }
         reject(this.fmtError(`${err.message} ${rPath}`, '_get', err.code));
       });
       if (dst === undefined) {
@@ -1443,7 +1446,7 @@ class SftpClient {
         resolve(true);
       };
       this.on('close', endCloseHandler);
-      if (this.client) {
+      if (this.client.sftp) {
         this.client.end();
       } else {
         // no actual connection exists - just resolve