ssh-mcp 1.0.1 → 1.0.4

package/build/index.js

@@ -1,5 +1,3 @@
-// This file should be renamed to index.ts for TypeScript support
-import 'dotenv/config';
 import { McpServer } from '@modelcontextprotocol/sdk/server/mcp.js';
 import { McpError, ErrorCode } from "@modelcontextprotocol/sdk/types.js";
 import { Client as SSHClient } from 'ssh2';
@@ -24,9 +22,22 @@ const PORT = argvConfig.port ? parseInt(argvConfig.port) : 22;
 const USER = argvConfig.user;
 const PASSWORD = argvConfig.password;
 const KEY = argvConfig.key;
+function validateConfig(config) {
+    const errors = [];
+    if (!config.host)
+        errors.push('Missing required --host');
+    if (!config.user)
+        errors.push('Missing required --user');
+    if (config.port && isNaN(Number(config.port)))
+        errors.push('Invalid --port');
+    if (errors.length > 0) {
+        throw new Error('Configuration error:\n' + errors.join('\n'));
+    }
+}
+validateConfig(argvConfig);
 const server = new McpServer({
     name: 'SSH MCP Server',
-    version: '1.0.0',
+    version: '1.0.4',
     capabilities: {
         resources: {},
         tools: {},
@@ -35,20 +46,32 @@ const server = new McpServer({
 server.tool("exec", "Execute a shell command on the remote SSH server and return the output.", {
     command: z.string().describe("Shell command to execute on the remote SSH server"),
 }, async ({ command }) => {
+    // Sanitize command input
+    if (typeof command !== 'string' || !command.trim()) {
+        throw new McpError(ErrorCode.InternalError, 'Command must be a non-empty string.');
+    }
     const sshConfig = {
         host: HOST,
         port: PORT,
         username: USER,
     };
-    if (PASSWORD) {
-        sshConfig.password = PASSWORD;
+    try {
+        if (PASSWORD) {
+            sshConfig.password = PASSWORD;
+        }
+        else if (KEY) {
+            const fs = await import('fs/promises');
+            sshConfig.privateKey = await fs.readFile(KEY, 'utf8');
+        }
+        const result = await execSshCommand(sshConfig, command);
+        return result;
     }
-    else if (KEY) {
-        const fs = await import('fs/promises');
-        sshConfig.privateKey = await fs.readFile(KEY, 'utf8');
+    catch (err) {
+        // Wrap unexpected errors
+        if (err instanceof McpError)
+            throw err;
+        throw new McpError(ErrorCode.InternalError, `Unexpected error: ${err?.message || err}`);
     }
-    const result = await execSshCommand(sshConfig, command);
-    return result;
 });
 async function execSshCommand(sshConfig, command) {
     return new Promise((resolve, reject) => {

package/package.json

@@ -1,14 +1,15 @@
 {
   "name": "ssh-mcp",
-  "version": "1.0.1",
+  "license": "MIT",
+  "version": "1.0.4",
   "description": "MCP server exposing SSH control for Linux and Windows systems via Model Context Protocol.",
   "type": "module",
   "bin": {
-    "ssh-mcp": "./build/index.js"
+    "ssh-mcp": "build/index.js"
   },
   "scripts": {
     "prepare": "npm run build",
-    "build": "tsc --outDir build",
+    "build": "tsc && shx chmod +x build/*.js",
     "inspect": "npx @modelcontextprotocol/inspector node build/index.js"
   },
   "files": [
@@ -16,13 +17,13 @@
   ],
   "dependencies": {
     "@modelcontextprotocol/sdk": "^1.10.2",
-    "dotenv": "^16.3.1",
     "ssh2": "^1.11.0",
     "zod": "^3.24.3"
   },
   "devDependencies": {
     "@types/node": "^20.17.31",
     "@types/ssh2": "^1.15.5",
+    "shx": "^0.4.0",
     "typescript": "^5.4.5"
   }
 }