sr-npm 1.7.927 → 1.7.928

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "sr-npm",
-  "version": "1.7.927",
+  "version": "1.7.928",
   "description": "",
   "main": "index.js",
   "scripts": {

package/pages/careersMultiBoxesPage.js

@@ -23,15 +23,13 @@ const pagination = {
 };
 async function careersMultiBoxesPageOnReady(_$w,urlParams) {
     await loadData(_$w);
-
-    await Promise.all([
-      loadJobsRepeater(_$w),
-      loadPrimarySearchRepeater(_$w),
-      loadFilters(_$w),
-      loadSelectedValuesRepeater(_$w),
-      bindSearchInput(_$w),
-      loadPaginationButtons(_$w)
-    ]);
+    loadJobsRepeater(_$w);
+    loadPrimarySearchRepeater(_$w);
+    await loadFilters(_$w);
+    loadSelectedValuesRepeater(_$w);
+    bindSearchInput(_$w);
+    loadPaginationButtons(_$w);
+    
     await handleUrlParams(_$w, urlParams);
     _$w(CAREERS_MULTI_BOXES_PAGE_CONSTS.CLEAR_ALL_BUTTON_ID).onClick(async () => {
       await clearAll(_$w);
@@ -121,7 +119,7 @@ async function handleParams(_$w,param,value) {
       return applyFiltering;
 }
 
-async function loadPaginationButtons(_$w) {
+ function loadPaginationButtons(_$w) {
   try {
     _$w(CAREERS_MULTI_BOXES_PAGE_CONSTS.PAGE_BUTTON_NEXT).onClick(async () => {
       let nextPageJobs=currentJobs.slice(pagination.pageSize*pagination.currentPage,pagination.pageSize*(pagination.currentPage+1));
@@ -143,7 +141,7 @@ async function loadPaginationButtons(_$w) {
   }
 }
 
-async function loadSelectedValuesRepeater(_$w) {
+ function loadSelectedValuesRepeater(_$w) {
   try {
        _$w(CAREERS_MULTI_BOXES_PAGE_CONSTS.SELECTED_VALUES_REPEATER).onItemReady(($item, itemData) => {
         $item(CAREERS_MULTI_BOXES_PAGE_CONSTS.SELECTED_VALUES_REPEATER_ITEM_LABEL).text = itemData.label || '';
@@ -170,7 +168,7 @@ async function loadSelectedValuesRepeater(_$w) {
             await updateJobsAndNumbersAndFilters(_$w);
           });
     });
-    await updateSelectedValuesRepeater(_$w);
+     updateSelectedValuesRepeater(_$w);
   } catch (error) {
     console.error('Failed to load selected values repeater:', error);
   }
@@ -494,9 +492,9 @@ async function secondarySearch(_$w,query) {
     await refreshFacetCounts(_$w); 
     return allsecondarySearchJobs;
 }
-  async function bindSearchInput(_$w) {
+   function bindSearchInput(_$w) {
     try {
-      await bindPrimarySearch(_$w,allvaluesobjects,alljobs);
+       bindPrimarySearch(_$w,allvaluesobjects,alljobs);
 
     const secondarySearchDebounced = debounce(async () => {
       const query = (_$w(CAREERS_MULTI_BOXES_PAGE_CONSTS.SECONDARY_SEARCH_INPUT).value || '').toLowerCase().trim();

package/pages/homePage.js

@@ -18,13 +18,13 @@ async function homePageOnReady(_$w,thisObject=null) {
     if(siteconfig.categorySearch==="true") {
         const allJobs=await getAllRecords(COLLECTIONS.JOBS);
         const allvaluesobjects=await getAllRecords(COLLECTIONS.CUSTOM_VALUES);
-       await Promise.all([
-            bindPrimarySearch(_$w,allvaluesobjects,allJobs),
-            loadPrimarySearchRepeater(_$w),
-            bindTeamRepeater(_$w),
-            bindViewAllButton(_$w),
+       
+        bindPrimarySearch(_$w,allvaluesobjects,allJobs);
+        loadPrimarySearchRepeater(_$w)
+        bindTeamRepeater(_$w)
+        bindViewAllButton(_$w)
 
-        ]);
+        
     }
     else{
 

package/pages/pagesUtils.js

@@ -60,8 +60,8 @@ function groupValuesByField(values, refKey) {
     }
   }
 
-async function loadPrimarySearchRepeater(_$w) {
-  try {
+function loadPrimarySearchRepeater(_$w) {
+  
   _$w(CAREERS_MULTI_BOXES_PAGE_CONSTS.JOB_RESULTS_REPEATER).onItemReady(async ($item, itemData) => {
     $item(CAREERS_MULTI_BOXES_PAGE_CONSTS.PRIMARY_SEARCH_POSITION_BUTTON).label = itemData.title || '';   
   });
@@ -87,12 +87,9 @@ async function loadPrimarySearchRepeater(_$w) {
       location.to(`${baseUrl}/search?category=${encodedCategory}`);
   });
 
-  } catch (error) {
-    console.error('Failed to load primary search repeater:', error);
-  }
 }
 
-async function bindPrimarySearch(_$w,allvaluesobjects,alljobs) {
+ function bindPrimarySearch(_$w,allvaluesobjects,alljobs) {
 
   const primarySearchDebounced = debounce(async () => {
     const query = (_$w(CAREERS_MULTI_BOXES_PAGE_CONSTS.PRIMARY_SEARCH_INPUT).value || '').toLowerCase().trim();

package/pages/positionPage.js

@@ -89,7 +89,8 @@ async function getCategoryValueId(customValues) {
   function handleApplyButton(_$w,item) {
     try{
     _$w('#applyButton').target="_blank";//so it can open in new tab
-      const url=appendQueryParams(item.applyLink,query);
+    
+      const url=buildApplyLinkWithQueryParams(item.applyLink,query);
       _$w('#applyButton').link=url; //so it can be clicked
     }
     catch(error){
@@ -99,6 +100,20 @@ async function getCategoryValueId(customValues) {
     }
   }
 
+  function buildApplyLinkWithQueryParams(url, query) {
+    if (!url || typeof url !== 'string' || !url.startsWith('http')) {
+      console.warn(`Invalid URL ${url}, button link will not be set`);
+      return null;
+    }
+  
+    if (!query || typeof query !== 'object') {
+      console.warn(`Invalid query params ${query}, button link will not be set`);
+      return null;
+    }
+  
+    return appendQueryParams(url, query);
+  }
+
   async function getRelatedJobs({ categoryValueId, itemId, limit = 1000 }) {