sr-npm 1.7.454 → 1.7.455

package/backend/data.js

@@ -318,6 +318,9 @@ async function referenceJobs() {
 
 async function syncJobsFast() {
   console.log("Syncing jobs fast");
+  //database
+
+  
   await createCollections();
   await clearCollections();
   await fillSecretManagerMirror();
@@ -344,6 +347,7 @@ async function clearCollections() {
 }
 
 async function markTemplateAsExternal() {
+  console.log("TEMPLATE_TYPE$#@#$$@#@#$",TEMPLATE_TYPE);
   await createCollectionIfMissing(COLLECTIONS.TEMPLATE_TYPE, COLLECTIONS_FIELDS.TEMPLATE_TYPE,null,'singleItem');
   await wixData.save(COLLECTIONS.TEMPLATE_TYPE, {
     templateType: TEMPLATE_TYPE.EXTERNAL

package/backend/fetchPositionsFromSRAPI.js

@@ -8,11 +8,13 @@ async function makeSmartRecruitersRequest(path,templateType) {
   const fullUrl = `${baseUrl}${path}`;
   
   try {
+    //if templatetype is internal make headers object with x-smarttoken
     const headers = {
       'Accept-Language': 'en',
       'accept': 'application/json',
       'Cookie': 'AWSALB=GYltFw3fLKortMxHR5vIOT1CuUROyhWNIX/qL8ZnPl1/8mhOcnIsBKYslzmNJPEzSy/jvNbO+6tXpH8yqcpQJagYt57MhbKlLqTSzoNq1G/w7TjOxPGR3UTdXW0d; AWSALBCORS=GYltFw3fLKortMxHR5vIOT1CuUROyhWNIX/qL8ZnPl1/8mhOcnIsBKYslzmNJPEzSy/jvNbO+6tXpH8yqcpQJagYt57MhbKlLqTSzoNq1G/w7TjOxPGR3UTdXW0d'
     };
+    //here is the only place where we check templateType
     if (templateType === TEMPLATE_TYPE.INTERNAL) {
       const smartToken = await getTokenFromCMS(TOKEN_NAME.SMART_TOKEN);
       headers['x-smarttoken'] = smartToken;
@@ -34,7 +36,7 @@ async function makeSmartRecruitersRequest(path,templateType) {
   }
 }
 
-async function fetchPositionsFromSRAPI(companyID=undefined) {
+async function fetchPositionsFromSRAPI() {
   let allPositions = [];
   let totalFound = 0;
   let page = 0;

package/backend/secretsData.js

@@ -11,7 +11,6 @@ function getSmartToken() {
 }
 
   function getCompanyId() {
-    console.log("Getting the company%$##%$#$% ID from the secrets");
     return getSecretValue("companyID")
       .then((secret) => {
         return secret;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "sr-npm",
-  "version": "1.7.454",
+  "version": "1.7.455",
   "description": "",
   "main": "index.js",
   "scripts": {

package/tests/fetchPositionsFromSRApiTest.spec.js

@@ -1,5 +1,5 @@
 const { executeApiRequest } = require('tests-utils');
-const { getRandomPosition, executeRequestAndTest } = require('./testsUtils');
+const { getRandomPosition } = require('./testsUtils');
 
 describe('Job details fetch from SR API Tests', () => {
 
@@ -30,30 +30,6 @@ describe('Job details fetch from SR API Tests', () => {
         expect(jobFetchResponse.data.result.applyUrl.length).toBeGreaterThan(0);
         expect(jobFetchResponse.data.result.location).toBeDefined();
       });
-  });
-
-describe('fetchPositionsFromSRAPI error handling', () => {
-  test('should throw error if invalid companyId is found', async () => {
-    const requestBody = `fetchPositionsFromSRAPI('invalid_company_id');`;
-    executeRequestAndTest(requestBody)
-  });
-
-  test('should throw error when a bad URL is used', async () => {
-    const requestBody = `makeSmartRecruitersRequest('/v1/error/companyId/postings');`;
-    executeRequestAndTest(requestBody)
-  });
-
-
-
-});
-
-describe('fetchJobDescription error handling', () => {
-  test('should throw error if invalid jobId is given', async () => {
-    const requestBody = `fetchJobDescription('invalid_job_id');`;
-    executeRequestAndTest(requestBody)
-  });
-  test('should throw error when given a valid but wrong jobId is given', async () => {
-    const requestBody = `fetchJobDescription('1234567890');`;
-    executeRequestAndTest(requestBody)
-  });
-});
+  
+  
+  });

package/tests/testsUtils.js

@@ -1,17 +1,7 @@
-const { executeApiRequest } = require('tests-utils');
-
 function getRandomPosition(positions) {
     return positions[Math.floor(Math.random() * positions.length)];
 }
-async function executeRequestAndTest(requestBody) {
-    try{
-        response = await executeApiRequest(requestBody);
-        expect(response.status).not.toBe(500);
-    }catch(error){
-        expect(error.message).toBe('Request failed with status code 500');
-    }
-}
 
 module.exports = {
-    getRandomPosition, executeRequestAndTest
+    getRandomPosition
 }