sr-npm 1.7.452 → 1.7.453

package/backend/collectionConsts.js

@@ -71,17 +71,6 @@ const COLLECTIONS_FIELDS = {
     ],
   };
 
-TEMPLATE_TYPE = {
-  INTERNAL: 'INTERNAL',
-  EXTERNAL: 'PUBLIC',
-}
-
-TOKEN_NAME = {
-  COMPANY_ID: 'companyId',
-  SMART_TOKEN: 'x-smarttoken',
-}
-
-
 
   module.exports = {
     COLLECTIONS,
@@ -89,6 +78,4 @@ TOKEN_NAME = {
     JOBS_COLLECTION_FIELDS,
     AMOUNT_OF_JOBS_PER_DEPARTMENT_COLLECTION_FIELDS,
     CITIES_COLLECTION_FIELDS,
-    TEMPLATE_TYPE,
-    TOKEN_NAME,
 };

package/backend/data.js

@@ -1,9 +1,10 @@
 const { items: wixData } = require('@wix/data');
 const { fetchPositionsFromSRAPI, fetchJobDescription } = require('./fetchPositionsFromSRAPI');
 const { createCollectionIfMissing } = require('@hisense-staging/velo-npm/backend');
-const { COLLECTIONS, COLLECTIONS_FIELDS,JOBS_COLLECTION_FIELDS,TEMPLATE_TYPE,TOKEN_NAME } = require('./collectionConsts');
+const { COLLECTIONS, COLLECTIONS_FIELDS,JOBS_COLLECTION_FIELDS } = require('./collectionConsts');
 const { chunkedBulkOperation, countJobsPerGivenField, fillCityLocationAndLocationAddress ,prepareToSaveArray,normalizeCityName} = require('./utils');
 const { getAllPositions } = require('./queries');
+const{TEMPLATE_TYPE,TOKEN_NAME} = require('./consts');
 const { getCompanyId, getSmartToken } = require('./secretsData');
 
 function validatePosition(position) {

package/backend/fetchPositionsFromSRAPI.js

@@ -131,6 +131,5 @@ async function getApiKeys() {
 module.exports = {
   fetchPositionsFromSRAPI,
   fetchJobDescription,
-  getTokenFromCMS,
-  makeSmartRecruitersRequest
+  getTokenFromCMS
 };

package/backend/index.js

@@ -3,5 +3,4 @@ module.exports = {
   ...require('./queries'),
   ...require('./fetchPositionsFromSRAPI'),
   ...require('./consts'),
-  ...require('./data'),
 };

package/backend/secretsData.js

@@ -11,7 +11,7 @@ function getSmartToken() {
 }
 
   function getCompanyId() {
-    console.log("Getting the#$#@@$# company ID from the secrets");
+    console.log("Getting th#@$$#@@#$e company ID from the secrets");
     return getSecretValue("companyID")
       .then((secret) => {
         return secret;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "sr-npm",
-  "version": "1.7.452",
+  "version": "1.7.453",
   "description": "",
   "main": "index.js",
   "scripts": {

package/tests/fetchPositionsFromSRApiTest.spec.js

@@ -1,59 +1,59 @@
-// const { executeApiRequest } = require('tests-utils');
-// const { getRandomPosition, executeRequestAndTest } = require('./testsUtils');
+const { executeApiRequest } = require('tests-utils');
+const { getRandomPosition, executeRequestAndTest } = require('./testsUtils');
 
-// describe('Job details fetch from SR API Tests', () => {
+describe('Job details fetch from SR API Tests', () => {
 
-//     let positions;
-//     beforeAll(async () => {
-//         const requestBody = `fetchPositionsFromSRAPI();`;
-//         positions = await executeApiRequest(requestBody);
-//     });
+    let positions;
+    beforeAll(async () => {
+        const requestBody = `fetchPositionsFromSRAPI();`;
+        positions = await executeApiRequest(requestBody);
+    });
   
-//       test('should successfully fetch job details from SR API', async () => {
-//         const randomPosition = getRandomPosition(positions.data.result.content);
-//         expect(positions.data.result.totalFound).toBeGreaterThan(0);
-//         expect(positions.data.result.content.length).toBeGreaterThan(0);
-//         expect(randomPosition.id.length).toBeGreaterThan(0);
-//         expect(randomPosition.name.length).toBeGreaterThan(0);
-//         expect(randomPosition.jobAdId.length).toBeGreaterThan(0);
-//         expect(randomPosition.location).toBeDefined();
-//         expect(randomPosition.department).toBeDefined();
-//       });
-
-//       test('should successfully fetch job description from SR API', async () => {
-//         const randomPosition = getRandomPosition(positions.data.result.content);
-//         const fetchJobDescriptionRequestBody = `fetchJobDescription(${randomPosition.id});`;
-//         const jobFetchResponse = await executeApiRequest(fetchJobDescriptionRequestBody);
-//         expect(jobFetchResponse.data.result.id).toBe(randomPosition.id);
-//         expect(jobFetchResponse.data.result.jobAd.sections.jobDescription).toBeDefined();
-//         expect(jobFetchResponse.data.result.jobAd.sections.jobDescription.text.length).toBeGreaterThan(0);
-//         expect(jobFetchResponse.data.result.applyUrl.length).toBeGreaterThan(0);
-//         expect(jobFetchResponse.data.result.location).toBeDefined();
-//       });
-//   });
-
-// describe('fetchPositionsFromSRAPI error handling', () => {
-//   test('should throw error if invalid companyId is found', async () => {
-//     const requestBody = `fetchPositionsFromSRAPI('invalid_company_id');`;
-//     executeRequestAndTest(requestBody)
-//   });
-
-//   test('should throw error when a bad URL is used', async () => {
-//     const requestBody = `makeSmartRecruitersRequest('/v1/error/companyId/postings');`;
-//     executeRequestAndTest(requestBody)
-//   });
-
-
-
-// });
-
-// describe('fetchJobDescription error handling', () => {
-//   test('should throw error if invalid jobId is given', async () => {
-//     const requestBody = `fetchJobDescription('invalid_job_id');`;
-//     executeRequestAndTest(requestBody)
-//   });
-//   test('should throw error when given a valid but wrong jobId is given', async () => {
-//     const requestBody = `fetchJobDescription('1234567890');`;
-//     executeRequestAndTest(requestBody)
-//   });
-// });
+      test('should successfully fetch job details from SR API', async () => {
+        const randomPosition = getRandomPosition(positions.data.result.content);
+        expect(positions.data.result.totalFound).toBeGreaterThan(0);
+        expect(positions.data.result.content.length).toBeGreaterThan(0);
+        expect(randomPosition.id.length).toBeGreaterThan(0);
+        expect(randomPosition.name.length).toBeGreaterThan(0);
+        expect(randomPosition.jobAdId.length).toBeGreaterThan(0);
+        expect(randomPosition.location).toBeDefined();
+        expect(randomPosition.department).toBeDefined();
+      });
+
+      test('should successfully fetch job description from SR API', async () => {
+        const randomPosition = getRandomPosition(positions.data.result.content);
+        const fetchJobDescriptionRequestBody = `fetchJobDescription(${randomPosition.id});`;
+        const jobFetchResponse = await executeApiRequest(fetchJobDescriptionRequestBody);
+        expect(jobFetchResponse.data.result.id).toBe(randomPosition.id);
+        expect(jobFetchResponse.data.result.jobAd.sections.jobDescription).toBeDefined();
+        expect(jobFetchResponse.data.result.jobAd.sections.jobDescription.text.length).toBeGreaterThan(0);
+        expect(jobFetchResponse.data.result.applyUrl.length).toBeGreaterThan(0);
+        expect(jobFetchResponse.data.result.location).toBeDefined();
+      });
+  });
+
+describe('fetchPositionsFromSRAPI error handling', () => {
+  test('should throw error if invalid companyId is found', async () => {
+    const requestBody = `fetchPositionsFromSRAPI('invalid_company_id');`;
+    executeRequestAndTest(requestBody)
+  });
+
+  test('should throw error when a bad URL is used', async () => {
+    const requestBody = `makeSmartRecruitersRequest('/v1/error/companyId/postings');`;
+    executeRequestAndTest(requestBody)
+  });
+
+
+
+});
+
+describe('fetchJobDescription error handling', () => {
+  test('should throw error if invalid jobId is given', async () => {
+    const requestBody = `fetchJobDescription('invalid_job_id');`;
+    executeRequestAndTest(requestBody)
+  });
+  test('should throw error when given a valid but wrong jobId is given', async () => {
+    const requestBody = `fetchJobDescription('1234567890');`;
+    executeRequestAndTest(requestBody)
+  });
+});

package/tests/testsUtils.js

@@ -1,5 +1,4 @@
 const { executeApiRequest } = require('tests-utils');
-const { COLLECTIONS } = require('./consts');
 
 function getRandomPosition(positions) {
     return positions[Math.floor(Math.random() * positions.length)];
@@ -13,15 +12,6 @@ async function executeRequestAndTest(requestBody) {
     }
 }
 
-async function clearCollections(wixData) {
-
-    for (const collection of Object.values(COLLECTIONS)) {
-        await wixData.truncate(collection);
-    }
-}
-
 module.exports = {
-    getRandomPosition, 
-    executeRequestAndTest,
-    clearCollections
+    getRandomPosition, executeRequestAndTest
 }

package/tests/consts.js

@@ -1,12 +0,0 @@
-const COLLECTIONS = {
-    TEMPLATE_TYPE: 'templateType',
-}
-const TEMPLATE_TYPE = {
-    INTERNAL: 'INTERNAL',
-    EXTERNAL: 'PUBLIC',
-  }
-
-module.exports = {
-    COLLECTIONS,
-    TEMPLATE_TYPE
-}

package/tests/markTemplateTest.spec.js

@@ -1,27 +0,0 @@
-const { executeApiRequest } = require('tests-utils');
-const { items: wixData } = require('@wix/data');
-const { clearCollections } = require('./testsUtils');
-const { TEMPLATE_TYPE } = require('./consts');
-const { COLLECTIONS } = require('./consts');
-
-beforeAll(async () => {
-    clearCollections(wixData);
-});
-
-
-
-
-it.each([
-    { name: 'internal', templateType: TEMPLATE_TYPE.INTERNAL },
-    { name: 'external', templateType: TEMPLATE_TYPE.EXTERNAL },
-])('should successfully mark template as $name', async ({ templateType }) => {
-    const requestBody = `markTemplateAs${templateType}();`;
-    await executeApiRequest(requestBody);
-    const TemplateTypeFromCMS = await wixData.query(COLLECTIONS.TEMPLATE_TYPE).limit(1).find();
-    expect(TemplateTypeFromCMS.items[0].templateType).toBe(templateType);
-  });
-
-
-
-
-