sr-npm 1.7.448 → 1.7.449

package/backend/fetchPositionsFromSRAPI.js

@@ -33,7 +33,6 @@ async function makeSmartRecruitersRequest(path,templateType) {
 }
 
 async function fetchPositionsFromSRAPI(testObject=undefined) {
-  
   let allPositions = [];
   let totalFound = 0;
   let page = 0;
@@ -104,6 +103,15 @@ async function fetchPositionsFromSRAPI(testObject=undefined) {
   return result;
 }
 
+// async function fetchJobDescription(jobId,testObject=undefined) {
+//   let companyId, templateType;
+//   if (testObject) {
+//     ({ companyId, templateType } = testObject);
+//   } else {
+//     ({ companyId, templateType } = await getApiKeys());
+//   }
+//   return await makeSmartRecruitersRequest(`/v1/companies/${companyId}/postings/${jobId}`,templateType);
+// }
 async function fetchJobDescription(jobId) {
   const {companyId,templateType} = await getApiKeys();
   return await makeSmartRecruitersRequest(`/v1/companies/${companyId}/postings/${jobId}`,templateType);

package/backend/secretsData.js

@@ -11,10 +11,17 @@ function getSmartToken() {
 }
 
   function getCompanyId() {
-    return getSecretValue("companyID")
+    console.log("Getting the company ID from the secrets");
+    const getSecretValue2 = auth.elevate(secrets.getSecretValue);
+    console.log("getSecretValue2 is : ", getSecretValue2);
+
+    return getSecretValue2("companyID")
       .then((secret) => {
         return secret;
-      })
+      }).catch((error) => {
+        console.error("Error getting the company ID from the secrets: ", error);
+        throw error;
+      });
   }
   module.exports = {
     getCompanyId,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "sr-npm",
-  "version": "1.7.448",
+  "version": "1.7.449",
   "description": "",
   "main": "index.js",
   "scripts": {

package/tests/fetchPositionsFromSRApiTest.spec.js

@@ -3,33 +3,43 @@ const { getRandomPosition, executeRequestAndTest } = require('./testsUtils');
 
 describe('Job details fetch from SR API Tests', () => {
 
-    let positions;
-    beforeAll(async () => {
-        const requestBody = `fetchPositionsFromSRAPI();`;
-        positions = await executeApiRequest(requestBody);
-    });
-  
-      test('should successfully fetch job details from SR API', async () => {
-        const randomPosition = getRandomPosition(positions.data.result.content);
-        expect(positions.data.result.totalFound).toBeGreaterThan(0);
-        expect(positions.data.result.content.length).toBeGreaterThan(0);
-        expect(randomPosition.id.length).toBeGreaterThan(0);
-        expect(randomPosition.name.length).toBeGreaterThan(0);
-        expect(randomPosition.jobAdId.length).toBeGreaterThan(0);
-        expect(randomPosition.location).toBeDefined();
-        expect(randomPosition.department).toBeDefined();
-      });
+    const templateTypes = [
+      { templatename: 'External', templateType: 'PUBLIC'},
+      { templatename: 'Internal', templateType: 'INTERNAL'}
+    ];
+    
+    templateTypes.forEach(({ templateType ,templatename}) => {
+      describe(`Job details fetch from SR API Tests - ${templatename}`, () => {
+        let positions;
+        beforeAll(async () => {
+          const fetchPositionsFromSRAPIRequestBody = `fetchPositionsFromSRAPI({companyId:'WixTest',templateType: '${templateType}'});`;
+           positions = await executeApiRequest(fetchPositionsFromSRAPIRequestBody);
+        });
+        
 
-      test('should successfully fetch job description from SR API', async () => {
-        const randomPosition = getRandomPosition(positions.data.result.content);
-        const fetchJobDescriptionRequestBody = `fetchJobDescription(${randomPosition.id});`;
-        const jobFetchResponse = await executeApiRequest(fetchJobDescriptionRequestBody);
-        expect(jobFetchResponse.data.result.id).toBe(randomPosition.id);
-        expect(jobFetchResponse.data.result.jobAd.sections.jobDescription).toBeDefined();
-        expect(jobFetchResponse.data.result.jobAd.sections.jobDescription.text.length).toBeGreaterThan(0);
-        expect(jobFetchResponse.data.result.applyUrl.length).toBeGreaterThan(0);
-        expect(jobFetchResponse.data.result.location).toBeDefined();
+        test(`should successfully fetch job details from SR API (${templatename})`, async () => {
+          const randomPosition = getRandomPosition(positions.data.result.content);
+          expect(positions.data.result.totalFound).toBeGreaterThan(0);
+          expect(positions.data.result.content.length).toBeGreaterThan(0);
+          expect(randomPosition.id.length).toBeGreaterThan(0);
+          expect(randomPosition.name.length).toBeGreaterThan(0);
+          expect(randomPosition.jobAdId.length).toBeGreaterThan(0);
+          expect(randomPosition.location).toBeDefined();
+          expect(randomPosition.department).toBeDefined();
+        });
+
+        test(`should successfully fetch job description from SR API (${templatename})`, async () => {
+          const randomPosition = getRandomPosition(positions.data.result.content);
+          const fetchJobDescriptionRequestBody = `fetchJobDescription(${randomPosition.id},{companyId:'WixTest',templateType: '${templateType}'});`;
+          const jobFetchResponse = await executeApiRequest(fetchJobDescriptionRequestBody);
+          expect(jobFetchResponse.data.result.id).toBe(randomPosition.id);
+          expect(jobFetchResponse.data.result.jobAd.sections.jobDescription).toBeDefined();
+          expect(jobFetchResponse.data.result.jobAd.sections.jobDescription.text.length).toBeGreaterThan(0);
+          expect(jobFetchResponse.data.result.applyUrl.length).toBeGreaterThan(0);
+          expect(jobFetchResponse.data.result.location).toBeDefined();
+        });
       });
+    });
   });
 
 describe('fetchPositionsFromSRAPI error handling', () => {