sr-npm 1.7.432 → 1.7.434

package/backend/data.js

@@ -346,21 +346,18 @@ async function clearCollections() {
 
 async function markTemplateAsExternal() {
   await createCollectionIfMissing(COLLECTIONS.TEMPLATE_TYPE, COLLECTIONS_FIELDS.TEMPLATE_TYPE,null,'singleItem');
-  console.log("marking template as external");
-  console.log("TEMPLATE_TYPE: ", TEMPLATE_TYPE);
-  await wixData.save(COLLECTIONS.TEMPLATE_TYPE, {
+  const tempalte = await wixData.save(COLLECTIONS.TEMPLATE_TYPE, {
     templateType: TEMPLATE_TYPE.EXTERNAL
   });
+  return tempalte;
 }
 
 async function markTemplateAsInternal() {
   await createCollectionIfMissing(COLLECTIONS.TEMPLATE_TYPE, COLLECTIONS_FIELDS.TEMPLATE_TYPE,null,'singleItem');
-  console.log("marking template as internal");
-  console.log("COLLECTIONS: ", COLLECTIONS);
-  console.log("TEMPLATE_TYPE: ", TEMPLATE_TYPE);
-  await wixData.save(COLLECTIONS.TEMPLATE_TYPE, {
+  const tempalte = await wixData.save(COLLECTIONS.TEMPLATE_TYPE, {
     templateType: TEMPLATE_TYPE.INTERNAL
   });
+  return tempalte;
 }
 
 async function fillSecretManagerMirror() {

package/backend/fetchPositionsFromSRAPI.js

@@ -34,12 +34,18 @@ async function makeSmartRecruitersRequest(path,templateType) {
   }
 }
 
-async function fetchPositionsFromSRAPI(companyID=undefined) {
+async function fetchPositionsFromSRAPI(testObject=undefined) {
   let allPositions = [];
   let totalFound = 0;
   let page = 0;
   const MAX_PAGES = 30 // Safety limit to prevent infinite loops
-  const {companyId,templateType} = await getApiKeys();
+  
+  let companyId, templateType;
+  if (testObject) {
+    ({ companyId, templateType } = testObject);
+  } else {
+    ({ companyId, templateType } = await getApiKeys());
+  }
   console.log('Starting to fetch all positions with pagination...');
   let offset=0;
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "sr-npm",
-  "version": "1.7.432",
+  "version": "1.7.434",
   "description": "",
   "main": "index.js",
   "scripts": {

package/tests/fetchPositionsFromSRApiTest.spec.js

@@ -1,59 +1,64 @@
-// const { executeApiRequest } = require('tests-utils');
-// const { getRandomPosition, executeRequestAndTest } = require('./testsUtils');
+const { executeApiRequest } = require('tests-utils');
+const { getRandomPosition, executeRequestAndTest } = require('./testsUtils');
 
-// describe('Job details fetch from SR API Tests', () => {
+describe('Job details fetch from SR API Tests', () => {
 
-//     let positions;
-//     beforeAll(async () => {
-//         const requestBody = `fetchPositionsFromSRAPI();`;
-//         positions = await executeApiRequest(requestBody);
-//     });
+    let positions;
+    beforeAll(async () => {
+        const requestBody = `fetchPositionsFromSRAPI();`;
+        positions = await executeApiRequest(requestBody);
+    });
   
-//       test('should successfully fetch job details from SR API', async () => {
-//         const randomPosition = getRandomPosition(positions.data.result.content);
-//         expect(positions.data.result.totalFound).toBeGreaterThan(0);
-//         expect(positions.data.result.content.length).toBeGreaterThan(0);
-//         expect(randomPosition.id.length).toBeGreaterThan(0);
-//         expect(randomPosition.name.length).toBeGreaterThan(0);
-//         expect(randomPosition.jobAdId.length).toBeGreaterThan(0);
-//         expect(randomPosition.location).toBeDefined();
-//         expect(randomPosition.department).toBeDefined();
-//       });
-
-//       test('should successfully fetch job description from SR API', async () => {
-//         const randomPosition = getRandomPosition(positions.data.result.content);
-//         const fetchJobDescriptionRequestBody = `fetchJobDescription(${randomPosition.id});`;
-//         const jobFetchResponse = await executeApiRequest(fetchJobDescriptionRequestBody);
-//         expect(jobFetchResponse.data.result.id).toBe(randomPosition.id);
-//         expect(jobFetchResponse.data.result.jobAd.sections.jobDescription).toBeDefined();
-//         expect(jobFetchResponse.data.result.jobAd.sections.jobDescription.text.length).toBeGreaterThan(0);
-//         expect(jobFetchResponse.data.result.applyUrl.length).toBeGreaterThan(0);
-//         expect(jobFetchResponse.data.result.location).toBeDefined();
-//       });
-//   });
-
-// describe('fetchPositionsFromSRAPI error handling', () => {
-//   test('should throw error if invalid companyId is found', async () => {
-//     const requestBody = `fetchPositionsFromSRAPI('invalid_company_id');`;
-//     executeRequestAndTest(requestBody)
-//   });
-
-//   test('should throw error when a bad URL is used', async () => {
-//     const requestBody = `makeSmartRecruitersRequest('/v1/error/companyId/postings');`;
-//     executeRequestAndTest(requestBody)
-//   });
-
-
-
-// });
-
-// describe('fetchJobDescription error handling', () => {
-//   test('should throw error if invalid jobId is given', async () => {
-//     const requestBody = `fetchJobDescription('invalid_job_id');`;
-//     executeRequestAndTest(requestBody)
-//   });
-//   test('should throw error when given a valid but wrong jobId is given', async () => {
-//     const requestBody = `fetchJobDescription('1234567890');`;
-//     executeRequestAndTest(requestBody)
-//   });
-// });
+      test('should successfully fetch job details from SR API', async () => {
+        const randomPosition = getRandomPosition(positions.data.result.content);
+        expect(positions.data.result.totalFound).toBeGreaterThan(0);
+        expect(positions.data.result.content.length).toBeGreaterThan(0);
+        expect(randomPosition.id.length).toBeGreaterThan(0);
+        expect(randomPosition.name.length).toBeGreaterThan(0);
+        expect(randomPosition.jobAdId.length).toBeGreaterThan(0);
+        expect(randomPosition.location).toBeDefined();
+        expect(randomPosition.department).toBeDefined();
+      });
+
+      test('should successfully fetch job description from SR API', async () => {
+        const randomPosition = getRandomPosition(positions.data.result.content);
+        const fetchJobDescriptionRequestBody = `fetchJobDescription(${randomPosition.id});`;
+        const jobFetchResponse = await executeApiRequest(fetchJobDescriptionRequestBody);
+        expect(jobFetchResponse.data.result.id).toBe(randomPosition.id);
+        expect(jobFetchResponse.data.result.jobAd.sections.jobDescription).toBeDefined();
+        expect(jobFetchResponse.data.result.jobAd.sections.jobDescription.text.length).toBeGreaterThan(0);
+        expect(jobFetchResponse.data.result.applyUrl.length).toBeGreaterThan(0);
+        expect(jobFetchResponse.data.result.location).toBeDefined();
+      });
+  });
+
+describe('fetchPositionsFromSRAPI error handling', () => {
+  test('should throw error if invalid companyId is found external template', async () => {
+    const requestBody = `fetchPositionsFromSRAPI({companyId: 'invalid_company_id',templateType: 'EXTERNAL'});`;
+    executeRequestAndTest(requestBody)
+  });
+
+  test('should throw error if invalid companyId is found internal template', async () => {
+    const requestBody = `fetchPositionsFromSRAPI({companyId: 'invalid_company_id',templateType: 'INTERNAL'});`;
+    executeRequestAndTest(requestBody)
+  });
+
+  test('should throw error when a bad URL is used', async () => {
+    const requestBody = `makeSmartRecruitersRequest('/v1/error/companyId/postings');`;
+    executeRequestAndTest(requestBody)
+  });
+
+
+
+});
+
+describe('fetchJobDescription error handling', () => {
+  test('should throw error if invalid jobId is given', async () => {
+    const requestBody = `fetchJobDescription('invalid_job_id');`;
+    executeRequestAndTest(requestBody)
+  });
+  test('should throw error when given a valid but wrong jobId is given', async () => {
+    const requestBody = `fetchJobDescription('1234567890');`;
+    executeRequestAndTest(requestBody)
+  });
+});

package/tests/markTemplateTest.spec.js

@@ -1,10 +1,9 @@
 const { executeApiRequest } = require('tests-utils');
-const { items: wixData } = require('@wix/data');
 const { clearCollections } = require('./testsUtils');
-const { TEMPLATE_TYPE, COLLECTIONS } = require('./consts');
+const { TEMPLATE_TYPE } = require('./consts');
 
 beforeAll(async () => {
-    clearCollections(wixData);
+    clearCollections();
 });
 
 
@@ -13,9 +12,10 @@ it.each([
     { templateName: 'External', templateType: TEMPLATE_TYPE.EXTERNAL },
 ])('should successfully mark template as $templateName', async ({ templateName,templateType }) => {
     const requestBody = `markTemplateAs${templateName}();`;
-    await executeApiRequest(requestBody);
-    const TemplateTypeFromCMS = await wixData.query(COLLECTIONS.TEMPLATE_TYPE).find();
-    expect(TemplateTypeFromCMS.items[0].templateType).toBe(templateType);
+    const response = await executeApiRequest(requestBody);
+    expect(response.status).toBe(200);
+    expect(response.data).toBeDefined();
+    expect(response.data.result.templateType).toBe(templateType);
   });
 
 

package/tests/testsUtils.js

@@ -1,5 +1,6 @@
 const { executeApiRequest } = require('tests-utils');
 const { COLLECTIONS } = require('./consts');
+const { items: wixData } = require('@wix/data');
 
 function getRandomPosition(positions) {
     return positions[Math.floor(Math.random() * positions.length)];
@@ -13,7 +14,7 @@ async function executeRequestAndTest(requestBody) {
     }
 }
 
-async function clearCollections(wixData) {
+async function clearCollections() {
 
     for (const collection of Object.values(COLLECTIONS)) {
         await wixData.truncate(collection);