sr-npm 1.7.398 → 1.7.400

package/backend/fetchPositionsFromSRAPI.js

@@ -32,13 +32,11 @@ async function fetchPositionsFromSRAPI(companyID=undefined) {
   let totalFound = 0;
   let page = 0;
   const MAX_PAGES = 30 // Safety limit to prevent infinite loops
-  console.log('companyID =', companyID);
   let companyId=companyID
   if(!companyID)
   {
    companyId = await getCompanyIdFromCMS();
   }
-  console.log('companyId =', companyId);
   console.log('Starting to fetch all positions with pagination...');
   let offset=0;
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "sr-npm",
-  "version": "1.7.398",
+  "version": "1.7.400",
   "description": "",
   "main": "index.js",
   "scripts": {

package/tests/fetchPositionsFromSRApiTest.spec.js

@@ -1,5 +1,5 @@
 const { executeApiRequest } = require('tests-utils');
-const { getRandomPosition } = require('./testsUtils');
+const { getRandomPosition, executeRequestAndTest } = require('./testsUtils');
 
 describe('Job details fetch from SR API Tests', () => {
 
@@ -33,29 +33,27 @@ describe('Job details fetch from SR API Tests', () => {
   });
 
 describe('fetchPositionsFromSRAPI error handling', () => {
-  test('should return 0 positions if invalid companyId is found', async () => {
-    try{
+  test('should throw error if invalid companyId is found', async () => {
     const requestBody = `fetchPositionsFromSRAPI('invalid_company_id');`;
-    response = await executeApiRequest(requestBody);
-    expect(response.status).not.toBe(500);
-    }catch(error){
-      console.log(error);
-      
-      expect(error.message).toBe('Request failed with status code 500');
-    }
+    executeRequestAndTest(requestBody)
   });
 
-  test('throw error when bad request', async () => {
+  test('should throw error when a bad URL is used', async () => {
     const requestBody = `makeSmartRecruitersRequest('/v1/error/companyId/postings');`;
-    try{
-      response = await executeApiRequest(requestBody);
-      expect(response.status).not.toBe(500);
-    }catch(error){
-      console.log(error);
-      expect(error.message).toBe('Request failed with status code 500');
-    }
+    executeRequestAndTest(requestBody)
   });
 
 
 
+});
+
+describe('fetchJobDescription error handling', () => {
+  test('should throw error if invalid jobId is found', async () => {
+    const requestBody = `fetchJobDescription('invalid_job_id');`;
+    executeRequestAndTest(requestBody)
+  });
+  test('should throw error when given a valid jobId but no jobAdId is found', async () => {
+    const requestBody = `fetchJobDescription('1234567890');`;
+    executeRequestAndTest(requestBody)
+  });
 });

package/tests/testsUtils.js

@@ -1,7 +1,15 @@
 function getRandomPosition(positions) {
     return positions[Math.floor(Math.random() * positions.length)];
 }
+async function executeRequestAndTest(requestBody) {
+    try{
+        response = await executeApiRequest(requestBody);
+        expect(response.status).not.toBe(500);
+    }catch(error){
+        expect(error.message).toBe('Request failed with status code 500');
+    }
+}
 
 module.exports = {
-    getRandomPosition
+    getRandomPosition, executeRequestAndTest
 }