sr-npm 1.7.1264 → 1.7.1268

package/backend/data.js

@@ -287,7 +287,7 @@ async function saveJobsDescriptionsAndLocationApplyUrlReferencesToCMS() {
         const chunkPromises = chunk.map(async job => {
           try {
             const jobDetails = await fetchJobDescription(job._id);
-            const richContentDescription=await htmlRichContentConverter(jobDetails.jobAd.sections,richContentConverterToken,jobDetails);
+            const richContentDescription=await htmlRichContentConverter(jobDetails.jobAd.sections,richContentConverterToken);
             const jobLocation = fetchJobLocation(jobDetails);
             const {applyLink , referFriendLink} = fetchApplyAndReferFriendLink(jobDetails);
             const updatedJob = {

package/backend/fetchPositionsFromSRAPI.js

@@ -114,12 +114,12 @@ async function fetchJobDescription(jobId,testObject=undefined) {
   return await makeSmartRecruitersRequest(`/v1/companies/${companyId}/postings/${jobId}`,templateType);
 }
 
-async function htmlRichContentConverter(sections,richContentConverterToken,jobName) {
+async function htmlRichContentConverter(sections,richContentConverterToken) {
   
   const richContentObject = {}
   for (const [sectionTitle, sectionData] of Object.entries(sections)) {
     if (sectionData.text) {
-      // Strip span tags but keep their content
+      // Strip span tags but keep their content , since <span> tags paragraphs are deleted by the converter
       const cleanedHtml = sectionData.text.replace(/<\/?span[^>]*>/gi, '');
       const raw = JSON.stringify({
         content: cleanedHtml,
@@ -142,7 +142,7 @@ async function htmlRichContentConverter(sections,richContentConverterToken,jobNa
         // Fix list items with nested paragraphs (causes line breaks after bold text)
         const flattenedContent = flattenListItems(data.richContent.richContent);
        // const richContentWithSpacing=addSpacingToRichContent(cleanedHtml,flattenedContent);
-       const richContentWithSpacing=addEmptyParagraphsBetweenConsecutive(cleanedHtml,flattenedContent,jobName);
+       const richContentWithSpacing=addEmptyParagraphsBetweenConsecutive(cleanedHtml,flattenedContent);
         richContentObject[sectionTitle] = richContentWithSpacing
       }
       else {
@@ -153,163 +153,6 @@ async function htmlRichContentConverter(sections,richContentConverterToken,jobNa
   return richContentObject;
 }
 
-//Adds empty paragraph nodes between sections in rich content 
-// to create visual spacing that the Wix RICOS converter strips out
-function addSpacingToRichContent(html, richContent) {
-  if (!richContent || !richContent.nodes) {
-      return richContent;
-  }
-
-  
-  // Extract paragraph texts from HTML that end with &#xa0;
-  const htmlParagraphsWithSpace = [];
-  // Extract paragraphs with <br> tags
-  const htmlParagraphsWithBr = new Map(); // text -> array of parts split by <br>
-  // Check if HTML has consecutive paragraphs (</p><p> pattern)
-  const hasConsecutiveParagraphs = /<\/p>\s*<p/i.test(html);
-  // Check if HTML has paragraph followed by list (</p><ul> pattern)
-  const hasParagraphBeforeList = /<\/p>\s*<ul/i.test(html);
-  
-  const pTagRegex = /<p>(.*?)<\/p>/gi;
-  let match;
-  
-  while ((match = pTagRegex.exec(html)) !== null) {
-      const content = match[1];
-      
-      // Check if this paragraph ends with &#xa0; (before closing tags)
-      if (content.includes('&#xa0;')) {
-          const textOnly = content.replace(/<[^>]+>/g, '').trim();
-          htmlParagraphsWithSpace.push(textOnly);
-      }
-      
-      // Check if this paragraph contains <br> tags
-      if (content.includes('<br>') || content.includes('<br/>') || content.includes('<br />')) {
-          // Split by <br> tags and extract text parts
-          const parts = content.split(/<br\s*\/?>/i).map(part => 
-              part.replace(/<[^>]+>/g, '').trim()
-          ).filter(part => part.length > 0);
-          
-          if (parts.length > 1) {
-              // Store the parts for this paragraph
-              const fullText = content.replace(/<[^>]+>/g, '').replace(/\s+/g, '').trim();
-              htmlParagraphsWithBr.set(fullText, parts);
-          }
-      }
-  }
-
-  const nodes = richContent.nodes;
-  const newNodes = [];
-  let nodeIdCounter = 0;
-  
-  // Check if a paragraph is bold (has BOLD decoration)
-  const isBoldParagraph = (node) => {
-      if (node.type !== 'PARAGRAPH') return false;
-      const decorations = node.nodes?.[0]?.textData?.decorations || [];
-      return decorations.some(d => d.type === 'BOLD');
-  };
-  
-  // Check if a paragraph node's text matches one with &#xa0; in HTML
-  const needsSpacingAfter = (node, nextNode) => {
-      if (node.type !== 'PARAGRAPH') return false;
-      
-      // Add spacing after bold paragraphs
-      if (isBoldParagraph(node)) {
-          return true;
-      }
-      
-      // If HTML has consecutive <p> tags and next node is also a paragraph, add spacing
-      if (hasConsecutiveParagraphs && nextNode && nextNode.type === 'PARAGRAPH') {
-          return true;
-      }
-      
-      // If HTML has </p><ul> and next node is a list, add spacing
-      if (hasParagraphBeforeList && nextNode && nextNode.type === 'BULLETED_LIST') {
-          return true;
-      }
-      
-      const text = node.nodes?.[0]?.textData?.text || '';
-      const trimmedText = text.trim();
-      
-      // Check if this text matches any HTML paragraph that had &#xa0;
-      return htmlParagraphsWithSpace.some(htmlText => {
-          const cleanHtml = htmlText.replace(/&#xa0;/g, ' ').trim();
-          return trimmedText.includes(cleanHtml) || cleanHtml.includes(trimmedText);
-      });
-  };
-  
-  // Check if a paragraph contains text that should be split by <br>
-  const shouldSplitByBr = (node) => {
-      if (node.type !== 'PARAGRAPH') return null;
-      
-      const text = node.nodes?.[0]?.textData?.text || '';
-      const normalizedText = text.replace(/\s+/g, '').trim();
-      
-      // Find matching HTML paragraph with <br>
-      for (const [htmlText, parts] of htmlParagraphsWithBr.entries()) {
-          if (normalizedText.includes(htmlText) || htmlText.includes(normalizedText)) {
-              return parts;
-          }
-      }
-      return null;
-  };
-  
-  // Add spacing after bulleted lists
-  const isListEnd = (currentNode, nextNode) => {
-      return currentNode.type === 'BULLETED_LIST' && 
-             nextNode && 
-             nextNode.type === 'PARAGRAPH';
-  };
-
-  for (let i = 0; i < nodes.length; i++) {
-      const currentNode = nodes[i];
-      const nextNode = nodes[i + 1];
-      
-      // Check if this paragraph should be split by <br>
-      const brParts = shouldSplitByBr(currentNode);
-      if (brParts && brParts.length > 1) {
-          // Split into multiple paragraphs and add spacing between them
-          const decorations = currentNode.nodes?.[0]?.textData?.decorations || [];
-          
-          brParts.forEach((part, idx) => {
-              newNodes.push({
-                  ...currentNode,
-                  id: `${currentNode.id}_split_${idx}`,
-                  nodes: [{
-                      type: "TEXT",
-                      id: "",
-                      nodes: [],
-                      textData: {
-                          text: part,
-                          decorations: decorations
-                      }
-                  }]
-              });
-              
-              // Add empty paragraph after each split part except the last
-              if (idx < brParts.length - 1) {
-                  newNodes.push(createEmptyParagraph(`empty_br_${nodeIdCounter++}`));
-              }
-          });
-          
-          // Add spacing after the split paragraphs if there's a next node
-          if (nextNode) {
-              newNodes.push(createEmptyParagraph(`empty_${nodeIdCounter++}`));
-          }
-      } else {
-          newNodes.push(currentNode);
-          
-          // Add empty paragraph after paragraphs with &#xa0;, consecutive paragraphs, or after lists
-          if ((needsSpacingAfter(currentNode, nextNode) || isListEnd(currentNode, nextNode)) && nextNode) {
-              newNodes.push(createEmptyParagraph(`empty_${nodeIdCounter++}`));
-          }
-      }
-  }
-  
-  return {
-      ...richContent,
-      nodes: newNodes
-  };
-}
 
 function createEmptyParagraph(id) {
   return {
@@ -371,13 +214,7 @@ function flattenListItems(richContent) {
 }
 
 // Adds empty paragraph nodes between consecutive paragraphs and before lists
-function addEmptyParagraphsBetweenConsecutive(html, richContent,jobName) {
-  console.log("jobName is : ",jobName);
-if(jobName.name==="Assistant Store Manager - Noel Leeming Albany")
-{
-  console.log("rich content is : ",richContent);
-  console.log("html is : ",html);
-}
+function addEmptyParagraphsBetweenConsecutive(html, richContent) {
   if (!richContent || !richContent.nodes) return richContent;
   const hasConsecutiveParagraphs = /<\/p>\s*<p/i.test(html);
   const hasParagraphBeforeList = /<\/p>\s*<ul/i.test(html);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "sr-npm",
-  "version": "1.7.1264",
+  "version": "1.7.1268",
   "description": "",
   "main": "index.js",
   "scripts": {

package/pages/careersMultiBoxesPage.js

@@ -39,7 +39,7 @@ let secondarySearchIsFilled=false // whether the secondary search is filled with
 let keywordAllJobs; // all jobs that are displayed in the jobs repeater when the keyword is filled
 let ActivateURLOnchange=true; // whether to activate the url onchange
 let considerAllJobs=false; // whether to consider all jobs or not
-
+let finishedUrlOnChange=false;
 const pagination = {
   pageSize: 10,
   currentPage: 1,
@@ -48,7 +48,8 @@ const pagination = {
 async function careersMultiBoxesPageOnReady(_$w,urlParams) {
   //to handle back and forth , url changes
   onChange(async ()=>{
-    await handleBackAndForth(_$w);
+    finishedUrlOnChange? finishedUrlOnChange=false : await handleBackAndForth(_$w);
+
   });
   await loadData(_$w);
   await loadJobsRepeater(_$w); // if we remove the await here the job list will be flaky , it doesn't fill it properly
@@ -76,6 +77,7 @@ async function handleBackAndForth(_$w){
       await clearAll(_$w,true);
       await handleUrlParams(_$w,newQueryParams,true); 
       ActivateURLOnchange=true;
+      
 
     }
     else{
@@ -206,6 +208,11 @@ async function handleUrlParams(_$w,urlParams,handleBackAndForth=false) {
         const jobsFirstPage=currentJobs.slice(startSlicIndex,endSlicIndex);
         _$w(CAREERS_MULTI_BOXES_PAGE_CONSTS.JOBS_REPEATER).data = jobsFirstPage;
         handlePaginationButtons(_$w);
+        if(ActivateURLOnchange)
+        {
+          finishedUrlOnChange=true;
+        }
+
       }
   } catch (error) {
     console.error('Failed to handle url params:', error);