squishjs 1.4.2 → 1.4.3

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "squishjs",
-  "version": "1.4.2",
+  "version": "1.4.3",
   "description": "squish & unsquish stuff",
   "scripts": {
     "test": "node testRunner.js"

package/src/Asset.js

@@ -165,23 +165,34 @@ class Asset {
             const fileHash = this.getHash(assetId);
             const filePath = `${assetPath}/${fileHash}`;
 
-            const writeStream = fs.createWriteStream(filePath);
             const getModule = ASSET_URL.startsWith('https') ? https : http;
 
-            writeStream.on('close', () => {
-                resolve(filePath);
-            });
-
             getModule.get(`${ASSET_URL}/${assetId}`, (res) => {
                 if (res.statusCode !== 200) {
+                    res.resume();
                     reject('Bad response when downloading asset');
-                } else {
-                    writeStream.on('finish', () => {
-                        writeStream.close();
-                    });
-
-                    res.pipe(writeStream);
+                    return;
                 }
+
+                // Only open the cache file once we know the response is good —
+                // otherwise a failed download leaves a zero-byte file behind
+                // that reads back as a valid cache hit forever after.
+                const writeStream = fs.createWriteStream(filePath);
+
+                writeStream.on('close', () => {
+                    resolve(filePath);
+                });
+
+                writeStream.on('error', (error) => {
+                    fs.unlink(filePath, () => reject(error));
+                });
+
+                res.on('error', (error) => {
+                    writeStream.destroy();
+                    fs.unlink(filePath, () => reject(error));
+                });
+
+                res.pipe(writeStream);
             }).on('error', error => {
                 console.error('Failed to download asset');
                 console.error(error);

package/src/Squisher.js

@@ -35,7 +35,9 @@ class Squisher {
 
         if (this.game.tick) {
             const tickRate = this.gameMetadata && this.gameMetadata.tickRate ? this.gameMetadata.tickRate : DEFAULT_TICK_RATE;
-            setInterval(this.game.tick.bind(this.game), 1000 / tickRate);
+            // Keep the handle so consumers can end the tick loop (repeated
+            // session create/destroy in one process leaks it otherwise).
+            this._tickInterval = setInterval(this.game.tick.bind(this.game), 1000 / tickRate);
         }
     }
 

package/src/squishHelpers/coordinates2d.js

@@ -28,12 +28,16 @@ const squishCoordinates2d = {
 
 		if (node.subType == subtypes.SHAPE_2D_CIRCLE) {
 			if (scale) {
+				// Math.floor on the integer byte is required, not decorative:
+				// a raw float here only decoded correctly because Node's
+				// Buffer truncated it on send. Consumers that don't go through
+				// Buffer (e.g. the in-browser LocalSession) would round.
 				const shiftedCenterX = clampCoord(squishHelper(scale.x, originalCoords[0]))
-				squished[0] = shiftedCenterX;
+				squished[0] = Math.floor(shiftedCenterX);
 				squished[1] = getFractional(shiftedCenterX);
 
 				const shiftedCenterY = clampCoord(squishHelper(scale.y, originalCoords[1]))
-				squished[2] = shiftedCenterY;
+				squished[2] = Math.floor(shiftedCenterY);
 				squished[3] = getFractional(shiftedCenterY);
 
 				let diagonal;
@@ -70,7 +74,7 @@ const squishCoordinates2d = {
 
 					const shifted = clampCoord(scaled + (removedSpace / 2));
 
-					squished[2 * i] = shifted;
+					squished[2 * i] = Math.floor(shifted);
 					squished[(2 * i) + 1] = getFractional(shifted);
 
 				} else {