squirreling 0.12.8 → 0.12.9

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "squirreling",
-  "version": "0.12.8",
+  "version": "0.12.9",
   "description": "Squirreling Async SQL Engine",
   "author": "Hyperparam",
   "homepage": "https://hyperparam.app",

package/src/ast.d.ts

@@ -106,6 +106,14 @@ export interface FunctionNode extends AstBase {
   filter?: ExprNode
 }
 
+export interface WindowFunctionNode extends AstBase {
+  type: 'window'
+  funcName: string
+  args: ExprNode[]
+  partitionBy: ExprNode[]
+  orderBy: OrderByItem[]
+}
+
 export type CastType = 'TEXT' | 'STRING' | 'VARCHAR' | 'INTEGER' | 'INT' | 'BIGINT' | 'FLOAT' | 'REAL' | 'DOUBLE' | 'BOOLEAN' | 'BOOL'
 
 export interface CastNode extends AstBase {
@@ -166,6 +174,7 @@ export type ExprNode =
   | UnaryNode
   | BinaryNode
   | FunctionNode
+  | WindowFunctionNode
   | CastNode
   | InSubqueryNode
   | InValuesNode

package/src/execute/execute.js

@@ -9,6 +9,7 @@ import { executeHashAggregate, executeScalarAggregate } from './aggregates.js'
 import { executeHashJoin, executeNestedLoopJoin, executePositionalJoin } from './join.js'
 import { executeSort } from './sort.js'
 import { addBounds, minBounds, stableRowKey } from './utils.js'
+import { executeWindow } from './window.js'
 
 /**
  * @import { AsyncCells, AsyncDataSource, AsyncRow, DerivedColumn, ExecuteContext, ExecuteSqlOptions, ExprNode, IdentifierNode, QueryResults, SelectColumn, SqlPrimitive, Statement } from '../types.js'
@@ -120,6 +121,8 @@ export function executePlan({ plan, context }) {
     return executeSetOperation(plan, context)
   } else if (plan.type === 'TableFunction') {
     return executeTableFunction(plan, context)
+  } else if (plan.type === 'Window') {
+    return executeWindow(plan, context)
   }
   return { columns: [], async *rows() {} }
 }

package/src/execute/window.js

@@ -0,0 +1,154 @@
+import { evaluateExpr } from '../expression/evaluate.js'
+import { executePlan } from './execute.js'
+import { compareForTerm, keyify } from './utils.js'
+
+/**
+ * @import { AsyncRow, ExecuteContext, QueryResults, SqlPrimitive } from '../types.js'
+ * @import { WindowNode, WindowSpec } from '../plan/types.js'
+ */
+
+/**
+ * Executes a Window plan node: buffers the child's rows, assigns each window
+ * function's output per partition, and yields rows in input order with the
+ * synthetic window cells attached.
+ *
+ * @param {WindowNode} plan
+ * @param {ExecuteContext} context
+ * @returns {QueryResults}
+ */
+export function executeWindow(plan, context) {
+  const child = executePlan({ plan: plan.child, context })
+  const extraColumns = plan.windows.map(w => w.alias)
+
+  // Streaming fast path: every window is OVER () with no partition/order, so
+  // each row's output depends only on its position in the input stream. Avoids
+  // buffering — critical for large scans (e.g. parquet).
+  const streamable = plan.windows.every(w => w.partitionBy.length === 0 && w.orderBy.length === 0)
+
+  if (streamable) {
+    return {
+      columns: [...child.columns, ...extraColumns],
+      numRows: child.numRows,
+      maxRows: child.maxRows,
+      async *rows() {
+        let i = 0
+        for await (const row of child.rows()) {
+          if (context.signal?.aborted) return
+          i++
+          const cells = { ...row.cells }
+          for (const w of plan.windows) {
+            const value = assignRowNumber(w.funcName, i - 1)
+            cells[w.alias] = () => Promise.resolve(value)
+          }
+          yield {
+            columns: [...row.columns, ...extraColumns],
+            cells,
+          }
+        }
+      },
+    }
+  }
+
+  return {
+    columns: [...child.columns, ...extraColumns],
+    numRows: child.numRows,
+    maxRows: child.maxRows,
+    async *rows() {
+      /** @type {AsyncRow[]} */
+      const rows = []
+      for await (const row of child.rows()) {
+        if (context.signal?.aborted) return
+        rows.push(row)
+      }
+      if (rows.length === 0) return
+
+      // One SqlPrimitive per window spec per row, indexed by row input position.
+      /** @type {SqlPrimitive[][]} */
+      const windowValues = plan.windows.map(() => new Array(rows.length))
+
+      for (let w = 0; w < plan.windows.length; w++) {
+        await computeWindow(plan.windows[w], rows, windowValues[w], context)
+        if (context.signal?.aborted) return
+      }
+
+      for (let i = 0; i < rows.length; i++) {
+        if (context.signal?.aborted) return
+        const row = rows[i]
+        const cells = { ...row.cells }
+        for (let w = 0; w < plan.windows.length; w++) {
+          const { alias } = plan.windows[w]
+          const value = windowValues[w][i]
+          cells[alias] = () => Promise.resolve(value)
+        }
+        yield {
+          columns: [...row.columns, ...extraColumns],
+          cells,
+        }
+      }
+    },
+  }
+}
+
+/**
+ * Computes a single window function across all rows, writing the per-row
+ * output values into `output`.
+ *
+ * @param {WindowSpec} spec
+ * @param {AsyncRow[]} rows
+ * @param {SqlPrimitive[]} output
+ * @param {ExecuteContext} context
+ */
+async function computeWindow(spec, rows, output, context) {
+  // Bucket row indices by partition key.
+  /** @type {Map<string | number | bigint | boolean, number[]>} */
+  const partitions = new Map()
+  const partitionKeys = await Promise.all(rows.map(row =>
+    Promise.all(spec.partitionBy.map(expr => evaluateExpr({ node: expr, row, context })))
+  ))
+  for (let i = 0; i < rows.length; i++) {
+    const key = keyify(...partitionKeys[i])
+    let bucket = partitions.get(key)
+    if (!bucket) {
+      bucket = []
+      partitions.set(key, bucket)
+    }
+    bucket.push(i)
+  }
+
+  for (const bucket of partitions.values()) {
+    if (context.signal?.aborted) return
+
+    // Order within the partition. Empty ORDER BY → input order.
+    if (spec.orderBy.length) {
+      const orderValues = await Promise.all(bucket.map(idx =>
+        Promise.all(spec.orderBy.map(term => evaluateExpr({ node: term.expr, row: rows[idx], context })))
+      ))
+      /** @type {{ idx: number, values: SqlPrimitive[], pos: number }[]} */
+      const entries = bucket.map((idx, k) => ({ idx, values: orderValues[k], pos: k }))
+      entries.sort((a, b) => {
+        for (let i = 0; i < spec.orderBy.length; i++) {
+          const cmp = compareForTerm(a.values[i], b.values[i], spec.orderBy[i])
+          if (cmp !== 0) return cmp
+        }
+        return a.pos - b.pos
+      })
+      for (let k = 0; k < entries.length; k++) {
+        output[entries[k].idx] = assignRowNumber(spec.funcName, k)
+      }
+    } else {
+      for (let k = 0; k < bucket.length; k++) {
+        output[bucket[k]] = assignRowNumber(spec.funcName, k)
+      }
+    }
+  }
+}
+
+/**
+ * @param {string} funcName
+ * @param {number} rank - 0-based rank within the partition
+ * @returns {SqlPrimitive}
+ */
+function assignRowNumber(funcName, rank) {
+  if (funcName === 'ROW_NUMBER') return rank + 1
+  throw new Error(`Unsupported window function: ${funcName}`)
+}

package/src/expression/alias.js

@@ -31,6 +31,9 @@ export function derivedAlias(expr) {
     }
     return expr.funcName.toLowerCase() + '_' + expr.args.map(derivedAlias).join('_')
   }
+  if (expr.type === 'window') {
+    return expr.funcName.toLowerCase()
+  }
   if (expr.type === 'interval') {
     return `interval_${expr.value}_${expr.unit.toLowerCase()}`
   }

package/src/parse/functions.js

@@ -1,10 +1,10 @@
-import { isAggregateFunc, isKnownFunction, niladicFuncs, validateFunctionArgs } from '../validation/functions.js'
+import { isAggregateFunc, isKnownFunction, isWindowFunc, niladicFuncs, validateFunctionArgs } from '../validation/functions.js'
 import { ParseError, UnknownFunctionError } from '../validation/parseErrors.js'
 import { parseExpression } from './expression.js'
 import { consume, current, expect, match } from './state.js'
 
 /**
- * @import { ExprNode, ParserState } from '../types.js'
+ * @import { ExprNode, OrderByItem, ParserState } from '../types.js'
  */
 
 /**
@@ -128,13 +128,43 @@ export function parseFunctionCall(state, positionStart) {
     expect(state, 'paren', ')')
   }
 
-  // Check for OVER clause (window functions not supported)
+  // Check for OVER clause
   const overTok = current(state)
-  if (overTok.type === 'identifier' && overTok.value.toUpperCase() === 'OVER') {
+  const hasOver = overTok.type === 'identifier' && overTok.value.toUpperCase() === 'OVER'
+
+  if (hasOver) {
+    if (!isWindowFunc(funcNameUpper)) {
+      throw new ParseError({
+        message: `Window functions are not supported: ${funcName}(...) OVER (...)`,
+        positionStart,
+        positionEnd: overTok.positionEnd,
+      })
+    }
+    if (filter) {
+      throw new ParseError({
+        message: `FILTER cannot be combined with OVER for "${funcName}"`,
+        positionStart,
+        positionEnd: overTok.positionEnd,
+      })
+    }
+    consume(state)
+    const { partitionBy, orderBy } = parseWindowSpec(state, positionStart)
+    return {
+      type: 'window',
+      funcName,
+      args,
+      partitionBy,
+      orderBy,
+      positionStart,
+      positionEnd: state.lastPos,
+    }
+  }
+
+  if (isWindowFunc(funcNameUpper)) {
     throw new ParseError({
-      message: `Window functions are not supported: ${funcName}(...) OVER (...)`,
+      message: `${funcName}() requires an OVER clause at position ${positionStart}`,
       positionStart,
-      positionEnd: overTok.positionEnd,
+      positionEnd: state.lastPos,
     })
   }
 
@@ -148,3 +178,64 @@ export function parseFunctionCall(state, positionStart) {
     positionEnd: state.lastPos,
   }
 }
+
+/**
+ * Parses the window spec after OVER: ( [PARTITION BY expr[, ...]] [ORDER BY expr [ASC|DESC] [NULLS FIRST|LAST][, ...]] )
+ *
+ * @param {ParserState} state
+ * @param {number} positionStart - start position of the enclosing function call (for OrderByItem positions)
+ * @returns {{ partitionBy: ExprNode[], orderBy: OrderByItem[] }}
+ */
+function parseWindowSpec(state, positionStart) {
+  expect(state, 'paren', '(')
+  /** @type {ExprNode[]} */
+  const partitionBy = []
+  /** @type {OrderByItem[]} */
+  const orderBy = []
+
+  const partitionTok = current(state)
+  if (partitionTok.type === 'identifier' && partitionTok.value.toUpperCase() === 'PARTITION') {
+    consume(state)
+    expect(state, 'keyword', 'BY')
+    while (true) {
+      partitionBy.push(parseExpression(state))
+      if (!match(state, 'comma')) break
+    }
+  }
+
+  if (match(state, 'keyword', 'ORDER')) {
+    expect(state, 'keyword', 'BY')
+    while (true) {
+      const expr = parseExpression(state)
+      /** @type {'ASC' | 'DESC'} */
+      let direction = 'ASC'
+      if (match(state, 'keyword', 'ASC')) {
+        direction = 'ASC'
+      } else if (match(state, 'keyword', 'DESC')) {
+        direction = 'DESC'
+      }
+      /** @type {'FIRST' | 'LAST' | undefined} */
+      let nulls
+      if (match(state, 'keyword', 'NULLS')) {
+        const tok = consume(state)
+        const upper = tok.value.toUpperCase()
+        if (tok.type === 'identifier' && upper === 'FIRST') {
+          nulls = 'FIRST'
+        } else if (tok.type === 'identifier' && upper === 'LAST') {
+          nulls = 'LAST'
+        } else {
+          throw new ParseError({
+            message: `Expected FIRST or LAST after NULLS at position ${tok.positionStart}`,
+            positionStart: tok.positionStart,
+            positionEnd: tok.positionEnd,
+          })
+        }
+      }
+      orderBy.push({ expr, direction, nulls, positionStart, positionEnd: state.lastPos })
+      if (!match(state, 'comma')) break
+    }
+  }
+
+  expect(state, 'paren', ')')
+  return { partitionBy, orderBy }
+}

package/src/plan/columns.js

@@ -211,6 +211,10 @@ function collectColumnsFromExpr(expr, columns, aliases) {
       collectColumnsFromExpr(arg, columns, aliases)
     }
     collectColumnsFromExpr(expr.filter, columns, aliases)
+  } else if (expr.type === 'window') {
+    for (const arg of expr.args) collectColumnsFromExpr(arg, columns, aliases)
+    for (const p of expr.partitionBy) collectColumnsFromExpr(p, columns, aliases)
+    for (const o of expr.orderBy) collectColumnsFromExpr(o.expr, columns, aliases)
   } else if (expr.type === 'cast') {
     collectColumnsFromExpr(expr.expr, columns, aliases)
   } else if (expr.type === 'in valuelist') {

package/src/plan/plan.js

@@ -1,13 +1,14 @@
 import { derivedAlias } from '../expression/alias.js'
 import { parseSql } from '../parse/parse.js'
 import { findAggregate } from '../validation/aggregates.js'
+import { ParseError } from '../validation/parseErrors.js'
 import { ColumnNotFoundError, TableNotFoundError } from '../validation/tables.js'
 import { validateNoIdentifiers, validateScan, validateTableRefs } from '../validation/tables.js'
 import { extractColumns, fromAlias, inferSelectSourceColumns, inferStatementColumns, tableFunctionColumnNames } from './columns.js'
 
 /**
- * @import { AsyncDataSource, ExprNode, DerivedColumn, IdentifierNode, JoinClause, PlanSqlOptions, ScanOptions, SelectColumn, SelectStatement, SetOperationStatement, Statement } from '../types.js'
- * @import { QueryPlan } from './types.d.ts'
+ * @import { AsyncDataSource, ExprNode, DerivedColumn, IdentifierNode, JoinClause, PlanSqlOptions, ScanOptions, SelectColumn, SelectStatement, SetOperationStatement, Statement, WindowFunctionNode } from '../types.js'
+ * @import { QueryPlan, WindowSpec } from './types.d.ts'
  */
 
 /**
@@ -106,12 +107,51 @@ function planSetOperation({ compound, ctePlans, cteColumns, tables, parentColumn
  * @returns {QueryPlan}
  */
 function planSelect({ select, ctePlans, cteColumns, tables, parentColumns, outerScope }) {
+  // Reject window functions in clauses where they're not permitted.
+  expectNoWindowFunction(select.where, 'WHERE')
+  expectNoWindowFunction(select.having, 'HAVING')
+  for (const expr of select.groupBy) expectNoWindowFunction(expr, 'GROUP BY')
+  for (const term of select.orderBy) expectNoWindowFunction(term.expr, 'ORDER BY')
+  for (const join of select.joins) expectNoWindowFunction(join.on, 'JOIN ON')
+
+  // Collect window functions from SELECT columns and rewrite them to identifiers
+  // pointing at the synthetic cells produced by the Window plan node.
+  /** @type {WindowSpec[]} */
+  const windows = []
+  const windowColumns = select.columns.map(col => {
+    if (col.type !== 'derived') return col
+    const originalAlias = col.alias ?? derivedAlias(col.expr)
+    const expr = collectWindows(col.expr, windows)
+    if (expr === col.expr) return col
+    return { ...col, expr, alias: originalAlias }
+  })
+
+  if (windows.length && select.columns.some(col => col.type === 'derived' && findAggregate(col.expr))) {
+    throw new ParseError({
+      message: 'Window functions are not supported in queries with aggregation',
+      ...select,
+    })
+  }
+  if (windows.length && select.groupBy.length) {
+    throw new ParseError({
+      message: 'Window functions are not supported in queries with aggregation',
+      ...select,
+    })
+  }
+
+  // Preserve the pre-substitution columns for column-extraction, so synthetic
+  // `__window_N` identifiers are not requested from the data source.
+  const originalSelect = select
+  select = { ...select, columns: windowColumns }
+
   // Check for aggregation
   const hasAggregate = select.columns.some(col =>
     col.type === 'derived' && findAggregate(col.expr)
   )
   const useGrouping = hasAggregate || select.groupBy.length > 0
-  const needsBuffering = useGrouping || select.orderBy.length > 0
+  // Windows with PARTITION BY or ORDER BY buffer; `OVER ()` streams.
+  const bufferingWindows = windows.some(w => w.partitionBy.length > 0 || w.orderBy.length > 0)
+  const needsBuffering = useGrouping || select.orderBy.length > 0 || bufferingWindows
 
   // Source alias for FROM clause
   const sourceAlias = fromAlias(select.from)
@@ -155,7 +195,7 @@ function planSelect({ select, ctePlans, cteColumns, tables, parentColumns, outer
   // included so they are only applied to fresh scans, not CTE/subquery plans)
   /** @type {ScanOptions} */
   const hints = {}
-  const perTableColumns = extractColumns({ select, parentColumns })
+  const perTableColumns = extractColumns({ select: originalSelect, parentColumns })
   hints.columns = perTableColumns.get(sourceAlias)
   // Empty columns array means no columns were referenced, but a FROM subquery
   // still needs its own columns (e.g. for DISTINCT). Treat empty as unrestricted.
@@ -219,6 +259,12 @@ function planSelect({ select, ctePlans, cteColumns, tables, parentColumns, outer
   } else {
     // Non-aggregation path
 
+    // Window functions: insert before Sort so outer ORDER BY can reference
+    // the window output aliases.
+    if (windows.length) {
+      plan = { type: 'Window', windows, child: plan }
+    }
+
     // ORDER BY (before projection so it can access all columns)
     // Resolve SELECT aliases in ORDER BY expressions at plan time
     if (select.orderBy.length) {
@@ -609,6 +655,126 @@ function validateLateralSubqueries({ expr, ctePlans, cteColumns, tables, outerSc
   }
 }
 
+/**
+ * Walks an expression, replacing every window function subnode with an
+ * identifier that points at a synthetic `__window_N` cell. The collected
+ * WindowSpec entries drive the Window plan node. Returns the same node
+ * reference when no window function is present, so untouched expressions
+ * aren't shallow-cloned.
+ *
+ * @param {ExprNode} expr
+ * @param {WindowSpec[]} windows
+ * @returns {ExprNode}
+ */
+function collectWindows(expr, windows) {
+  if (!expr || !findWindow(expr)) return expr
+  if (expr.type === 'window') {
+    const alias = `__window_${windows.length}`
+    windows.push({
+      alias,
+      funcName: expr.funcName.toUpperCase(),
+      args: expr.args,
+      partitionBy: expr.partitionBy,
+      orderBy: expr.orderBy,
+    })
+    return {
+      type: 'identifier',
+      name: alias,
+      positionStart: expr.positionStart,
+      positionEnd: expr.positionEnd,
+    }
+  }
+  if (expr.type === 'unary') {
+    return { ...expr, argument: collectWindows(expr.argument, windows) }
+  }
+  if (expr.type === 'binary') {
+    return { ...expr, left: collectWindows(expr.left, windows), right: collectWindows(expr.right, windows) }
+  }
+  if (expr.type === 'function') {
+    return { ...expr, args: expr.args.map(a => collectWindows(a, windows)) }
+  }
+  if (expr.type === 'cast') {
+    return { ...expr, expr: collectWindows(expr.expr, windows) }
+  }
+  if (expr.type === 'in valuelist') {
+    return {
+      ...expr,
+      expr: collectWindows(expr.expr, windows),
+      values: expr.values.map(v => collectWindows(v, windows)),
+    }
+  }
+  if (expr.type === 'case') {
+    return {
+      ...expr,
+      caseExpr: expr.caseExpr && collectWindows(expr.caseExpr, windows),
+      whenClauses: expr.whenClauses.map(w => ({
+        ...w,
+        condition: collectWindows(w.condition, windows),
+        result: collectWindows(w.result, windows),
+      })),
+      elseResult: expr.elseResult && collectWindows(expr.elseResult, windows),
+    }
+  }
+  return expr
+}
+
+/**
+ * Throws if the expression tree contains a window function.
+ *
+ * @param {ExprNode | undefined} expr
+ * @param {string} clause
+ */
+function expectNoWindowFunction(expr, clause) {
+  const win = findWindow(expr)
+  if (win) {
+    throw new ParseError({
+      message: `Window function ${win.funcName.toUpperCase()} is not allowed in ${clause} clause`,
+      positionStart: win.positionStart,
+      positionEnd: win.positionEnd,
+    })
+  }
+}
+
+/**
+ * @param {ExprNode | undefined} expr
+ * @returns {WindowFunctionNode | undefined}
+ */
+function findWindow(expr) {
+  if (!expr) return undefined
+  if (expr.type === 'window') return expr
+  if (expr.type === 'binary') return findWindow(expr.left) || findWindow(expr.right)
+  if (expr.type === 'unary') return findWindow(expr.argument)
+  if (expr.type === 'function') {
+    for (const arg of expr.args) {
+      const found = findWindow(arg)
+      if (found) return found
+    }
+    return undefined
+  }
+  if (expr.type === 'cast') return findWindow(expr.expr)
+  if (expr.type === 'in valuelist') {
+    const found = findWindow(expr.expr)
+    if (found) return found
+    for (const val of expr.values) {
+      const f = findWindow(val)
+      if (f) return f
+    }
+    return undefined
+  }
+  if (expr.type === 'case') {
+    if (expr.caseExpr) {
+      const f = findWindow(expr.caseExpr)
+      if (f) return f
+    }
+    for (const w of expr.whenClauses) {
+      const f = findWindow(w.condition) || findWindow(w.result)
+      if (f) return f
+    }
+    if (expr.elseResult) return findWindow(expr.elseResult)
+  }
+  return undefined
+}
+
 /**
  * Checks if every SELECT column is a plain COUNT(*).
  *

package/src/plan/types.d.ts

@@ -15,6 +15,7 @@ export type QueryPlan =
   | PositionalJoinNode
   | SetOperationNode
   | TableFunctionNode
+  | WindowNode
 
 // Scan node
 export interface ScanNode {
@@ -124,3 +125,17 @@ export interface TableFunctionNode {
   args: ExprNode[]
   columnNames: string[]
 }
+
+export interface WindowSpec {
+  alias: string
+  funcName: string
+  args: ExprNode[]
+  partitionBy: ExprNode[]
+  orderBy: OrderByItem[]
+}
+
+export interface WindowNode {
+  type: 'Window'
+  windows: WindowSpec[]
+  child: QueryPlan
+}

package/src/validation/functions.js

@@ -26,6 +26,14 @@ export function isMathFunc(name) {
   ].includes(name)
 }
 
+/**
+ * @param {string} name
+ * @returns {boolean}
+ */
+export function isWindowFunc(name) {
+  return ['ROW_NUMBER'].includes(name)
+}
+
 /**
  * @param {string} name
  * @returns {name is RegExpFunction}
@@ -200,6 +208,9 @@ export const FUNCTION_SIGNATURES = {
   APPROX_QUANTILE: { min: 2, max: 2, signature: 'expression, fraction' },
   STRING_AGG: { min: 2, max: 2, signature: 'expression, separator' },
 
+  // Window functions
+  ROW_NUMBER: { min: 0, max: 0, signature: '' },
+
   // Spatial functions
   ST_INTERSECTS: { min: 2, max: 2, signature: 'geometry, geometry' },
   ST_CONTAINS: { min: 2, max: 2, signature: 'geometry, geometry' },

package/src/validation/parseErrors.js

@@ -2,7 +2,7 @@ import { FUNCTION_SIGNATURES } from './functions.js'
 
 /** Well-known window functions that are not supported */
 const WINDOW_FUNCTIONS = new Set([
-  'ROW_NUMBER', 'RANK', 'DENSE_RANK', 'NTILE',
+  'RANK', 'DENSE_RANK', 'NTILE',
   'LAG', 'LEAD', 'FIRST_VALUE', 'LAST_VALUE', 'NTH_VALUE',
   'CUME_DIST', 'PERCENT_RANK',
 ])

package/src/validation/tables.js

@@ -119,6 +119,10 @@ export function validateTableRefs(expr, tables) {
     for (const arg of expr.args) {
       validateTableRefs(arg, tables)
     }
+  } else if (expr.type === 'window') {
+    for (const arg of expr.args) validateTableRefs(arg, tables)
+    for (const p of expr.partitionBy) validateTableRefs(p, tables)
+    for (const o of expr.orderBy) validateTableRefs(o.expr, tables)
   } else if (expr.type === 'cast') {
     validateTableRefs(expr.expr, tables)
   } else if (expr.type === 'in valuelist') {