squadrant 0.28.1 → 0.29.0

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "squadrant",
   "packageManager": "pnpm@10.30.3",
-  "version": "0.28.1",
+  "version": "0.29.0",
   "description": "Multi-project orchestration for your coding agents (Claude, Codex, opencode, Gemini)",
   "type": "module",
   "bin": {

package/plugin/skills/captain-ops/SKILL.md

@@ -28,13 +28,13 @@ Execute the 4-step startup contract defined in your system prompt.
    Check tasks from the same call — `liveRepo.liveCrews` lists every non-terminal crew task for this project. A `state: "blocked"` entry with a `question` is waiting on you right now.
 
 4. **Read handoff:**
-   `~/.config/squadrant/scripts/read-handoff.sh "{spokeVaultPath}"`
+   `~/.config/squadrant/scripts/read-handoff.sh "{project}"` (reads `~/squadrant/workspace/{project}/handoff.json`)
    If a handoff exists, read the context carefully (`currentState`, `openBranches`, `nextSteps`, `blockedItems`, `decisions`). 
    If it reported `"exists": false`, reconstruct from the `handoff facts` output instead of cold-starting blind (check `checkpoint`, `gapSessions`, `claudeMem`). You do the synthesizing.
 
 5. **Additional Context (opt-in):**
    - Search **claude-mem** (`mem-search` skill) for your project name.
-   - Check `{spokeVault}/daily-logs/` for the most recent log.
+   - Check `~/squadrant/workspace/{project}/artifacts/daily-logs/` for the most recent log.
    - Check `{spokeVault}/learnings/` — selectively load relevant learnings.
    - Check `{spokeVault}/skills/` and `{spokeVault}/wiki/`.
    - Crew lifecycle events (done / blocked / idle) are delivered to your captain pane automatically by the squadrant daemon via daemon-direct cmux delivery (#332). No relay setup required.
@@ -300,8 +300,12 @@ On CREW REVIEW or CREW DONE:
 | Good — matches the task, tests pass, no scope creep | **DEFAULT mode:** Surface diff summary to user and WAIT. Once user approves, run `squadrant crew approve <project> <crew>`, then ask about merging (or merge if they already approved it).<br><br>**DELEGATED mode:** Run `squadrant crew approve <project> <crew>`, then merge autonomously. |
 | Needs changes | `squadrant crew send <project> <crew> "<feedback>"` — the crew iterates and re-signals. Loop until approved. |
 
-3. **Never auto-terminalize** by emitting `task.done` directly — always go through `squadrant crew approve`.
-4. Do **not** re-send the original task or close the crew while it's awaiting review — `crew close` on a `review`-state task discards work that hasn't been pushed anywhere yet.
+3. **Grade the rules the crew was given** (only if the project subscribes to a knowledge base; #945). While the diff is open:
+   - `squadrant knowledge surfaced --task <task-id>` lists the rules delivered to that task (task id from `squadrant crew tasks <project>`).
+   - For each listed rule that **applies to this diff**, record what you saw: `squadrant knowledge feedback <rule-id> --followed|--violated --source review --task <task-id>` (`--wrong` if the rule itself is wrong).
+   - Skip the rules that don't apply. Don't guess: grade only what the diff shows. These grades are the high-confidence signal behind `complianceRate` and `violationRate` in the KB's REPORT.md.
+4. **Never auto-terminalize** by emitting `task.done` directly — always go through `squadrant crew approve`.
+5. Do **not** re-send the original task or close the crew while it's awaiting review — `crew close` on a `review`-state task discards work that hasn't been pushed anywhere yet.
 
 ## When Crew is Fully Finished (After Approval)
 
@@ -390,7 +394,7 @@ End-of-session writes are **opt-in**, not on a schedule. Only write what is mean
 3. **Handoff (opt-in but recommended for in-flight work):** if work is mid-flight, write a handoff so tomorrow's session can resume:
 
 ```bash
-~/.config/squadrant/scripts/write-handoff.sh "{spokeVaultPath}" '{
+~/.config/squadrant/scripts/write-handoff.sh "{project}" '{
   "currentState": "Brief description of where things stand",
   "openBranches": ["feat/branch-name — what it contains"],
   "nextSteps": ["First thing to do tomorrow", "Second thing"],

package/plugin/skills/command-ops/SKILL.md

@@ -13,9 +13,9 @@ Run when session starts, or user says "morning", "catch up", "summary":
 
 1. **Check handoffs from all projects** (context from yesterday's sessions):
 ```bash
-for vault in $(cat ~/.config/squadrant/config.json | python3 -c "import json,sys; [print(p['spokeVault']) for p in json.loads(sys.stdin.read())['projects'].values()]"); do
-  echo "=== $(basename $vault) ==="
-  ~/.config/squadrant/scripts/read-handoff.sh "$vault" --keep
+for project in $(cat ~/.config/squadrant/config.json | python3 -c "import json,sys; [print(p) for p in json.loads(sys.stdin.read())['projects']]"); do
+  echo "=== $project ==="
+  ~/.config/squadrant/scripts/read-handoff.sh "$project" --keep
 done
 ```
 Handoffs contain: currentState, openBranches, nextSteps, blockedItems, decisions. Use these to understand where each project left off.
@@ -24,9 +24,9 @@ Handoffs contain: currentState, openBranches, nextSteps, blockedItems, decisions
 3. Read yesterday's logs:
 ```bash
 YESTERDAY=$(date -v-1d +"%Y-%m-%d")
-for vault in $(cat ~/.config/squadrant/config.json | python3 -c "import json,sys; [print(p['spokeVault']) for p in json.loads(sys.stdin.read())['projects'].values()]"); do
-  echo "=== $vault ==="
-  cat "$vault/daily-logs/${YESTERDAY}.md" 2>/dev/null || echo "(no log)"
+for project in $(cat ~/.config/squadrant/config.json | python3 -c "import json,sys; [print(p) for p in json.loads(sys.stdin.read())['projects']]"); do
+  echo "=== $project ==="
+  cat ~/squadrant/workspace/"$project"/artifacts/daily-logs/"${YESTERDAY}.md" 2>/dev/null || echo "(no log)"
 done
 ```
 4. Run quick standup for context: `squadrant standup --yesterday --raw`
@@ -49,7 +49,9 @@ squadrant runtime list
 A name match is **not** sufficient — the workspace may be holding a session from a previous day. Check `sessions.json` against today before reusing:
 ```bash
 TODAY=$(date +%Y-%m-%d)
-LAST=$(python3 -c "import json; d=json.load(open('$HOME/.config/squadrant/sessions.json')); print(d.get('workspaces',{}).get('{captainName}',{}).get('lastLaunched',''))" 2>/dev/null)
+S="${SQUADRANT_STATE_DIR:-${XDG_STATE_HOME:-$HOME/.local/state}/squadrant}/sessions.json"
+[ -f "$S" ] || S="$HOME/.config/squadrant/sessions.json"  # pre-#983 location
+LAST=$(python3 -c "import json,sys; d=json.load(open(sys.argv[1])); print(d.get('workspaces',{}).get('{captainName}',{}).get('lastLaunched',''))" "$S" 2>/dev/null)
 [ "$LAST" = "$TODAY" ] && echo "fresh" || echo "stale"
 ```
 - `fresh` → reuse the existing workspace, proceed to step 5.

package/plugin/skills/daily-log/SKILL.md

@@ -1,6 +1,6 @@
 ---
 name: daily-log
-description: Write an end-of-day log to your spoke vault. Use when session ends or user says "end of day" / "wrap up".
+description: Write an end-of-day log to your project workspace. Use when session ends or user says "end of day" / "wrap up".
 ---
 
 # Daily Log
@@ -11,11 +11,11 @@ Write a daily log before your session ends.
 
 ```bash
 DATE=$(date +"%Y-%m-%d")
-SPOKE_VAULT="{spokeVaultPath}"
-mkdir -p "$SPOKE_VAULT/daily-logs"
+LOG_DIR=~/squadrant/workspace/{project-name}/artifacts/daily-logs
+mkdir -p "$LOG_DIR"
 ```
 
-## Write to `{spokeVaultPath}/daily-logs/YYYY-MM-DD.md`
+## Write to `~/squadrant/workspace/{project-name}/artifacts/daily-logs/YYYY-MM-DD.md`
 
 ```markdown
 ---

package/plugin/skills/side-session/SKILL.md

@@ -61,7 +61,7 @@ If the topic already contains all of this, it confirms and proceeds. Otherwise i
 1. Side session produces a result (root cause / artifact).
 2. Session asks: "Notify the primary captain now? (y/n)"
 3. On yes:
-   - Writes durable record: {spokeVault}/side-handoffs/<topic>.md
+   - Writes durable record: ~/squadrant/workspace/<project>/side-handoffs/<topic>.md
    - Sends: squadrant runtime send <project> "🗒 Side handoff [<role>] — <topic> ..."
 4. Primary captain receives handoff delivered daemon-direct via cmux (#332).
 5. Captain does NOT auto-spawn a crew — waits for user's go.

package/plugin/skills/where-i-am/SKILL.md

@@ -73,12 +73,12 @@ echo "$PROJECT_JSON"
 
 If empty `{}`: not inside a known squadrant project — build the report from **session context + git only**, and skip steps 2–3 below.
 
-Otherwise note `name` and `spokeVault` for the next steps.
+Otherwise note `name` for the next steps.
 
 **2. Read the handoff WITHOUT consuming it** (note the `--keep` — never drop the `--keep`, or you destroy the next session's startup context):
 
 ```bash
-~/.config/squadrant/scripts/read-handoff.sh "<spokeVault>" --keep
+~/.config/squadrant/scripts/read-handoff.sh "<name>" --keep
 ```
 
 `{"exists": false}` means none — fine, skip it.
@@ -86,7 +86,7 @@ Otherwise note `name` and `spokeVault` for the next steps.
 **3. Read the latest daily-log** (if any):
 
 ```bash
-ls -t "<spokeVault>"/daily-logs/*.md 2>/dev/null | head -1
+ls -t ~/squadrant/workspace/"<name>"/artifacts/daily-logs/*.md 2>/dev/null | head -1
 ```
 
 Read that one file for `Completed` / `In Progress` / `Blocked` / `Tomorrow`.

package/scripts/read-handoff.sh

@@ -1,14 +1,29 @@
 #!/bin/bash
-# Usage: read-handoff.sh <spoke-vault-path> [--keep]
-# Reads and prints handoff.json, then archives it to handoffs/<date>.json
-# (unless --keep). Captain calls this on session startup to load previous
-# context.
+# Usage: read-handoff.sh <project|workspace-path|spoke-vault-path> [--keep]
+# Reads and prints workspace/<project>/handoff.json, then archives it to
+# workspace/<project>/handoffs/<date>.json (unless --keep). Captain calls this
+# on session startup to load previous context. Only the basename of the first
+# arg is used (#983).
 set -euo pipefail
 
-VAULT="${1:?Usage: read-handoff.sh <vault-path> [--keep]}"
+TARGET="${1:?Usage: read-handoff.sh <project-or-vault-path> [--keep]}"
 KEEP="${2:-}"
+PROJECT="$(basename "$TARGET")"
+VAULT="${SQUADRANT_WORKSPACE_DIR:-$HOME/squadrant/workspace}/$PROJECT"
 HANDOFF_FILE="$VAULT/handoff.json"
 
+# #983 dual-read (one version): a handoff written before the move still sits
+# in the old spoke vault — the path passed in, or the default hub location.
+if [ ! -f "$HANDOFF_FILE" ]; then
+  for LEGACY in "$TARGET" "$HOME/squadrant-hub/spokes/$PROJECT"; do
+    case "$LEGACY" in */*) ;; *) continue ;; esac
+    if [ -f "$LEGACY/handoff.json" ]; then
+      HANDOFF_FILE="$LEGACY/handoff.json"
+      break
+    fi
+  done
+fi
+
 if [ ! -f "$HANDOFF_FILE" ]; then
   echo '{"exists": false}'
   exit 0

package/scripts/record-side-handoff.sh

@@ -1,9 +1,11 @@
 #!/bin/bash
-# Usage: record-side-handoff.sh <spoke-vault-path> <topic> <role> <summary>
-# Writes a durable handoff record to {spokeVault}/side-handoffs/<topic-slug>.md
+# Usage: record-side-handoff.sh <project|workspace-path|spoke-vault-path> <topic> <role> <summary>
+# Writes a durable handoff record to workspace/<project>/side-handoffs/<topic-slug>.md
+# (#983: was {spokeVault}/side-handoffs/). Only the basename of the first arg is used.
 set -euo pipefail
 
-VAULT="${1:?Usage: record-side-handoff.sh <vault-path> <topic> <role> <summary>}"
+TARGET="${1:?Usage: record-side-handoff.sh <project-or-vault-path> <topic> <role> <summary>}"
+VAULT="${SQUADRANT_WORKSPACE_DIR:-$HOME/squadrant/workspace}/$(basename "$TARGET")"
 TOPIC="${2:?}"
 ROLE="${3:?}"
 SUMMARY="${4:?}"

package/scripts/spawn-workspace.sh

@@ -6,7 +6,11 @@ set -euo pipefail
 
 CMUX="/Applications/cmux.app/Contents/Resources/bin/cmux"
 TEMPLATES_DIR="${HOME}/.config/squadrant/templates"
-SESSIONS_FILE="${HOME}/.config/squadrant/sessions.json"
+# #983 6a: sessions.json lives in XDG state (mirrors stateRoot()). Read the
+# pre-move ~/.config file until the new one exists; writes go to the new path.
+SESSIONS_FILE="${SQUADRANT_STATE_DIR:-${XDG_STATE_HOME:-$HOME/.local/state}/squadrant}/sessions.json"
+SESSIONS_READ="$SESSIONS_FILE"
+[ -f "$SESSIONS_READ" ] || SESSIONS_READ="${HOME}/.config/squadrant/sessions.json"
 NAME="${1:?Usage: spawn-workspace.sh <name> <cwd> [role] [--fresh]}"
 CWD="${2:?Usage: spawn-workspace.sh <name> <cwd> [role] [--fresh]}"
 ROLE="${3:-captain}"
@@ -18,12 +22,12 @@ FRESH=false
 # --- Session freshness check ---
 if [ "$FORCE_FRESH" = "--fresh" ]; then
   FRESH=true
-elif [ -f "$SESSIONS_FILE" ]; then
+elif [ -f "$SESSIONS_READ" ]; then
   # Check last launch date
   LAST_DATE=$(python3 -c "
 import json, sys
 try:
-    data = json.load(open('$SESSIONS_FILE'))
+    data = json.load(open('$SESSIONS_READ'))
     print(data.get('workspaces', {}).get('$NAME', {}).get('lastLaunched', ''))
 except: print('')
 " 2>/dev/null)
@@ -43,7 +47,7 @@ except: print('')
     STORED_HASH=$(python3 -c "
 import json
 try:
-    data = json.load(open('$SESSIONS_FILE'))
+    data = json.load(open('$SESSIONS_READ'))
     print(data.get('workspaces', {}).get('$NAME', {}).get('templateHash', ''))
 except: print('')
 " 2>/dev/null)
@@ -64,7 +68,7 @@ python3 -c "
 import json, os
 path = '$SESSIONS_FILE'
 try:
-    data = json.load(open(path))
+    data = json.load(open('$SESSIONS_READ'))
 except: data = {'workspaces': {}}
 data.setdefault('workspaces', {})['$NAME'] = {'lastLaunched': '$TODAY', 'templateHash': '$CURRENT_HASH'}
 os.makedirs(os.path.dirname(path), exist_ok=True)

package/scripts/write-handoff.sh

@@ -1,11 +1,14 @@
 #!/bin/bash
-# Usage: write-handoff.sh <spoke-vault-path> <json-content>
-# Writes a handoff.json file for session continuity.
+# Usage: write-handoff.sh <project|workspace-path|spoke-vault-path> <json-content>
+# Writes workspace/<project>/handoff.json for session continuity (#983: was
+# <spokeVault>/handoff.json). Only the basename of the first arg is used, so
+# captains still passing their old spoke path keep working.
 # Captain calls this at session end to preserve context for tomorrow.
 set -euo pipefail
 
-VAULT="${1:?Usage: write-handoff.sh <vault-path> <json-content>}"
+TARGET="${1:?Usage: write-handoff.sh <project-or-vault-path> <json-content>}"
 CONTENT="${2:?Provide JSON content as second argument}"
+VAULT="${SQUADRANT_WORKSPACE_DIR:-$HOME/squadrant/workspace}/$(basename "$TARGET")"
 
 mkdir -p "$VAULT"
 HANDOFF_FILE="$VAULT/handoff.json"

package/templates/captain.claude.md

@@ -16,7 +16,7 @@ You are a **project captain** for Squadrant. You lead ONE project. You are a **c
 1. **Fetch and gather facts:** `squadrant handoff facts {project} --fetch` (updates remote refs so branch state is verified, not stale).
 2. **Check branchState flags:** Act on `upstreamStatus` (`behind`, `diverged`, `upstream-gone`) explicitly.
 3. **Identify current state:** List live crews (`squadrant crew list`) and current task.
-4. **Read handoff:** `~/.config/squadrant/scripts/read-handoff.sh {spokeVaultPath}` to load previous session context.
+4. **Read handoff:** `~/.config/squadrant/scripts/read-handoff.sh {project}` to load previous session context.
 5. **Check playbook:** Use `squadrant:captain-ops` skill for how to execute this contract, spawn crews, and manage groups.
 
 ## Core Rules
@@ -40,7 +40,7 @@ You are a **project captain** for Squadrant. You lead ONE project. You are a **c
    ```
    **Operator Takeover:** A crew under operator takeover is off-limits — no `send`, no `close`, and its lifecycle signals are not yours to act on. If you are at your crew limit, **ask the operator**; never pick a held crew to close. `--force` exists only for when the operator explicitly tells you to use it.
 3. **Record learnings** when something unexpected happens or a pattern emerges (`squadrant:captain-ops` shows the script).
-4. **Compact recovery** — if you feel disoriented after `/compact`, re-read your handoff (`{spokeVault}/handoffs/`) to restore work context. Role itself survives compact via `--append-system-prompt-file`.
+4. **Compact recovery** — if you feel disoriented after `/compact`, re-read your handoff (`~/squadrant/workspace/{project}/handoffs/`) to restore work context. Role itself survives compact via `--append-system-prompt-file`.
 
 ## Available Skills
 

package/templates/captain.generic.md

@@ -34,7 +34,7 @@ Use `squadrant crew spawn`. Never spawn workspaces directly with `cmux` or runti
 1. **Fetch and gather facts:** `squadrant handoff facts {project} --fetch` (updates remote refs so branch state is verified, not stale).
 2. **Check branchState flags:** Act on `upstreamStatus` (`behind`, `diverged`, `upstream-gone`) explicitly.
 3. **Identify current state:** List live crews (`squadrant crew list`) and current task.
-4. **Read handoff:** `~/.config/squadrant/scripts/read-handoff.sh {spokeVaultPath}` to load previous session context.
+4. **Read handoff:** `~/.config/squadrant/scripts/read-handoff.sh {project}` to load previous session context.
 
 ## Session Lifecycle
 

package/templates/side.debug.claude.md

@@ -52,7 +52,7 @@ When you have a root cause (with or without a draft patch):
 
    a. Write the durable vault record (replace placeholders with actual values from the "Side-session context" block in your first turn):
    ```bash
-   ~/.config/squadrant/scripts/record-side-handoff.sh "<spoke-vault>" "<topic>" "debug" "<one-line root cause>"
+   ~/.config/squadrant/scripts/record-side-handoff.sh "<workspace>" "<topic>" "debug" "<one-line root cause>"
    ```
 
    b. Send the structured handoff to the primary captain via relay:
@@ -68,7 +68,7 @@ HANDOFF
 
 3. **On no:** keep working; you can trigger the handoff whenever you're ready.
 
-The `<project>`, `<spoke-vault>`, and `<name>` (your scratch branch) are in the "Side-session context" block of your first turn. The draft patch (if any) lives on the scratch branch — reference it by name; do NOT merge it.
+The `<project>`, `<workspace>`, and `<name>` (your scratch branch) are in the "Side-session context" block of your first turn. The draft patch (if any) lives on the scratch branch — reference it by name; do NOT merge it.
 
 ## Karpathy Discipline
 

package/templates/side.research.claude.md

@@ -37,7 +37,7 @@ When you have produced a result that deserves the primary captain's attention:
 
    a. Write the durable vault record (replace placeholders with actual values from the "Side-session context" block in your first turn):
    ```bash
-   ~/.config/squadrant/scripts/record-side-handoff.sh "<spoke-vault>" "<topic>" "research" "<one-line summary>"
+   ~/.config/squadrant/scripts/record-side-handoff.sh "<workspace>" "<topic>" "research" "<one-line summary>"
    ```
 
    b. Send the structured handoff to the primary captain via relay:
@@ -53,7 +53,7 @@ HANDOFF
 
 3. **On no:** keep working; you can trigger the handoff whenever you're ready.
 
-The `<project>` and `<spoke-vault>` values are in the "Side-session context" block of your first turn.
+The `<project>` and `<workspace>` values are in the "Side-session context" block of your first turn.
 
 ## Karpathy Discipline
 

package/obsidian/spoke/meta/vault-changelog.md

@@ -1,6 +0,0 @@
-# Spoke Vault Changelog
-
-Track structural changes to this vault.
-
-## Log
-- Initial creation

package/obsidian/spoke/status.md

@@ -1,19 +0,0 @@
----
-project: unnamed
-captain_session: inactive
-last_updated:
-active_crew: 0
-tasks_total: 0
-tasks_completed: 0
-tasks_in_progress: 0
-tasks_pending: 0
----
-
-# Captain Status
-
-## Active Crew
-
-| Crew | Task | Branch | Status |
-|------|------|--------|--------|
-
-## Recent Activity

package/obsidian/spoke/templates/crew-session.md

@@ -1,21 +0,0 @@
----
-crew: {{crew_name}}
-task: {{task}}
-branch: {{branch}}
-worktree: .worktrees/{{task}}
-started: {{date}}
-status: in-progress
----
-
-# {{crew_name}} — Session Log
-
-## Task
-{{task}}
-
-## Branch
-{{branch}}
-
-## Progress
--
-
-## Notes

package/obsidian/spoke/templates/daily-log.md

@@ -1,16 +0,0 @@
----
-date: {{date}}
-project: {{project}}
----
-
-# {{date}} — Daily Log
-
-## Summary
-
-## Tasks Completed
-
-## Tasks In Progress
-
-## Blockers
-
-## Learnings

package/obsidian/spoke/wiki/index.md

@@ -1,14 +0,0 @@
----
-type: wiki-index
-project: unnamed
-last_updated:
-page_count: 0
----
-
-# Wiki Index
-
-> Auto-maintained by wiki-ingest. Do not edit manually.
-
-## By Category
-
-<!-- Categories will be added automatically as pages are ingested -->

package/obsidian/spoke/wiki/log.md

@@ -1,10 +0,0 @@
----
-type: wiki-log
-project: unnamed
----
-
-# Wiki Changelog
-
-> Append-only record of wiki changes. Newest entries at top.
-
-<!-- Entries will be appended by wiki-ingest -->