squadrant 0.16.5 → 0.16.6

package/dist/index.js

@@ -1323,6 +1323,11 @@ function nextPendingTool(current, ev, now) {
     return void 0;
   return current;
 }
+function nextPendingMonitor(current, ev, now) {
+  if (ev.note === "agent.hook.PreToolUse" && ev.tool === "Monitor")
+    return { since: now };
+  return current;
+}
 function reduce(rec, ev, now) {
   if (ev.type === "task.reopened") {
     return { ...rec, state: "working", question: void 0, error: void 0, lastHeartbeat: now, lastEvent: ev.type };
@@ -1339,14 +1344,17 @@ function reduce(rec, ev, now) {
         sessionId: ev.sessionId ?? rec.sessionId,
         question: void 0,
         // resuming after a blocked→reply clears the question
-        pendingTool: void 0
+        pendingTool: void 0,
         // #354: a new turn closes any prior tool window
+        pendingMonitor: void 0
+        // #594a: same reset — a new turn moots any prior watch
       };
     case "task.progress": {
       const pendingTool = nextPendingTool(rec.pendingTool, ev, now);
+      const pendingMonitor = nextPendingMonitor(rec.pendingMonitor, ev, now);
       if (isStickyAttention(rec.state))
-        return { ...rec, lastHeartbeat: now, lastEvent: ev.type, pendingTool };
-      const b = { ...base, pendingTool };
+        return { ...rec, lastHeartbeat: now, lastEvent: ev.type, pendingTool, pendingMonitor };
+      const b = { ...base, pendingTool, pendingMonitor };
       if (rec.state === "awaiting-input" || rec.state === "stalled")
         return { ...stampAttempt(b, {}, now), state: "working" };
       return stampAttempt(b, {}, now);
@@ -1360,9 +1368,9 @@ function reduce(rec, ev, now) {
     case "task.blocked":
       if (rec.state === "blocked")
         return { ...rec, lastHeartbeat: now, lastEvent: ev.type };
-      return { ...base, state: "blocked", question: ev.question, pendingTool: void 0 };
+      return { ...base, state: "blocked", question: ev.question, pendingTool: void 0, pendingMonitor: void 0 };
     case "task.review":
-      return { ...base, state: "review", reviewNote: ev.message, pendingTool: void 0 };
+      return { ...base, state: "review", reviewNote: ev.message, pendingTool: void 0, pendingMonitor: void 0 };
     case "task.done":
       if (rec.state === "review" && ev.source !== "approve") {
         return { ...rec, lastHeartbeat: now, lastEvent: ev.type };
@@ -1377,19 +1385,19 @@ function reduce(rec, ev, now) {
     case "task.session":
       return stampAttempt(base, { resumeRef: ev.resumeRef }, now);
     case "task.turn.started":
-      return { ...stampAttempt(base, {}, now), state: "working", pendingTool: void 0 };
+      return { ...stampAttempt(base, {}, now), state: "working", pendingTool: void 0, pendingMonitor: void 0 };
     case "task.turn.completed":
       if (isStickyAttention(rec.state))
         return { ...rec, lastHeartbeat: now, lastEvent: ev.type };
-      if (rec.pendingTool)
+      if (rec.pendingTool || rec.pendingMonitor)
         return stampAttempt(base, {}, now);
-      return { ...stampAttempt(base, {}, now), state: "awaiting-input", pendingTool: void 0 };
+      return { ...stampAttempt(base, {}, now), state: "awaiting-input", pendingTool: void 0, pendingMonitor: void 0 };
     case "task.delta":
       return stampAttempt(base, {}, now);
     // heartbeat-only
     case "task.input.requested":
     case "task.approval.requested":
-      return { ...stampAttempt(base, {}, now), state: "blocked", question: ev.question, pendingTool: void 0 };
+      return { ...stampAttempt(base, {}, now), state: "blocked", question: ev.question, pendingTool: void 0, pendingMonitor: void 0 };
     case "task.reattached":
       return stampAttempt(base, {}, now);
     case "task.first-turn.confirmed":
@@ -1414,15 +1422,21 @@ var init_state_machine = __esm({
 });
 
 // packages/core/dist/watchdog.js
-function evaluateStall(rec, now, toolStallMs = TOOL_STALL_BUDGET_MS) {
+function evaluateStall(rec, now, toolStallMs = TOOL_STALL_BUDGET_MS, monitorStallMs = MONITOR_STALL_BUDGET_MS) {
   if (rec.state !== "working")
     return null;
   if (rec.mode === "interactive") {
-    if (!rec.pendingTool)
-      return null;
-    if (now - rec.pendingTool.since <= toolStallMs)
-      return null;
-    return { ...rec, state: "stalled", lastEvent: "watchdog.tool-stall" };
+    if (rec.pendingTool) {
+      if (now - rec.pendingTool.since <= toolStallMs)
+        return null;
+      return { ...rec, state: "stalled", lastEvent: "watchdog.tool-stall" };
+    }
+    if (rec.pendingMonitor) {
+      if (now - rec.pendingMonitor.since <= monitorStallMs)
+        return null;
+      return { ...rec, state: "stalled", lastEvent: "watchdog.monitor-stall" };
+    }
+    return null;
   }
   const liveness = rec.attempts.at(-1)?.lastHeartbeatAt ?? rec.lastHeartbeat;
   if (now - liveness <= rec.heartbeatBudgetMs)
@@ -1432,12 +1446,13 @@ function evaluateStall(rec, now, toolStallMs = TOOL_STALL_BUDGET_MS) {
 function recoverStall(rec, now) {
   if (rec.state !== "stalled")
     return null;
-  return { ...rec, state: "working", lastHeartbeat: now, lastEvent: "watchdog.recover", pendingTool: void 0 };
+  return { ...rec, state: "working", lastHeartbeat: now, lastEvent: "watchdog.recover", pendingTool: void 0, pendingMonitor: void 0 };
 }
-var TOOL_STALL_BUDGET_MS;
+var TOOL_STALL_BUDGET_MS, MONITOR_STALL_BUDGET_MS;
 var init_watchdog = __esm({
   "packages/core/dist/watchdog.js"() {
     TOOL_STALL_BUDGET_MS = 10 * 60 * 1e3;
+    MONITOR_STALL_BUDGET_MS = 60 * 60 * 1e3;
   }
 });
 
@@ -1711,7 +1726,7 @@ function createDaemon(deps) {
           store.delete(r.project, r.id);
           continue;
         }
-        if (!TERMINAL_STATES.has(r.state)) {
+        if (!TERMINAL_STATES.has(r.state) && !isStickyAttention(r.state)) {
           const ceiling = deps.taskTimeoutMs ?? DEFAULT_TASK_TIMEOUT_MS;
           if (t - r.createdAt > ceiling) {
             const prevState = r.state;
@@ -1756,7 +1771,7 @@ function createDaemon(deps) {
         const idle = evaluateStall(r, t);
         if (idle) {
           store.put(idle);
-          const synthEvent = idle.pendingTool ? { type: "task.stalled", id: r.id, heartbeatBudgetMs: r.heartbeatBudgetMs, tool: idle.pendingTool.name, elapsedMs: t - idle.pendingTool.since } : { type: "task.stalled", id: r.id, heartbeatBudgetMs: r.heartbeatBudgetMs };
+          const synthEvent = idle.pendingTool ? { type: "task.stalled", id: r.id, heartbeatBudgetMs: r.heartbeatBudgetMs, tool: idle.pendingTool.name, elapsedMs: t - idle.pendingTool.since } : idle.pendingMonitor ? { type: "task.stalled", id: r.id, heartbeatBudgetMs: r.heartbeatBudgetMs, tool: "Monitor", elapsedMs: t - idle.pendingMonitor.since } : { type: "task.stalled", id: r.id, heartbeatBudgetMs: r.heartbeatBudgetMs };
           firePush(deps, r.project, r.state, idle, synthEvent, lastCaptainTurnAt.get(r.id));
           continue;
         }
@@ -3319,9 +3334,11 @@ var init_defer_delivery = __esm({
   "packages/core/dist/delivery/defer-delivery.js"() {
     DeferDelivery = class extends Error {
       draft;
-      constructor(draft = null) {
+      reason;
+      constructor(draft = null, reason = "draft") {
         super("deferred: captain composing");
         this.draft = draft;
+        this.reason = reason;
         this.name = "DeferDelivery";
       }
     };
@@ -3345,6 +3362,7 @@ var init_captain_delivery = __esm({
       deferCounts = /* @__PURE__ */ new Map();
       lastContent = /* @__PURE__ */ new Map();
       stableCounts = /* @__PURE__ */ new Map();
+      lastReason = /* @__PURE__ */ new Map();
       constructor(opts) {
         this.opts = opts;
       }
@@ -3367,29 +3385,40 @@ var init_captain_delivery = __esm({
           this.deferCounts.delete(seq);
           this.stableCounts.delete(seq);
           this.lastContent.delete(seq);
+          this.lastReason.delete(seq);
           return { delivered: true };
         } catch (e) {
           if (e instanceof DeferDelivery) {
             this.deferCounts.set(seq, deferCount + 1);
             const content = e.draft;
+            let stableCount;
             if (content && content === this.lastContent.get(seq)) {
-              this.stableCounts.set(seq, (this.stableCounts.get(seq) ?? 0) + 1);
+              stableCount = (this.stableCounts.get(seq) ?? 0) + 1;
+              this.stableCounts.set(seq, stableCount);
             } else {
+              stableCount = 0;
               this.stableCounts.set(seq, 0);
             }
             this.lastContent.set(seq, content);
-            return { deferred: true };
+            const reason = e.reason !== "draft" ? e.reason : stableCount >= this.opts.stableProbePolls ? "stable" : "draft";
+            this.lastReason.set(seq, reason);
+            return { deferred: true, reason };
           }
-          return { deferred: true };
+          this.lastReason.set(seq, "unknown");
+          return { deferred: true, reason: "unknown" };
         }
       }
       /** Read-only. Never mutates — safe to poll from the snapshot assembler every tick. */
       stats() {
         let maxDeferCount = 0;
-        for (const c of this.deferCounts.values())
-          if (c > maxDeferCount)
+        let reason;
+        for (const [seq, c] of this.deferCounts) {
+          if (c > maxDeferCount) {
             maxDeferCount = c;
-        return { maxDeferCount, stuck: maxDeferCount >= this.opts.maxDefers };
+            reason = this.lastReason.get(seq);
+          }
+        }
+        return { maxDeferCount, stuck: maxDeferCount >= this.opts.maxDefers, reason };
       }
     };
   }
@@ -3489,6 +3518,10 @@ function createDelivery(ctx, daemonCmux) {
   const notifyFault = ctx.notifyFault ?? (() => {
   });
   const defaultNotify = async (args) => {
+    const fresh = store.get(args.project, args.record.id);
+    if (fresh && TERMINAL_STATES.has(fresh.state) && fresh.state !== args.record.state) {
+      return;
+    }
     try {
       await appendToMailbox({
         stateRoot,
@@ -3578,16 +3611,19 @@ function createDelivery(ctx, daemonCmux) {
           log(`delivery seq=${entry.seq} kind=${entry.kind} outcome=delivered`);
           await writeCursor({ stateRoot, project, subscriber: CURSOR_SUBSCRIBER, lastAckedSeq: entry.seq });
         } else {
-          log(`delivery seq=${entry.seq} kind=${entry.kind} outcome=deferred`);
+          const { maxDeferCount } = d.stats();
+          if (maxDeferCount === 1 || maxDeferCount % 30 === 0) {
+            log(`delivery seq=${entry.seq} kind=${entry.kind} outcome=deferred project=${project} reason=${result.reason}`);
+          }
           break;
         }
       }
       const stuck = d.stats().stuck;
       if (stuck && !stuckNotified.has(project)) {
         stuckNotified.add(project);
-        const { maxDeferCount } = d.stats();
-        log(`delivery stuck project=${project} deferCount=${maxDeferCount}`);
-        const text = `\u26A0\uFE0F DELIVERY STUCK: an in-progress draft (or ghost text) in your input box has blocked pending notification(s) for ${maxDeferCount}+ retries. Your input is never touched \u2014 this keeps retrying safely and will deliver automatically once you submit or clear it.`;
+        const { maxDeferCount, reason } = d.stats();
+        log(`delivery stuck project=${project} deferCount=${maxDeferCount} reason=${reason ?? "unknown"}`);
+        const text = reason === "modal" ? `\u26A0\uFE0F DELIVERY STUCK: a modal question is open in your captain pane and has blocked pending notification(s) for ${maxDeferCount}+ retries. This keeps retrying safely and will deliver automatically once you answer or dismiss it.` : `\u26A0\uFE0F DELIVERY STUCK: an in-progress draft (or ghost text) in your input box has blocked pending notification(s) for ${maxDeferCount}+ retries. Your input is never touched \u2014 this keeps retrying safely and will deliver automatically once you submit or clear it.`;
         appendCaptainMessage({ stateRoot, project, text, source: "daemon" }).catch((e) => log(`delivery stuck alert failed project=${project}: ${e.message}`));
         Promise.resolve(notifyFault(project, text)).catch((e) => log(`delivery stuck fault-notify failed project=${project}: ${e.message}`));
         telegramBridge?.pushRaw(project, text);
@@ -6079,6 +6115,7 @@ __export(dist_exports2, {
   GROUP_DISPATCH_WARMUP_TIMEOUT_MS: () => GROUP_DISPATCH_WARMUP_TIMEOUT_MS,
   IDLE_DEBOUNCE_MS: () => IDLE_DEBOUNCE_MS,
   LABEL: () => LABEL,
+  MONITOR_STALL_BUDGET_MS: () => MONITOR_STALL_BUDGET_MS,
   PROBE_QUIET_MS: () => PROBE_QUIET_MS,
   PROTOCOL_VERSION: () => PROTOCOL_VERSION,
   STALE_THRESHOLD_MS: () => STALE_THRESHOLD_MS,
@@ -6148,6 +6185,7 @@ __export(dist_exports2, {
   isDaemonSocketLive: () => isDaemonSocketLive,
   isNotifyActive: () => isNotifyActive,
   isSideTitle: () => isSideTitle,
+  isStickyAttention: () => isStickyAttention,
   isTurnAccepted: () => isTurnAccepted,
   kickstartArgv: () => kickstartArgv,
   launchOneWorkspace: () => launchOneWorkspace,
@@ -6666,9 +6704,9 @@ function createCmuxDriver() {
       }
       const draft = parseDraftFromScreen(screen);
       if (draft === null)
-        throw new DeferDelivery(null);
+        throw new DeferDelivery(null, "no-box");
       if (hasModalOptionList(screen))
-        throw new DeferDelivery(null);
+        throw new DeferDelivery(null, "modal");
       if (draft === "") {
         await deliver();
         return;
@@ -7493,6 +7531,7 @@ function installClaudeHooks(opts = {}) {
   });
   let settings = {};
   const raw = readFile6(settingsPath);
+  const hadExistingSettings = raw !== void 0;
   if (raw) {
     try {
       settings = JSON.parse(raw);
@@ -7505,6 +7544,7 @@ function installClaudeHooks(opts = {}) {
   }
   const hooks = settings.hooks;
   let changed = false;
+  const repaired = [];
   for (const [eventName, sub, matcher] of CLAUDE_HOOK_EVENTS) {
     if (!Array.isArray(hooks[eventName])) {
       hooks[eventName] = [];
@@ -7516,6 +7556,26 @@ function installClaudeHooks(opts = {}) {
     if (!alreadyPresent) {
       entries.push({ matcher: hookMatcher, hooks: [{ type: "command", command, timeout: 10 }] });
       changed = true;
+      repaired.push(`${eventName}/${sub}`);
+    }
+  }
+  if (repaired.length > 0 && hadExistingSettings) {
+    log(`native-hook: repaired ${repaired.length} missing squadrant hook(s) in ${settingsPath} [${repaired.join(", ")}] \u2014 WARNING: blocked-signalling or lifecycle tracking may have been broken until this run`);
+  }
+  if (opts.claudeEnv && Object.keys(opts.claudeEnv).length > 0) {
+    if (typeof settings.env !== "object" || settings.env === null || Array.isArray(settings.env)) {
+      settings.env = {};
+    }
+    const env = settings.env;
+    for (const [key, value] of Object.entries(opts.claudeEnv)) {
+      if (key in env) {
+        if (env[key] !== value) {
+          log(`native-hook: claudeEnv key '${key}' already set to '${String(env[key])}' in ${settingsPath} \u2014 not overwriting with '${value}'`);
+        }
+        continue;
+      }
+      env[key] = value;
+      changed = true;
     }
   }
   if (changed) {
@@ -7590,9 +7650,9 @@ var init_native_hook_source = __esm({
       cache = /* @__PURE__ */ new Map();
       active = false;
       constructor(opts = {}) {
-        this.hookInstall = opts.hookInstall ?? {};
         this.log = opts.log ?? (() => {
         });
+        this.hookInstall = { log: this.log, ...opts.hookInstall };
       }
       start(deps) {
         this.deps = deps;
@@ -11484,6 +11544,16 @@ function defaultCreatePr(cwd, o) {
     { cwd, encoding: "utf-8" }
   ).trim();
 }
+function defaultGetCommitSubject(cwd) {
+  try {
+    return execFileSync6("git", ["-C", cwd, "log", "-1", "--format=%s"], {
+      encoding: "utf-8",
+      stdio: ["ignore", "pipe", "pipe"]
+    }).trim();
+  } catch {
+    return "";
+  }
+}
 async function runCrewApprove(project, crew, deps) {
   const config = loadConfig();
   const proj = config.projects[project];
@@ -11499,8 +11569,12 @@ async function runCrewApprove(project, crew, deps) {
   const cwd = task.cwd ?? proj.path;
   const base = resolveWorktreeBase(proj.path);
   const branch = crewBranch(crew);
-  const title = (task.task ?? branch).split(/\r?\n/)[0].trim().slice(0, 100);
   const body = (task.reviewNote ?? task.task ?? "").trim();
+  const getCommitSubject = deps.getCommitSubject ?? defaultGetCommitSubject;
+  const commitSubject = getCommitSubject(cwd).trim();
+  const reviewNoteFirstLine = (task.reviewNote ?? "").split(/\r?\n/)[0].trim();
+  const taskFirstLine = (task.task ?? branch).split(/\r?\n/)[0].trim();
+  const title = (commitSubject || reviewNoteFirstLine || taskFirstLine).slice(0, 100);
   const pushBranch = deps.pushBranch ?? defaultPushBranch;
   const createPr = deps.createPr ?? defaultCreatePr;
   pushBranch(cwd, branch);