sqlite-hub 0.9.13 → 0.11.1

package/tests/sql-identifier-safety.test.js

@@ -8,6 +8,7 @@ test("data browser mutations preserve quoted dynamic identifiers", () => {
   const db = new Database(":memory:");
   const tableName = 'items" archived';
   const valueColumn = 'display"name';
+  const noteColumn = 'review"note';
 
   try {
     db.exec(
@@ -16,7 +17,9 @@ test("data browser mutations preserve quoted dynamic identifiers", () => {
         quoteIdentifier(tableName),
         "(",
         quoteIdentifier(valueColumn),
-        "TEXT, status INTEGER",
+        "TEXT, status INTEGER,",
+        quoteIdentifier(noteColumn),
+        "TEXT",
         ")",
       ].join(" ")
     );
@@ -24,10 +27,10 @@ test("data browser mutations preserve quoted dynamic identifiers", () => {
       [
         "INSERT INTO",
         quoteIdentifier(tableName),
-        "(" + quoteIdentifier(valueColumn) + ", status)",
-        "VALUES (?, ?)",
+        "(" + quoteIdentifier(valueColumn) + ", status, " + quoteIdentifier(noteColumn) + ")",
+        "VALUES (?, ?, ?)",
       ].join(" ")
-    ).run("before", 0);
+    ).run("before", 0, null);
 
     const service = new DataBrowserService({
       connectionManager: {
@@ -36,20 +39,116 @@ test("data browser mutations preserve quoted dynamic identifiers", () => {
       },
     });
     const tableData = service.getTableData(tableName, { limit: 10, offset: 0 });
+    const filteredTableData = service.getTableData(tableName, {
+      limit: 10,
+      offset: 0,
+      filterColumn: valueColumn,
+      filterOperator: "=",
+      filterValue: "EFO",
+    });
+    const negativeFilteredTableData = service.getTableData(tableName, {
+      limit: 10,
+      offset: 0,
+      filterColumn: valueColumn,
+      filterOperator: "!=",
+      filterValue: "EFO",
+    });
+    const exactFilteredTableData = service.getTableData(tableName, {
+      limit: 10,
+      offset: 0,
+      filterColumn: valueColumn,
+      filterOperator: "equals",
+      filterValue: "BEFORE",
+    });
+    const exactSubstringMissTableData = service.getTableData(tableName, {
+      limit: 10,
+      offset: 0,
+      filterColumn: valueColumn,
+      filterOperator: "equals",
+      filterValue: "EFO",
+    });
+
+    assert.equal(filteredTableData.rowCount, 1);
+    assert.equal(filteredTableData.rows[0][valueColumn], "before");
+    assert.deepEqual(filteredTableData.filter, {
+      column: valueColumn,
+      operator: "=",
+      value: "EFO",
+      matchMode: "contains",
+    });
+    assert.equal(negativeFilteredTableData.rowCount, 0);
+    assert.equal(exactFilteredTableData.rowCount, 1);
+    assert.equal(exactFilteredTableData.rows[0][valueColumn], "before");
+    assert.deepEqual(exactFilteredTableData.filter, {
+      column: valueColumn,
+      operator: "equals",
+      value: "BEFORE",
+      matchMode: "equals",
+    });
+    assert.equal(exactSubstringMissTableData.rowCount, 0);
+    assert.throws(
+      () =>
+        service.getTableData(tableName, {
+          limit: 10,
+          offset: 0,
+          filterColumn: valueColumn,
+          filterOperator: "<>",
+          filterValue: "before",
+        }),
+      /filterOperator/
+    );
+
     const identity = tableData.rows[0].__identity;
+    const preview = service.previewTableRowUpdate(tableName, {
+      identity,
+      values: {
+        [valueColumn]: "after",
+        status: 0,
+        [noteColumn]: "",
+      },
+    });
+
+    assert.equal(
+      preview.sql,
+      [
+        "UPDATE",
+        quoteIdentifier(tableName),
+        "SET",
+        quoteIdentifier(valueColumn) + " = ?",
+        "WHERE",
+        "rowid IS ?",
+      ].join(" ")
+    );
+    assert.deepEqual(preview.changes, [
+      {
+        column: valueColumn,
+        oldValue: "before",
+        newValue: "after",
+      },
+    ]);
 
     const updated = service.updateTableRow(tableName, {
       identity,
       values: {
         [valueColumn]: "after",
+        [noteColumn]: "",
       },
     });
 
     assert.equal(updated.row[valueColumn], "after");
-    assert.equal(
-      db.prepare(["SELECT", quoteIdentifier(valueColumn), "FROM", quoteIdentifier(tableName)].join(" ")).get()[valueColumn],
-      "after"
-    );
+    assert.equal(updated.row[noteColumn], null);
+    const persistedRow = db.prepare(
+      [
+        "SELECT",
+        quoteIdentifier(valueColumn) + ",",
+        quoteIdentifier(noteColumn),
+        "FROM",
+        quoteIdentifier(tableName),
+      ].join(" ")
+    ).get();
+
+    assert.equal(persistedRow[valueColumn], "after");
+    assert.equal(persistedRow[noteColumn], null);
 
     const deleted = service.deleteTableRow(tableName, {
       identity: updated.row.__identity,