sqlew 5.0.8 → 5.1.0

package/dist/tests/docker/native/db-init.js

@@ -1,13 +1,8 @@
 /**
  * Native RDBMS Database Initialization
  *
- * Handles fresh database setup via Knex migrations for
- * MySQL, MariaDB, and PostgreSQL integration tests.
- *
- * Key Features:
- * - Initialize fresh database with all migrations
- * - Verify migration success
- * - Clean teardown with proper disconnect
+ * Fresh database setup and teardown via Knex migrations
+ * for MySQL, MariaDB, and PostgreSQL integration tests.
  */
 import knex from 'knex';
 import assert from 'node:assert';
@@ -17,9 +12,6 @@ import { dirname } from 'path';
 import { getTestConfig } from '../../database/testing-config.js';
 const __filename = fileURLToPath(import.meta.url);
 const __dirname = dirname(__filename);
-// ============================================================================
-// Migration Directory Configuration
-// ============================================================================
 /**
  * Get migration directory paths
  *
@@ -35,22 +27,9 @@ function getMigrationDirs() {
         join(projectRoot, 'dist/database/migrations/v4'),
     ];
 }
-// ============================================================================
-// Database Initialization
-// ============================================================================
 /**
  * Initialize fresh database with all Knex migrations
  *
- * This creates a clean database state by:
- * 1. Connecting to the database
- * 2. Running all migrations (bootstrap + upgrades + enhancements)
- * 3. Verifying migration success
- *
- * @param dbType - Database type (mysql, mariadb, postgresql)
- * @returns Knex instance connected to fresh database
- *
- * @throws Error if connection fails or migrations fail
- *
  * @example
  * ```typescript
  * const db = await initDatabase('postgresql');
@@ -59,9 +38,7 @@ function getMigrationDirs() {
  * ```
  */
 export async function initDatabase(dbType) {
-    // Get base configuration from centralized testing config
     const config = getTestConfig(dbType);
-    // Add migration configuration
     const migrationDirs = getMigrationDirs();
     const fullConfig = {
         ...config,
@@ -72,12 +49,9 @@ export async function initDatabase(dbType) {
             loadExtensions: ['.js'],
         },
     };
-    // Create connection
     const db = knex(fullConfig);
     try {
-        // Verify connection
         await db.raw('SELECT 1');
-        // Run all migrations
         const [batchNo, migrations] = await db.migrate.latest();
         if (migrations.length === 0) {
             console.log(`    ℹ️  Database already migrated (batch ${batchNo})`);
@@ -85,65 +59,39 @@ export async function initDatabase(dbType) {
         else {
             console.log(`    ✅ Ran ${migrations.length} migrations (batch ${batchNo})`);
         }
-        // Verify migrations completed
         await verifyMigrations(db);
         return db;
     }
     catch (error) {
-        // Cleanup on failure
         await db.destroy().catch(() => { });
         throw new Error(`Failed to initialize ${dbType} database: ${error.message}`);
     }
 }
 /**
  * Verify that migrations completed successfully
- *
- * Checks:
- * - knex_migrations table exists
- * - At least one migration ran
- * - Key tables exist (t_decisions, t_constraints)
- *
- * Note: v4_tasks removed in v5.0 (deprecated)
- *
- * @param db - Knex database connection
- * @throws Error if verification fails
  */
 export async function verifyMigrations(db) {
-    // Check migration table exists
     const hasMigrationTable = await db.schema.hasTable('knex_migrations');
     assert.ok(hasMigrationTable, 'knex_migrations table should exist');
-    // Check migrations ran
     const migrations = await db('knex_migrations').select('name');
     assert.ok(migrations.length > 0, 'At least one migration should have run');
-    // Check key tables exist (task tables removed in v5.0)
+    // Note: v4_tasks removed in v5.0 (deprecated)
     const keyTables = ['m_context_keys', 't_decisions', 't_constraints'];
     for (const table of keyTables) {
         const exists = await db.schema.hasTable(table);
         assert.ok(exists, `Table ${table} should exist after migrations`);
     }
 }
-// ============================================================================
-// Database Teardown
-// ============================================================================
 /**
  * Clean up database and disconnect
  *
- * Performs proper cleanup:
- * 1. Drop all tables (including knex_migrations)
- * 2. Disconnect from database
- *
- * Note: This is safe because tests use Docker containers with isolated databases.
- *
- * @param db - Knex database connection
+ * Safe because tests use Docker containers with isolated databases.
  */
 export async function teardownDatabase(db) {
     try {
-        // Get database type from client config
         const client = db.client.config.client;
         const dbType = getDbTypeFromClient(client);
-        // Drop all tables (including knex_migrations)
         await dropAllTables(db, dbType);
-        // Disconnect
         await db.destroy();
     }
     catch (error) {
@@ -151,23 +99,15 @@ export async function teardownDatabase(db) {
         await db.destroy().catch(() => { });
     }
 }
-/**
- * Drop all tables from database
- *
- * Database-specific DROP TABLE implementations to handle different SQL dialects.
- *
- * @param db - Knex database connection
- * @param dbType - Database type
- */
+/** Drop all tables using database-specific SQL dialects */
 async function dropAllTables(db, dbType) {
     if (dbType === 'mysql' || dbType === 'mariadb') {
-        // MySQL/MariaDB: Disable FK checks, drop all tables
         await db.raw('SET FOREIGN_KEY_CHECKS=0');
-        const tables = await db.raw(`
-      SELECT TABLE_NAME
-      FROM INFORMATION_SCHEMA.TABLES
-      WHERE TABLE_SCHEMA = DATABASE()
-        AND TABLE_TYPE = 'BASE TABLE'
+        const tables = await db.raw(`
+      SELECT TABLE_NAME
+      FROM INFORMATION_SCHEMA.TABLES
+      WHERE TABLE_SCHEMA = DATABASE()
+        AND TABLE_TYPE = 'BASE TABLE'
     `);
         for (const row of tables[0]) {
             await db.raw(`DROP TABLE IF EXISTS \`${row.TABLE_NAME}\``);
@@ -175,11 +115,10 @@ async function dropAllTables(db, dbType) {
         await db.raw('SET FOREIGN_KEY_CHECKS=1');
     }
     else if (dbType === 'postgresql') {
-        // PostgreSQL: Drop all tables with CASCADE
-        const tables = await db.raw(`
-      SELECT tablename
-      FROM pg_tables
-      WHERE schemaname = 'public'
+        const tables = await db.raw(`
+      SELECT tablename
+      FROM pg_tables
+      WHERE schemaname = 'public'
     `);
         for (const row of tables.rows) {
             await db.raw(`DROP TABLE IF EXISTS "${row.tablename}" CASCADE`);
@@ -195,8 +134,7 @@ async function dropAllTables(db, dbType) {
 function getDbTypeFromClient(client) {
     switch (client) {
         case 'mysql2':
-            // Cannot distinguish MySQL from MariaDB via client, default to mysql
-            return 'mysql';
+            return 'mysql'; // Cannot distinguish MySQL from MariaDB via client string
         case 'pg':
             return 'postgresql';
         case 'better-sqlite3':

package/dist/tests/docker/native/db-init.js.map

@@ -1 +1 @@
-{"version":3,"file":"db-init.js","sourceRoot":"","sources":["../../../../src/tests/docker/native/db-init.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;GAUG;AAEH,OAAO,IAAc,MAAM,MAAM,CAAC;AAClC,OAAO,MAAM,MAAM,aAAa,CAAC;AACjC,OAAO,EAAE,IAAI,EAAE,MAAM,WAAW,CAAC;AACjC,OAAO,EAAE,aAAa,EAAE,MAAM,KAAK,CAAC;AACpC,OAAO,EAAE,OAAO,EAAE,MAAM,MAAM,CAAC;AAC/B,OAAO,EAAE,aAAa,EAAqB,MAAM,kCAAkC,CAAC;AAEpF,MAAM,UAAU,GAAG,aAAa,CAAC,MAAM,CAAC,IAAI,CAAC,GAAG,CAAC,CAAC;AAClD,MAAM,SAAS,GAAG,OAAO,CAAC,UAAU,CAAC,CAAC;AAEtC,+EAA+E;AAC/E,oCAAoC;AACpC,+EAA+E;AAE/E;;;;;GAKG;AACH,SAAS,gBAAgB;IACvB,8DAA8D;IAC9D,MAAM,WAAW,GAAG,IAAI,CAAC,SAAS,EAAE,aAAa,CAAC,CAAC,CAAC,2CAA2C;IAE/F,yDAAyD;IACzD,8CAA8C;IAC9C,OAAO;QACL,IAAI,CAAC,WAAW,EAAE,6BAA6B,CAAC;KACjD,CAAC;AACJ,CAAC;AAED,+EAA+E;AAC/E,0BAA0B;AAC1B,+EAA+E;AAE/E;;;;;;;;;;;;;;;;;;;GAmBG;AACH,MAAM,CAAC,KAAK,UAAU,YAAY,CAAC,MAAoB;IACrD,yDAAyD;IACzD,MAAM,MAAM,GAAG,aAAa,CAAC,MAAM,CAAC,CAAC;IAErC,8BAA8B;IAC9B,MAAM,aAAa,GAAG,gBAAgB,EAAE,CAAC;IACzC,MAAM,UAAU,GAAgB;QAC9B,GAAG,MAAM;QACT,UAAU,EAAE;YACV,SAAS,EAAE,aAAa;YACxB,SAAS,EAAE,IAAI;YACf,SAAS,EAAE,iBAAiB;YAC5B,cAAc,EAAE,CAAC,KAAK,CAAC;SACxB;KACF,CAAC;IAEF,oBAAoB;IACpB,MAAM,EAAE,GAAG,IAAI,CAAC,UAAU,CAAC,CAAC;IAE5B,IAAI,CAAC;QACH,oBAAoB;QACpB,MAAM,EAAE,CAAC,GAAG,CAAC,UAAU,CAAC,CAAC;QAEzB,qBAAqB;QACrB,MAAM,CAAC,OAAO,EAAE,UAAU,CAAC,GAAG,MAAM,EAAE,CAAC,OAAO,CAAC,MAAM,EAAE,CAAC;QAExD,IAAI,UAAU,CAAC,MAAM,KAAK,CAAC,EAAE,CAAC;YAC5B,OAAO,CAAC,GAAG,CAAC,4CAA4C,OAAO,GAAG,CAAC,CAAC;QACtE,CAAC;aAAM,CAAC;YACN,OAAO,CAAC,GAAG,CAAC,aAAa,UAAU,CAAC,MAAM,sBAAsB,OAAO,GAAG,CAAC,CAAC;QAC9E,CAAC;QAED,8BAA8B;QAC9B,MAAM,gBAAgB,CAAC,EAAE,CAAC,CAAC;QAE3B,OAAO,EAAE,CAAC;IACZ,CAAC;IAAC,OAAO,KAAU,EAAE,CAAC;QACpB,qBAAqB;QACrB,MAAM,EAAE,CAAC,OAAO,EAAE,CAAC,KAAK,CAAC,GAAG,EAAE,GAAE,CAAC,CAAC,CAAC;QACnC,MAAM,IAAI,KAAK,CAAC,wBAAwB,MAAM,cAAc,KAAK,CAAC,OAAO,EAAE,CAAC,CAAC;IAC/E,CAAC;AACH,CAAC;AAED;;;;;;;;;;;;GAYG;AACH,MAAM,CAAC,KAAK,UAAU,gBAAgB,CAAC,EAAQ;IAC7C,+BAA+B;IAC/B,MAAM,iBAAiB,GAAG,MAAM,EAAE,CAAC,MAAM,CAAC,QAAQ,CAAC,iBAAiB,CAAC,CAAC;IACtE,MAAM,CAAC,EAAE,CAAC,iBAAiB,EAAE,oCAAoC,CAAC,CAAC;IAEnE,uBAAuB;IACvB,MAAM,UAAU,GAAG,MAAM,EAAE,CAAC,iBAAiB,CAAC,CAAC,MAAM,CAAC,MAAM,CAAC,CAAC;IAC9D,MAAM,CAAC,EAAE,CAAC,UAAU,CAAC,MAAM,GAAG,CAAC,EAAE,wCAAwC,CAAC,CAAC;IAE3E,uDAAuD;IACvD,MAAM,SAAS,GAAG,CAAC,gBAAgB,EAAE,aAAa,EAAE,eAAe,CAAC,CAAC;IACrE,KAAK,MAAM,KAAK,IAAI,SAAS,EAAE,CAAC;QAC9B,MAAM,MAAM,GAAG,MAAM,EAAE,CAAC,MAAM,CAAC,QAAQ,CAAC,KAAK,CAAC,CAAC;QAC/C,MAAM,CAAC,EAAE,CAAC,MAAM,EAAE,SAAS,KAAK,gCAAgC,CAAC,CAAC;IACpE,CAAC;AACH,CAAC;AAED,+EAA+E;AAC/E,oBAAoB;AACpB,+EAA+E;AAE/E;;;;;;;;;;GAUG;AACH,MAAM,CAAC,KAAK,UAAU,gBAAgB,CAAC,EAAQ;IAC7C,IAAI,CAAC;QACH,uCAAuC;QACvC,MAAM,MAAM,GAAG,EAAE,CAAC,MAAM,CAAC,MAAM,CAAC,MAAM,CAAC;QACvC,MAAM,MAAM,GAAG,mBAAmB,CAAC,MAAM,CAAC,CAAC;QAE3C,8CAA8C;QAC9C,MAAM,aAAa,CAAC,EAAE,EAAE,MAAM,CAAC,CAAC;QAEhC,aAAa;QACb,MAAM,EAAE,CAAC,OAAO,EAAE,CAAC;IACrB,CAAC;IAAC,OAAO,KAAK,EAAE,CAAC;QACf,sCAAsC;QACtC,MAAM,EAAE,CAAC,OAAO,EAAE,CAAC,KAAK,CAAC,GAAG,EAAE,GAAE,CAAC,CAAC,CAAC;IACrC,CAAC;AACH,CAAC;AAED;;;;;;;GAOG;AACH,KAAK,UAAU,aAAa,CAAC,EAAQ,EAAE,MAAoB;IACzD,IAAI,MAAM,KAAK,OAAO,IAAI,MAAM,KAAK,SAAS,EAAE,CAAC;QAC/C,oDAAoD;QACpD,MAAM,EAAE,CAAC,GAAG,CAAC,0BAA0B,CAAC,CAAC;QAEzC,MAAM,MAAM,GAAG,MAAM,EAAE,CAAC,GAAG,CAAC;;;;;KAK3B,CAAC,CAAC;QAEH,KAAK,MAAM,GAAG,IAAI,MAAM,CAAC,CAAC,CAAC,EAAE,CAAC;YAC5B,MAAM,EAAE,CAAC,GAAG,CAAC,0BAA0B,GAAG,CAAC,UAAU,IAAI,CAAC,CAAC;QAC7D,CAAC;QAED,MAAM,EAAE,CAAC,GAAG,CAAC,0BAA0B,CAAC,CAAC;IAC3C,CAAC;SAAM,IAAI,MAAM,KAAK,YAAY,EAAE,CAAC;QACnC,2CAA2C;QAC3C,MAAM,MAAM,GAAG,MAAM,EAAE,CAAC,GAAG,CAAC;;;;KAI3B,CAAC,CAAC;QAEH,KAAK,MAAM,GAAG,IAAI,MAAM,CAAC,IAAI,EAAE,CAAC;YAC9B,MAAM,EAAE,CAAC,GAAG,CAAC,yBAAyB,GAAG,CAAC,SAAS,WAAW,CAAC,CAAC;QAClE,CAAC;IACH,CAAC;AACH,CAAC;AAED;;;;;GAKG;AACH,SAAS,mBAAmB,CAAC,MAAc;IACzC,QAAQ,MAAM,EAAE,CAAC;QACf,KAAK,QAAQ;YACX,qEAAqE;YACrE,OAAO,OAAO,CAAC;QACjB,KAAK,IAAI;YACP,OAAO,YAAY,CAAC;QACtB,KAAK,gBAAgB,CAAC;QACtB,KAAK,SAAS;YACZ,OAAO,QAAQ,CAAC;QAClB;YACE,MAAM,IAAI,KAAK,CAAC,wBAAwB,MAAM,EAAE,CAAC,CAAC;IACtD,CAAC;AACH,CAAC"}
+{"version":3,"file":"db-init.js","sourceRoot":"","sources":["../../../../src/tests/docker/native/db-init.ts"],"names":[],"mappings":"AAAA;;;;;GAKG;AAEH,OAAO,IAAc,MAAM,MAAM,CAAC;AAClC,OAAO,MAAM,MAAM,aAAa,CAAC;AACjC,OAAO,EAAE,IAAI,EAAE,MAAM,WAAW,CAAC;AACjC,OAAO,EAAE,aAAa,EAAE,MAAM,KAAK,CAAC;AACpC,OAAO,EAAE,OAAO,EAAE,MAAM,MAAM,CAAC;AAC/B,OAAO,EAAE,aAAa,EAAqB,MAAM,kCAAkC,CAAC;AAEpF,MAAM,UAAU,GAAG,aAAa,CAAC,MAAM,CAAC,IAAI,CAAC,GAAG,CAAC,CAAC;AAClD,MAAM,SAAS,GAAG,OAAO,CAAC,UAAU,CAAC,CAAC;AAEtC;;;;;GAKG;AACH,SAAS,gBAAgB;IACvB,8DAA8D;IAC9D,MAAM,WAAW,GAAG,IAAI,CAAC,SAAS,EAAE,aAAa,CAAC,CAAC,CAAC,2CAA2C;IAE/F,yDAAyD;IACzD,8CAA8C;IAC9C,OAAO;QACL,IAAI,CAAC,WAAW,EAAE,6BAA6B,CAAC;KACjD,CAAC;AACJ,CAAC;AAED;;;;;;;;;GASG;AACH,MAAM,CAAC,KAAK,UAAU,YAAY,CAAC,MAAoB;IACrD,MAAM,MAAM,GAAG,aAAa,CAAC,MAAM,CAAC,CAAC;IAErC,MAAM,aAAa,GAAG,gBAAgB,EAAE,CAAC;IACzC,MAAM,UAAU,GAAgB;QAC9B,GAAG,MAAM;QACT,UAAU,EAAE;YACV,SAAS,EAAE,aAAa;YACxB,SAAS,EAAE,IAAI;YACf,SAAS,EAAE,iBAAiB;YAC5B,cAAc,EAAE,CAAC,KAAK,CAAC;SACxB;KACF,CAAC;IAEF,MAAM,EAAE,GAAG,IAAI,CAAC,UAAU,CAAC,CAAC;IAE5B,IAAI,CAAC;QACH,MAAM,EAAE,CAAC,GAAG,CAAC,UAAU,CAAC,CAAC;QAEzB,MAAM,CAAC,OAAO,EAAE,UAAU,CAAC,GAAG,MAAM,EAAE,CAAC,OAAO,CAAC,MAAM,EAAE,CAAC;QAExD,IAAI,UAAU,CAAC,MAAM,KAAK,CAAC,EAAE,CAAC;YAC5B,OAAO,CAAC,GAAG,CAAC,4CAA4C,OAAO,GAAG,CAAC,CAAC;QACtE,CAAC;aAAM,CAAC;YACN,OAAO,CAAC,GAAG,CAAC,aAAa,UAAU,CAAC,MAAM,sBAAsB,OAAO,GAAG,CAAC,CAAC;QAC9E,CAAC;QAED,MAAM,gBAAgB,CAAC,EAAE,CAAC,CAAC;QAE3B,OAAO,EAAE,CAAC;IACZ,CAAC;IAAC,OAAO,KAAU,EAAE,CAAC;QACpB,MAAM,EAAE,CAAC,OAAO,EAAE,CAAC,KAAK,CAAC,GAAG,EAAE,GAAE,CAAC,CAAC,CAAC;QACnC,MAAM,IAAI,KAAK,CAAC,wBAAwB,MAAM,cAAc,KAAK,CAAC,OAAO,EAAE,CAAC,CAAC;IAC/E,CAAC;AACH,CAAC;AAED;;GAEG;AACH,MAAM,CAAC,KAAK,UAAU,gBAAgB,CAAC,EAAQ;IAC7C,MAAM,iBAAiB,GAAG,MAAM,EAAE,CAAC,MAAM,CAAC,QAAQ,CAAC,iBAAiB,CAAC,CAAC;IACtE,MAAM,CAAC,EAAE,CAAC,iBAAiB,EAAE,oCAAoC,CAAC,CAAC;IAEnE,MAAM,UAAU,GAAG,MAAM,EAAE,CAAC,iBAAiB,CAAC,CAAC,MAAM,CAAC,MAAM,CAAC,CAAC;IAC9D,MAAM,CAAC,EAAE,CAAC,UAAU,CAAC,MAAM,GAAG,CAAC,EAAE,wCAAwC,CAAC,CAAC;IAE3E,8CAA8C;IAC9C,MAAM,SAAS,GAAG,CAAC,gBAAgB,EAAE,aAAa,EAAE,eAAe,CAAC,CAAC;IACrE,KAAK,MAAM,KAAK,IAAI,SAAS,EAAE,CAAC;QAC9B,MAAM,MAAM,GAAG,MAAM,EAAE,CAAC,MAAM,CAAC,QAAQ,CAAC,KAAK,CAAC,CAAC;QAC/C,MAAM,CAAC,EAAE,CAAC,MAAM,EAAE,SAAS,KAAK,gCAAgC,CAAC,CAAC;IACpE,CAAC;AACH,CAAC;AAED;;;;GAIG;AACH,MAAM,CAAC,KAAK,UAAU,gBAAgB,CAAC,EAAQ;IAC7C,IAAI,CAAC;QACH,MAAM,MAAM,GAAG,EAAE,CAAC,MAAM,CAAC,MAAM,CAAC,MAAM,CAAC;QACvC,MAAM,MAAM,GAAG,mBAAmB,CAAC,MAAM,CAAC,CAAC;QAE3C,MAAM,aAAa,CAAC,EAAE,EAAE,MAAM,CAAC,CAAC;QAEhC,MAAM,EAAE,CAAC,OAAO,EAAE,CAAC;IACrB,CAAC;IAAC,OAAO,KAAK,EAAE,CAAC;QACf,sCAAsC;QACtC,MAAM,EAAE,CAAC,OAAO,EAAE,CAAC,KAAK,CAAC,GAAG,EAAE,GAAE,CAAC,CAAC,CAAC;IACrC,CAAC;AACH,CAAC;AAED,2DAA2D;AAC3D,KAAK,UAAU,aAAa,CAAC,EAAQ,EAAE,MAAoB;IACzD,IAAI,MAAM,KAAK,OAAO,IAAI,MAAM,KAAK,SAAS,EAAE,CAAC;QAC/C,MAAM,EAAE,CAAC,GAAG,CAAC,0BAA0B,CAAC,CAAC;QAEzC,MAAM,MAAM,GAAG,MAAM,EAAE,CAAC,GAAG,CAAC;;;;;KAK3B,CAAC,CAAC;QAEH,KAAK,MAAM,GAAG,IAAI,MAAM,CAAC,CAAC,CAAC,EAAE,CAAC;YAC5B,MAAM,EAAE,CAAC,GAAG,CAAC,0BAA0B,GAAG,CAAC,UAAU,IAAI,CAAC,CAAC;QAC7D,CAAC;QAED,MAAM,EAAE,CAAC,GAAG,CAAC,0BAA0B,CAAC,CAAC;IAC3C,CAAC;SAAM,IAAI,MAAM,KAAK,YAAY,EAAE,CAAC;QACnC,MAAM,MAAM,GAAG,MAAM,EAAE,CAAC,GAAG,CAAC;;;;KAI3B,CAAC,CAAC;QAEH,KAAK,MAAM,GAAG,IAAI,MAAM,CAAC,IAAI,EAAE,CAAC;YAC9B,MAAM,EAAE,CAAC,GAAG,CAAC,yBAAyB,GAAG,CAAC,SAAS,WAAW,CAAC,CAAC;QAClE,CAAC;IACH,CAAC;AACH,CAAC;AAED;;;;;GAKG;AACH,SAAS,mBAAmB,CAAC,MAAc;IACzC,QAAQ,MAAM,EAAE,CAAC;QACf,KAAK,QAAQ;YACX,OAAO,OAAO,CAAC,CAAC,0DAA0D;QAC5E,KAAK,IAAI;YACP,OAAO,YAAY,CAAC;QACtB,KAAK,gBAAgB,CAAC;QACtB,KAAK,SAAS;YACZ,OAAO,QAAQ,CAAC;QAClB;YACE,MAAM,IAAI,KAAK,CAAC,wBAAwB,MAAM,EAAE,CAAC,CAAC;IACtD,CAAC;AACH,CAAC"}

package/dist/tests/docker/native/decision-operations.test.d.ts

@@ -1,16 +1,8 @@
 /**
  * Decision Operations - Native RDBMS Integration Tests
  *
- * Tests decision table schema correctness across MySQL, MariaDB, and PostgreSQL:
- * - Foreign key constraint enforcement
- * - UNIQUE constraint validation
- * - CASCADE delete behavior
- * - View functionality (v_tagged_decisions)
- * - Tag index population (m_tag_index)
- * - Cross-database compatibility
- *
- * Architecture: Direct Knex operations, no MCP tool dependencies
- * Task #530: Refactored from MCP tool calls to database layer testing
+ * Tests decision schema correctness (FK, UNIQUE, CASCADE, tags, cross-DB)
+ * via direct Knex operations on MySQL, MariaDB, and PostgreSQL.
  */
 export {};
 //# sourceMappingURL=decision-operations.test.d.ts.map

package/dist/tests/docker/native/decision-operations.test.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"decision-operations.test.d.ts","sourceRoot":"","sources":["../../../../src/tests/docker/native/decision-operations.test.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;;GAaG"}
+{"version":3,"file":"decision-operations.test.d.ts","sourceRoot":"","sources":["../../../../src/tests/docker/native/decision-operations.test.ts"],"names":[],"mappings":"AAAA;;;;;GAKG"}

package/dist/tests/docker/native/decision-operations.test.js

@@ -1,36 +1,23 @@
 /**
  * Decision Operations - Native RDBMS Integration Tests
  *
- * Tests decision table schema correctness across MySQL, MariaDB, and PostgreSQL:
- * - Foreign key constraint enforcement
- * - UNIQUE constraint validation
- * - CASCADE delete behavior
- * - View functionality (v_tagged_decisions)
- * - Tag index population (m_tag_index)
- * - Cross-database compatibility
- *
- * Architecture: Direct Knex operations, no MCP tool dependencies
- * Task #530: Refactored from MCP tool calls to database layer testing
+ * Tests decision schema correctness (FK, UNIQUE, CASCADE, tags, cross-DB)
+ * via direct Knex operations on MySQL, MariaDB, and PostgreSQL.
  */
 import { describe, it } from 'node:test';
 import assert from 'node:assert';
 import { runTestsOnAllDatabases, assertDecisionExists, assertDecisionHasTags, cleanupTestData, getLayerId, getTagId, getScopeId, } from './test-harness.js';
 runTestsOnAllDatabases('Decision Operations', (getDb, dbType) => {
     let projectId;
-    // Get project ID before running tests
     it('should get project ID', async () => {
         const db = getDb();
         const project = await db('m_projects').first();
         assert.ok(project, 'Project should exist');
         projectId = project.id;
     });
-    // ============================================================================
-    // Foreign Key Constraint Tests
-    // ============================================================================
     describe('Foreign key constraints', () => {
         it('should enforce FK constraint on key_id', async () => {
             const db = getDb();
-            // Try to insert decision with non-existent key_id
             const insertPromise = db('t_decisions').insert({
                 key_id: 999999, // Non-existent
                 project_id: projectId,
@@ -47,12 +34,10 @@ runTestsOnAllDatabases('Decision Operations', (getDb, dbType) => {
         });
         it('should enforce FK constraint on layer_id', async () => {
             const db = getDb();
-            // Setup: Create valid key
             await db('m_context_keys').insert({ key_name: 'fk-test-layer' });
             const keyRecord = await db('m_context_keys')
                 .where({ key_name: 'fk-test-layer' })
                 .first();
-            // Try to insert with invalid layer_id
             const insertPromise = db('t_decisions').insert({
                 key_id: keyRecord.id,
                 project_id: projectId,
@@ -62,17 +47,12 @@ runTestsOnAllDatabases('Decision Operations', (getDb, dbType) => {
                 layer_id: 999999, // Non-existent
             });
             await assert.rejects(insertPromise, /foreign key|FOREIGN KEY|Cannot add or update a child row/i);
-            // Cleanup
             await db('m_context_keys').where({ id: keyRecord.id }).del();
         });
     });
-    // ============================================================================
-    // UNIQUE Constraint Tests
-    // ============================================================================
     describe('UNIQUE constraints', () => {
         it('should enforce PRIMARY KEY uniqueness on key_id', async () => {
             const db = getDb();
-            // Setup: Create key and decision
             await db('m_context_keys').insert({ key_name: 'unique-test-pk' });
             const keyRecord = await db('m_context_keys')
                 .where({ key_name: 'unique-test-pk' })
@@ -86,7 +66,6 @@ runTestsOnAllDatabases('Decision Operations', (getDb, dbType) => {
                 ts: Math.floor(Date.now() / 1000),
                 layer_id: layerId,
             });
-            // Try to insert duplicate (same key_id + project_id)
             const duplicatePromise = db('t_decisions').insert({
                 key_id: keyRecord.id,
                 project_id: projectId,
@@ -96,7 +75,6 @@ runTestsOnAllDatabases('Decision Operations', (getDb, dbType) => {
                 layer_id: layerId,
             });
             await assert.rejects(duplicatePromise, /UNIQUE constraint|Duplicate entry|duplicate key value/i);
-            // Cleanup
             await cleanupTestData(db);
         });
         // NOTE: v4 schema intentionally does NOT have UNIQUE constraint on decision_key_id in t_decision_context
@@ -104,7 +82,6 @@ runTestsOnAllDatabases('Decision Operations', (getDb, dbType) => {
         // evolving rationale over time). Application layer handles context management.
         it('should allow multiple context entries per decision in v4 schema (no UNIQUE on decision_key_id)', async () => {
             const db = getDb();
-            // Setup: Create decision
             await db('m_context_keys').insert({ key_name: 'context-multi-test' });
             const keyRecord = await db('m_context_keys')
                 .where({ key_name: 'context-multi-test' })
@@ -118,32 +95,25 @@ runTestsOnAllDatabases('Decision Operations', (getDb, dbType) => {
                 ts: Math.floor(Date.now() / 1000),
                 layer_id: layerId,
             });
-            // Insert first context
             await db('t_decision_context').insert({
                 decision_key_id: keyRecord.id,
                 project_id: projectId,
                 rationale: 'First rationale',
                 ts: Math.floor(Date.now() / 1000),
             });
-            // Insert second context - should succeed in v4 (no UNIQUE constraint)
             await db('t_decision_context').insert({
                 decision_key_id: keyRecord.id,
                 project_id: projectId,
                 rationale: 'Second rationale',
                 ts: Math.floor(Date.now() / 1000),
             });
-            // Verify both context entries exist
             const contexts = await db('t_decision_context')
                 .where({ decision_key_id: keyRecord.id, project_id: projectId })
                 .select('id', 'rationale');
             assert.strictEqual(contexts.length, 2, 'Should allow multiple context entries per decision in v4');
-            // Cleanup
             await cleanupTestData(db);
         });
     });
-    // ============================================================================
-    // Foreign Key Behavior Tests (v4 Schema Design)
-    // ============================================================================
     // NOTE: v4 schema uses m_context_keys as the central reference point.
     // - t_decisions, t_decision_tags, t_decision_context all reference m_context_keys
     // - ON DELETE CASCADE is only applied to project_id (not key_id/decision_key_id)
@@ -151,7 +121,6 @@ runTestsOnAllDatabases('Decision Operations', (getDb, dbType) => {
     describe('Foreign key behavior (v4 schema)', () => {
         it('should block context_keys deletion when decisions exist (no CASCADE on key_id)', async () => {
             const db = getDb();
-            // Setup: Create key and decision
             await db('m_context_keys').insert({ key_name: 'fk-block-test-key' });
             const keyRecord = await db('m_context_keys')
                 .where({ key_name: 'fk-block-test-key' })
@@ -165,7 +134,6 @@ runTestsOnAllDatabases('Decision Operations', (getDb, dbType) => {
                 ts: Math.floor(Date.now() / 1000),
                 layer_id: layerId,
             });
-            // Try to delete context key - should be blocked by FK constraint
             const deletePromise = db('m_context_keys').where({ id: keyRecord.id }).del();
             await assert.rejects(deletePromise, /foreign key|FOREIGN KEY|Cannot delete or update a parent row|violates foreign key constraint/i, 'Should block deletion when child records exist');
             // Cleanup: Delete in correct order (child first)
@@ -174,7 +142,6 @@ runTestsOnAllDatabases('Decision Operations', (getDb, dbType) => {
         });
         it('should allow decision deletion without affecting decision_tags (different FK reference)', async () => {
             const db = getDb();
-            // Setup: Create decision with tags
             await db('m_context_keys').insert({ key_name: 'fk-tags-test' });
             const keyRecord = await db('m_context_keys')
                 .where({ key_name: 'fk-tags-test' })
@@ -194,7 +161,6 @@ runTestsOnAllDatabases('Decision Operations', (getDb, dbType) => {
                 project_id: projectId,
                 tag_id: tagId,
             });
-            // Verify tags exist
             let tags = await db('t_decision_tags').where({ decision_key_id: keyRecord.id });
             assert.ok(tags.length > 0, 'Tags should exist before deletion');
             // Delete decision - t_decision_tags references m_context_keys, not t_decisions
@@ -209,7 +175,6 @@ runTestsOnAllDatabases('Decision Operations', (getDb, dbType) => {
         });
         it('should allow decision deletion without affecting decision_context (different FK reference)', async () => {
             const db = getDb();
-            // Setup: Create decision with context
             await db('m_context_keys').insert({ key_name: 'fk-context-test' });
             const keyRecord = await db('m_context_keys')
                 .where({ key_name: 'fk-context-test' })
@@ -229,7 +194,6 @@ runTestsOnAllDatabases('Decision Operations', (getDb, dbType) => {
                 rationale: 'Test rationale',
                 ts: Math.floor(Date.now() / 1000),
             });
-            // Verify context exists
             let context = await db('t_decision_context').where({ decision_key_id: keyRecord.id }).first();
             assert.ok(context, 'Context should exist before deletion');
             // Delete decision - t_decision_context references m_context_keys, not t_decisions
@@ -242,19 +206,14 @@ runTestsOnAllDatabases('Decision Operations', (getDb, dbType) => {
             await db('m_context_keys').where({ id: keyRecord.id }).del();
         });
     });
-    // ============================================================================
-    // Decision CRUD Operations (Database Layer)
-    // ============================================================================
     describe('Decision table operations', () => {
         it('should insert decision with all required fields', async () => {
             const db = getDb();
-            // Setup: Insert master data
             await db('m_context_keys').insert({ key_name: 'crud-test-key' });
             const keyRecord = await db('m_context_keys')
                 .where({ key_name: 'crud-test-key' })
                 .first();
             const layerId = await getLayerId(db, 'infrastructure');
-            // Insert decision
             await db('t_decisions').insert({
                 key_id: keyRecord.id,
                 project_id: projectId,
@@ -263,14 +222,11 @@ runTestsOnAllDatabases('Decision Operations', (getDb, dbType) => {
                 ts: Math.floor(Date.now() / 1000),
                 layer_id: layerId,
             });
-            // Verify
             await assertDecisionExists(db, 'crud-test-key', 'fastify');
-            // Cleanup
             await cleanupTestData(db);
         });
         it('should update existing decision value', async () => {
             const db = getDb();
-            // Setup: Create initial decision
             await db('m_context_keys').insert({ key_name: 'update-test-key' });
             const keyRecord = await db('m_context_keys')
                 .where({ key_name: 'update-test-key' })
@@ -284,7 +240,6 @@ runTestsOnAllDatabases('Decision Operations', (getDb, dbType) => {
                 ts: Math.floor(Date.now() / 1000),
                 layer_id: layerId,
             });
-            // Update decision
             await db('t_decisions')
                 .where({ key_id: keyRecord.id })
                 .update({
@@ -292,20 +247,16 @@ runTestsOnAllDatabases('Decision Operations', (getDb, dbType) => {
                 version: '1.1.0',
                 ts: Math.floor(Date.now() / 1000),
             });
-            // Verify
             await assertDecisionExists(db, 'update-test-key', 'postgresql-v16');
-            // Cleanup
             await cleanupTestData(db);
         });
         it('should store numeric decisions in t_decisions_numeric', async () => {
             const db = getDb();
-            // Setup: Create key
             await db('m_context_keys').insert({ key_name: 'numeric-test-key' });
             const keyRecord = await db('m_context_keys')
                 .where({ key_name: 'numeric-test-key' })
                 .first();
             const layerId = await getLayerId(db, 'infrastructure');
-            // Insert numeric decision
             await db('t_decisions_numeric').insert({
                 key_id: keyRecord.id,
                 project_id: projectId,
@@ -314,23 +265,17 @@ runTestsOnAllDatabases('Decision Operations', (getDb, dbType) => {
                 ts: Math.floor(Date.now() / 1000),
                 layer_id: layerId,
             });
-            // Verify
             const numericDecision = await db('t_decisions_numeric')
                 .where({ key_id: keyRecord.id })
                 .first();
             assert.ok(numericDecision, 'Numeric decision should exist');
             assert.strictEqual(numericDecision.value, 100, 'Numeric value should match');
-            // Cleanup
             await cleanupTestData(db);
         });
     });
-    // ============================================================================
-    // Decision Context Operations
-    // ============================================================================
     describe('Decision context operations', () => {
         it('should insert decision context with rationale, alternatives, tradeoffs', async () => {
             const db = getDb();
-            // Setup: Create decision
             await db('m_context_keys').insert({ key_name: 'context-test-key' });
             const keyRecord = await db('m_context_keys')
                 .where({ key_name: 'context-test-key' })
@@ -344,7 +289,6 @@ runTestsOnAllDatabases('Decision Operations', (getDb, dbType) => {
                 ts: Math.floor(Date.now() / 1000),
                 layer_id: layerId,
             });
-            // Insert context
             await db('t_decision_context').insert({
                 decision_key_id: keyRecord.id,
                 project_id: projectId,
@@ -353,7 +297,6 @@ runTestsOnAllDatabases('Decision Operations', (getDb, dbType) => {
                 tradeoffs: 'More complex implementation than basic auth',
                 ts: Math.floor(Date.now() / 1000),
             });
-            // Verify
             const context = await db('t_decision_context')
                 .where({ decision_key_id: keyRecord.id })
                 .first();
@@ -361,12 +304,10 @@ runTestsOnAllDatabases('Decision Operations', (getDb, dbType) => {
             assert.strictEqual(context.rationale, 'OAuth2 provides better security and user experience');
             assert.strictEqual(context.alternatives_considered, 'JWT, Session-based auth, Basic auth');
             assert.strictEqual(context.tradeoffs, 'More complex implementation than basic auth');
-            // Cleanup
             await cleanupTestData(db);
         });
         it('should update existing decision context', async () => {
             const db = getDb();
-            // Setup: Create decision with context
             await db('m_context_keys').insert({ key_name: 'context-update-key' });
             const keyRecord = await db('m_context_keys')
                 .where({ key_name: 'context-update-key' })
@@ -386,30 +327,23 @@ runTestsOnAllDatabases('Decision Operations', (getDb, dbType) => {
                 rationale: 'Original rationale',
                 ts: Math.floor(Date.now() / 1000),
             });
-            // Update context
             await db('t_decision_context')
                 .where({ decision_key_id: keyRecord.id })
                 .update({
                 rationale: 'Updated rationale',
                 alternatives_considered: 'New alternatives',
             });
-            // Verify
             const context = await db('t_decision_context')
                 .where({ decision_key_id: keyRecord.id })
                 .first();
             assert.strictEqual(context.rationale, 'Updated rationale');
             assert.strictEqual(context.alternatives_considered, 'New alternatives');
-            // Cleanup
             await cleanupTestData(db);
         });
     });
-    // ============================================================================
-    // Tag Operations
-    // ============================================================================
     describe('Decision tagging', () => {
         it('should insert decision tags', async () => {
             const db = getDb();
-            // Setup: Create decision
             await db('m_context_keys').insert({ key_name: 'tag-test-key' });
             const keyRecord = await db('m_context_keys')
                 .where({ key_name: 'tag-test-key' })
@@ -423,29 +357,22 @@ runTestsOnAllDatabases('Decision Operations', (getDb, dbType) => {
                 ts: Math.floor(Date.now() / 1000),
                 layer_id: layerId,
             });
-            // Insert tags
             const apiTagId = await getTagId(db, 'api');
             const perfTagId = await getTagId(db, 'performance');
             await db('t_decision_tags').insert([
                 { decision_key_id: keyRecord.id, project_id: projectId, tag_id: apiTagId },
                 { decision_key_id: keyRecord.id, project_id: projectId, tag_id: perfTagId },
             ]);
-            // Verify
             await assertDecisionHasTags(db, 'tag-test-key', ['api', 'performance']);
-            // Cleanup
             await cleanupTestData(db);
         });
         // Note: m_tag_index test removed - the table has a different schema
         // (tag_name, decision_count, constraint_count, task_count, total_count)
         // It's an aggregate count table populated by application logic, not individual mappings
     });
-    // ============================================================================
-    // Scope Operations
-    // ============================================================================
     describe('Decision scoping', () => {
         it('should insert decision scopes', async () => {
             const db = getDb();
-            // Setup: Create decision
             await db('m_context_keys').insert({ key_name: 'scope-test-key' });
             const keyRecord = await db('m_context_keys')
                 .where({ key_name: 'scope-test-key' })
@@ -459,14 +386,12 @@ runTestsOnAllDatabases('Decision Operations', (getDb, dbType) => {
                 ts: Math.floor(Date.now() / 1000),
                 layer_id: layerId,
             });
-            // Insert scopes
             const globalScopeId = await getScopeId(db, 'global');
             const moduleScopeId = await getScopeId(db, 'module');
             await db('t_decision_scopes').insert([
                 { decision_key_id: keyRecord.id, project_id: projectId, scope_id: globalScopeId },
                 { decision_key_id: keyRecord.id, project_id: projectId, scope_id: moduleScopeId },
             ]);
-            // Verify
             const scopes = await db('t_decision_scopes')
                 .join('m_scopes', 't_decision_scopes.scope_id', 'm_scopes.id')
                 .where({ 't_decision_scopes.decision_key_id': keyRecord.id, 't_decision_scopes.project_id': projectId })
@@ -474,13 +399,9 @@ runTestsOnAllDatabases('Decision Operations', (getDb, dbType) => {
             assert.strictEqual(scopes.length, 2, 'Should have 2 scopes');
             assert.ok(scopes.includes('global'), 'Should have global scope');
             assert.ok(scopes.includes('module'), 'Should have module scope');
-            // Cleanup
             await cleanupTestData(db);
         });
     });
-    // ============================================================================
-    // Cross-Database Compatibility Tests
-    // ============================================================================
     describe(`Cross-database compatibility - ${dbType}`, () => {
         it('should handle long VARCHAR keys', async () => {
             const db = getDb();
@@ -499,7 +420,6 @@ runTestsOnAllDatabases('Decision Operations', (getDb, dbType) => {
                 layer_id: layerId,
             });
             await assertDecisionExists(db, longKey, 'test');
-            // Cleanup
             await cleanupTestData(db);
         });
         it('should handle special characters in values', async () => {
@@ -519,7 +439,6 @@ runTestsOnAllDatabases('Decision Operations', (getDb, dbType) => {
                 layer_id: layerId,
             });
             await assertDecisionExists(db, 'special-chars-key', specialValue);
-            // Cleanup
             await cleanupTestData(db);
         });
         it('should handle unicode characters', async () => {
@@ -539,7 +458,6 @@ runTestsOnAllDatabases('Decision Operations', (getDb, dbType) => {
                 layer_id: layerId,
             });
             await assertDecisionExists(db, 'unicode-key', unicodeValue);
-            // Cleanup
             await cleanupTestData(db);
         });
     });