spyne 0.20.1 → 0.20.2

package/.husky/pre-commit

@@ -0,0 +1 @@
+npm run test:single

package/README.md

@@ -3,7 +3,9 @@ Spyne is a full-featured, Javascript framework that reactively renders to the Re
 
 [![NPM version](https://img.shields.io/npm/v/spyne.svg?longCache=true&style=flat-square)](https://www.npmjs.com/package/spyne)
 [![GitHub license](https://img.shields.io/github/license/spynejs/spyne.svg?longCache=true&style=flat-square)](https://github.com/spynejs/spyne/blob/master/LICENSE)
-[![Build Status](https://travis-ci.com/spynejs/spyne.svg?branch=master)](https://travis-ci.com/spynejs/spyne)
+[![Build Status](https://app.travis-ci.com/spynejs/spyne.svg?token=tUNpKxHHHcwypyVzqWmD&branch=main&style=flat-square)](https://travis-ci.com/spynejs/spyne)
+
+
 
 ### Spyne.js’ key features includes:
 

package/karma.conf.js

@@ -12,7 +12,7 @@ const karmaWebpackConfig = {
   mode: 'none',
 
   // Karma manages watching/rebuilding on its own, so we typically disable watch from Webpack
-  watch: false,
+  watch: true,
 
   // Remove the library entry/output so that Karma can inline test files
   entry: undefined,
@@ -101,9 +101,6 @@ module.exports = function (config) {
     // autoWatch: if true, re-run tests on file changes
     autoWatch: true,
 
-    // For file-watching inside containers or certain OS environments
-    usePolling: true,
-
     customLaunchers: {
       ChromeHeadlessNoSandbox: {
         base: 'ChromeHeadless',
@@ -115,7 +112,7 @@ module.exports = function (config) {
     browsers: ['Chrome'],
 
     // If true, Karma runs tests once and exits
-    singleRun: true,
+    singleRun: false,
 
     // Concurrency level
     concurrency: Infinity

package/package.json

@@ -1,14 +1,14 @@
 {
   "name": "spyne",
-  "version": "0.20.1",
+  "version": "0.20.2",
   "description": "Reactive Real-DOM Framework for Advanced Javascript applications",
   "sideEffects": true,
-  "main": "./lib/spyne.umd.js",
+  "main": "./lib/spyne.esm.js",
   "module": "./lib/spyne.esm.js",
   "exports": {
     ".": {
       "import": "./lib/spyne.esm.js",
-      "require": "./lib/spyne.umd.js"
+      "require": "./lib/spyne.esm.js"
     },
     "./lib/*": "./lib/*.js"
   },
@@ -19,6 +19,7 @@
     "report-coverage": "nyc report --reporter=text-lcov > coverage.lcov && codecov",
     "commit": "git-cz",
     "start": "webpack-dev-server --hot",
+    "prepare": "husky",
     "build": "webpack --config webpack.config.js --mode production",
     "build:esm": "rollup --config rollup.config.js",
     "dev": "webpack --config webpack.config.js --mode development",
@@ -60,6 +61,7 @@
     "eslint-plugin-node": "^11.1.0",
     "eslint-webpack-plugin": "^4.2.0",
     "file-loader": "^6.2.0",
+    "husky": "^9.1.7",
     "karma": "^6.4.4",
     "karma-chai": "^0.1.0",
     "karma-chrome-launcher": "^3.2.0",

package/src/spyne/spyne-app.js

@@ -5,7 +5,7 @@ import { SpyneAppProperties } from './utils/spyne-app-properties'
 import { sanitizeHTMLConfigure } from './utils/sanitize-html'
 
 const _channels = new ChannelsMap()
-const version = '0.20.1'
+const version = '0.20.2'
 
 class SpyneApplication {
   /**
@@ -42,7 +42,7 @@ class SpyneApplication {
   init(config = {}, testMode = false) {
     // this.channels = new ChannelsMap();
     /*!
-     * Spyne 0.20.1
+     * Spyne 0.20.2
      * https://spynejs.org
      *
      * @license Copyright 2017-2021, Frank Batista, Relevant Context, LLC. All rights reserved.
@@ -121,6 +121,7 @@ class SpyneApplication {
     this.pluginsFn = SpyneAppProperties.getPluginsMethodObj(config['pluginMethods']);
     this.getChannelActions = (str) => _channels.getChannelActions(str);
     this.registerChannel = (val) => _channels.registerStream(val);
+    this.registerPlugin = (pluginInstance) => SpyneAppProperties.registerPlugin(pluginInstance);
     this.registerDataChannel = (obs$) => _channels.registerStream(obs$);
     this.listChannels = () => Array.from(_channels.map.keys());
     let nullHolder = new ViewStream({ id:'spyne-null-views' });

package/src/spyne/spyne-plugins.js

@@ -1,6 +1,7 @@
 import { DomElement } from './views/dom-element'
 import { SpyneAppProperties } from './utils/spyne-app-properties'
 import { is, clone, pathSatisfies } from 'ramda'
+let _spyneAppProps = SpyneAppProperties
 export class SpynePlugin {
   constructor(props = {}) {
     let { name, config, parentEl } = props
@@ -14,27 +15,65 @@ export class SpynePlugin {
     this.props.name = name
     config = SpynePlugin.mergeDefaultConfig(config, this.defaultConfig())
     this.props.parentEl = parentEl || SpynePlugin.createParentEl()
-    SpynePlugin.getSpyneApp(name, config)
-
+    // SpynePlugin.getSpyneApp(name, config)
+    this.props.config = config
     if (this.props.traits !== undefined) {
       this.addTraits(this.props.traits)
     }
 
+    // this.onBeforeRegistered()
+    // this.onRegistered()
+    // this.onRender()
+  }
+
+  /**
+   * Now this method will be called when the app decides to register the plugin.
+   * This way, the plugin no longer has to import or rely on its own version
+   * of SpyneAppProperties. Instead, it is *passed* the authoritative instance.
+   */
+  register(spyneAppProps) {
+    // 1. Save a reference to the real SpyneAppProperties
+    _spyneAppProps = spyneAppProps
+    this.props.pluginName = this.props.name
+
+    // this.props.config = _spyneAppProps.getPluginConfigByPluginName(this.props.pluginName)
+
+    if (_spyneAppProps.initialized === false) {
+      console.warn(
+          `Spyne Warning: SpyneApp has not been initialized yet! Cannot register plugin "${this.name}".`
+      )
+      return
+    }
+
     this.onBeforeRegistered()
+
+    // 2. Add plugin config in the real SpyneAppProperties
+    this.props.config = clone(this.props.config)
+    _spyneAppProps.addPluginConfig(this.name, this.props.config)
+
+    // If you have plugin-level logic that depends on the real spyneApp,
+    // you can add it here, e.g.:
+    // spyneAppProps.addPluginMethods(this.props.config.pluginMethods)
+
+    // 3. If you have other plugin lifecycle methods
     this.onRegistered()
     this.onRender()
   }
 
+  get SpyneAppProperties() {
+    return _spyneAppProps
+  }
+
   static mergeDefaultConfig(config = {}, defaultConfig = this.defaultConfig()) {
     return Object.assign(defaultConfig, config)
   }
 
   static getSpyneApp(name, config) {
-    if (SpyneAppProperties.initialized === false) {
+    if (_spyneAppProps.initialized === false) {
       console.warn(`Spyne Warning: Unable to install plugin, ${name}! SpyneApp has not been initialized!`)
       // SpyneApp.init()
     } else {
-      SpyneAppProperties.addPluginConfig(name, config)
+      _spyneAppProps.addPluginConfig(name, config)
     }
   }
 
@@ -82,8 +121,8 @@ export class SpynePlugin {
   }
 
   onBeforeRegistered() {
-    this.props.pluginName = this.props.name
-    this.props.config = SpyneAppProperties.getPluginConfigByPluginName(this.props.pluginName)
+    // this.props.pluginName = this.props.name
+    // this.props.config = _spyneAppProps.getPluginConfigByPluginName(this.props.pluginName)
   }
 
   defaultConfig() {

package/src/spyne/utils/spyne-app-properties.js

@@ -61,6 +61,7 @@ class SpyneAppPropertiesClass {
     this.getChannelActions = _channels.getChannelActions.bind(_channels)
     this.listRegisteredChannels = _channels.listRegisteredChannels.bind(_channels)
     _initialized = true
+    this._initialized = _initialized
     this.setChannelsMap()
     if (config?.baseHref) {
       this.setHeadBaseHref(config.baseHref)
@@ -178,6 +179,16 @@ class SpyneAppPropertiesClass {
     // console.log("REGISTERD PROXY REVIVER",_proxiesMap, _proxiesMap.get(name));
   }
 
+  // This is the new method you add
+  registerPlugin(pluginInstance) {
+    if (!this._initialized) {
+      console.warn('SpyneApp is not initialized yet. Plugin will not be fully registered.')
+    }
+    // console.log("INSTANCE ",this, pluginInstance)
+
+    pluginInstance.register(this)
+  }
+
   getProxyReviver(proxyName) {
     return _proxiesMap.get(proxyName)
   }

package/src/tests/package-json.spec.test.js

@@ -4,6 +4,9 @@ import pkg from '../../package.json' // Import package.json
 describe('package.json export import statement', () => {
   it('should be set to "./lib/spyne.esm.js"', () => {
     const exports = pkg.exports['.']
+    expect(pkg.main).to.equal('./lib/spyne.esm.js')
+    expect(pkg.module).to.equal('./lib/spyne.esm.js')
     expect(exports.import).to.equal('./lib/spyne.esm.js')
+    expect(exports.require).to.equal('./lib/spyne.esm.js')
   })
 })