spyne 0.17.1 → 0.18.3

package/src/spyne/channels/channel-proxy.js

@@ -1,7 +1,7 @@
 import { Channel } from './channel';
 import {SpyneAppProperties} from '../utils/spyne-app-properties';
 import { Subject, ReplaySubject, merge } from 'rxjs';
-import {includes, path} from 'ramda';
+import {includes} from 'ramda';
 import {delayCall} from '../utils/frp-tools';
 
 export class ChannelProxy extends Channel {

package/src/spyne/channels/channel.js

@@ -1,6 +1,5 @@
 import { registeredStreamNames } from './channels-config';
 import { ChannelPayload } from './channel-payload-class';
-import { ChannelPayloadFilter} from '../utils/channel-payload-filter';
 import {SpyneAppProperties} from '../utils/spyne-app-properties';
 import {RouteChannelUpdater} from '../utils/route-channel-updater';
 import { ReplaySubject, Subject } from 'rxjs';
@@ -19,12 +18,10 @@ import {
   always,
   fromPairs,
   path,
- assocPath,
-    isEmpty,
+  isEmpty,
   equals,
   prop,
-    propEq,
-  apply,
+  propEq
 } from 'ramda';
 const rMap = require('ramda').map;
 
@@ -152,7 +149,7 @@ export class Channel {
         traits = [traits];
       }
       const addTrait=(TraitClass)=>{
-        new TraitClass(this);
+        return new TraitClass(this);
       };
 
       traits.forEach(addTrait);
@@ -403,26 +400,6 @@ export class Channel {
     return fn(CHANNEL_NAME);
   }
 
-  /**
-   *
-   * Wraps window.setTimeout with a check to see if "this" ViewStream element and its props property still exists
-   * @property {function} fn - = 'function'; The local method that is to be called.
-   * @property {number} ms - = 0;  The time, in milleseconds, for the timeout.
-   * @property {boolean} bind - = false;  When true, will bind the method to 'this'.
-   *
-   */
-
-/*
-  setTimeout(fn, ms=0, bind=false){
-    const timeoutMethod = (...args)=>{
-      if (this!==undefined && this.props!==undefined){
-        const methodFn = bind===true ? fn.bind(this) : fn;
-        apply(methodFn, args);
-      }
-    }
-    window.setTimeout(timeoutMethod, ms);
-  }
-*/
 
 
 

package/src/spyne/channels/channels-config.js

@@ -1,5 +1,3 @@
-// import Spyne from '../spyne';
-import { arrFromMapKeys } from '../utils/frp-tools';
 import {SpyneAppProperties} from '../utils/spyne-app-properties';
 import {compose, path, is} from 'ramda';
 const Observable = require('rxjs');

package/src/spyne/channels/channels-map.js

@@ -1,18 +1,14 @@
-// import {baseCoreMixins}    from '../utils/mixins/base-core-mixins';
-// import {BaseStreamsMixins} from '../utils/mixins/base-streams-mixins';
 import { SpyneChannelRoute } from './spyne-channel-route';
 import { SpyneChannelUI } from './spyne-channel-ui';
 import { SpyneChannelWindow } from './spyne-channel-window';
 import { SpyneChannelLifecycle } from './spyne-channel-lifecycle';
-//import { validate } from '../utils/channel-config-validator';
 
 import { Subject } from 'rxjs';
 import { ChannelProxy } from './channel-proxy';
-import {propEq, pluck, prop, filter, pathEq, clone, reject, compose, join} from 'ramda';
+import {propEq, pluck, prop, filter, pathEq, reject, compose, join} from 'ramda';
 const rMap = require('ramda').map;
 const _map = new Map();
 
-// import * as R from 'ramda';
 
 export class ChannelsMap {
   /**
@@ -29,10 +25,6 @@ export class ChannelsMap {
 
   constructor() {
     this.addMixins();
-    //_map = new Map();
-
-    // console.log('Rx is ',Rx);
-    // console.log('RX IS ', Subject);
     _map.set('DISPATCHER', new Subject());
     this.listRegisteredChannels = ChannelsMap.listRegisteredChannels.bind(this);
     this.getChannelsList = ChannelsMap.getChannelsList.bind(this);
@@ -73,23 +65,14 @@ export class ChannelsMap {
       let channels = compose(join(', '), rMap(prop('key')))(filterProxyArr);
       let filterPrefixWarning = `Spyne Warning: The following ${channelStr} not been initialized: ${channels}`;
       console.warn(filterPrefixWarning);
-      // console.log("FILTER PROXY WARNING ",filterProxyArr);
     }
 
-    // console.log(filterProxy(proxyMap),' proxyMap ', proxyMap);
   }
 
   init() {
     this.createMainStreams();
   }
 
-/*
-  createObserver(obj) {
-    // RIGHT NOW THIS CREATES THE DISPATCHER STREAM
-    validate(obj.validations, obj.init);
-    _map.set(obj.init.name, obj.init.observable());
-  }
-*/
 
   createMainStreams() {
     this.routeStream = new SpyneChannelRoute();

package/src/spyne/channels/spyne-channel-lifecycle.js

@@ -1,5 +1,4 @@
 import { Channel } from './channel';
-import {prop} from 'ramda';
 
 export class SpyneChannelLifecycle extends Channel {
   /**
@@ -30,7 +29,7 @@ export class SpyneChannelLifecycle extends Channel {
   }
 
   onViewStreamInfo(obj) {
-    let {data, action, srcElement} = obj;
+    let {action, srcElement} = obj;
     let payload = srcElement;
     payload['action'] = action;
     this.onSendEvent(action, payload);

package/src/spyne/channels/spyne-channel-route.js

@@ -6,13 +6,11 @@ import { ReplaySubject, merge } from 'rxjs';
 import { map } from 'rxjs/operators';
 
 import {
-  clone,
   pick,
-    find,
+  find,
   omit,
   over,
   mergeRight,
-  mergeDeepRight,
   is,
   objOf,
   mergeAll,
@@ -33,7 +31,10 @@ import {
     reverse,
   curryN,
   __,
-  test, replace, fromPairs, toPairs, forEach, reduceRight, reduce
+  test,
+  replace,
+  toPairs,
+  reduce
 } from 'ramda';
 const ramdaFilter = require('ramda').filter;
 const rMerge = require('ramda').mergeRight;
@@ -140,7 +141,6 @@ export class SpyneChannelRoute extends Channel {
     this.bindStaticMethods();
     this.navToStream$ = new ReplaySubject(1);
     this.observer$ = this.navToStream$.pipe(map(info => this.onMapNext(info)));
-    // let compareKeysFn = SpyneUtilsChannelRoute.compareRouteKeywords.bind(this);
     this.compareRouteKeywords = SpyneUtilsChannelRoute.compareRouteKeywords();
   }
 
@@ -203,9 +203,7 @@ export class SpyneChannelRoute extends Channel {
     }
 
     let arr = SpyneUtilsChannelRoute.flattenConfigObject(routeConfig.routes);
-    // console.log("FLATTENED CONFIG ",arr);
     routeConfig['paramsArr'] = arr;
-    //console.log("ROUTE CONFIG IS ",routeConfig);
     return routeConfig;
   }
 
@@ -220,7 +218,6 @@ export class SpyneChannelRoute extends Channel {
   }
 
   onMapNext(data, firstLoaded = false) {
-   // console.log("MAP NEXT ",{firstLoaded, data});
     data['action'] = 'CHANNEL_ROUTE_CHANGE_EVENT';
     return data;
   }
@@ -247,15 +244,11 @@ export class SpyneChannelRoute extends Channel {
 
     let keywordArrs = this.compareRouteKeywords.compare(payload.routeData, payload.paths);
     payload = rMerge(payload, keywordArrs);
-    // console.log("SEND STREAM onIncomingDomEvent", payload, keywordArrs);;
-   // payload = SpyneChannelRoute.removeSSID(payload);
       this.sendChannelPayload(action, payload, undefined, evt, this.navToStream$);
 
   }
 
   static checkForRouteParamsOverrides(payload) {
-    // console.log("CHECK FOR OVERRIDES ",payload);
-
     return payload;
   }
 
@@ -280,31 +273,13 @@ export class SpyneChannelRoute extends Channel {
   }
 
 
-
-/*
-  static checkToPreventDefaultEvent(obs) {
-    const checkDataForPreventDefault = pathEq(['viewStreamInfo', 'payload', 'eventPreventDefault'], 'true');
-    const setPreventDefault = (evt) => {
-      if (evt !== undefined) {
-        evt.preventDefault();
-      }
-    };
-    const selectEvtAndPreventDefault = compose(setPreventDefault, prop('event'));
-    const checkForPreventDefault = when(checkDataForPreventDefault, selectEvtAndPreventDefault);
-    checkForPreventDefault(obs);
-  }
-*/
-
-
   static checkForEndRoute(pl, routeConfigJson = this.routeConfigJson, debugBool){
 
     const endRoute = compose(equals("true"), path(['payload', 'endRoute']))(pl);
-    //console.log('pl and aend route',{endRoute, pl})
 
     if (endRoute!==true){
       return pl;
     }
-    const win = window || {};
     const debug = debugBool !== undefined ? debugBool : SpyneAppProperties.debug === true;
      const {payload} = pl;
 
@@ -316,7 +291,6 @@ export class SpyneChannelRoute extends Channel {
           let routeNameVal = payload[routeName]
           const pred = arrStr => new RegExp(`^${arrStr}$`).test(routeNameVal);
           const routeVal = find(pred, keysArr);
-           // console.log('route val is ',{routeVal, keysArr})
           return routeVal;
 
         }
@@ -347,7 +321,6 @@ export class SpyneChannelRoute extends Channel {
               acc.push(routeName)
             }
           }
-         // compose(reduce(onReduceRoutePaths), toPairs)(nextRoutePath);
         }
         return acc;
 
@@ -375,17 +348,15 @@ export class SpyneChannelRoute extends Channel {
     SpyneChannelRoute.checkForEventMethods(pl);
     pl = this.checkForEndRoute(pl);
     let payload = this.getDataFromParams(pl);
-    const {routeConfigJson} = this;
-    //console.log("LOADING ROUTE FROM LINK ", {pl, payload,routeConfigJson})
 
     let srcElement = prop('srcElement', pl);
     let event = prop('event', pl);
     let changeLocationBool = !payload.isHidden;
     let keywordArrs = this.compareRouteKeywords.compare(payload.routeData, payload.paths);
+
     payload = rMerge(payload, keywordArrs);
-    // this.checkForRouteParamsOverrides(payload);
     this.sendRouteStream(payload, changeLocationBool);
-     //console.log("SEND STREAM onViewStreamInfo", payload);
+
     payload = SpyneChannelRoute.removeSSID(payload);
 
     this.sendChannelPayload(action, payload, srcElement, event,
@@ -426,7 +397,6 @@ export class SpyneChannelRoute extends Channel {
   static getExtraPayloadParams(config = this.routeConfigJson, isHistory=false) {
     let routeCount = this.getRouteCount(isHistory);
     let isDeepLink = this.getIsDeepLinkBool(isHistory);
-    //console.log("GETTING DEEP LINK ", {routeCount, isDeepLink,isHistory, config})
     let isHash = config.isHash;
     let isHidden = config.isHidden;
     let routeType = config.type;
@@ -445,7 +415,6 @@ export class SpyneChannelRoute extends Channel {
     let nextWindowLoc = SpyneUtilsChannelRouteUrl.formatStrAsWindowLocation(routeValue);
     let dataFromStr = this.getDataFromLocationStr(typeForStr, isHashForStr, nextWindowLoc);
 
-    // console.log(" DATA FROM STRING ",{routeValue, pl, dataFromStr});
     let { pathInnermost, paths } = dataFromStr;
 
     routeData = rMerge(dataFromStr.routeData, routeData);
@@ -469,7 +438,6 @@ export class SpyneChannelRoute extends Channel {
   static getDataFromString(config = this.routeConfigJson, isHistory=false) {
     const type = config.type;
     const hashIsTrue = config.isHash === true;
-    // type = config.isHash === true ? ''
     const str = SpyneUtilsChannelRouteUrl.getLocationStrByType(type, hashIsTrue);
     let { paths, pathInnermost, routeData, routeValue } = SpyneChannelRoute.getParamsFromRouteStr(
       str, config, type);
@@ -496,7 +464,6 @@ export class SpyneChannelRoute extends Channel {
       ? this.routeConfigJson.type
       : t;
 
-    // console.log("DATA CHECK STRING ",loc);
     const str = SpyneUtilsChannelRouteUrl.getLocationStrByType(type, isHash, loc);
     let { paths, pathInnermost, routeData, routeValue } = this.getParamsFromRouteStr(
       str, this.routeConfigJson, type);
@@ -521,15 +488,12 @@ export class SpyneChannelRoute extends Channel {
   static getRouteStrFromParams(paramsData, routeConfig, t) {
     const type = t !== undefined ? t : routeConfig.type;
     let obj = SpyneUtilsChannelRouteUrl.convertParamsToRoute(paramsData, routeConfig, type);
-
-    // console.log("ROUTE getRouteStrFromParams ",paramsData,obj);
     return obj;
   }
 
   static getParamsFromRouteStr(str, routeConfig, t) {
     const type = t !== undefined ? t : routeConfig.type;
     let obj = SpyneUtilsChannelRouteUrl.convertRouteToParams(str, routeConfig, type);
-    // console.log("ROUTE getParamsFromRouteStr ",obj);
     return obj;
   }
 
@@ -539,7 +503,6 @@ export class SpyneChannelRoute extends Channel {
     const hashNameIsEmptyBool = isEmptyBool === true && isHash === true;
     const hashNameBool = isEmptyBool === false && isHash === true;
 
-    // console.log('ROUTE STR CHECK ', {str, isHash});
     if (pathNameIsEmptyBool === true || hashNameIsEmptyBool === true) {
       return '/';
     } else if (hashNameBool === true) {
@@ -559,11 +522,8 @@ export class SpyneChannelRoute extends Channel {
     if (isHash === true) {
       let pathName = SpyneChannelRoute.removeLastSlash(window.location.pathname);
       routeValue = pathName + routeValue;
-      // window.location.hash = routeValue;
-      // console.log('ROUTE STR FOR HASH ', routeValue);
       window.history.pushState({routeCount}, '', routeValue);
     } else {
-      // routeValue =  when(isEmpty, always('/'))(routeValue);
       const checkForSlash = when(
         compose(complement(equals('/')), head), concat('/', __));
       window.history.pushState({routeCount}, '', checkForSlash(routeValue));

package/src/spyne/channels/spyne-channel-ui.js

@@ -25,7 +25,6 @@ export class SpyneChannelUI extends Channel {
     super(name, props);
     this.keyEventsLoaded = false;
     this.keyCodeArr = [];
-    // this.addKeyEvent(13);
   }
 
   addRegisteredActions() {
@@ -137,7 +136,6 @@ export class SpyneChannelUI extends Channel {
   onIncomingObservable(obj) {
     let eqsName = equals(obj.name, this.props.name);
     obj.data = SpyneChannelUI.removeSSID(obj.data);
-    //console.log("OBJECT DATA ",obj.data);
     let {payload, srcElement} = obj.data;
     let dataObj = obsVal => ({ payload, srcElement, event: obsVal });
     let onSuccess = (obj) => obj.observable.pipe(map(dataObj))

package/src/spyne/channels/spyne-channel-window.js

@@ -4,7 +4,7 @@ import {SpyneAppProperties} from '../utils/spyne-app-properties';
 import { SpyneUtilsChannelWindow } from '../utils/spyne-utils-channel-window';
 import { merge } from 'rxjs';
 import { map, debounceTime, skipWhile } from 'rxjs/operators';
-import {curry, pathEq, path, pick, partialRight, mapObjIndexed, apply} from 'ramda';
+import {curry, pick, partialRight, mapObjIndexed, apply} from 'ramda';
 import {deepMerge} from '../utils/deep-merge';
 
 const rMap = require('ramda').map;
@@ -39,8 +39,6 @@ export class SpyneChannelWindow extends Channel {
     this.bindStaticMethods();
     this.currentScrollY=0;
 
-    //this.spyneScrollLock = SpyneAppProperties.scrollLock;
-    // this.props.name = 'WINDOW';
   }
 
   initializeStream() {
@@ -167,19 +165,10 @@ export class SpyneChannelWindow extends Channel {
     return SpyneUtilsChannelWindow.createDomObservableFromEvent('scroll',
         scrollMapFn, isPassive, element)
       .pipe(
-         /* map(p=>{
-            if (pathEq(['Spyne', 'config', 'scrollLock'], true)(scrollElement)){
-              let x = SpyneAppProperties.config.scrollLockX
-              let y = SpyneAppProperties.config.scrollLockY;
-              window.scrollTo(x,y);
-            }
-            return p;
-          }),*/
         debounceTime(dTime),
         skipWhile(skipWhenDirIsMissing),
         map(p=>{
           const newScrollY = SpyneChannelWindow.getScrollY(element);
-          //console.log("SCROLL P IS ",{p});
           p.payload['scrollDistanceAbs'] = Math.abs(this.currentScrollY-newScrollY);
           this.currentScrollY=newScrollY;
           return p;
@@ -218,13 +207,11 @@ export class SpyneChannelWindow extends Channel {
     // CHECK TO ADD MEDIA QUERY OBSERVABLE
     // ==========================================
     config['listenForMediaQueries'] = checkIfObjIsNotEmptyOrNil(
-      config.mediqQueries);
+      config.mediaQueries) || checkIfObjIsNotEmptyOrNil(
+        config.mediqQueries);
 
     // =========================================
 
-    // config.listenForResize = false;
-    // config.listenForMouseWheel = true;
-    // config.listenForScroll = false;
     let methods = {
       'listenForResize': this.createResizeObservable.bind(this),
       'listenForOrientation': this.createOrientationObservable.bind(this),
@@ -338,43 +325,7 @@ export class SpyneChannelWindow extends Channel {
   }
 
   onScrollLockEvent(e){
-    const setScrollPos = ()=>{
-      SpyneAppProperties.config.scrollLockX = window.scrollX;
-      SpyneAppProperties.config.scrollLockY = window.scrollY;
-      this.spyneScrollLock.setScroll();
-    };
-    let {action, scrollLock, el} = e.payload;
-    SpyneAppProperties.config.scrollLock = scrollLock;
-    el = el || window;
-    if (scrollLock === true){
-     // setScrollPos();
-
-      this.spyneScrollLock.disableBodyScroll();
-      const id = path(['srcElement', 'id'], e);
-      /**
-       * TODO: ADD EL TO Scroll lock --- this is hard coded .scroll-lock class
-       *
-       * */
-       //el = document.querySelector(`#${id} .card-scroll`);
-      //console.log("E TO SCROLL IS ",{id,el,e});
-     // this.onSetElementToScroll({}, el);
-
-      this.createScrollObservable(this.domChannelConfig, el, true)
-      .subscribe(p => {
-        let { action, payload, srcElement, event } = p;
-        //console.log("SCROLL OBS IS ",p)
-        this.sendChannelPayload(action, payload, srcElement, event);
-      });
-
-
-
-    } else {
-      this.spyneScrollLock.enableBodyScroll();
-    }
-
-    //console.log('scroll lock window channel ',{action,scrollLock});
-
-    this.sendChannelPayload(action, {scrollLock}, el);
+    // DEPRECATED -- MOVED TO spyne-plugin-scroll-lock;
   }
 
   onSetElementToScroll(e){
@@ -384,7 +335,6 @@ export class SpyneChannelWindow extends Channel {
     config = deepMerge(this.domChannelConfig, config);
 
     scrollElement = scrollElement || el;
-    //console.log('set elemenet to scroll ',{scrollElement})
 
     const action = "CHANNEL_WINDOW_SCROLL_ELEMENT_ADDED_EVENT";
     this.sendChannelPayload(action, {el}, el);

package/src/spyne/spyne-app.js

@@ -1,10 +1,9 @@
 import {ChannelsMap} from './channels/channels-map';
 import {ViewStream} from './views/view-stream';
-import {SpyneUtilsChannelRoute} from './utils/spyne-utils-channel-route';
 import {SpyneAppProperties} from './utils/spyne-app-properties';
 import {deepMerge} from './utils/deep-merge';
 const _channels = new ChannelsMap();
-const version = '0.17.2';
+const version = '0.18.3';
 
 class SpyneApplication {
   /**
@@ -42,7 +41,7 @@ class SpyneApplication {
   init(config = {}, testMode=false) {
     //this.channels = new ChannelsMap();
     /*!
-     * Spyne 0.17.1
+     * Spyne 0.18.3
      * https://spynejs.org
      *
      * @license Copyright 2017-2021, Frank Batista, Relevant Context, LLC. All rights reserved.
@@ -52,18 +51,9 @@ class SpyneApplication {
      * @email:  frbatista.nyc@gmail.com
     */
     /* eslint-disable */
-   /* this.ViewStream = ViewStream;
-    this.BasicView = ViewStreamElement;
-    this.DomEl = DomElement;
-    this.ViewStreamBroadcaster = ViewStreamBroadcaster;
-    this.ChannelsPayload = ViewStreamPayload;
-    this.ChannelsController = ChannelsMap;
-    this.ChannelsBase = Channel;
-    this.ChannelPayloadItem = ChannelPayload;*/
-
-    //console.log('spyne app ',{config,testMode}, SpyneAppProperties.initialized);
-    if(SpyneAppProperties.initialized === true){
 
+
+    if(SpyneAppProperties.initialized === true){
       if (testMode){
         return 'The Spyne Application has already been initialized!';
       } else {
@@ -113,14 +103,9 @@ class SpyneApplication {
     if (config !== undefined) {
        config = SpyneAppProperties.initialize(defaultConfig, config, _channels);
       //window.Spyne = this;
-      //window.Spyne['config'] = "SDFSD";// {};
-      //config = SpyneUtilsChannelRoute.conformRouteObject(config);
       //window.Spyne['config'] = deepMerge(defaultConfig, config)
     }
 
-
-    //const ranNum = Math.random();
-    //console.log('ranNum is ',{ranNum})
     this.pluginsFn = SpyneAppProperties.getPluginsMethodObj(config['pluginMethods']);
     this.getChannelActions = (str) => _channels.getChannelActions(str);
     this.registerChannel = (val) => _channels.registerStream(val);
@@ -130,10 +115,9 @@ class SpyneApplication {
     nullHolder.appendToDom(document.body);
     nullHolder.props.el.style.cssText = 'display:none; opacity:0; pointer-events:none;';
     _channels.init();
-    //console.log('spyne app initialized ',SpyneAppProperties.config.debug);
 
     if (SpyneAppProperties.config.debug===true){
-      window.Spyne = {version};
+       window.Spyne = {version};
     }
 
 

package/src/spyne/spyne-plugins.js

@@ -1,5 +1,5 @@
-import {SpyneApp, ViewStream, DomElement, SpyneAppProperties} from './spyne';
-import {prop, path, is, clone, mergeRight, pathSatisfies} from 'ramda';
+import {SpyneApp, DomElement, SpyneAppProperties} from './spyne';
+import {is, clone, pathSatisfies} from 'ramda';
 export class SpynePlugin {
 
   constructor(props={}) {
@@ -11,20 +11,11 @@ export class SpynePlugin {
       config = clone(props);
     }
 
-
-     //console.log("CONFIG AND PROPS ",{config, props});
-
     this.name = name || 'empty';
     this.props.name = name;
     config = SpynePlugin.mergeDefaultConfig(config, this.defaultConfig());
     this.props.parentEl = parentEl || SpynePlugin.createParentEl();
     SpynePlugin.getSpyneApp(name, config);
-    //console.log("SPYNE APP ",{name},this.name,this.props.spyneApp);
-   // if (this.props.spyneApp===false){
-      //console.warn(`Spyne Warning: Spyne Plugin, ${this.name} already exists!`)
-     // return false;
-   // }
-
 
     if (this.props.traits!==undefined){
       this.addTraits(this.props.traits);
@@ -35,70 +26,24 @@ export class SpynePlugin {
     this.onRender();
   }
 
-
-  addTraits(traits){
-    if (traits.constructor.name!=='Array'){
-      traits = [traits];
-    }
-    const addTrait=(TraitClass)=>{
-      new TraitClass(this);
-    };
-
-    traits.forEach(addTrait);
-
-
-  }
-
-
-  onBeforeRegistered(){
-    this.props.pluginName = this.props.name;
-    //this.props.config = path(['Spyne', 'config', 'plugins', this.props.name], window);
-    this.props.config = SpyneAppProperties.getPluginConfigByPluginName(this.props.pluginName);
-  }
-
   static mergeDefaultConfig(config={}, defaultConfig=this.defaultConfig()){
-    return Object.assign(defaultConfig, config);z
+    return Object.assign(defaultConfig, config);
   }
 
-
-  defaultConfig(){
-
-    return {
-
-
-    }
-
-  }
-
-
-
   static getSpyneApp(name, config){
-   // const win = window || {};
-   // let spyneApp = prop('Spyne', win) ;
-   // const spyneInitialized = typeof(spyneApp) === 'object';
-    //console.log('spyne app is ',{spyneApp, spyneInitialized}, typeof(spyneApp));
-
-   // spyneApp = spyneInitialized === true ? spyneApp : new spyneApp();
     if(SpyneAppProperties.initialized===false){
-      SpyneApp.init()
-    }
-
-
-    SpyneAppProperties.addPluginConfig(name, config);
-
-   /*  const updateConfig = SpynePlugin.updateSpyneConfig(spyneApp, name, config);
 
-     if(updateConfig===false){
-       return false;
-     }*/
+      console.warn(`Spyne Warning: Unable to install plugin, ${name}! SpyneApp has not been initialized!`);
+       //SpyneApp.init()
+    } else{
+      SpyneAppProperties.addPluginConfig(name, config);
+    }
 
-   // spyneApp.config.plugins[name] = config;
-    //return spyneApp;
   }
 
+
   static updateSpyneConfig(spyneApp, pluginName, pluginConfig){
     const pathExists = pathSatisfies(is(Object), ['config', 'plugins', pluginName])(spyneApp);
-   // console.log('path exists ',{pathExists}, spyneApp.config.plugins[pluginName])
 
     if (pathExists===true){
       if (spyneApp.config.debug===true) {
@@ -130,6 +75,32 @@ export class SpynePlugin {
     return el || createPluginParentEl();
   }
 
+  addTraits(traits){
+    if (traits.constructor.name!=='Array'){
+      traits = [traits];
+    }
+    const addTrait=(TraitClass)=>{
+      return new TraitClass(this);
+    };
+
+    traits.forEach(addTrait);
+
+  }
+
+  onBeforeRegistered(){
+    this.props.pluginName = this.props.name;
+    this.props.config = SpyneAppProperties.getPluginConfigByPluginName(this.props.pluginName);
+  }
+
+  defaultConfig(){
+
+    return {
+
+
+    }
+
+  }
+
   onRegistered(){
 
 

package/src/spyne/spyne.js

@@ -17,7 +17,6 @@ import { deepMerge } from './utils/deep-merge';
 import {SpyneAppProperties} from './utils/spyne-app-properties';
 import {SpyneApp} from './spyne-app';
 
-//window['Spyne'] = SpyneApp;
 export {
   ViewStreamElement,
   Channel,

package/src/spyne/utils/channel-config-validator.js

@@ -1,6 +1,5 @@
 import Validation from 'data.validation';
 import {curry, curryN, length, always, reduce} from 'ramda';
-// import { curry, curryN, reduce, length, always } from 'ramda';
 const success = Validation.Success;
 const failure = Validation.Failure;
 let validate = () => {};