spine-rigc 2.49.0 → 2.51.0

package/src/validate.ts

@@ -77,14 +77,13 @@ import {
   walkTimelines,
 } from './timelines.ts';
 import type { RigInfo } from './types.ts';
-import { ASSERTION_KIND, kindRunsUnder, type AssertionProfile } from './assertions/kinds.ts';
+import { ASSERTION_KIND, kindRunsUnder, resolveProfile, type AssertionProfile } from './assertions/kinds.ts';
 import { verdictHarness, type Failure } from './assertions/harness.ts';
 import { isObj, type Json } from './assertions/values.ts';
 import type { SkinEntryFacts } from './assertions/facts/skin_entries.ts';
 import type { AtlasPageFacts } from './assertions/facts/atlas_pages.ts';
 import type { SlotColourFacts, SlotTimelines } from './assertions/facts/slot_colour.ts';
 import { a03RegionWidthHeightFinite } from './assertions/bodies/a03.ts';
-import { a11NoClippingAttachments } from './assertions/bodies/a11.ts';
 import { a17AtlasPageFilesExist } from './assertions/bodies/a17.ts';
 import { a18DeterministicEmit } from './assertions/bodies/a18.ts';
 import { a45SeparableColorTimelinesOwnTheirChannelsAndPoseAsWritten } from './assertions/bodies/a45.ts';
@@ -108,7 +107,6 @@ import { a50StageBoxIsTheStage } from './assertions/bodies/a50.ts';
 import { a51BonesLieAlongTheirDeclaredAxis } from './assertions/bodies/a51.ts';
 import { inactiveAtSetup, type SetupWorldFacts } from './assertions/facts/setup_world.ts';
 import { SKIP_NO_STAGE_BOX, type StageBoxFacts } from './assertions/facts/stage_box.ts';
-import { a27RegionNameMatchesPageFilename } from './assertions/bodies/a27.ts';
 import type { MeshEntry as MeshAttachmentEntry, MeshFacts } from './assertions/facts/mesh_attachments.ts';
 import type { ClipEnd, PolygonEntry, PolygonFacts } from './assertions/facts/vertex_polygons.ts';
 import type { LinkEntry, LinkFacts } from './assertions/facts/linked_meshes.ts';
@@ -168,14 +166,14 @@ export type { Failure } from './assertions/harness.ts';
  * ⭐ The distinction this draws is the difference between "wrong" and "not how we
  * do it here", and conflating the two is how a validator stops being usable on
  * anybody else's data. Fifteen of the 40 assertions are policy — seven for one
- * renderer (`spine-html`) and one project's canvas budget, eight for rigc's own
+ * renderer (`rig-play`) and one project's canvas budget, eight for rigc's own
  * formations — and every one of them fires
  * on real, correct, editor-produced Spine data — the official example projects
  * carry clipping attachments, unweighted meshes, 116-triangle meshes and packed
  * atlases, all of which are perfectly valid and none of which spine-html likes.
  *
  * - `spine`      — is this valid Spine 4.3 that any runtime will play correctly?
- * - `spine-html` — the above, plus this project's renderer and archetype policy.
+ * - `rig-play`   — the above, plus this project's renderer and archetype policy.
  *
  * ⚠️ `validate()` has NO default profile — `ValidateInput.profile` is required,
  * and that is deliberate. A silent default here can only be wrong in one of two
@@ -207,7 +205,7 @@ export const ASSERTION_NAMES: readonly string[] = Object.keys(ASSERTION_KIND);
 
 /** How many assertions this profile applies, by the kinds it carries. */
 export function assertionCountForProfile(profile: ValidateProfile): number {
-  if (profile === 'spine-html') return ASSERTION_NAMES.length;
+  if (profile === 'rig-play') return ASSERTION_NAMES.length;
   return ASSERTION_NAMES.filter((name) => ASSERTION_KIND[name] === 'validity').length;
 }
 
@@ -846,14 +844,12 @@ export function timelineAddCells(data: ReturnType<SkeletonJson['readSkeletonData
  */
 export function spineSkinEntries(data: ReturnType<SkeletonJson['readSkeletonData']>): SkinEntryFacts {
   const regionAttachments: RegionAttachment[] = [];
-  let clippingCount = 0;
   for (const skin of data.skins) {
     for (const entry of skin.getAttachments()) {
       if (entry.attachment instanceof RegionAttachment) regionAttachments.push(entry.attachment);
-      else if (entry.attachment instanceof ClippingAttachment) clippingCount++;
     }
   }
-  return { regionAttachments, clippingCount };
+  return { regionAttachments };
 }
 
 /**
@@ -2012,9 +2008,10 @@ function once<T>(supply: () => T): () => T {
 }
 
 export function validate(input: ValidateInput): ValidateReport {
-  const profile = input.profile;
+  // A former name reads as its profile (issue #1277): the policy switch below and the report both use the resolved one.
+  const profile = resolveProfile(input.profile, 'validate');
   /** True when this profile's rulebook includes the policy layer. */
-  const policy = profile === 'spine-html';
+  const policy = profile === 'rig-play';
   // The harness — `check`, `fail`, `skip` and the lists they fill — is
   // `./assertions/harness.ts`'s since issue #1025, and the rule is the one it
   // always was: the model side runs the bodies that moved there in the same
@@ -2566,7 +2563,7 @@ export function validate(input: ValidateInput): ValidateReport {
   });
 
   // --- A12: no dark / two-colour tint --------------------------------------
-  // Parsed, then silently ignored by spine-html.
+  // Parsed, then ignored by rig-play's DOM mode.
   check('A12_NO_DARK_COLOR', () => a12NoDarkColor(verdicts, rawSkeletonRoster(raw), rawSlotTimelines(raw)));
 
   // --- A05: curve arrays are 4 numbers per value channel --------------------
@@ -2667,8 +2664,9 @@ export function validate(input: ValidateInput): ValidateReport {
     // `./assertions/bodies/a33.ts` (issue #1025, cut 4c-2).
     check('A33_VERTEX_ATTACHMENT_GEOMETRY', () => a33VertexAttachmentGeometry(verdicts, polygonFacts()));
 
-    // --- A11 / A13 / A14: renderer + canvas budgets ----
-    check('A11_NO_CLIPPING_ATTACHMENTS', () => a11NoClippingAttachments(verdicts, skinEntries));
+    // --- A13 / A14: canvas budgets ----
+    // A11 stood here until issue #1404 retired it: the player `rig-play` names
+    // draws a clipping attachment in both of its modes.
     // 📐 The two numbers come from the rig spec's `invariants`, never from here.
     // A mesh budget is one consumer's frame time written down — the editor's own
     // example projects ship meshes many times denser and they are valid — so a
@@ -3309,7 +3307,7 @@ export function validate(input: ValidateInput): ValidateReport {
   // first build — and told them, untruthfully, that the file held no transparency
   // at all. That audit is also why the CLI's default is now `spine`, which does
   // not run this rule at all (#221): a stranger reaches this refusal only by
-  // asking for `spine-html`. It still has to be both TRUE and actionable when it
+  // asking for `rig-play`. It still has to be both TRUE and actionable when it
   // fires, and it now has to name the profile it belongs to as well as the one
   // that does not ask — the reader opted in, and the message is where they find
   // out what they opted into.
@@ -3385,15 +3383,11 @@ export function validate(input: ValidateInput): ValidateReport {
   // what a `drawOrder` key's offsets are counted against.
   check('A26_SLOT_DRAW_ORDER', () => a26SlotDrawOrder(verdicts, rawSkeletonRoster(raw), input));
 
-  // --- A27: region name == the PNG's basename ------------------------------
-  //
-  // The join key is a chain of three names — attachment -> atlas region -> file —
-  // and A08 only holds the first link. The second was held by convention alone:
-  // an atlas could declare page `../plates/02_overlay.png` with a region
-  // called anything at all, every attachment could agree with it, and the rig
-  // would load with the wrong pixels under the right name. One part per page (A06
-  // forces it) makes the check exact.
-  check('A27_REGION_NAME_MATCHES_PAGE_FILENAME', () => a27RegionNameMatchesPageFilename(verdicts, { atlas }));
+  // A27 stood here until issue #1404 retired it. It held a page's only region
+  // to the page's file basename, a join no reader makes: spine-core and the
+  // player `rig-play` names both take a region off the page record the atlas
+  // states it under, and the player draws a region on a page named for
+  // something else in both of its modes.
 
   // --- A28: a ribbon's rows share their weights ----------------------------
   //

package/src/assertions/bodies/a11.ts

@@ -1,15 +0,0 @@
-/**
- * A11, the body (issue #1025, step 4c of #380): no clipping attachment — the
- * renderer skips them silently. A `renderer` rule, so `spine` never runs it.
- *
- * Moved out of `src/validate.ts` unchanged but for what it reads: the count is
- * a fact (`../facts/skin_entries.ts`).
- */
-import type { Verdicts } from '../harness.ts';
-import type { SkinEntryFacts } from '../facts/skin_entries.ts';
-
-export function a11NoClippingAttachments({ fail }: Verdicts, { clippingCount }: SkinEntryFacts): void {
-  if (clippingCount > 0) {
-    fail('A11_NO_CLIPPING_ATTACHMENTS', `${clippingCount} clipping attachment(s); the renderer skips them silently`);
-  }
-}

package/src/assertions/bodies/a27.ts

@@ -1,33 +0,0 @@
-/**
- * A27, the body (issue #1025, step 4c of #380): the only region on a page is
- * named for the page's file.
- *
- * Moved out of `src/validate.ts` unchanged but for what it reads: the regions
- * are a fact (`../facts/atlas_regions.ts`). Why the second link of the
- * attachment -> region -> file chain needs holding stays above the `check`
- * call in `validate()`.
- */
-import { basename } from 'node:path';
-import type { Verdicts } from '../harness.ts';
-import type { AtlasRegionFacts } from '../facts/atlas_regions.ts';
-import { SKIP_NO_ATLAS, SKIP_NO_ATLAS_REGION } from '../reasons.ts';
-
-export function a27RegionNameMatchesPageFilename({ fail, skip }: Verdicts, { atlas }: AtlasRegionFacts): void {
-  if (!atlas) return skip('A27_REGION_NAME_MATCHES_PAGE_FILENAME', SKIP_NO_ATLAS);
-  if (atlas.regions.length === 0) return skip('A27_REGION_NAME_MATCHES_PAGE_FILENAME', SKIP_NO_ATLAS_REGION);
-  const perPage = new Map<string, number>();
-  for (const region of atlas.regions) perPage.set(region.page.name, (perPage.get(region.page.name) ?? 0) + 1);
-  for (const region of atlas.regions) {
-    // A real packer puts many regions on one page and the names stop matching
-    // filenames by design. Then this check has nothing to say, so it says
-    // nothing rather than something wrong.
-    if ((perPage.get(region.page.name) ?? 0) !== 1) continue;
-    const expected = basename(region.page.name).replace(/\.png$/i, '');
-    if (region.name !== expected) {
-      fail(
-        'A27_REGION_NAME_MATCHES_PAGE_FILENAME',
-        `region "${region.name}" is the only region on page "${region.page.name}", whose basename is "${expected}"`,
-      );
-    }
-  }
-}