spine-framework 0.4.4 → 0.5.0-rc.4

package/.framework/src/components/app-shell/GenericListPage.tsx

@@ -14,15 +14,14 @@ import { DataStats } from '../runtime/DataStats'
 import { DataFilters } from '../runtime/DataFilters'
 import { DataTable } from '../runtime/DataTable'
 import { PageInstructions } from '../admin/PageInstructions'
+// CIL[END stable_id="~/.framework/src/components/app-shell/GenericListPage.tsx:module_header:module_header"]
 // CIL[DOC-VECTOR type="context" content="purpose='Imports and module setup for the generic list page'; No verified external callers; imports: .framework/src/hooks/useListSchema.ts,.framework/src/hooks/useEntityList.ts,.framework/src/components/runtime/DataHeader.tsx"]
 // CIL[DOC-VECTOR type="blast_radius" content="No direct caller data from CIL graph; local impact only"]
 // CIL[DOC-VECTOR type="configuration" content="No environment or build configuration dependencies identified"]
 // CIL[DOC-VECTOR type="constraint" content="Standard runtime; no special invariants documented"]
 // CIL[DOC-VECTOR type="implementation_pattern" content="" status="pending_human_input"]
 // CIL[DOC-VECTOR type="user_journey" content="" status="pending_human_input"]
-// CIL[END stable_id="~/.framework/src/components/app-shell/GenericListPage.tsx:module_header:module_header"]
 
-// CIL[BEGIN stable_id="~/.framework/src/components/app-shell/GenericListPage.tsx:genericlistpageprops:interface" type="interface" identity="genericlistpageprops" parent="~/.framework/src/components/app-shell/GenericListPage.tsx"]
 // CIL[DOC-MACRO purpose="Props interface for GenericListPage"]
 // CIL[DOC-RESPONSIBILITY responsibility="Define the expected props for the list page"]
 // CIL[DOC-CONTEXT module="app-shell" layer="framework" related_files=".framework/src/components/admin/PageInstructions.tsx,.framework/src/components/app-shell/GenericListPage.tsx,.framework/src/components/runtime/DataFilters.tsx,.framework/src/components/runtime/DataHeader.tsx,.framework/src/components/runtime/DataStats.tsx,.framework/src/components/runtime/DataTable.tsx,.framework/src/hooks/useEntityList.ts,.framework/src/hooks/useListSchema.ts"]
@@ -30,21 +29,21 @@ import { PageInstructions } from '../admin/PageInstructions'
 // CIL[DOC-MICRO logic_summary="TypeScript interface describing typeSlug, viewSlug, appPrefix, and detailPath" notable_decisions="[]"]
 // CIL[DOC-CONFIDENCE pass="second" score="0.90" flags="none"]
 // CIL[DOC-STABILITY stability="stable"]
+// CIL[BEGIN stable_id="~/.framework/src/components/app-shell/GenericListPage.tsx:GenericListPageProps:interface" type="interface" identity="GenericListPageProps" parent="~/.framework/src/components/app-shell/GenericListPage.tsx"]
 interface GenericListPageProps {
   typeSlug: string
   viewSlug?: string
   appPrefix: string
   detailPath: string
 }
+// CIL[END stable_id="~/.framework/src/components/app-shell/GenericListPage.tsx:GenericListPageProps:interface"]
 // CIL[DOC-VECTOR type="context" content="purpose='Props interface for GenericListPage'; No verified external callers; imports: .framework/src/hooks/useListSchema.ts,.framework/src/hooks/useEntityList.ts,.framework/src/components/runtime/DataHeader.tsx"]
 // CIL[DOC-VECTOR type="blast_radius" content="No direct caller data from CIL graph; local impact only"]
 // CIL[DOC-VECTOR type="configuration" content="No environment or build configuration dependencies identified"]
 // CIL[DOC-VECTOR type="constraint" content="Standard runtime; no special invariants documented"]
 // CIL[DOC-VECTOR type="implementation_pattern" content="" status="pending_human_input"]
 // CIL[DOC-VECTOR type="user_journey" content="" status="pending_human_input"]
-// CIL[END stable_id="~/.framework/src/components/app-shell/GenericListPage.tsx:genericlistpageprops:interface"]
 
-// CIL[BEGIN stable_id="~/.framework/src/components/app-shell/GenericListPage.tsx:genericlistpage:function" type="function" identity="genericlistpage" parent="~/.framework/src/components/app-shell/GenericListPage.tsx"]
 // CIL[DOC-MACRO purpose="Render the generic list page for an app type"]
 // CIL[DOC-RESPONSIBILITY responsibility="Display a sortable, filterable data table with schema-driven headers, stats, filters, and instructions"]
 // CIL[DOC-CONTEXT module="app-shell" layer="framework" related_files=".framework/src/components/admin/PageInstructions.tsx,.framework/src/components/app-shell/GenericListPage.tsx,.framework/src/components/runtime/DataFilters.tsx,.framework/src/components/runtime/DataHeader.tsx,.framework/src/components/runtime/DataStats.tsx,.framework/src/components/runtime/DataTable.tsx,.framework/src/hooks/useEntityList.ts,.framework/src/hooks/useListSchema.ts"]
@@ -52,6 +51,7 @@ interface GenericListPageProps {
 // CIL[DOC-MICRO logic_summary="Resolve the list schema, build a config, load entity data, and render the list page with header, instructions, stats, filters, and table" notable_decisions="[]"]
 // CIL[DOC-CONFIDENCE pass="second" score="0.90" flags="none"]
 // CIL[DOC-STABILITY stability="stable"]
+// CIL[BEGIN stable_id="~/.framework/src/components/app-shell/GenericListPage.tsx:GenericListPage:component" type="component" identity="GenericListPage" parent="~/.framework/src/components/app-shell/GenericListPage.tsx"]
 export function GenericListPage({ typeSlug, viewSlug, appPrefix, detailPath }: GenericListPageProps) {
   const resolvedViewSlug = viewSlug || 'default_list'
 
@@ -61,8 +61,13 @@ export function GenericListPage({ typeSlug, viewSlug, appPrefix, detailPath }: G
     viewSlug: resolvedViewSlug
   })
 
+  // nav_item `view` is a single slug shared by list + detail pages; a
+  // detail-shaped view (sections, no fields) must not resolve here.
+  const resolvedListView = view && ((view as any).type === 'list' || (view as any).fields)
+    ? view
+    : schema?.views?.default_list ?? view
 
-  const config = view && schema ? {
+  const config = resolvedListView && schema ? {
     entity: 'items',
     typeSlug,
     icon: 'database',
@@ -71,12 +76,22 @@ export function GenericListPage({ typeSlug, viewSlug, appPrefix, detailPath }: G
       listAction: 'list'
     },
     list: {
-      defaultSort: (view as any).default_sort || { field: 'created_at', direction: 'desc' },
-      stats: (view as any).stats || [],
-      filters: (view as any).filters || [],
-      columns: Object.entries((view as any).fields || {}).map(([key, fieldConfig]: [string, any]) => ({
+      defaultSort: (resolvedListView as any).default_sort || { field: 'created_at', direction: 'desc' },
+      stats: (resolvedListView as any).stats || [],
+      // Docs allow bare field-name strings; DataFilters needs full
+      // EntityFilter objects, so normalize strings against the schema.
+      filters: ((resolvedListView as any).filters || []).map((f: any) => {
+        if (typeof f !== 'string') return f
+        const field: any = (schema.fields as any)?.[f] || (schema.fields as any)?.[f.replace(/^data\./, '')] || {}
+        const options = (field.options || []).map((o: any) => (typeof o === 'string' ? o : o.value))
+        const type = field.data_type === 'boolean' || field.data_type === 'checkbox'
+          ? 'boolean'
+          : options.length ? 'enum' : 'search'
+        return { key: f, label: field.label || f, type, options: options.length ? options : undefined }
+      }),
+      columns: Object.entries((resolvedListView as any).fields || {}).map(([key, fieldConfig]: [string, any]) => ({
         key,
-        label: schema.fields[key]?.label || key,
+        label: schema.fields[key]?.label || schema.fields[key.replace(/^data\./, '')]?.label || key,
         sortable: fieldConfig.sortable !== false,
         display_type: fieldConfig.display_type
       }))
@@ -115,32 +130,13 @@ export function GenericListPage({ typeSlug, viewSlug, appPrefix, detailPath }: G
   return (
     <div className="space-y-6">
       <DataHeader
-        title={schema?.fields ? Object.keys(schema.fields).length > 0 ? (view as any)?.label || typeSlug : typeSlug : typeSlug}
+        title={schema?.fields ? Object.keys(schema.fields).length > 0 ? (resolvedListView as any)?.label || typeSlug : typeSlug : typeSlug}
         icon={config.icon}
         description={`Manage ${typeSlug}`}
         newButtonHref={`${appPrefix}/${detailPath}/new`}
       />
 
-      <PageInstructions
-        sections={[
-          {
-            title: 'What this page is for',
-            content: `This page lists all ${typeSlug} records for this app. It displays the stored records, their field values, and current status based on the app type schema.`,
-          },
-          {
-            title: 'How to find records',
-            content: `Use the filters above the table to narrow results. Click any column header to sort ascending or descending. The available columns and filters are defined by the type's design schema.`,
-          },
-          {
-            title: 'How to create, view, and edit records',
-            content: `Click the New button in the top-right to create a new ${typeSlug}. Click any row to open its detail view. From the detail view you can edit field values or delete the record. Permissions may restrict which actions are available to your role.`,
-          },
-          {
-            title: 'Understanding the stats',
-            content: `The cards above the table show summary counts and key metrics for this record type. Use them to quickly assess volume and status before drilling into the list.`,
-          },
-        ]}
-      />
+      <PageInstructions pageKey="runtime-list" />
 
       <DataStats
         stats={config.list.stats}
@@ -170,10 +166,10 @@ export function GenericListPage({ typeSlug, viewSlug, appPrefix, detailPath }: G
     </div>
   )
 }
+// CIL[END stable_id="~/.framework/src/components/app-shell/GenericListPage.tsx:GenericListPage:component"]
 // CIL[DOC-VECTOR type="context" content="purpose='Render the generic list page for an app type'; No verified external callers; imports: .framework/src/hooks/useListSchema.ts,.framework/src/hooks/useEntityList.ts,.framework/src/components/runtime/DataHeader.tsx"]
 // CIL[DOC-VECTOR type="blast_radius" content="No direct caller data from CIL graph; local impact only"]
 // CIL[DOC-VECTOR type="configuration" content="No environment or build configuration dependencies identified"]
 // CIL[DOC-VECTOR type="constraint" content="Standard runtime; no special invariants documented"]
 // CIL[DOC-VECTOR type="implementation_pattern" content="" status="pending_human_input"]
 // CIL[DOC-VECTOR type="user_journey" content="" status="pending_human_input"]
-// CIL[END stable_id="~/.framework/src/components/app-shell/GenericListPage.tsx:genericlistpage:function"]