spine-framework 0.4.3 → 0.5.0-rc.4

package/.framework/migrations/072_slug_autofill.sql

@@ -0,0 +1,77 @@
+-- 072_slug_autofill.sql
+-- Fill slug from name on insert when the caller omits it.
+-- Fresh-install schema (001) declares slug NOT NULL on these tables, but the
+-- create handlers for triggers/timers/pipelines/ai_agents/test_runs/
+-- item_progress/invites never write slug — inserts fail on fresh chains.
+-- The trigger is a no-op whenever the caller supplies a slug.
+
+CREATE OR REPLACE FUNCTION public.spine_fill_slug()
+RETURNS trigger
+LANGUAGE plpgsql
+AS $$
+DECLARE
+  base text;
+  candidate text;
+  clash boolean;
+  i int := 2;
+BEGIN
+  IF NEW.slug IS NOT NULL AND NEW.slug <> '' THEN
+    RETURN NEW;
+  END IF;
+
+  base := trim(both '_' from regexp_replace(lower(coalesce(NEW.name, '')), '[^a-z0-9]+', '_', 'g'));
+  IF base = '' THEN
+    base := 'row';
+  END IF;
+  candidate := base;
+
+  LOOP
+    EXECUTE format(
+      'SELECT EXISTS (SELECT 1 FROM %I.%I WHERE app_id IS NOT DISTINCT FROM $1 AND slug = $2)',
+      TG_TABLE_SCHEMA, TG_TABLE_NAME
+    ) INTO clash USING NEW.app_id, candidate;
+    EXIT WHEN NOT clash;
+    candidate := base || '_' || i;
+    i := i + 1;
+    IF i > 100 THEN
+      candidate := base || '_' || substr(replace(gen_random_uuid()::text, '-', ''), 1, 6);
+      EXECUTE format(
+        'SELECT EXISTS (SELECT 1 FROM %I.%I WHERE app_id IS NOT DISTINCT FROM $1 AND slug = $2)',
+        TG_TABLE_SCHEMA, TG_TABLE_NAME
+      ) INTO clash USING NEW.app_id, candidate;
+      EXIT WHEN NOT clash;
+    END IF;
+  END LOOP;
+
+  NEW.slug := candidate;
+  RETURN NEW;
+END;
+$$;
+
+DROP TRIGGER IF EXISTS spine_fill_slug_trg ON public.triggers;
+CREATE TRIGGER spine_fill_slug_trg BEFORE INSERT ON public.triggers
+  FOR EACH ROW EXECUTE FUNCTION public.spine_fill_slug();
+
+DROP TRIGGER IF EXISTS spine_fill_slug_trg ON public.timers;
+CREATE TRIGGER spine_fill_slug_trg BEFORE INSERT ON public.timers
+  FOR EACH ROW EXECUTE FUNCTION public.spine_fill_slug();
+
+DROP TRIGGER IF EXISTS spine_fill_slug_trg ON public.pipelines;
+CREATE TRIGGER spine_fill_slug_trg BEFORE INSERT ON public.pipelines
+  FOR EACH ROW EXECUTE FUNCTION public.spine_fill_slug();
+
+DROP TRIGGER IF EXISTS spine_fill_slug_trg ON public.ai_agents;
+CREATE TRIGGER spine_fill_slug_trg BEFORE INSERT ON public.ai_agents
+  FOR EACH ROW EXECUTE FUNCTION public.spine_fill_slug();
+
+DROP TRIGGER IF EXISTS spine_fill_slug_trg ON public.test_runs;
+CREATE TRIGGER spine_fill_slug_trg BEFORE INSERT ON public.test_runs
+  FOR EACH ROW EXECUTE FUNCTION public.spine_fill_slug();
+
+DROP TRIGGER IF EXISTS spine_fill_slug_trg ON public.item_progress;
+CREATE TRIGGER spine_fill_slug_trg BEFORE INSERT ON public.item_progress
+  FOR EACH ROW EXECUTE FUNCTION public.spine_fill_slug();
+
+DROP TRIGGER IF EXISTS spine_fill_slug_trg ON public.invites;
+CREATE TRIGGER spine_fill_slug_trg BEFORE INSERT ON public.invites
+  FOR EACH ROW EXECUTE FUNCTION public.spine_fill_slug();

package/.framework/migrations/073_seed_member_roles.sql

@@ -0,0 +1,26 @@
+-- 073_seed_member_roles.sql
+-- Seed the member and member_admin end-user roles.
+--
+-- F-066: 003_core_system_data.sql seeds system_admin plus the department
+-- roles but never member/member_admin, even though the platform assumes
+-- they exist:
+--   * 003's own thread/message types grant record_permissions to both
+--   * 060 grants them CRU on account/person; 051/007 grant member reads
+--   * the registration RPCs (052/059) default join_request to 'member'
+--   * RegisterPage falls back to 'member'; the admin UI defaults app
+--     min_role to 'member'; create-app defaults --role member
+-- With no roles row the slug never resolves, so every member grant was a
+-- dead key (guaranteed-deny) and apps scaffolded with the default --role
+-- wrote a min_role no person could satisfy.
+--
+-- is_system stays false: invites.ts resolveRoleId and the invite-accept
+-- path reject is_system role slugs, and these are the self-service
+-- end-user roles (same shape the app seed/roles.json files carry).
+-- App installs upsert the same slugs (conflict 'slug'), so ON CONFLICT
+-- DO NOTHING keeps this a no-op wherever an app already claimed them.
+
+INSERT INTO public.roles (id, slug, name, description, permissions, is_system, is_active, is_protected, app_id, account_id)
+VALUES
+  (gen_random_uuid(), 'member',       'Member',       'Standard account member — end-user access to account-scoped apps',                 '["*"]'::jsonb, false, true, false, NULL, NULL),
+  (gen_random_uuid(), 'member_admin', 'Member Admin', 'Member administrator — same access as member plus invite and member management', '["*"]'::jsonb, false, true, false, NULL, NULL)
+ON CONFLICT (slug) DO NOTHING;

package/.framework/schemas/spine.config.schema.json

@@ -0,0 +1,62 @@
+{
+  "$schema": "http://json-schema.org/draft-07/schema#",
+  "$id": "https://spine-framework.dev/schemas/spine.config.schema.json",
+  "title": "Spine Framework instance config",
+  "type": "object",
+  "additionalProperties": true,
+  "properties": {
+    "branding": {
+      "type": "object",
+      "additionalProperties": false,
+      "description": "Instance branding applied to framework-owned pages (login, register, setup, sidebars) plus document.title and favicon. All keys optional; absent block falls back to Spine defaults.",
+      "properties": {
+        "app_name": {
+          "type": "string",
+          "description": "Display name used in headings and logo alt text, e.g. 'Answer Once'"
+        },
+        "title": {
+          "type": "string",
+          "description": "document.title and sidebar wordmark; defaults to app_name"
+        },
+        "logo_url": {
+          "type": "string",
+          "description": "Public asset path for the brand logo, e.g. '/answer-once-logo.svg'"
+        },
+        "favicon_url": {
+          "type": "string",
+          "description": "Public asset path swapped into link[rel=icon] at runtime"
+        }
+      }
+    },
+    "registration": {
+      "type": "object",
+      "additionalProperties": true,
+      "properties": {
+        "default_app": { "type": "string" },
+        "default_role": { "type": "string" },
+        "allow_url_override": { "type": "boolean" },
+        "default_app_by_role": {
+          "type": "object",
+          "additionalProperties": { "type": "string" }
+        },
+        "apps": {
+          "type": "object",
+          "additionalProperties": {
+            "type": "object",
+            "additionalProperties": true,
+            "properties": {
+              "roles": { "type": "array", "items": { "type": "string" } },
+              "default_role": { "type": "string" },
+              "path": { "type": "string" },
+              "enabled": { "type": "boolean" },
+              "account_strategy": { "type": "string", "enum": ["new", "existing"] },
+              "parent_account": { "type": "string" },
+              "target_account": { "type": "string" },
+              "allow_domain_join": { "type": "boolean" }
+            }
+          }
+        }
+      }
+    }
+  }
+}

package/.framework/src/App.tsx

@@ -14,6 +14,7 @@
 import { Suspense, lazy, useEffect } from 'react'
 import { Routes, Route, Navigate, useNavigate, useLocation } from 'react-router-dom'
 import { useAuth } from './contexts/AuthContext'
+import { useBranding } from './hooks/useBranding'
 import { LoadingSpinner } from './components/ui/LoadingSpinner'
 import { LoginPage } from './pages/auth/LoginPage'
 import { RegisterPage } from './pages/auth/RegisterPage'
@@ -65,13 +66,14 @@ const AdminApp = lazy(() => import('./apps/admin/index'))
 // CIL[DOC-NOTE type="change" content="Batch4b: authenticated-but-unplaced users (falsy account_id, not pending) are routed to /register?resume=1 for all paths so RegisterPage can finish placement — they no longer fall through to NotFound"]
 function App() {
   const { user, isLoading } = useAuth()
+  const branding = useBranding()
 
   if (isLoading) {
     return (
       <div className="min-h-screen flex items-center justify-center bg-slate-50">
         <div className="text-center">
           <LoadingSpinner className="w-8 h-8 mx-auto mb-4" />
-          <p className="text-slate-600">Loading Spine...</p>
+          <p className="text-slate-600">Loading {branding.app_name}...</p>
         </div>
       </div>
     )