spindb 0.9.1 → 0.9.3

package/cli/commands/connect.ts

@@ -22,7 +22,7 @@ import {
 import { getEngine } from '../../engines'
 import { getEngineDefaults } from '../../config/defaults'
 import { promptContainerSelect } from '../ui/prompts'
-import { error, warning, info, success } from '../ui/theme'
+import { uiError, uiWarning, uiInfo, uiSuccess } from '../ui/theme'
 import { Engine } from '../../types'
 
 export const connectCommand = new Command('connect')
@@ -78,11 +78,13 @@ export const connectCommand = new Command('connect')
           if (connectable.length === 0) {
             if (containers.length === 0) {
               console.log(
-                warning('No containers found. Create one with: spindb create'),
+                uiWarning(
+                  'No containers found. Create one with: spindb create',
+                ),
               )
             } else {
               console.log(
-                warning(
+                uiWarning(
                   'No running containers. Start one first with: spindb start',
                 ),
               )
@@ -100,7 +102,7 @@ export const connectCommand = new Command('connect')
 
         const config = await containerManager.getConfig(containerName)
         if (!config) {
-          console.error(error(`Container "${containerName}" not found`))
+          console.error(uiError(`Container "${containerName}" not found`))
           process.exit(1)
         }
 
@@ -114,9 +116,7 @@ export const connectCommand = new Command('connect')
         if (engineName === Engine.SQLite) {
           if (!existsSync(config.database)) {
             console.error(
-              error(
-                `SQLite database file not found: ${config.database}`,
-              ),
+              uiError(`SQLite database file not found: ${config.database}`),
             )
             process.exit(1)
           }
@@ -127,7 +127,7 @@ export const connectCommand = new Command('connect')
           })
           if (!running) {
             console.error(
-              error(
+              uiError(
                 `Container "${containerName}" is not running. Start it first.`,
               ),
             )
@@ -145,17 +145,17 @@ export const connectCommand = new Command('connect')
           if (!usqlInstalled) {
             if (options.installTui) {
               console.log(
-                info('Installing usql for enhanced shell experience...'),
+                uiInfo('Installing usql for enhanced shell experience...'),
               )
               const pm = await detectPackageManager()
               if (pm) {
                 const result = await installUsql(pm)
                 if (result.success) {
-                  console.log(success('usql installed successfully!'))
+                  console.log(uiSuccess('usql installed successfully!'))
                   console.log()
                 } else {
                   console.error(
-                    error(`Failed to install usql: ${result.error}`),
+                    uiError(`Failed to install usql: ${result.error}`),
                   )
                   console.log()
                   console.log(chalk.gray('Manual installation:'))
@@ -165,7 +165,7 @@ export const connectCommand = new Command('connect')
                   process.exit(1)
                 }
               } else {
-                console.error(error('No supported package manager found'))
+                console.error(uiError('No supported package manager found'))
                 console.log()
                 console.log(chalk.gray('Manual installation:'))
                 for (const instruction of getUsqlManualInstructions()) {
@@ -174,7 +174,7 @@ export const connectCommand = new Command('connect')
                 process.exit(1)
               }
             } else {
-              console.error(error('usql is not installed'))
+              console.error(uiError('usql is not installed'))
               console.log()
               console.log(
                 chalk.gray('Install usql for enhanced shell experience:'),
@@ -194,7 +194,7 @@ export const connectCommand = new Command('connect')
         if (usePgcli) {
           if (engineName !== 'postgresql') {
             console.error(
-              error('pgcli is only available for PostgreSQL containers'),
+              uiError('pgcli is only available for PostgreSQL containers'),
             )
             console.log(chalk.gray('For MySQL, use: spindb connect --mycli'))
             process.exit(1)
@@ -205,17 +205,17 @@ export const connectCommand = new Command('connect')
           if (!pgcliInstalled) {
             if (options.installPgcli) {
               console.log(
-                info('Installing pgcli for enhanced PostgreSQL shell...'),
+                uiInfo('Installing pgcli for enhanced PostgreSQL shell...'),
               )
               const pm = await detectPackageManager()
               if (pm) {
                 const result = await installPgcli(pm)
                 if (result.success) {
-                  console.log(success('pgcli installed successfully!'))
+                  console.log(uiSuccess('pgcli installed successfully!'))
                   console.log()
                 } else {
                   console.error(
-                    error(`Failed to install pgcli: ${result.error}`),
+                    uiError(`Failed to install pgcli: ${result.error}`),
                   )
                   console.log()
                   console.log(chalk.gray('Manual installation:'))
@@ -225,7 +225,7 @@ export const connectCommand = new Command('connect')
                   process.exit(1)
                 }
               } else {
-                console.error(error('No supported package manager found'))
+                console.error(uiError('No supported package manager found'))
                 console.log()
                 console.log(chalk.gray('Manual installation:'))
                 for (const instruction of getPgcliManualInstructions()) {
@@ -234,7 +234,7 @@ export const connectCommand = new Command('connect')
                 process.exit(1)
               }
             } else {
-              console.error(error('pgcli is not installed'))
+              console.error(uiError('pgcli is not installed'))
               console.log()
               console.log(
                 chalk.gray('Install pgcli for enhanced PostgreSQL shell:'),
@@ -253,7 +253,9 @@ export const connectCommand = new Command('connect')
         const useMycli = options.mycli || options.installMycli
         if (useMycli) {
           if (engineName !== 'mysql') {
-            console.error(error('mycli is only available for MySQL containers'))
+            console.error(
+              uiError('mycli is only available for MySQL containers'),
+            )
             console.log(
               chalk.gray('For PostgreSQL, use: spindb connect --pgcli'),
             )
@@ -264,16 +266,18 @@ export const connectCommand = new Command('connect')
 
           if (!mycliInstalled) {
             if (options.installMycli) {
-              console.log(info('Installing mycli for enhanced MySQL shell...'))
+              console.log(
+                uiInfo('Installing mycli for enhanced MySQL shell...'),
+              )
               const pm = await detectPackageManager()
               if (pm) {
                 const result = await installMycli(pm)
                 if (result.success) {
-                  console.log(success('mycli installed successfully!'))
+                  console.log(uiSuccess('mycli installed successfully!'))
                   console.log()
                 } else {
                   console.error(
-                    error(`Failed to install mycli: ${result.error}`),
+                    uiError(`Failed to install mycli: ${result.error}`),
                   )
                   console.log()
                   console.log(chalk.gray('Manual installation:'))
@@ -283,7 +287,7 @@ export const connectCommand = new Command('connect')
                   process.exit(1)
                 }
               } else {
-                console.error(error('No supported package manager found'))
+                console.error(uiError('No supported package manager found'))
                 console.log()
                 console.log(chalk.gray('Manual installation:'))
                 for (const instruction of getMycliManualInstructions()) {
@@ -292,7 +296,7 @@ export const connectCommand = new Command('connect')
                 process.exit(1)
               }
             } else {
-              console.error(error('mycli is not installed'))
+              console.error(uiError('mycli is not installed'))
               console.log()
               console.log(chalk.gray('Install mycli for enhanced MySQL shell:'))
               console.log(chalk.cyan('  spindb connect --install-mycli'))
@@ -309,9 +313,13 @@ export const connectCommand = new Command('connect')
         const useLitecli = options.litecli || options.installLitecli
         if (useLitecli) {
           if (engineName !== Engine.SQLite) {
-            console.error(error('litecli is only available for SQLite containers'))
+            console.error(
+              uiError('litecli is only available for SQLite containers'),
+            )
             if (engineName === 'postgresql') {
-              console.log(chalk.gray('For PostgreSQL, use: spindb connect --pgcli'))
+              console.log(
+                chalk.gray('For PostgreSQL, use: spindb connect --pgcli'),
+              )
             } else if (engineName === 'mysql') {
               console.log(chalk.gray('For MySQL, use: spindb connect --mycli'))
             }
@@ -322,16 +330,18 @@ export const connectCommand = new Command('connect')
 
           if (!litecliInstalled) {
             if (options.installLitecli) {
-              console.log(info('Installing litecli for enhanced SQLite shell...'))
+              console.log(
+                uiInfo('Installing litecli for enhanced SQLite shell...'),
+              )
               const pm = await detectPackageManager()
               if (pm) {
                 const result = await installLitecli(pm)
                 if (result.success) {
-                  console.log(success('litecli installed successfully!'))
+                  console.log(uiSuccess('litecli installed successfully!'))
                   console.log()
                 } else {
                   console.error(
-                    error(`Failed to install litecli: ${result.error}`),
+                    uiError(`Failed to install litecli: ${result.error}`),
                   )
                   console.log()
                   console.log(chalk.gray('Manual installation:'))
@@ -341,7 +351,7 @@ export const connectCommand = new Command('connect')
                   process.exit(1)
                 }
               } else {
-                console.error(error('No supported package manager found'))
+                console.error(uiError('No supported package manager found'))
                 console.log()
                 console.log(chalk.gray('Manual installation:'))
                 for (const instruction of getLitecliManualInstructions()) {
@@ -350,9 +360,11 @@ export const connectCommand = new Command('connect')
                 process.exit(1)
               }
             } else {
-              console.error(error('litecli is not installed'))
+              console.error(uiError('litecli is not installed'))
               console.log()
-              console.log(chalk.gray('Install litecli for enhanced SQLite shell:'))
+              console.log(
+                chalk.gray('Install litecli for enhanced SQLite shell:'),
+              )
               console.log(chalk.cyan('  spindb connect --install-litecli'))
               console.log()
               console.log(chalk.gray('Or install manually:'))
@@ -364,7 +376,7 @@ export const connectCommand = new Command('connect')
           }
         }
 
-        console.log(info(`Connecting to ${containerName}:${database}...`))
+        console.log(uiInfo(`Connecting to ${containerName}:${database}...`))
         console.log()
 
         let clientCmd: string
@@ -415,7 +427,7 @@ export const connectCommand = new Command('connect')
 
         clientProcess.on('error', (err: NodeJS.ErrnoException) => {
           if (err.code === 'ENOENT') {
-            console.log(warning(`${clientCmd} not found on your system.`))
+            console.log(uiWarning(`${clientCmd} not found on your system.`))
             console.log()
             console.log(
               chalk.gray('  Install client tools or connect manually:'),
@@ -451,16 +463,16 @@ export const connectCommand = new Command('connect')
             }
             console.log()
           } else {
-            console.error(error(err.message))
+            console.error(uiError(err.message))
           }
         })
 
         await new Promise<void>((resolve) => {
           clientProcess.on('close', () => resolve())
         })
-      } catch (err) {
-        const e = err as Error
-        console.error(error(e.message))
+      } catch (error) {
+        const e = error as Error
+        console.error(uiError(e.message))
         process.exit(1)
       }
     },

package/cli/commands/create.ts

@@ -13,7 +13,7 @@ import {
   promptConfirm,
 } from '../ui/prompts'
 import { createSpinner } from '../ui/spinner'
-import { header, error, connectionBox } from '../ui/theme'
+import { header, uiError, connectionBox } from '../ui/theme'
 import { tmpdir } from 'os'
 import { join } from 'path'
 import { getMissingDependencies } from '../../core/dependency-manager'
@@ -21,9 +21,9 @@ import { platformService } from '../../core/platform-service'
 import { startWithRetry } from '../../core/start-with-retry'
 import { TransactionManager } from '../../core/transaction-manager'
 import { isValidDatabaseName } from '../../core/error-handler'
+import { resolve } from 'path'
 import { Engine } from '../../types'
 import type { BaseEngine } from '../../engines/base-engine'
-import { resolve } from 'path'
 
 /**
  * Simplified SQLite container creation flow
@@ -43,8 +43,13 @@ async function createSqliteContainer(
 
   const missingDeps = await getMissingDependencies('sqlite')
   if (missingDeps.length > 0) {
-    depsSpinner.warn(`Missing tools: ${missingDeps.map((d) => d.name).join(', ')}`)
-    const installed = await promptInstallDependencies(missingDeps[0].binary, 'sqlite')
+    depsSpinner.warn(
+      `Missing tools: ${missingDeps.map((d) => d.name).join(', ')}`,
+    )
+    const installed = await promptInstallDependencies(
+      missingDeps[0].binary,
+      'sqlite',
+    )
     if (!installed) {
       process.exit(1)
     }
@@ -64,7 +69,7 @@ async function createSqliteContainer(
 
   // Check if file already exists
   if (existsSync(absolutePath)) {
-    console.error(error(`File already exists: ${absolutePath}`))
+    console.error(uiError(`File already exists: ${absolutePath}`))
     process.exit(1)
   }
 
@@ -75,9 +80,9 @@ async function createSqliteContainer(
     // Initialize the SQLite database file and register in registry
     await dbEngine.initDataDir(containerName, version, { path: absolutePath })
     createSpinnerInstance.succeed('SQLite database created')
-  } catch (err) {
+  } catch (error) {
     createSpinnerInstance.fail('Failed to create SQLite database')
-    throw err
+    throw error
   }
 
   // Handle --from restore
@@ -85,15 +90,23 @@ async function createSqliteContainer(
     const config = await containerManager.getConfig(containerName)
     if (config) {
       const format = await dbEngine.detectBackupFormat(restoreLocation)
-      const restoreSpinner = createSpinner(`Restoring from ${format.description}...`)
+      const restoreSpinner = createSpinner(
+        `Restoring from ${format.description}...`,
+      )
       restoreSpinner.start()
 
       try {
         await dbEngine.restore(config, restoreLocation)
         restoreSpinner.succeed('Backup restored successfully')
-      } catch (err) {
+      } catch (error) {
         restoreSpinner.fail('Failed to restore backup')
-        throw err
+        // Clean up the created container on restore failure
+        try {
+          await containerManager.delete(containerName, { force: true })
+        } catch {
+          // Ignore cleanup errors - still throw the original restore error
+        }
+        throw error
       }
     }
   }
@@ -146,7 +159,11 @@ function detectLocationType(location: string): {
   if (existsSync(location)) {
     // Check if it's a SQLite file (case-insensitive)
     const lowerLocation = location.toLowerCase()
-    if (lowerLocation.endsWith('.sqlite') || lowerLocation.endsWith('.db') || lowerLocation.endsWith('.sqlite3')) {
+    if (
+      lowerLocation.endsWith('.sqlite') ||
+      lowerLocation.endsWith('.db') ||
+      lowerLocation.endsWith('.sqlite3')
+    ) {
       return { type: 'file', inferredEngine: Engine.SQLite }
     }
     return { type: 'file' }
@@ -158,7 +175,10 @@ function detectLocationType(location: string): {
 export const createCommand = new Command('create')
   .description('Create a new database container')
   .argument('[name]', 'Container name')
-  .option('-e, --engine <engine>', 'Database engine (postgresql, mysql, sqlite)')
+  .option(
+    '-e, --engine <engine>',
+    'Database engine (postgresql, mysql, sqlite)',
+  )
   .option('-v, --version <version>', 'Database version')
   .option('-d, --database <database>', 'Database name')
   .option('-p, --port <port>', 'Port number')
@@ -207,7 +227,7 @@ export const createCommand = new Command('create')
           const locationInfo = detectLocationType(options.from)
 
           if (locationInfo.type === 'not_found') {
-            console.error(error(`Location not found: ${options.from}`))
+            console.error(uiError(`Location not found: ${options.from}`))
             console.log(
               chalk.gray(
                 '  Provide a valid file path or connection string (postgresql://, mysql://)',
@@ -230,7 +250,7 @@ export const createCommand = new Command('create')
 
           if (options.start === false) {
             console.error(
-              error(
+              uiError(
                 'Cannot use --no-start with --from (restore requires running container)',
               ),
             )
@@ -257,7 +277,7 @@ export const createCommand = new Command('create')
         // Validate database name to prevent SQL injection
         if (!isValidDatabaseName(database)) {
           console.error(
-            error(
+            uiError(
               'Database name must start with a letter and contain only letters, numbers, hyphens, and underscores',
             ),
           )
@@ -282,13 +302,26 @@ export const createCommand = new Command('create')
         // For server databases, validate --connect with --no-start
         if (options.connect && options.start === false) {
           console.error(
-            error(
+            uiError(
               'Cannot use --no-start with --connect (connection requires running container)',
             ),
           )
           process.exit(1)
         }
 
+        // Validate --max-connections if provided
+        if (options.maxConnections) {
+          const parsed = parseInt(options.maxConnections, 10)
+          if (!Number.isFinite(parsed) || parsed <= 0) {
+            console.error(
+              uiError(
+                'Invalid --max-connections value: must be a positive integer',
+              ),
+            )
+            process.exit(1)
+          }
+        }
+
         const depsSpinner = createSpinner('Checking required tools...')
         depsSpinner.start()
 
@@ -310,7 +343,7 @@ export const createCommand = new Command('create')
           missingDeps = await getMissingDependencies(engine)
           if (missingDeps.length > 0) {
             console.error(
-              error(
+              uiError(
                 `Still missing tools: ${missingDeps.map((d) => d.name).join(', ')}`,
               ),
             )
@@ -399,9 +432,9 @@ export const createCommand = new Command('create')
           })
 
           createSpinnerInstance.succeed('Container created')
-        } catch (err) {
+        } catch (error) {
           createSpinnerInstance.fail('Failed to create container')
-          throw err
+          throw error
         }
 
         const initSpinner = createSpinner('Initializing database cluster...')
@@ -415,10 +448,10 @@ export const createCommand = new Command('create')
               : undefined,
           })
           initSpinner.succeed('Database cluster initialized')
-        } catch (err) {
+        } catch (error) {
           initSpinner.fail('Failed to initialize database cluster')
           await tx.rollback()
-          throw err
+          throw error
         }
 
         // --from requires start, --start forces start, --no-start skips, otherwise ask user
@@ -484,14 +517,14 @@ export const createCommand = new Command('create')
             } else {
               startSpinner.succeed(`${dbEngine.displayName} started`)
             }
-          } catch (err) {
+          } catch (error) {
             if (!startSpinner.isSpinning) {
               // Error was already handled above
             } else {
               startSpinner.fail(`Failed to start ${dbEngine.displayName}`)
             }
             await tx.rollback()
-            throw err
+            throw error
           }
 
           const defaultDb = engineDefaults.superuser
@@ -504,10 +537,10 @@ export const createCommand = new Command('create')
             try {
               await dbEngine.createDatabase(config, database)
               dbSpinner.succeed(`Database "${database}" created`)
-            } catch (err) {
+            } catch (error) {
               dbSpinner.fail(`Failed to create database "${database}"`)
               await tx.rollback()
-              throw err
+              throw error
             }
           }
         }
@@ -538,8 +571,8 @@ export const createCommand = new Command('create')
                 dumpSpinner.succeed('Dump created from remote database')
                 backupPath = tempDumpPath
                 dumpSuccess = true
-              } catch (err) {
-                const e = err as Error
+              } catch (error) {
+                const e = error as Error
                 dumpSpinner.fail('Failed to create dump')
 
                 if (
@@ -554,14 +587,14 @@ export const createCommand = new Command('create')
                 }
 
                 console.log()
-                console.error(error('pg_dump error:'))
+                console.error(uiError('pg_dump error:'))
                 console.log(chalk.gray(`  ${e.message}`))
                 process.exit(1)
               }
             }
 
             if (!dumpSuccess) {
-              console.error(error('Failed to create dump after retries'))
+              console.error(uiError('Failed to create dump after retries'))
               process.exit(1)
             }
           } else {
@@ -639,8 +672,8 @@ export const createCommand = new Command('create')
             console.log()
           }
         }
-      } catch (err) {
-        const e = err as Error
+      } catch (error) {
+        const e = error as Error
 
         const missingToolPatterns = [
           'pg_restore not found',
@@ -666,7 +699,7 @@ export const createCommand = new Command('create')
           process.exit(1)
         }
 
-        console.error(error(e.message))
+        console.error(uiError(e.message))
         process.exit(1)
       } finally {
         if (tempDumpPath) {

package/cli/commands/delete.ts

@@ -4,7 +4,7 @@ import { processManager } from '../../core/process-manager'
 import { getEngine } from '../../engines'
 import { promptContainerSelect, promptConfirm } from '../ui/prompts'
 import { createSpinner } from '../ui/spinner'
-import { error, warning } from '../ui/theme'
+import { uiError, uiWarning } from '../ui/theme'
 
 export const deleteCommand = new Command('delete')
   .alias('rm')
@@ -24,7 +24,7 @@ export const deleteCommand = new Command('delete')
           const containers = await containerManager.list()
 
           if (containers.length === 0) {
-            console.log(warning('No containers found'))
+            console.log(uiWarning('No containers found'))
             return
           }
 
@@ -38,7 +38,7 @@ export const deleteCommand = new Command('delete')
 
         const config = await containerManager.getConfig(containerName)
         if (!config) {
-          console.error(error(`Container "${containerName}" not found`))
+          console.error(uiError(`Container "${containerName}" not found`))
           process.exit(1)
         }
 
@@ -48,7 +48,7 @@ export const deleteCommand = new Command('delete')
             false,
           )
           if (!confirmed) {
-            console.log(warning('Deletion cancelled'))
+            console.log(uiWarning('Deletion cancelled'))
             return
           }
         }
@@ -67,7 +67,7 @@ export const deleteCommand = new Command('delete')
             stopSpinner.succeed(`Stopped "${containerName}"`)
           } else {
             console.error(
-              error(
+              uiError(
                 `Container "${containerName}" is running. Stop it first or use --force`,
               ),
             )
@@ -81,9 +81,9 @@ export const deleteCommand = new Command('delete')
         await containerManager.delete(containerName, { force: true })
 
         deleteSpinner.succeed(`Container "${containerName}" deleted`)
-      } catch (err) {
-        const e = err as Error
-        console.error(error(e.message))
+      } catch (error) {
+        const e = error as Error
+        console.error(uiError(e.message))
         process.exit(1)
       }
     },