spindb 0.9.1 → 0.9.2

package/cli/commands/run.ts

@@ -5,7 +5,7 @@ import { containerManager } from '../../core/container-manager'
 import { processManager } from '../../core/process-manager'
 import { getEngine } from '../../engines'
 import { promptInstallDependencies } from '../ui/prompts'
-import { error, warning } from '../ui/theme'
+import { uiError, uiWarning } from '../ui/theme'
 import { getMissingDependencies } from '../../core/dependency-manager'
 import { Engine } from '../../types'
 
@@ -26,7 +26,7 @@ export const runCommand = new Command('run')
 
         const config = await containerManager.getConfig(containerName)
         if (!config) {
-          console.error(error(`Container "${containerName}" not found`))
+          console.error(uiError(`Container "${containerName}" not found`))
           process.exit(1)
         }
 
@@ -36,9 +36,7 @@ export const runCommand = new Command('run')
         if (engineName === Engine.SQLite) {
           if (!existsSync(config.database)) {
             console.error(
-              error(
-                `SQLite database file not found: ${config.database}`,
-              ),
+              uiError(`SQLite database file not found: ${config.database}`),
             )
             process.exit(1)
           }
@@ -49,7 +47,7 @@ export const runCommand = new Command('run')
           })
           if (!running) {
             console.error(
-              error(
+              uiError(
                 `Container "${containerName}" is not running. Start it first with: spindb start ${containerName}`,
               ),
             )
@@ -59,16 +57,16 @@ export const runCommand = new Command('run')
 
         if (file && options.sql) {
           console.error(
-            error('Cannot specify both a file and --sql option. Choose one.'),
+            uiError('Cannot specify both a file and --sql option. Choose one.'),
           )
           process.exit(1)
         }
 
         if (!file && !options.sql) {
-          console.error(error('Must provide either a SQL file or --sql option'))
-          console.log(
-            chalk.gray('  Usage: spindb run <container> <file.sql>'),
+          console.error(
+            uiError('Must provide either a SQL file or --sql option'),
           )
+          console.log(chalk.gray('  Usage: spindb run <container> <file.sql>'))
           console.log(
             chalk.gray('     or: spindb run <container> --sql "SELECT ..."'),
           )
@@ -76,7 +74,7 @@ export const runCommand = new Command('run')
         }
 
         if (file && !existsSync(file)) {
-          console.error(error(`SQL file not found: ${file}`))
+          console.error(uiError(`SQL file not found: ${file}`))
           process.exit(1)
         }
 
@@ -85,7 +83,7 @@ export const runCommand = new Command('run')
         let missingDeps = await getMissingDependencies(engineName)
         if (missingDeps.length > 0) {
           console.log(
-            warning(
+            uiWarning(
               `Missing tools: ${missingDeps.map((d) => d.name).join(', ')}`,
             ),
           )
@@ -102,7 +100,7 @@ export const runCommand = new Command('run')
           missingDeps = await getMissingDependencies(engineName)
           if (missingDeps.length > 0) {
             console.error(
-              error(
+              uiError(
                 `Still missing tools: ${missingDeps.map((d) => d.name).join(', ')}`,
               ),
             )
@@ -120,8 +118,8 @@ export const runCommand = new Command('run')
           sql: options.sql,
           database,
         })
-      } catch (err) {
-        const e = err as Error
+      } catch (error) {
+        const e = error as Error
 
         const missingToolPatterns = [
           'psql not found',
@@ -138,8 +136,12 @@ export const runCommand = new Command('run')
             .replace(' not found', '')
             .replace(' client', '')
           // Determine engine from the missing tool name
-          const toolEngine = missingTool === 'mysql' ? Engine.MySQL : Engine.PostgreSQL
-          const installed = await promptInstallDependencies(missingTool, toolEngine)
+          const toolEngine =
+            missingTool === 'mysql' ? Engine.MySQL : Engine.PostgreSQL
+          const installed = await promptInstallDependencies(
+            missingTool,
+            toolEngine,
+          )
           if (installed) {
             console.log(
               chalk.yellow('  Please re-run your command to continue.'),
@@ -148,7 +150,7 @@ export const runCommand = new Command('run')
           process.exit(1)
         }
 
-        console.error(error(e.message))
+        console.error(uiError(e.message))
         process.exit(1)
       }
     },

package/cli/commands/self-update.ts

@@ -3,7 +3,7 @@ import chalk from 'chalk'
 import inquirer from 'inquirer'
 import { updateManager } from '../../core/update-manager'
 import { createSpinner } from '../ui/spinner'
-import { success, error, info, header } from '../ui/theme'
+import { uiSuccess, uiError, uiInfo, header } from '../ui/theme'
 
 export const selfUpdateCommand = new Command('self-update')
   .alias('update')
@@ -24,7 +24,7 @@ export const selfUpdateCommand = new Command('self-update')
       if (!result) {
         checkSpinner.fail('Could not reach npm registry')
         console.log()
-        console.log(info('Check your internet connection and try again.'))
+        console.log(uiInfo('Check your internet connection and try again.'))
         console.log(chalk.gray('  Manual update: npm install -g spindb@latest'))
         process.exit(1)
       }
@@ -84,7 +84,7 @@ export const selfUpdateCommand = new Command('self-update')
         updateSpinner.succeed('Update complete')
         console.log()
         console.log(
-          success(
+          uiSuccess(
             `Updated from ${updateResult.previousVersion} to ${updateResult.newVersion}`,
           ),
         )
@@ -100,9 +100,9 @@ export const selfUpdateCommand = new Command('self-update')
       } else {
         updateSpinner.fail('Update failed')
         console.log()
-        console.log(error(updateResult.error || 'Unknown error'))
+        console.log(uiError(updateResult.error || 'Unknown error'))
         console.log()
-        console.log(info('Manual update: npm install -g spindb@latest'))
+        console.log(uiInfo('Manual update: npm install -g spindb@latest'))
         process.exit(1)
       }
     },

package/cli/commands/start.ts

@@ -7,7 +7,7 @@ import { getEngine } from '../../engines'
 import { getEngineDefaults } from '../../config/defaults'
 import { promptContainerSelect } from '../ui/prompts'
 import { createSpinner } from '../ui/spinner'
-import { error, warning } from '../ui/theme'
+import { uiError, uiWarning } from '../ui/theme'
 
 export const startCommand = new Command('start')
   .description('Start a container')
@@ -23,10 +23,10 @@ export const startCommand = new Command('start')
         if (stopped.length === 0) {
           if (containers.length === 0) {
             console.log(
-              warning('No containers found. Create one with: spindb create'),
+              uiWarning('No containers found. Create one with: spindb create'),
             )
           } else {
-            console.log(warning('All containers are already running'))
+            console.log(uiWarning('All containers are already running'))
           }
           return
         }
@@ -41,7 +41,7 @@ export const startCommand = new Command('start')
 
       const config = await containerManager.getConfig(containerName)
       if (!config) {
-        console.error(error(`Container "${containerName}" not found`))
+        console.error(uiError(`Container "${containerName}" not found`))
         process.exit(1)
       }
 
@@ -51,7 +51,9 @@ export const startCommand = new Command('start')
         engine: engineName,
       })
       if (running) {
-        console.log(warning(`Container "${containerName}" is already running`))
+        console.log(
+          uiWarning(`Container "${containerName}" is already running`),
+        )
         return
       }
 
@@ -72,7 +74,7 @@ export const startCommand = new Command('start')
       if (!result.success) {
         spinner.fail(`Failed to start "${containerName}"`)
         if (result.error) {
-          console.error(error(result.error.message))
+          console.error(uiError(result.error.message))
         }
         process.exit(1)
       }
@@ -110,9 +112,9 @@ export const startCommand = new Command('start')
       console.log(chalk.gray('  Connect with:'))
       console.log(chalk.cyan(`  spindb connect ${containerName}`))
       console.log()
-    } catch (err) {
-      const e = err as Error
-      console.error(error(e.message))
+    } catch (error) {
+      const e = error as Error
+      console.error(uiError(e.message))
       process.exit(1)
     }
   })

package/cli/commands/stop.ts

@@ -4,7 +4,7 @@ import { processManager } from '../../core/process-manager'
 import { getEngine } from '../../engines'
 import { promptContainerSelect } from '../ui/prompts'
 import { createSpinner } from '../ui/spinner'
-import { success, error, warning } from '../ui/theme'
+import { uiSuccess, uiError, uiWarning } from '../ui/theme'
 
 export const stopCommand = new Command('stop')
   .description('Stop a container')
@@ -17,7 +17,7 @@ export const stopCommand = new Command('stop')
         const running = containers.filter((c) => c.status === 'running')
 
         if (running.length === 0) {
-          console.log(warning('No running containers found'))
+          console.log(uiWarning('No running containers found'))
           return
         }
 
@@ -34,7 +34,7 @@ export const stopCommand = new Command('stop')
           spinner.succeed(`Stopped "${container.name}"`)
         }
 
-        console.log(success(`Stopped ${running.length} container(s)`))
+        console.log(uiSuccess(`Stopped ${running.length} container(s)`))
         return
       }
 
@@ -45,7 +45,7 @@ export const stopCommand = new Command('stop')
         const running = containers.filter((c) => c.status === 'running')
 
         if (running.length === 0) {
-          console.log(warning('No running containers found'))
+          console.log(uiWarning('No running containers found'))
           return
         }
 
@@ -59,7 +59,7 @@ export const stopCommand = new Command('stop')
 
       const config = await containerManager.getConfig(containerName)
       if (!config) {
-        console.error(error(`Container "${containerName}" not found`))
+        console.error(uiError(`Container "${containerName}" not found`))
         process.exit(1)
       }
 
@@ -67,7 +67,7 @@ export const stopCommand = new Command('stop')
         engine: config.engine,
       })
       if (!running) {
-        console.log(warning(`Container "${containerName}" is not running`))
+        console.log(uiWarning(`Container "${containerName}" is not running`))
         return
       }
 
@@ -80,9 +80,9 @@ export const stopCommand = new Command('stop')
       await containerManager.updateConfig(containerName, { status: 'stopped' })
 
       spinner.succeed(`Container "${containerName}" stopped`)
-    } catch (err) {
-      const e = err as Error
-      console.error(error(e.message))
+    } catch (error) {
+      const e = error as Error
+      console.error(uiError(e.message))
       process.exit(1)
     }
   })

package/cli/commands/url.ts

@@ -3,7 +3,7 @@ import { containerManager } from '../../core/container-manager'
 import { platformService } from '../../core/platform-service'
 import { getEngine } from '../../engines'
 import { promptContainerSelect } from '../ui/prompts'
-import { error, warning, success } from '../ui/theme'
+import { uiError, uiWarning, uiSuccess } from '../ui/theme'
 
 export const urlCommand = new Command('url')
   .alias('connection-string')
@@ -24,7 +24,7 @@ export const urlCommand = new Command('url')
           const containers = await containerManager.list()
 
           if (containers.length === 0) {
-            console.log(warning('No containers found'))
+            console.log(uiWarning('No containers found'))
             return
           }
 
@@ -38,13 +38,16 @@ export const urlCommand = new Command('url')
 
         const config = await containerManager.getConfig(containerName)
         if (!config) {
-          console.error(error(`Container "${containerName}" not found`))
+          console.error(uiError(`Container "${containerName}" not found`))
           process.exit(1)
         }
 
         const engine = getEngine(config.engine)
         const databaseName = options.database || config.database
-        const connectionString = engine.getConnectionString(config, databaseName)
+        const connectionString = engine.getConnectionString(
+          config,
+          databaseName,
+        )
 
         if (options.json) {
           const jsonOutput =
@@ -72,10 +75,10 @@ export const urlCommand = new Command('url')
           const copied = await platformService.copyToClipboard(connectionString)
           if (copied) {
             console.log(connectionString)
-            console.error(success('Copied to clipboard'))
+            console.error(uiSuccess('Copied to clipboard'))
           } else {
             console.log(connectionString)
-            console.error(warning('Could not copy to clipboard'))
+            console.error(uiWarning('Could not copy to clipboard'))
           }
         } else {
           process.stdout.write(connectionString)
@@ -83,9 +86,9 @@ export const urlCommand = new Command('url')
             console.log()
           }
         }
-      } catch (err) {
-        const e = err as Error
-        console.error(error(e.message))
+      } catch (error) {
+        const e = error as Error
+        console.error(uiError(e.message))
         process.exit(1)
       }
     },

package/cli/helpers.ts

@@ -1,7 +1,7 @@
 import { existsSync } from 'fs'
 import { readdir, lstat } from 'fs/promises'
 import { join } from 'path'
-import { exec } from 'child_process'
+import { exec, execFile } from 'child_process'
 import { promisify } from 'util'
 import { paths } from '../config/paths'
 import {
@@ -11,6 +11,7 @@ import {
 } from '../engines/mysql/binary-detection'
 
 const execAsync = promisify(exec)
+const execFileAsync = promisify(execFile)
 
 export type InstalledPostgresEngine = {
   engine: 'postgresql'
@@ -49,7 +50,7 @@ async function getPostgresVersion(binPath: string): Promise<string | null> {
   }
 
   try {
-    const { stdout } = await execAsync(`"${postgresPath}" --version`)
+    const { stdout } = await execFileAsync(postgresPath, ['--version'])
     const match = stdout.match(/\(PostgreSQL\)\s+([\d.]+)/)
     return match ? match[1] : null
   } catch {
@@ -57,7 +58,9 @@ async function getPostgresVersion(binPath: string): Promise<string | null> {
   }
 }
 
-export async function getInstalledPostgresEngines(): Promise<InstalledPostgresEngine[]> {
+export async function getInstalledPostgresEngines(): Promise<
+  InstalledPostgresEngine[]
+> {
   const binDir = paths.bin
 
   if (!existsSync(binDir)) {
@@ -144,7 +147,9 @@ async function getInstalledSqliteEngine(): Promise<InstalledSqliteEngine | null>
       return null
     }
 
-    const { stdout: versionOutput } = await execAsync(`"${sqlitePath}" --version`)
+    const { stdout: versionOutput } = await execFileAsync(sqlitePath, [
+      '--version',
+    ])
     // sqlite3 --version outputs: "3.43.2 2023-10-10 12:14:04 ..."
     const versionMatch = versionOutput.match(/^([\d.]+)/)
     const version = versionMatch ? versionMatch[1] : 'unknown'

package/cli/ui/prompts.ts

@@ -289,7 +289,9 @@ export async function promptDatabaseName(
     engine === 'mysql' ? 'Database (schema) name:' : 'Database name:'
 
   // Sanitize the default name to ensure it's valid
-  const sanitizedDefault = defaultName ? sanitizeDatabaseName(defaultName) : undefined
+  const sanitizedDefault = defaultName
+    ? sanitizeDatabaseName(defaultName)
+    : undefined
 
   const { database } = await inquirer.prompt<{ database: string }>([
     {
@@ -420,7 +422,11 @@ export async function promptSqlitePath(
 ): Promise<string | undefined> {
   const defaultPath = `./${containerName}.sqlite`
 
-  console.log(chalk.gray('  SQLite databases are stored as files in your project directory.'))
+  console.log(
+    chalk.gray(
+      '  SQLite databases are stored as files in your project directory.',
+    ),
+  )
   console.log(chalk.gray(`  Default: ${defaultPath}`))
   console.log()
 
@@ -496,7 +502,8 @@ export async function promptSqlitePath(
       {
         type: 'list',
         name: 'overwrite',
-        message: 'A file already exists at this location. What would you like to do?',
+        message:
+          'A file already exists at this location. What would you like to do?',
         choices: [
           { name: 'Choose a different path', value: 'different' },
           { name: 'Cancel', value: 'cancel' },
@@ -702,8 +709,8 @@ export async function promptInstallDependencies(
 
       return false
     }
-  } catch (err) {
-    const e = err as Error
+  } catch (error) {
+    const e = error as Error
     console.log()
     console.log(chalk.red(`  Installation failed: ${e.message}`))
     console.log()

package/cli/ui/spinner.ts

@@ -27,10 +27,10 @@ export async function withSpinner<T>(
     })
     spinner.succeed()
     return result
-  } catch (err) {
-    const error = err as Error
-    spinner.fail(error.message)
-    throw error
+  } catch (error) {
+    const e = error as Error
+    spinner.fail(e.message)
+    throw e
   }
 }
 

package/cli/ui/theme.ts

@@ -60,28 +60,28 @@ ${chalk.cyan('└' + line + '┘')}
 /**
  * Format a success message
  */
-export function success(message: string): string {
+export function uiSuccess(message: string): string {
   return `${theme.icons.success} ${message}`
 }
 
 /**
  * Format an error message
  */
-export function error(message: string): string {
+export function uiError(message: string): string {
   return `${theme.icons.error} ${chalk.red(message)}`
 }
 
 /**
  * Format a warning message
  */
-export function warning(message: string): string {
+export function uiWarning(message: string): string {
   return `${theme.icons.warning} ${chalk.yellow(message)}`
 }
 
 /**
  * Format an info message
  */
-export function info(message: string): string {
+export function uiInfo(message: string): string {
   return `${theme.icons.info} ${message}`
 }
 

package/core/binary-manager.ts

@@ -6,7 +6,11 @@ import { exec } from 'child_process'
 import { promisify } from 'util'
 import { paths } from '../config/paths'
 import { defaults } from '../config/defaults'
-import { Engine, type ProgressCallback, type InstalledBinary } from '../types'
+import {
+  type Engine,
+  type ProgressCallback,
+  type InstalledBinary,
+} from '../types'
 
 const execAsync = promisify(exec)
 

package/core/container-manager.ts

@@ -397,12 +397,12 @@ export class ContainerManager {
       await this.saveConfig(targetName, { engine }, config)
 
       return config
-    } catch (err) {
+    } catch (error) {
       // Clean up the copied directory on failure
       await rm(targetPath, { recursive: true, force: true }).catch(() => {
         // Ignore cleanup errors
       })
-      throw err
+      throw error
     }
   }
 
@@ -497,8 +497,8 @@ export class ContainerManager {
     try {
       // Try atomic rename first (only works on same filesystem)
       await fsRename(sourcePath, targetPath)
-    } catch (err) {
-      const e = err as NodeJS.ErrnoException
+    } catch (error) {
+      const e = error as NodeJS.ErrnoException
       if (e.code === 'EXDEV') {
         // Cross-filesystem move - fall back to copy+delete
         await cp(sourcePath, targetPath, { recursive: true })
@@ -514,7 +514,7 @@ export class ContainerManager {
           )
         }
       } else {
-        throw err
+        throw error
       }
     }
   }

package/core/platform-service.ts

@@ -11,7 +11,7 @@
  */
 
 import { homedir, platform as osPlatform, arch as osArch } from 'os'
-import { execSync, exec, spawn } from 'child_process'
+import { execSync, execFileSync, exec, spawn } from 'child_process'
 import { promisify } from 'util'
 import { existsSync } from 'fs'
 
@@ -205,7 +205,7 @@ class DarwinPlatformService extends BasePlatformService {
     let getentResult: string | null = null
     if (sudoUser) {
       try {
-        getentResult = execSync(`getent passwd ${sudoUser}`, {
+        getentResult = execFileSync('getent', ['passwd', sudoUser], {
           encoding: 'utf-8',
         })
       } catch {
@@ -347,7 +347,7 @@ class LinuxPlatformService extends BasePlatformService {
     let getentResult: string | null = null
     if (sudoUser) {
       try {
-        getentResult = execSync(`getent passwd ${sudoUser}`, {
+        getentResult = execFileSync('getent', ['passwd', sudoUser], {
           encoding: 'utf-8',
         })
       } catch {

package/core/start-with-retry.ts

@@ -26,8 +26,8 @@ export type StartWithRetryResult = {
   error?: Error
 }
 
-function isPortInUseError(err: unknown): boolean {
-  const message = (err as Error)?.message?.toLowerCase() || ''
+function isPortInUseError(error: unknown): boolean {
+  const message = (error as Error)?.message?.toLowerCase() || ''
   return (
     message.includes('address already in use') ||
     message.includes('eaddrinuse') ||
@@ -62,14 +62,14 @@ export async function startWithRetry(
         finalPort: config.port,
         retriesUsed: attempt - 1,
       }
-    } catch (err) {
-      const isPortError = isPortInUseError(err)
+    } catch (error) {
+      const isPortError = isPortInUseError(error)
 
       logDebug(`Start attempt ${attempt} failed`, {
         containerName: config.name,
         port: config.port,
         isPortError,
-        error: err instanceof Error ? err.message : String(err),
+        error: error instanceof Error ? error.message : String(error),
       })
 
       if (isPortError && attempt < maxRetries) {
@@ -101,7 +101,7 @@ export async function startWithRetry(
         success: false,
         finalPort: config.port,
         retriesUsed: attempt - 1,
-        error: err instanceof Error ? err : new Error(String(err)),
+        error: error instanceof Error ? error : new Error(String(error)),
       }
     }
   }

package/core/transaction-manager.ts

@@ -36,9 +36,9 @@ export type RollbackAction = {
  *   })
  *
  *   tx.commit() // Success - clear rollback stack
- * } catch (err) {
+ * } catch (error) {
  *   await tx.rollback() // Error - undo everything
- *   throw err
+ *   throw error
  * }
  * ```
  */
@@ -85,14 +85,14 @@ export class TransactionManager {
         logDebug(`Executing rollback: ${action.description}`)
         await action.execute()
         logDebug(`Rollback successful: ${action.description}`)
-      } catch (err) {
+      } catch (error) {
         // Log error but continue with other rollbacks
         logError({
           code: ErrorCodes.ROLLBACK_FAILED,
           message: `Failed to rollback: ${action.description}`,
           severity: 'warning',
           context: {
-            error: err instanceof Error ? err.message : String(err),
+            error: error instanceof Error ? error.message : String(error),
           },
         })
       }
@@ -155,8 +155,8 @@ export async function withTransaction<T>(
     const result = await operation(tx)
     tx.commit()
     return result
-  } catch (err) {
+  } catch (error) {
     await tx.rollback()
-    throw err
+    throw error
   }
 }