spindb 0.9.0 → 0.9.1

package/README.md

@@ -227,6 +227,9 @@ spindb create mydb --port 5433               # Custom port
 spindb create mydb --database my_app         # Custom database name
 spindb create mydb --no-start                # Create without starting
 
+# Create, start, and connect in one command
+spindb create mydb --start --connect
+
 # SQLite with custom path
 spindb create mydb --engine sqlite --path ./data/app.sqlite
 ```
@@ -250,7 +253,9 @@ spindb create mydb --from "postgresql://user:pass@host:5432/production"
 | `--path` | File path for SQLite databases |
 | `--max-connections` | Maximum database connections (default: 200) |
 | `--from` | Restore from backup file or connection string |
+| `--start` | Start container after creation (skip prompt) |
 | `--no-start` | Create without starting |
+| `--connect` | Open a shell connection after creation |
 
 </details>
 
@@ -400,10 +405,12 @@ ENGINE        VERSION     SOURCE            SIZE
 🐘 postgresql 17.7        darwin-arm64      45.2 MB
 🐘 postgresql 16.8        darwin-arm64      44.8 MB
 🐬 mysql      8.0.35      system            (system-installed)
+🪶 sqlite     3.43.2      system            (system-installed)
 ────────────────────────────────────────────────────────
 
 PostgreSQL: 2 version(s), 90.0 MB
 MySQL: system-installed at /opt/homebrew/bin/mysqld
+SQLite: system-installed at /usr/bin/sqlite3
 ```
 
 #### `deps` - Manage client tools

package/cli/commands/clone.ts

@@ -71,6 +71,12 @@ export const cloneCommand = new Command('clone')
         targetName = await promptContainerName(`${sourceName}-copy`)
       }
 
+      // Check if target container already exists
+      if (await containerManager.exists(targetName, { engine: sourceConfig.engine })) {
+        console.error(error(`Container "${targetName}" already exists`))
+        process.exit(1)
+      }
+
       const cloneSpinner = createSpinner(
         `Cloning ${sourceName} to ${targetName}...`,
       )

package/cli/commands/create.ts

@@ -20,6 +20,7 @@ import { getMissingDependencies } from '../../core/dependency-manager'
 import { platformService } from '../../core/platform-service'
 import { startWithRetry } from '../../core/start-with-retry'
 import { TransactionManager } from '../../core/transaction-manager'
+import { isValidDatabaseName } from '../../core/error-handler'
 import { Engine } from '../../types'
 import type { BaseEngine } from '../../engines/base-engine'
 import { resolve } from 'path'
@@ -32,9 +33,9 @@ async function createSqliteContainer(
   containerName: string,
   dbEngine: BaseEngine,
   version: string,
-  options: { path?: string; from?: string | null },
+  options: { path?: string; from?: string | null; connect?: boolean },
 ): Promise<void> {
-  const { path: filePath, from: restoreLocation } = options
+  const { path: filePath, from: restoreLocation, connect } = options
 
   // Check dependencies
   const depsSpinner = createSpinner('Checking required tools...')
@@ -107,9 +108,20 @@ async function createSqliteContainer(
   console.log(chalk.gray('  Connection string:'))
   console.log(chalk.cyan(`    sqlite:///${absolutePath}`))
   console.log()
-  console.log(chalk.gray('  Connect with:'))
-  console.log(chalk.cyan(`    spindb connect ${containerName}`))
-  console.log()
+
+  // Connect if requested
+  if (connect) {
+    const config = await containerManager.getConfig(containerName)
+    if (config) {
+      console.log(chalk.gray('  Opening shell...'))
+      console.log()
+      await dbEngine.connect(config)
+    }
+  } else {
+    console.log(chalk.gray('  Connect with:'))
+    console.log(chalk.cyan(`    spindb connect ${containerName}`))
+    console.log()
+  }
 }
 
 function detectLocationType(location: string): {
@@ -132,8 +144,9 @@ function detectLocationType(location: string): {
   }
 
   if (existsSync(location)) {
-    // Check if it's a SQLite file
-    if (location.endsWith('.sqlite') || location.endsWith('.db') || location.endsWith('.sqlite3')) {
+    // Check if it's a SQLite file (case-insensitive)
+    const lowerLocation = location.toLowerCase()
+    if (lowerLocation.endsWith('.sqlite') || lowerLocation.endsWith('.db') || lowerLocation.endsWith('.sqlite3')) {
       return { type: 'file', inferredEngine: Engine.SQLite }
     }
     return { type: 'file' }
@@ -157,7 +170,9 @@ export const createCommand = new Command('create')
     '--max-connections <number>',
     'Maximum number of database connections (default: 200)',
   )
+  .option('--start', 'Start the container after creation (skip prompt)')
   .option('--no-start', 'Do not start the container after creation')
+  .option('--connect', 'Open a shell connection after creation')
   .option(
     '--from <location>',
     'Restore from a dump file or connection string after creation',
@@ -172,7 +187,8 @@ export const createCommand = new Command('create')
         port?: string
         path?: string
         maxConnections?: string
-        start: boolean
+        start?: boolean
+        connect?: boolean
         from?: string
       },
     ) => {
@@ -238,6 +254,16 @@ export const createCommand = new Command('create')
 
         database = database ?? containerName
 
+        // Validate database name to prevent SQL injection
+        if (!isValidDatabaseName(database)) {
+          console.error(
+            error(
+              'Database name must start with a letter and contain only letters, numbers, hyphens, and underscores',
+            ),
+          )
+          process.exit(1)
+        }
+
         console.log(header('Creating Database Container'))
         console.log()
 
@@ -248,10 +274,21 @@ export const createCommand = new Command('create')
           await createSqliteContainer(containerName, dbEngine, version, {
             path: options.path,
             from: restoreLocation,
+            connect: options.connect,
           })
           return
         }
 
+        // For server databases, validate --connect with --no-start
+        if (options.connect && options.start === false) {
+          console.error(
+            error(
+              'Cannot use --no-start with --connect (connection requires running container)',
+            ),
+          )
+          process.exit(1)
+        }
+
         const depsSpinner = createSpinner('Checking required tools...')
         depsSpinner.start()
 
@@ -384,9 +421,12 @@ export const createCommand = new Command('create')
           throw err
         }
 
-        // --from requires start, --no-start skips, otherwise ask user
+        // --from requires start, --start forces start, --no-start skips, otherwise ask user
+        // --connect implies --start for server databases
         let shouldStart = false
-        if (restoreLocation) {
+        if (restoreLocation || options.connect) {
+          shouldStart = true
+        } else if (options.start === true) {
           shouldStart = true
         } else if (options.start === false) {
           shouldStart = false
@@ -542,7 +582,7 @@ export const createCommand = new Command('create')
             createDatabase: false,
           })
 
-          if (result.code === 0 || !result.stderr) {
+          if (result.code === 0) {
             restoreSpinner.succeed('Backup restored successfully')
           } else {
             restoreSpinner.warn('Restore completed with warnings')
@@ -573,7 +613,17 @@ export const createCommand = new Command('create')
           )
           console.log()
 
-          if (shouldStart) {
+          if (options.connect && shouldStart) {
+            // --connect flag: open shell directly
+            const copied =
+              await platformService.copyToClipboard(connectionString)
+            if (copied) {
+              console.log(chalk.gray('  Connection string copied to clipboard'))
+            }
+            console.log(chalk.gray('  Opening shell...'))
+            console.log()
+            await dbEngine.connect(finalConfig, database)
+          } else if (shouldStart) {
             console.log(chalk.gray('  Connect with:'))
             console.log(chalk.cyan(`  spindb connect ${containerName}`))
 
@@ -582,12 +632,12 @@ export const createCommand = new Command('create')
             if (copied) {
               console.log(chalk.gray('  Connection string copied to clipboard'))
             }
+            console.log()
           } else {
             console.log(chalk.gray('  Start the container:'))
             console.log(chalk.cyan(`  spindb start ${containerName}`))
+            console.log()
           }
-
-          console.log()
         }
       } catch (err) {
         const e = err as Error

package/cli/commands/doctor.ts

@@ -247,10 +247,6 @@ export const doctorCommand = new Command('doctor')
   .description('Check system health and fix common issues')
   .option('--json', 'Output as JSON')
   .action(async (options: { json?: boolean }) => {
-    console.log()
-    console.log(header('SpinDB Health Check'))
-    console.log()
-
     const checks = [
       await checkConfiguration(),
       await checkContainers(),
@@ -265,6 +261,11 @@ export const doctorCommand = new Command('doctor')
       return
     }
 
+    // Human-readable output - print header first
+    console.log()
+    console.log(header('SpinDB Health Check'))
+    console.log()
+
     // Display results
     for (const check of checks) {
       displayResult(check)

package/cli/commands/edit.ts

@@ -37,7 +37,7 @@ async function promptEditAction(
   }
 
   // Only show config option for engines that support it
-  if (engine === 'postgresql') {
+  if (engine === Engine.PostgreSQL) {
     choices.push({ name: 'Edit database config (postgresql.conf)', value: 'config' })
   }
 
@@ -201,7 +201,7 @@ async function promptNewLocation(currentPath: string): Promise<string | null> {
       default: currentPath,
       validate: (input: string) => {
         if (!input.trim()) return 'Path is required'
-        const resolvedPath = resolve(input)
+        const resolvedPath = resolve(input).toLowerCase()
         if (!resolvedPath.endsWith('.sqlite') && !resolvedPath.endsWith('.db') && !resolvedPath.endsWith('.sqlite3')) {
           return 'Path should end with .sqlite, .sqlite3, or .db'
         }
@@ -518,7 +518,7 @@ export const editCommand = new Command('edit')
         // Handle config change
         if (options.setConfig) {
           // Only PostgreSQL supports config editing for now
-          if (config.engine !== 'postgresql') {
+          if (config.engine !== Engine.PostgreSQL) {
             console.error(
               error(`Config editing is only supported for PostgreSQL containers`),
             )
@@ -556,10 +556,12 @@ export const editCommand = new Command('edit')
               configKey,
               configValue,
             )
+            spinner.succeed(`Set ${configKey} = ${configValue}`)
+          } else {
+            spinner.fail('Config editing not supported for this engine')
+            process.exit(1)
           }
 
-          spinner.succeed(`Set ${configKey} = ${configValue}`)
-
           // Check if container is running and warn about restart
           const running = await processManager.isRunning(containerName, {
             engine: config.engine,

package/cli/commands/engines.ts

@@ -12,8 +12,17 @@ import {
   getInstalledPostgresEngines,
   type InstalledPostgresEngine,
   type InstalledMysqlEngine,
+  type InstalledSqliteEngine,
 } from '../helpers'
 
+/**
+ * Pad string to width, accounting for emoji taking 2 display columns
+ */
+function padWithEmoji(str: string, width: number): string {
+  // Count emojis using Extended_Pictographic (excludes digits/symbols that \p{Emoji} matches)
+  const emojiCount = (str.match(/\p{Extended_Pictographic}/gu) || []).length
+  return str.padEnd(width + emojiCount)
+}
 
 /**
  * List subcommand action
@@ -41,13 +50,16 @@ async function listEngines(options: { json?: boolean }): Promise<void> {
     return
   }
 
-  // Separate PostgreSQL and MySQL
+  // Separate engines by type
   const pgEngines = engines.filter(
     (e): e is InstalledPostgresEngine => e.engine === 'postgresql',
   )
   const mysqlEngine = engines.find(
     (e): e is InstalledMysqlEngine => e.engine === 'mysql',
   )
+  const sqliteEngine = engines.find(
+    (e): e is InstalledSqliteEngine => e.engine === 'sqlite',
+  )
 
   // Calculate total size for PostgreSQL
   const totalPgSize = pgEngines.reduce((acc, e) => acc + e.sizeBytes, 0)
@@ -67,10 +79,11 @@ async function listEngines(options: { json?: boolean }): Promise<void> {
   for (const engine of pgEngines) {
     const icon = getEngineIcon(engine.engine)
     const platformInfo = `${engine.platform}-${engine.arch}`
+    const engineDisplay = `${icon} ${engine.engine}`
 
     console.log(
       chalk.gray('  ') +
-        chalk.cyan(`${icon} ${engine.engine}`.padEnd(13)) +
+        chalk.cyan(padWithEmoji(engineDisplay, 13)) +
         chalk.yellow(engine.version.padEnd(12)) +
         chalk.gray(platformInfo.padEnd(18)) +
         chalk.white(formatBytes(engine.sizeBytes)),
@@ -81,16 +94,31 @@ async function listEngines(options: { json?: boolean }): Promise<void> {
   if (mysqlEngine) {
     const icon = ENGINE_ICONS.mysql
     const displayName = mysqlEngine.isMariaDB ? 'mariadb' : 'mysql'
+    const engineDisplay = `${icon} ${displayName}`
 
     console.log(
       chalk.gray('  ') +
-        chalk.cyan(`${icon} ${displayName}`.padEnd(13)) +
+        chalk.cyan(padWithEmoji(engineDisplay, 13)) +
         chalk.yellow(mysqlEngine.version.padEnd(12)) +
         chalk.gray('system'.padEnd(18)) +
         chalk.gray('(system-installed)'),
     )
   }
 
+  // SQLite row
+  if (sqliteEngine) {
+    const icon = ENGINE_ICONS.sqlite
+    const engineDisplay = `${icon} sqlite`
+
+    console.log(
+      chalk.gray('  ') +
+        chalk.cyan(padWithEmoji(engineDisplay, 13)) +
+        chalk.yellow(sqliteEngine.version.padEnd(12)) +
+        chalk.gray('system'.padEnd(18)) +
+        chalk.gray('(system-installed)'),
+    )
+  }
+
   console.log(chalk.gray('  ' + '─'.repeat(55)))
 
   // Summary
@@ -105,6 +133,9 @@ async function listEngines(options: { json?: boolean }): Promise<void> {
   if (mysqlEngine) {
     console.log(chalk.gray(`  MySQL: system-installed at ${mysqlEngine.path}`))
   }
+  if (sqliteEngine) {
+    console.log(chalk.gray(`  SQLite: system-installed at ${sqliteEngine.path}`))
+  }
   console.log()
 }
 

package/cli/commands/info.ts

@@ -2,6 +2,7 @@ import { Command } from 'commander'
 import chalk from 'chalk'
 import inquirer from 'inquirer'
 import { existsSync } from 'fs'
+import { basename } from 'path'
 import { containerManager } from '../../core/container-manager'
 import { processManager } from '../../core/process-manager'
 import { paths } from '../../config/paths'
@@ -197,8 +198,9 @@ async function displayAllContainersInfo(
     // Show truncated file path for SQLite instead of port
     let portOrPath: string
     if (isSQLite) {
-      const fileName = container.database.split('/').pop() || container.database
-      portOrPath = fileName.length > 7 ? fileName.slice(0, 6) + '…' : fileName
+      const fileName = basename(container.database)
+      // Truncate if longer than 8 chars to fit in 8-char column
+      portOrPath = fileName.length > 8 ? fileName.slice(0, 7) + '…' : fileName
     } else {
       portOrPath = String(container.port)
     }

package/cli/commands/list.ts

@@ -12,8 +12,8 @@ import type { ContainerConfig } from '../../types'
  * Pad string to width, accounting for emoji taking 2 display columns
  */
 function padWithEmoji(str: string, width: number): string {
-  // Count emojis (they take 2 display columns but count as 1-2 chars)
-  const emojiCount = (str.match(/[\u{1F300}-\u{1F9FF}]/gu) || []).length
+  // Count emojis using Extended_Pictographic (excludes digits/symbols that \p{Emoji} matches)
+  const emojiCount = (str.match(/\p{Extended_Pictographic}/gu) || []).length
   return str.padEnd(width + emojiCount)
 }
 
@@ -107,8 +107,8 @@ export const listCommand = new Command('list')
         let portOrPath: string
         if (container.engine === Engine.SQLite) {
           const fileName = basename(container.database)
-          // Truncate if longer than 7 chars to fit in 8-char column
-          portOrPath = fileName.length > 7 ? fileName.slice(0, 6) + '…' : fileName
+          // Truncate if longer than 8 chars to fit in 8-char column
+          portOrPath = fileName.length > 8 ? fileName.slice(0, 7) + '…' : fileName
         } else {
           portOrPath = String(container.port)
         }

package/cli/commands/logs.ts

@@ -88,13 +88,19 @@ export const logsCommand = new Command('logs')
             stdio: 'inherit',
           })
 
-          process.on('SIGINT', () => {
+          // Use named handler so we can remove it to prevent listener leaks
+          const sigintHandler = () => {
+            process.removeListener('SIGINT', sigintHandler)
             child.kill('SIGTERM')
             process.exit(0)
-          })
+          }
+          process.on('SIGINT', sigintHandler)
 
           await new Promise<void>((resolve) => {
-            child.on('close', () => resolve())
+            child.on('close', () => {
+              process.removeListener('SIGINT', sigintHandler)
+              resolve()
+            })
           })
           return
         }

package/cli/commands/menu/backup-handlers.ts

@@ -403,7 +403,7 @@ export async function handleRestore(): Promise<void> {
     createDatabase: false,
   })
 
-  if (result.code === 0 || !result.stderr) {
+  if (result.code === 0) {
     restoreSpinner.succeed('Backup restored successfully')
   } else {
     const stderr = result.stderr || ''
@@ -552,7 +552,7 @@ export async function handleRestore(): Promise<void> {
     }
   }
 
-  if (result.code === 0 || !result.stderr) {
+  if (result.code === 0) {
     const connectionString = engine.getConnectionString(config, databaseName)
     console.log()
     console.log(success(`Database "${databaseName}" restored`))
@@ -733,6 +733,12 @@ export async function handleClone(): Promise<void> {
   )
   if (!sourceName) return
 
+  const sourceConfig = await containerManager.getConfig(sourceName)
+  if (!sourceConfig) {
+    console.log(error(`Container "${sourceName}" not found`))
+    return
+  }
+
   const { targetName } = await inquirer.prompt<{ targetName: string }>([
     {
       type: 'input',
@@ -749,16 +755,28 @@ export async function handleClone(): Promise<void> {
     },
   ])
 
+  // Check if target container already exists
+  if (await containerManager.exists(targetName, { engine: sourceConfig.engine })) {
+    console.log(error(`Container "${targetName}" already exists`))
+    return
+  }
+
   const spinner = createSpinner(`Cloning ${sourceName} to ${targetName}...`)
   spinner.start()
 
-  const newConfig = await containerManager.clone(sourceName, targetName)
+  try {
+    const newConfig = await containerManager.clone(sourceName, targetName)
 
-  spinner.succeed(`Cloned "${sourceName}" to "${targetName}"`)
+    spinner.succeed(`Cloned "${sourceName}" to "${targetName}"`)
 
-  const engine = getEngine(newConfig.engine)
-  const connectionString = engine.getConnectionString(newConfig)
+    const engine = getEngine(newConfig.engine)
+    const connectionString = engine.getConnectionString(newConfig)
 
-  console.log()
-  console.log(connectionBox(targetName, connectionString, newConfig.port))
+    console.log()
+    console.log(connectionBox(targetName, connectionString, newConfig.port))
+  } catch (err) {
+    const e = err as Error
+    spinner.fail(`Failed to clone "${sourceName}"`)
+    console.log(error(e.message))
+  }
 }

package/cli/commands/menu/container-handlers.ts

@@ -1043,6 +1043,12 @@ async function handleCloneFromSubmenu(
   sourceName: string,
   showMainMenu: () => Promise<void>,
 ): Promise<void> {
+  const sourceConfig = await containerManager.getConfig(sourceName)
+  if (!sourceConfig) {
+    console.log(error(`Container "${sourceName}" not found`))
+    return
+  }
+
   const { targetName } = await inquirer.prompt<{ targetName: string }>([
     {
       type: 'input',
@@ -1059,20 +1065,32 @@ async function handleCloneFromSubmenu(
     },
   ])
 
+  // Check if target container already exists
+  if (await containerManager.exists(targetName, { engine: sourceConfig.engine })) {
+    console.log(error(`Container "${targetName}" already exists`))
+    return
+  }
+
   const spinner = createSpinner(`Cloning ${sourceName} to ${targetName}...`)
   spinner.start()
 
-  const newConfig = await containerManager.clone(sourceName, targetName)
+  try {
+    const newConfig = await containerManager.clone(sourceName, targetName)
 
-  spinner.succeed(`Cloned "${sourceName}" to "${targetName}"`)
+    spinner.succeed(`Cloned "${sourceName}" to "${targetName}"`)
 
-  const engine = getEngine(newConfig.engine)
-  const connectionString = engine.getConnectionString(newConfig)
+    const engine = getEngine(newConfig.engine)
+    const connectionString = engine.getConnectionString(newConfig)
 
-  console.log()
-  console.log(connectionBox(targetName, connectionString, newConfig.port))
+    console.log()
+    console.log(connectionBox(targetName, connectionString, newConfig.port))
 
-  await showContainerSubmenu(targetName, showMainMenu)
+    await showContainerSubmenu(targetName, showMainMenu)
+  } catch (err) {
+    spinner.fail(`Failed to clone "${sourceName}"`)
+    console.log(error((err as Error).message))
+    await pressEnterToContinue()
+  }
 }
 
 async function handleDelete(containerName: string): Promise<void> {