spiderly 19.12.2 → 19.12.4

package/agent/manifest.json

@@ -34,11 +34,6 @@
       "name": "spiderly-upgrade",
       "surface": "skill",
       "description": "Upgrade a Spiderly consumer app's package version (NuGet + npm) to a newer Spiderly release. Use when the user asks to upgrade Spiderly, bump the Spiderly version, jump to a newer Spiderly release, or migrate to a newer Spiderly package version. Do NOT use for EF Core schema migrations (see ef-migrations skill)."
-    },
-    {
-      "name": "verify-ui",
-      "surface": "skill",
-      "description": "Log past Spiderly's email-code auth wall to visually verify the running Angular admin panel — screenshot a page, click through a flow, or dogfood a UI change without writing a test. Use when asked to \"verify the admin UI\", \"check this page renders\", \"screenshot the admin panel\", \"does this screen look right\", or to eyeball a change in the live app. For authoring Playwright test suites or debugging CI traces, use the e2e-testing skill instead."
     }
   ]
 }

package/fesm2022/spiderly.mjs

@@ -17,7 +17,7 @@ import { TooltipModule } from 'primeng/tooltip';
 import * as FileSaver from 'file-saver';
 import mime from 'mime';
 import 'reflect-metadata';
-import { map, Subject, throttleTime, BehaviorSubject, of, filter as filter$1, firstValueFrom, take, finalize as finalize$1, tap as tap$1, throwError } from 'rxjs';
+import { map, Subject, throttleTime, BehaviorSubject, of, filter as filter$1, firstValueFrom, take, finalize as finalize$1, tap as tap$1, throwError, from } from 'rxjs';
 import * as i4$2 from 'primeng/checkbox';
 import { CheckboxModule } from 'primeng/checkbox';
 import * as i4$3 from 'primeng/colorpicker';
@@ -49,7 +49,7 @@ import * as i3$2 from '@angular/router';
 import { NavigationEnd, RouterModule } from '@angular/router';
 import * as i1$1 from 'primeng/api';
 import { ConfirmationService } from 'primeng/api';
-import { filter, map as map$1, finalize, catchError, delay, tap, takeUntil } from 'rxjs/operators';
+import { filter, map as map$1, finalize, catchError, delay, tap, takeUntil, switchMap } from 'rxjs/operators';
 import * as i1$2 from '@angular/common/http';
 import { HttpParams, HttpHeaders, HttpErrorResponse, HttpResponse } from '@angular/common/http';
 import { InputOtp } from 'primeng/inputotp';
@@ -7964,7 +7964,7 @@ const unauthorizedInterceptor = (req, next) => {
     const messageService = inject(SpiderlyMessageService);
     const translocoService = inject(TranslocoService);
     const authService = inject(AuthServiceBase);
-    const reactToError = (err, request) => {
+    const reactToError = (err, request, errorResponse) => {
         // Unconditional, production included, and the only log for a failed request (the global
         // ErrorHandler skips HTTP errors): the toast the user gets is deliberately vague, so this is
         // where a developer reads which request failed and how. See SpiderlyErrorHandler for why
@@ -7972,17 +7972,9 @@ const unauthorizedInterceptor = (req, next) => {
         // HttpErrorResponse on its own stringifies to "[object HttpErrorResponse]" in an error
         // tracker's console breadcrumb; the object still follows, to expand in devtools.
         console.error(`HTTP ${err.status} ${request.method} ${request.url}`, err);
-        // TODO: type this as an ApiError interface (TS mirror of ApiErrorDTO, next to errors/api-error-codes.ts)
-        // so message/errorCode/traceId reads of the cross-language contract are compile-checked, not conventional.
-        let errorResponse = err.error;
-        if (request.responseType !== 'json' && typeof err.error === 'string') {
-            try {
-                errorResponse = JSON.parse(err.error);
-            }
-            catch {
-                errorResponse = null;
-            }
-        }
+        // TODO: type errorResponse as an ApiError interface (TS mirror of ApiErrorDTO, next to
+        // errors/api-error-codes.ts) so message/errorCode/traceId reads of the cross-language contract
+        // are compile-checked, not conventional.
         // ApiErrorDTO.traceId is present only on reportable errors, so this is a no-op everywhere else —
         // the server decides which responses carry a support reference, never this status-code chain.
         const withReference = (detail) => errorResponse?.traceId
@@ -8015,10 +8007,36 @@ const unauthorizedInterceptor = (req, next) => {
             messageService.errorMessage(withReference(translocoService.translate('UnexpectedErrorDetails')), translocoService.translate('UnexpectedErrorTitle'));
         }
     };
-    return next(req).pipe(catchError((err) => {
-        reactToError(err, req);
+    return next(req).pipe(catchError((err) => readErrorBody(err, req).pipe(switchMap((errorResponse) => {
+        reactToError(err, req, errorResponse);
         return throwError(() => err);
-    }));
+    }))));
+};
+/**
+ * The server's ApiErrorDTO, whatever body type the request asked for. Angular hands the ERROR body
+ * back in the requested `responseType` too: a `'text'` request gets the JSON as a string, and a
+ * `'blob'` request (every PDF / Excel download) gets it as a Blob, whose text is only readable
+ * asynchronously — which is why this is an Observable and the toast waits for it. Before the Blob
+ * branch existed, a BusinessException on a download endpoint reached the operator as the generic
+ * "bad request" toast: the sentence the server had spelled out was sitting unread in the Blob.
+ * A body that is not JSON resolves to null, so the status-code fallbacks below still apply.
+ */
+const readErrorBody = (err, request) => {
+    if (err.error instanceof Blob) {
+        return from(err.error.text()).pipe(map$1(parseJsonOrNull), catchError(() => of(null)));
+    }
+    if (request.responseType !== 'json' && typeof err.error === 'string') {
+        return of(parseJsonOrNull(err.error));
+    }
+    return of(err.error);
+};
+const parseJsonOrNull = (text) => {
+    try {
+        return JSON.parse(text);
+    }
+    catch {
+        return null;
+    }
 };
 
 function authInitializer(authService, platformId) {