spiderlint 0.143.0 → 0.143.1

package/README.md

@@ -57,7 +57,7 @@ It also inherits the features of B19 / Ubuntu — see [Features](docs/FEATURES.m
 
 ## What this provides
 
-- **CI action** `damian-buho/spiderlint@0.143.0`
+- **CI action** `damian-buho/spiderlint@0.143.1`
 - **Container image** `ghcr.io/damian-buho/spiderlint:latest`
 - **Container image** `damianbuho/spiderlint:latest`
 - **npm package** `spiderlint` — command `spiderlint`
@@ -114,7 +114,7 @@ Needs Node.js >=26.
 Run it as a step in a GitHub Actions workflow:
 
 ```yaml
-- uses: damian-buho/spiderlint@0.143.0
+- uses: damian-buho/spiderlint@0.143.1
 ```
 
 The action takes these inputs:

package/dist/agent.js

@@ -10,8 +10,8 @@ const CHROME_MAJOR = "147";
 // The instance a web scan runs on, from its request Host header; empty on the CLI.
 const SCAN = { via: "" };
 // The instance `setVia` keeps, without port, path, casing or brackets; garbage becomes empty.
-export function normalizeVia(raw) {
-    const host = (raw ?? "").trim().toLowerCase().split("/", 1)[0] ?? "";
+export function normalizeVia(raw = "") {
+    const host = raw.trim().toLowerCase().split("/", 1)[0] ?? "";
     const bare = host.startsWith("[") ? (host.slice(1).split("]", 1)[0] ?? "") : (host.split(":", 1)[0] ?? "");
     return /^[a-z0-9:]([a-z0-9.:-]*[a-z0-9])?\.?$/.test(bare) ? bare.replace(/\.$/, "") : "";
 }

package/dist/cli.js

@@ -49,8 +49,8 @@ function severity(name, text) {
     });
 }
 // A --name and --no-name pair, shown as one --[no-]name row.
-function toggle(name, text, fallback, environment) {
-    return [Object.assign(flag(`--${name}`, text, fallback, environment), { flags: `--[no-]${name}` }), new Option(`--no-${name}`).hideHelp()];
+function toggle(name, text, environment) {
+    return [Object.assign(flag(`--${name}`, text, "auto", environment), { flags: `--[no-]${name}` }), new Option(`--no-${name}`).hideHelp()];
 }
 // Options under one help heading.
 function section(title, options) {
@@ -323,7 +323,7 @@ function program(act) {
     root.usage("<command> [domain…] [options]").description(DOMAIN);
     root.addOption(flag("--config <path>", "settings file", "projectfile.yaml", "SPIDERLINT_CONFIG"));
     root.addOption(repeatable("--site <names>", "only these org.spiderlint.sites, repeatable", "all"));
-    for (const option of [...toggle("color", "force or disable color", "auto", "NO_COLOR, FORCE_COLOR"), ...toggle("progress", "status line on an interactive stderr", "auto")])
+    for (const option of [...toggle("color", "force or disable color", "NO_COLOR, FORCE_COLOR"), ...toggle("progress", "status line on an interactive stderr")])
         root.addOption(option);
     root.addOption(flag("--log-level <level>", "trace, debug, info, warn, error or silent", "warn", "SPIDERLINT_LOG_LEVEL"));
     root.version(VERSION, "-V, --version", "show the version");

package/dist/crawl/browser.js

@@ -101,8 +101,8 @@ async function watchProtocols(page, seen) {
     }
 }
 // `type/subtype` and charset of a Content-Type header; an unparsable one is its raw essence.
-function contentTypeOf(header) {
-    const raw = [header ?? ""].flat()[0] ?? "";
+function contentTypeOf(header = "") {
+    const raw = [header].flat()[0] ?? "";
     try {
         const mime = new MIMEType(raw);
         const charset = mime.params.get("charset");

package/dist/crawl/rdap.js

@@ -80,7 +80,7 @@ export async function registration(domain, get) {
     const body = JSON.parse(answer.body);
     const expires = body.events?.find((event) => event.eventAction === "expiration")?.eventDate;
     const isDated = expires !== undefined && !Number.isNaN(Date.parse(expires));
-    const nameservers = [...new Set((body.nameservers ?? []).flatMap((server) => (server.ldhName ? [nsName(server.ldhName)] : [])))].toSorted((a, b) => a.localeCompare(b));
+    const nameservers = [...new Set((body.nameservers ?? []).flatMap((server) => (server.ldhName ? nsName(server.ldhName) : [])))].toSorted((a, b) => a.localeCompare(b));
     log.debug({ domain, url, status: body.status, expires, nameservers: nameservers.length }, "rdap answered");
     return { server: base, ...(Array.isArray(body.status) && { status: body.status.map((entry) => String(entry).toLowerCase()) }), ...(isDated && { expires: new Date(expires).toISOString() }), nameservers };
 }

package/dist/crawl/resolve.js

@@ -32,7 +32,7 @@ function notFound(hostname, why) {
 async function addressesOf(client, hostname, family) {
     const types = family === 4 ? ["A"] : family === 6 ? ["AAAA"] : ["A", "AAAA"];
     const replies = await Promise.all(types.map((type) => client.query(hostname, type)));
-    return replies.flatMap((reply) => reply.answers.flatMap((record) => (record.type === "A" || record.type === "AAAA" ? [{ address: record.data, family: record.type === "A" ? 4 : 6 }] : [])));
+    return replies.flatMap((reply) => reply.answers.flatMap((record) => (record.type === "A" || record.type === "AAAA" ? { address: record.data, family: record.type === "A" ? 4 : 6 } : [])));
 }
 // `dns.lookup` overloads (`(host, cb)`, `(host, family, cb)`) normalised to the three-argument form `lookup` takes.
 function overloaded(lookup) {

package/dist/crawl/resources.js

@@ -51,8 +51,9 @@ async function drain(response, max, isKept = false) {
     return { bytes, ...(isKept && { body: Buffer.concat(chunks) }) };
 }
 // The media type of a content-type header, lower-cased.
-function mediaType(raw) {
-    return (String(raw ?? "")
+function mediaType(raw = "") {
+    const text = raw;
+    return (String(text ?? "")
         .split(";", 1)[0]
         ?.trim()
         .toLowerCase() ?? "");

package/dist/facts/resources.js

@@ -11,8 +11,8 @@ const SOURCES = [
     ['link[rel~="manifest"][href]', "manifest", "href"],
 ];
 // Every candidate URL of a `srcset`, descriptors dropped.
-function srcset(raw) {
-    return (raw ?? "")
+function srcset(raw = "") {
+    return raw
         .split(",")
         .map((entry) => entry.trim().split(/\s+/, 1)[0] ?? "")
         .filter((entry) => entry.length > 0);

package/dist/facts/transport.js

@@ -114,8 +114,8 @@ export function redactHeaders(headers) {
     return out;
 }
 // `DNS:a, IP Address:b` to `[a, b]`.
-function subjectAltNames(raw) {
-    return (raw ?? "")
+function subjectAltNames(raw = "") {
+    return raw
         .split(",")
         .map((entry) => entry.trim().replace(/^[^:]+:/, ""))
         .filter((entry) => entry.length > 0);
@@ -189,10 +189,10 @@ export function servedVersions(pages) {
     for (const page of pages) {
         if (page.http.version === undefined || page.http.version === "3.0" || !quic.has(page.url.origin))
             continue;
-        const { hostname, port } = new URL(page.url.href);
-        const own = new Set([`:${port || "443"}`, `${hostname}:${port || "443"}`]);
+        const url = new URL(page.url.href);
+        const own = new Set([`:${url.port || "443"}`, `${url.hostname}:${url.port || "443"}`]);
         const offers = page.http.parsed?.["alt-svc"]?.value;
-        const isAdvertised = Array.isArray(offers) && offers.some((offer) => offer.protocol === "h3" && own.has(offer.authority ?? ""));
+        const isAdvertised = Array.isArray(offers) && offers.some(({ protocol, authority = "" }) => protocol === "h3" && own.has(authority));
         log.debug({ url: page.url.href, observed: page.http.version, isAdvertised }, "http version of a page carried over tcp");
         if (isAdvertised)
             page.http.version = "3.0";

package/dist/facts/vendors.js

@@ -42,7 +42,7 @@ export function vendorFacts(pages, site, isOn) {
         const anchors = page.html ? [...page.html.links.internal, ...page.html.links.external] : [];
         const linked = anchors.flatMap((href) => {
             const entry = vendorPath(href, "page");
-            return entry ? [{ href, entry }] : [];
+            return entry ? { href, entry } : [];
         });
         const loads = [...(page.resources ?? []).map((resource) => resource.url), ...(page.html?.scripts ?? []).flatMap((script) => script.src ?? [])];
         const loaded = loads.flatMap((href) => vendorPath(href, "resource") ?? []);

package/dist/i18n.js

@@ -29,8 +29,8 @@ function catalog(lang) {
     return entries;
 }
 // The language tags of an `Accept-Language` header or POSIX locale (`uk_UA.UTF-8`) with a positive q-value, best first.
-function ranked(accept) {
-    const parts = (accept ?? "").split(",").map((part) => {
+function ranked(accept = "") {
+    const parts = accept.split(",").map((part) => {
         const [tag = "", ...parameters] = part.trim().split(";");
         const q = Number(parameters
             .map((parameter) => parameter.trim())

package/dist/plugins/axe.js

@@ -5,7 +5,6 @@ import { AxeBuilder } from "@axe-core/playwright";
 import axeCore from "axe-core";
 import { log } from "../logger.js";
 import { said } from "../rules/message.js";
-import { definePlugin } from "./types.js";
 const ID = "axe";
 const PREFIX = "axe/";
 const WCAG = new Set(["wcag2a", "wcag2aa", "wcag21a", "wcag21aa", "wcag22aa"]);
@@ -92,7 +91,8 @@ async function extract(page, _body, live) {
     log.debug({ url: page.url.href, violations: facts.violations.length, incomplete: facts.incomplete.length, passes: results.passes.length }, "axe analysed");
     return facts;
 }
-export default definePlugin({
+// eslint-disable-next-line unicorn/no-top-level-side-effects -- preset() assembles plain rule data, no IO
+export default {
     name: "axe",
     extractors: [{ id: ID, mode: "browser", cost: "expensive", inputs: ["resources"], extract }],
     rules: Object.fromEntries(RULES.map((entry) => [`${PREFIX}${entry.ruleId}`, rule(entry.ruleId, entry.helpUrl.replace(/\?.*$/, ""), entry.help)])),
@@ -101,4 +101,4 @@ export default definePlugin({
         "axe:wcag": preset("WCAG 2.2 A and AA success criteria axe-core can test", isWcag),
         "axe:best-practice": preset("axe-core best practices beyond WCAG", (tags) => tags.includes("best-practice")),
     },
-});
+};

package/dist/plugins/cookies.js

@@ -8,7 +8,7 @@ import { log } from "../logger.js";
 import { resourceRule } from "../rules/builtin.js";
 import { said } from "../rules/message.js";
 import { TRACKING_COOKIES } from "./cookies-registry.js";
-import { definePlugin } from "./types.js";
+import {} from "./types.js";
 import { visit } from "./visit.js";
 // Every hand-kept tracking cookie name as one anchored pattern, `*` as any suffix.
 const TRACKING = `^(?:${Object.values(TRACKING_COOKIES)
@@ -148,7 +148,8 @@ const STORAGE_BEFORE_CONSENT = {
     docs: "https://eur-lex.europa.eu/eli/dir/2002/58/art_5/oj",
 };
 // One set of cookie expectations over the page’s Set-Cookie, each resource’s, and what scripts write through `document.cookie`.
-export default definePlugin({
+// eslint-disable-next-line unicorn/no-top-level-side-effects -- Object.fromEntries() assembles plain rule data, no IO
+export default {
     name: "cookies",
     extractors: [consent],
     rules: RESOURCES,
@@ -165,4 +166,4 @@ export default definePlugin({
             rules: { "cookies/before-consent": BEFORE_CONSENT, "cookies/storage-before-consent": STORAGE_BEFORE_CONSENT },
         },
     },
-});
+};

package/dist/plugins/css.js

@@ -7,7 +7,6 @@ import { Parser } from "htmlparser2";
 import { log } from "../logger.js";
 import { pageRule, resourceRule } from "../rules/builtin.js";
 import { said } from "../rules/message.js";
-import { definePlugin } from "./types.js";
 const ID = "css";
 const require = createRequire(import.meta.url);
 // Messages one style sheet or page keeps.
@@ -304,7 +303,8 @@ const inlineUnsupported = (severity, settings) => targeted(pageRule("css/inline-
     const judged = facts && unsupportedIn(facts, targets);
     return facts && (judged ? [{ ...said("inline CSS uses features the browser targets “{query}” lack", { query: targets.query }), data: { [page.url.href]: { features: judged.features } }, value: facts.features.length, locations: judged.locations }] : []);
 }, UNSUPPORTED)(severity), settings);
-export default definePlugin({
+// eslint-disable-next-line unicorn/no-top-level-side-effects -- kindRules() assembles plain rule data, no IO
+export default {
     name: "css",
     settings: SETTINGS,
     extractors: [{ id: ID, extract: extractInline }],
@@ -325,4 +325,4 @@ export default definePlugin({
             },
         },
     },
-});
+};

package/dist/plugins/dns.js

@@ -10,7 +10,7 @@ import { nsName, registration } from "../crawl/rdap.js";
 import { parseSvcb } from "../crawl/svcb.js";
 import { dnsProvider } from "../facts/vendors.js";
 import { log } from "../logger.js";
-import { definePlugin } from "./types.js";
+import {} from "./types.js";
 // Suffixes of special-use names, never queried.
 const SPECIAL_USE = ["localhost", "test", "invalid", "example", "local", "onion", "i2p", "alt", "internal", "home.arpa"];
 // RFC 8624 §3.1: DNSKEY algorithms that MUST NOT sign, and DS digests that MUST NOT be used.
@@ -60,14 +60,14 @@ export function records(reply, type) {
 export function texts(reply) {
     return records(reply, "TXT").map(({ data }) => (Array.isArray(data) ? data : [data]).map((chunk) => chunk.toString("utf8")).join(""));
 }
-// Parsed SVCB-shaped records of `type` (`UNKNOWN_64` SVCB, `UNKNOWN_65` HTTPS); an unparsable one warns and is dropped.
-function services(host, reply, type) {
-    return records(reply, type).flatMap(({ data }) => {
+// Parsed HTTPS-shaped records (`UNKNOWN_65`); an unparsable one warns and is dropped.
+function services(host, reply) {
+    return records(reply, "UNKNOWN_65").flatMap(({ data }) => {
         try {
             return [parseSvcb(data)];
         }
         catch (error) {
-            log.warn({ host, type, error: reason(error) }, `${type} record of ${host} unparsable:`);
+            log.warn({ host, type: "UNKNOWN_65", error: reason(error) }, `UNKNOWN_65 record of ${host} unparsable:`);
             return [];
         }
     });
@@ -158,7 +158,7 @@ const addresses = {
         const [a, aaaa, https, sale, agents, apex] = await Promise.all([context.dns.query(host, "A"), context.dns.query(host, "AAAA"), context.dns.query(host, "UNKNOWN_65"), context.dns.query(`_for-sale.${zone}`, "TXT"), context.dns.query(`_index._agents.${zone}`, "UNKNOWN_65"), context.dns.query(zone, "CNAME")]);
         const v4 = records(a, "A").map(({ data, ttl }) => ({ address: data, ttl }));
         const v6 = records(aaaa, "AAAA").map(({ data, ttl }) => ({ address: data, ttl }));
-        const hinted = services(host, https, "UNKNOWN_65").map((record) => {
+        const hinted = services(host, https).map((record) => {
             const isHinted = record.ipv4hint !== undefined || record.ipv6hint !== undefined;
             return isHinted && (record.target === "." || isSameName(record.target, host))
                 ? {
@@ -169,7 +169,7 @@ const addresses = {
                 : record;
         });
         const forSale = texts(sale);
-        const agentServices = services(host, agents, "UNKNOWN_65");
+        const agentServices = services(host, agents);
         const authorised = await caa(host, zone, context.dns);
         const allowed = authorised && issuer(host, authorised, context.pages);
         const broken = dangling(host, a);
@@ -851,7 +851,8 @@ const RECOMMENDED = [...CORE, "domain/expiry", "domain/expiring", "domain/lock",
 // The `RULES` entries named by `ids`.
 const pick = (ids) => Object.fromEntries(ids.map((id) => [id, RULES[id]]));
 // Records, CAA, DNSSEC and name servers of every crawled host, asked of the configured resolver.
-export default definePlugin({
+// eslint-disable-next-line unicorn/no-top-level-side-effects -- pick() assembles plain rule data, no IO
+export default {
     name: "dns",
     settings: { type: "object", additionalProperties: false, properties: { compare: { type: "array", items: { type: "string", minLength: 1 }, default: [] }, rdap: { type: "boolean", default: true } } },
     sites: [addresses, dnssec, nameservers, resolvers, rdap],
@@ -861,4 +862,4 @@ export default definePlugin({
         "dns:core": { description: "HTTPS record, CAA and its iodef contact, DNSSEC state and dangling CNAMEs, a handful of queries per host", rules: pick(CORE) },
         "dns:recommended": { description: "dns:core, the registration’s expiry and transfer lock, and name servers open to recursion", rules: pick(RECOMMENDED) },
     },
-});
+};

package/dist/plugins/feed-model.js

@@ -82,7 +82,7 @@ const childOf = (node, local, uri = "") => childrenOf(node, local, uri)[0];
 const textOf = (node) => node?.text.trim() || undefined;
 const typeOf = (node) => (node?.attributes.type === "html" || node?.attributes.type === "xhtml" ? node.attributes.type : "text");
 const dated = (node, field) => (textOf(node) ? { field, raw: textOf(node) } : undefined);
-const emailsOf = (node, names) => names.flatMap((name) => childrenOf(node, name).flatMap((child) => (textOf(child) ? [{ field: name, raw: textOf(child) }] : [])));
+const emailsOf = (node, names) => names.flatMap((name) => childrenOf(node, name).flatMap((child) => (textOf(child) ? { field: name, raw: textOf(child) } : [])));
 // Un-namespaced children `known` does not name, once each.
 const unknownIn = (node, known) => [...new Set((node?.children ?? []).filter((child) => child.uri === "" && !known.has(child.local)).map((child) => child.local))];
 // Atom links of `node` by relation, the default relation `alternate`, resolved against the element’s base.
@@ -105,7 +105,7 @@ function rssItem(node, position, isRdf) {
     const ns = isRdf ? NS.rss1 : "";
     const guid = childOf(node, "guid");
     const id = textOf(guid) ?? node.attributes["rdf:about"];
-    const contents = [childOf(node, "description", ns), childOf(node, "encoded", NS.content)].flatMap((child) => (child && child.text.trim() ? [{ field: child.uri === NS.content ? "content:encoded" : "description", type: "html", value: child.text, ...(child.base && { base: child.base }) }] : []));
+    const contents = [childOf(node, "description", ns), childOf(node, "encoded", NS.content)].flatMap((child) => (child && child.text.trim() ? { field: child.uri === NS.content ? "content:encoded" : "description", type: "html", value: child.text, ...(child.base && { base: child.base }) } : []));
     const title = childOf(node, "title", ns);
     const link = textOf(childOf(node, "link", ns));
     const missing = [...(!title && !childOf(node, "description", ns) ? ["title or description"] : []), ...(isRdf && !link ? ["link"] : [])];

package/dist/plugins/feeds.js

@@ -10,7 +10,7 @@ import { header, linkTargets, pageRule, resolve } from "../rules/builtin.js";
 import { said } from "../rules/message.js";
 import { judgeContent, judgeTitle, wordsOf } from "./feed-content.js";
 import { NS, readJson, readXml } from "./feed-model.js";
-import { definePlugin } from "./types.js";
+import {} from "./types.js";
 const ID = "feed";
 const FEED_TYPES = new Set(["application/rss+xml", "application/atom+xml", "application/rdf+xml", "application/feed+json"]);
 const WRONG_TYPES = new Set(["text/html", "text/plain", "application/octet-stream", ""]);
@@ -243,7 +243,7 @@ async function extract(page, body) {
             return [];
         const url = new URL(enclosure.url, page.url.href);
         url.hash = "";
-        return /^https?:$/.test(url.protocol) ? [{ url: url.href, ...(enclosure.length !== undefined && { length: enclosure.length }), ...(enclosure.type !== undefined && { type: enclosure.type }), position: item.position }] : [];
+        return /^https?:$/.test(url.protocol) ? { url: url.href, ...(enclosure.length !== undefined && { length: enclosure.length }), ...(enclosure.type !== undefined && { type: enclosure.type }), position: item.position } : [];
     }));
     const image = model.itunes.image ? resolve(model.itunes.image, page.url.href) : undefined;
     const itunesImage = image && URL.canParse(image) && /^https?:$/.test(new URL(image).protocol) ? new URL(image).href : undefined;
@@ -335,7 +335,7 @@ const enclosure = pageRule("feeds/enclosure", [`${ID}.enclosures`, "resources"],
         if (!answer)
             return [];
         if (answer.status < 200 || answer.status > 299)
-            return [`item ${position} ${url} answers ${answer.status}`];
+            return `item ${position} ${url} answers ${answer.status}`;
         const faults = [];
         const length = firstHeader(answer.headers["content-length"]);
         if (length !== undefined && declaredLength !== undefined && length !== declaredLength)
@@ -503,8 +503,8 @@ function target(entry, index, site) {
 const itemStatus = siteRule("feeds/item-status", [`${ID}.entries`, "http.status", "site.redirects"], "links items to pages that fail or redirect", (feed, _page, index, site) => (feed.entries ?? []).flatMap((entry) => {
     const { page, landing } = target(entry, index, site);
     if (landing)
-        return [`item ${entry.position} ${entry.link} redirects to ${landing}`];
-    return page && !isOk(page) ? [`item ${entry.position} ${entry.link} answers ${page.http.status}`] : [];
+        return `item ${entry.position} ${entry.link} redirects to ${landing}`;
+    return page && !isOk(page) ? `item ${entry.position} ${entry.link} answers ${page.http.status}` : [];
 }), { docs: DOCS.rss, fix: "Point each item link at the final URL of a page that answers 200." });
 const itemCanonical = siteRule("feeds/item-canonical", [`${ID}.entries`, "html.canonical"], "links items away from their canonical URL", (feed, _page, index, site) => (feed.entries ?? []).flatMap((entry) => {
     const { page, landing } = target(entry, index, site);
@@ -512,7 +512,7 @@ const itemCanonical = siteRule("feeds/item-canonical", [`${ID}.entries`, "html.c
         return [];
     const canonical = resolve(page.html.canonical, page.url.href);
     const here = [page.url.href, page.url.twin, entry.link].flatMap((href) => (href ? [resolve(href, href)] : []));
-    return here.includes(canonical) ? [] : [`item ${entry.position} links ${entry.link}, its canonical is ${canonical}`];
+    return here.includes(canonical) ? [] : `item ${entry.position} links ${entry.link}, its canonical is ${canonical}`;
 }), { docs: DOCS.rss, fix: "Link each item to its page’s canonical URL." });
 const itemTitle = siteRule("feeds/item-title", [`${ID}.entries`, "html.title", "html.property"], "titles items unlike the pages they link", (feed, _page, index, site) => (feed.entries ?? []).flatMap((entry) => {
     const { page, landing } = target(entry, index, site);
@@ -521,21 +521,21 @@ const itemTitle = siteRule("feeds/item-title", [`${ID}.entries`, "html.title", "
     const titles = [page.html.title, page.html.property["og:title"]].flatMap((title) => (title ? [normal(title)] : []));
     // A `Post: ` style label a mixed feed puts before the title is not part of the page’s title.
     const wanted = [normal(entry.title), normal(entry.title.replace(/^[^:]{1,30}:\s+/, ""))];
-    return titles.length === 0 || titles.some((title) => wanted.some((text) => title.includes(text))) ? [] : [`item ${entry.position} “${entry.title}” against “${page.html.title ?? page.html.property["og:title"]}”`];
+    return titles.length === 0 || titles.some((title) => wanted.some((text) => title.includes(text))) ? [] : `item ${entry.position} “${entry.title}” against “${page.html.title ?? page.html.property["og:title"]}”`;
 }), { docs: DOCS.rss, fix: "Use the page’s own title as the item title." });
 const itemDate = siteRule("feeds/item-date", [`${ID}.entries`, "html.published"], "dates items unlike the pages they link", (feed, _page, index, site) => (feed.entries ?? []).flatMap((entry) => {
     const { page, landing } = target(entry, index, site);
     const published = landing ? undefined : page?.html?.published;
     if (!published || !entry.published || Number.isNaN(Date.parse(published)))
         return [];
-    return Math.abs(Date.parse(published) - Date.parse(entry.published)) > DAY_MS ? [`item ${entry.position} ${entry.published}, the page says ${published}`] : [];
+    return Math.abs(Date.parse(published) - Date.parse(entry.published)) > DAY_MS ? `item ${entry.position} ${entry.published}, the page says ${published}` : [];
 }), { docs: DOCS.rss, fix: "Take the item date from the same field the page’s `article:published_time` or `datePublished` comes from." });
 // A feed carrying summaries where readers expect full posts: every linked page far longer than its item.
 const summaryOnly = siteRule("feeds/summary-only", [`${ID}.entries`, "html.text"], "carries summaries while the linked pages say far more", (feed, _page, index, site) => {
     const judged = (feed.entries ?? []).flatMap((entry) => {
         const { page, landing } = target(entry, index, site);
         const pageWords = page?.html?.text;
-        return landing || !page || !pageWords || entry.words === undefined || !isOk(page) || pageWords < 150 ? [] : [{ entry, words: entry.words, pageWords }];
+        return landing || !page || !pageWords || entry.words === undefined || !isOk(page) || pageWords < 150 ? [] : { entry, words: entry.words, pageWords };
     });
     const short = judged.filter(({ words, pageWords }) => words < pageWords * 0.3);
     return short.length === judged.length && judged.length > 0 ? short.map(({ entry, words, pageWords }) => `item ${entry.position}: ${words} words against ${pageWords} on the page`) : [];
@@ -582,8 +582,8 @@ const archive = siteRule("feeds/archive", [`${ID}.archives`, `${ID}.problems.arc
         if (!linked)
             return [];
         if (!isOk(linked))
-            return [`${relation} ${href} answers ${linked.http.status}`];
-        return parsed(linked) ? [] : [`${relation} ${href} is not a feed`];
+            return `${relation} ${href} answers ${linked.http.status}`;
+        return parsed(linked) ? [] : `${relation} ${href} is not a feed`;
     }),
 ], { docs: DOCS.archive, fix: "Point `prev-archive`, `next-archive` and `current` at feed documents that answer 200, and drop them from a complete feed." });
 const ARTWORK_MIN = 1400;
@@ -635,17 +635,17 @@ const feedImages = {
         const problems = declared.flatMap((url) => {
             const file = files[url];
             if (file.error)
-                return [`${url} does not answer (${file.error})`];
+                return `${url} does not answer (${file.error})`;
             if (file.status < 200 || file.status > 299)
-                return [`${url} answers ${file.status}`];
+                return `${url} answers ${file.status}`;
             if (!file.format)
-                return [`${url} is not an image (${file.type || "no type"})`];
+                return `${url} is not an image (${file.type || "no type"})`;
             if (!ARTWORK_TYPES.has(file.format))
-                return [`${url} is ${file.format}, not JPEG or PNG`];
+                return `${url} is ${file.format}, not JPEG or PNG`;
             if (file.width !== file.height)
-                return [`${url} is ${file.width}x${file.height}, not square`];
+                return `${url} is ${file.width}x${file.height}, not square`;
             const width = file.width ?? 0;
-            return width < ARTWORK_MIN || width > ARTWORK_MAX ? [`${url} is ${file.width} px wide, Apple wants ${ARTWORK_MIN}–${ARTWORK_MAX}`] : [];
+            return width < ARTWORK_MIN || width > ARTWORK_MAX ? `${url} is ${file.width} px wide, Apple wants ${ARTWORK_MIN}–${ARTWORK_MAX}` : [];
         });
         log.debug({ origin, declared: declared.length, problems: problems.length }, "podcast artwork measured");
         return { declared, files, "itunes-image": problems };
@@ -752,7 +752,7 @@ const RULES = {
     "feeds/enclosure": enclosure,
     "feeds/podcast-locked": podcastLocked,
 };
-export default definePlugin({
+export default {
     name: "feeds",
     settings: {
         type: "object",
@@ -833,4 +833,4 @@ export default definePlugin({
             },
         },
     },
-});
+};

package/dist/plugins/html-validate.js

@@ -5,7 +5,6 @@ import { HtmlValidate, StaticConfigLoader } from "html-validate";
 import { a11y, document as wholeDocument, recommended, standard } from "html-validate/presets";
 import { log } from "../logger.js";
 import { messageRule } from "./messages.js";
-import { definePlugin } from "./types.js";
 const UPSTREAM = { recommended, document: wholeDocument, standard, a11y };
 const ID = "htmlvalidate";
 const PREFIX = "html-validate/";
@@ -178,7 +177,8 @@ async function extract(page, body) {
     return { messages };
 }
 const rules = Object.fromEntries(Object.keys(severities(BASE)).map((id) => [`${PREFIX}${id}`, rule(id)]));
-export default definePlugin({
+// eslint-disable-next-line unicorn/no-top-level-side-effects -- preset() assembles plain rule data, no IO
+export default {
     name: "html-validate",
     extractors: [{ id: ID, extract }],
     rules,
@@ -188,4 +188,4 @@ export default definePlugin({
         "html-validate:a11y": preset("Accessibility defects html-validate can see in the markup", ["a11y"]),
         "html-validate:document": preset("Defects only a whole document has: doctype, labels, heading levels, SRI", ["document"]),
     },
-});
+};

package/dist/plugins/htmlhint.js

@@ -4,7 +4,6 @@
 import { HTMLHint } from "htmlhint/dist/core/core.js";
 import { log } from "../logger.js";
 import { messageRule } from "./messages.js";
-import { definePlugin } from "./types.js";
 const ID = "htmlhint";
 const PREFIX = "htmlhint/";
 const SOURCE = 120;
@@ -84,7 +83,8 @@ function preset(description, levels) {
     return { description, rules: Object.fromEntries(Object.entries(levels).map(([id, severity]) => [`${PREFIX}${id}`, SCORES[id] === undefined ? severity : { severity, score: SCORES[id] }])) };
 }
 const rules = Object.fromEntries(Object.keys(RULESET).map((id) => [`${PREFIX}${id}`, messageRule(ID, PREFIX, id, `https://htmlhint.com/rules/${id}`, DESCRIPTIONS.get(id))]));
-export default definePlugin({
+// eslint-disable-next-line unicorn/no-top-level-side-effects -- preset() assembles plain rule data, no IO
+export default {
     name: "htmlhint",
     extractors: [{ id: ID, extract }],
     rules,
@@ -92,4 +92,4 @@ export default definePlugin({
         htmlhint: preset("Markup defects htmlhint reports by default: unpaired tags, duplicate IDs and attributes, a missing doctype or title", DEFAULT),
         "htmlhint:extra": preset("Defects htmlhint ships off: missing alt, labels, lang, meta tags, obsolete tags, unsafe attribute characters", EXTRA),
     },
-});
+};

package/dist/plugins/icons.js

@@ -8,7 +8,7 @@ import { reason } from "../crawl/fetch.js";
 import { RobotsDisallowed } from "../crawl/probe.js";
 import { log } from "../logger.js";
 import { mediaType } from "./origin.js";
-import { definePlugin } from "./types.js";
+import {} from "./types.js";
 const ID = "icons";
 const APPLE = "180x180";
 const ICO_SIZES = ["16x16", "32x32"];
@@ -21,7 +21,7 @@ const UNPAINTED = new Set(["none", "transparent", "currentcolor", "inherit"]);
 // Media types an icon may declare, by the format they name.
 const TYPES = { "image/png": "png", "image/x-icon": "ico", "image/vnd.microsoft.icon": "ico", [SVG]: "svg", "image/jpeg": "jpeg", "image/gif": "gif", "image/webp": "webp", "image/avif": "avif" };
 // The lower-cased tokens of a `rel`, `sizes` or `purpose` value.
-const tokens = (value) => (value ?? "").toLowerCase().split(/\s+/).filter(Boolean);
+const tokens = (value = "") => value.toLowerCase().split(/\s+/).filter(Boolean);
 // The sizes an ICO directory lists, 0 standing for 256.
 function icoSizes(bytes) {
     const count = bytes.byteLength >= 6 ? bytes.readUInt16LE(4) : 0;
@@ -173,9 +173,9 @@ function faviconProblems(declared, files, root) {
         const file = files[url];
         const problem = unusable(url, file);
         if (problem)
-            return [problem];
+            return problem;
         const missing = file?.format === "ico" ? ICO_SIZES.filter((size) => !file.sizes?.includes(size)) : [];
-        return missing.length > 0 ? [`${url} holds ${file?.sizes?.join(", ") || "no image"}, not ${ICO_SIZES.join(" and ")}`] : [];
+        return missing.length > 0 ? `${url} holds ${file?.sizes?.join(", ") || "no image"}, not ${ICO_SIZES.join(" and ")}` : [];
     });
 }
 // SVG favicon: one linked with its media type, parsing as XML.
@@ -187,10 +187,10 @@ function svgProblems(declared, files) {
         const file = files[icon.url];
         const problem = unusable(icon.url, file);
         if (problem)
-            return [problem];
+            return problem;
         if (file?.xml === false)
-            return [`${icon.url} does not parse as XML`];
-        return icon.type === SVG ? [] : [`${icon.url} is linked without type="${SVG}"`];
+            return `${icon.url} does not parse as XML`;
+        return icon.type === SVG ? [] : `${icon.url} is linked without type="${SVG}"`;
     });
 }
 // Apple touch icon: linked, or at /apple-touch-icon.png for pages linking none; an opaque PNG, one of them 180×180.
@@ -210,7 +210,7 @@ function appleProblems(declared, files, root, unlinked) {
     }
     const sizes = judged.map((icon) => ("sizes" in icon && icon.sizes ? tokens(icon.sizes)[0] : files[icon.url]?.sizes?.[0]));
     if (judged.length > 0 && !sizes.includes(APPLE))
-        problems.push(`no apple-touch-icon is ${APPLE} (got ${sizes.map((size) => size ?? "unknown").join(", ")})`);
+        problems.push(`no apple-touch-icon is ${APPLE} (got ${sizes.map((size = "unknown") => size).join(", ")})`);
     return problems;
 }
 // Safari pinned tab: a single-colour SVG with a `color`, judged only when linked.
@@ -220,7 +220,7 @@ function maskProblems(declared, files) {
         .flatMap((icon) => {
         const problem = unusable(icon.url, files[icon.url]);
         if (problem)
-            return [problem];
+            return problem;
         const colours = files[icon.url]?.colours ?? 0;
         return [...(files[icon.url]?.format === "svg" ? [] : [`${icon.url} is not an SVG`]), ...(colours > 1 ? [`${icon.url} paints ${colours} colours, not one`] : []), ...(icon.color ? [] : [`${icon.url} is linked without a color`])];
     });
@@ -283,7 +283,8 @@ function problemRule(check, severity, score, message, documentation, fix) {
     // eslint-disable-next-line unicorn/no-incorrect-template-string-interpolation -- {got} is the rule message placeholder
     return { fact: `site.origins.*.${ID}.${check}`, expect: { maxItems: 0 }, message: `${message}: {got}`, severity, score, docs: documentation, fix };
 }
-export default definePlugin({
+// eslint-disable-next-line unicorn/no-top-level-side-effects -- problemRule() assembles plain rule data, no IO
+export default {
     name: ID,
     sites: [icons],
     presets: {
@@ -299,4 +300,4 @@ export default definePlugin({
             },
         },
     },
-});
+};

package/dist/plugins/images.js

@@ -8,7 +8,6 @@ import { optimize } from "svgo";
 import { log } from "../logger.js";
 import { resourceRule } from "../rules/builtin.js";
 import { said } from "../rules/message.js";
-import { definePlugin } from "./types.js";
 const ID = "images";
 const TEXT = "text";
 const FONTS = "fonts";
@@ -230,7 +229,7 @@ const oversized = (severity, settings) => {
 const lazyBelow = layoutRule("images/lazy-below-fold", "https://web.dev/articles/browser-level-image-lazy-loading", said("an <img> below the fold without loading=lazy loads before the reader scrolls"), (layout, box) => (box.top >= layout.viewport.height && box.loading !== "lazy" ? `${box.src} at ${box.top} px` : undefined), "Add loading=lazy to off-screen images.");
 const lazyAbove = layoutRule("images/lazy-above-fold", "https://web.dev/articles/lcp-lazy-loading", said("an <img> in the first viewport with loading=lazy waits for layout before loading"), (layout, box) => (box.top < layout.viewport.height && box.loading === "lazy" ? `${box.src} at ${box.top} px` : undefined), "Remove loading=lazy from images in the first viewport.");
 const renderedOversize = layoutRule("images/rendered-oversize", "https://web.dev/articles/serve-responsive-images", said("an <img> ships far more pixels than the page renders"), (layout, box, settings) => (box.natural > box.width * layout.viewport.dpr * settings.oversize ? `${box.src} ${box.natural} px shown at ${box.width} px` : undefined), "Serve an image whose natural width matches what the layout renders.");
-export default definePlugin({
+export default {
     name: "images",
     settings: SETTINGS,
     extractors: [{ id: LAYOUT, mode: "browser", cost: "expensive", inputs: ["resources"], extract: async (_page, _body, live) => live && (await live.evaluate(LAYOUT_SCRIPT)) }],
@@ -266,4 +265,4 @@ export default definePlugin({
             rules: { "images/lazy-below-fold": { severity: "warning", score: 4.8 }, "images/lazy-above-fold": { severity: "warning", score: 5.8 }, "images/rendered-oversize": { severity: "warning", score: 4.4 } },
         },
     },
-});
+};

package/dist/plugins/index.js

@@ -212,7 +212,7 @@ export function extractorsFor(rules) {
 export function siteExtractorsFor(rules) {
     const read = new Set(rules.flatMap((rule) => rule.meta.facts.flatMap((fact) => {
         const subject = subjectPath(fact);
-        return subject ? [`${subject.kind}\t${subject.id}`] : [];
+        return subject ? `${subject.kind}\t${subject.id}` : [];
     })));
     const active = plugins.flatMap((plugin) => (plugin.sites ?? []).filter((extractor) => read.has(`${extractor.per}s\t${extractor.id}`)).map((extractor) => (settings.has(plugin.name) ? { ...extractor, settings: settings.get(plugin.name) } : extractor)));
     log.debug({ extractors: active.map((extractor) => extractor.id), read: read.size }, "site extractors chosen");

package/dist/plugins/keyboard.js

@@ -4,7 +4,6 @@
 import { log } from "../logger.js";
 import { pageRule } from "../rules/builtin.js";
 import { said } from "../rules/message.js";
-import { definePlugin } from "./types.js";
 import { DESCRIBE, visit, withPage } from "./visit.js";
 const ID = "keyboard";
 // Tab presses allowed per candidate, beyond the count, and in all.
@@ -175,7 +174,7 @@ const skipLink = pageRule("keyboard/skip-link", [`${ID}.first`], (page) => {
         return;
     return first["in-main"] || first["skips-to"]?.main ? [] : [{ ...said("the first Tab stop is not a link to the main content"), value: first, locations: [first.target] }];
 }, { docs: "https://www.w3.org/WAI/WCAG22/Techniques/general/G1", fix: 'Make the first focusable element `<a href="#main">Skip to content</a>`, pointing at `<main id="main">`.' });
-export default definePlugin({
+export default {
     name: "keyboard",
     extractors: [{ id: ID, mode: "browser", cost: "expensive", inputs: ["resources"], extract }],
     rules: { "keyboard/tab-walk": tabWalk, "keyboard/focus-visible": focusVisible, "keyboard/focus-obscured": focusObscured, "keyboard/forced-focus": forcedFocus, "keyboard/skip-link": skipLink },
@@ -191,4 +190,4 @@ export default definePlugin({
             },
         },
     },
-});
+};