spice-js 2.7.24 → 2.7.26

package/build/models/SpiceModel.js

@@ -696,6 +696,9 @@ class SpiceModel {
       try {
         if (_.isString(data)) {
           var result = yield _this7.database.get(data);
+          if (!result) {
+            return false;
+          }
           if (result.type) if (result.type != _this7.type) {
             return false;
           }
@@ -703,6 +706,9 @@ class SpiceModel {
             return false;
           }
         } else {
+          if (!data) {
+            return false;
+          }
           if (data.type) if (data.type != _this7.type) {
             return false;
           }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "spice-js",
-  "version": "2.7.24",
+  "version": "2.7.26",
   "description": "spice",
   "main": "build/index.js",
   "repository": {

package/src/models/SpiceModel.js

@@ -762,6 +762,9 @@ export default class SpiceModel {
     try {
       if (_.isString(data)) {
         let result = await this.database.get(data);
+        if (!result) {
+          return false;
+        }
         if (result.type)
           if (result.type != this.type) {
             return false;
@@ -771,6 +774,9 @@ export default class SpiceModel {
             return false;
           }
       } else {
+        if (!data) {
+          return false;
+        }
         if (data.type)
           if (data.type != this.type) {
             return false;

package/tests/__mocks__/spice-couchbase.js

@@ -32,6 +32,18 @@ class MockDatabase {
     return this.mockData.get(id);
   }
 
+  /**
+   * Mock update operation
+   * @param {string} id - Document ID to update
+   * @param {Object} data - Updated document data
+   * @returns {Promise<Object>} Updated document
+   */
+  async update(id, data, ttl) {
+    const updated = { ...data, id };
+    this.mockData.set(id, updated);
+    return updated;
+  }
+
   /**
    * Seed mock database with test data
    * @param {string} id - Document ID

package/tests/models/SpiceModel.test.js

@@ -578,6 +578,12 @@ describe('SpiceModel - Critical Fixes for Empty/Null Values', () => {
       model = createTestModel({ type: 'user' });
     });
 
+    test('should fail update with a controlled not-found error when database returns undefined', async () => {
+      await expect(
+        model.update({ id: 'missing-user' })
+      ).rejects.toThrow('user does not exist. in update');
+    });
+
     test('should handle undefined columns parameter', async () => {
       seedDatabase(model, sampleDbResults.users);