spessasynth_lib 3.24.15 → 3.24.18

package/synthetizer/worklet_system/worklet_methods/controller_control/controller_change.js

@@ -47,6 +47,10 @@ export function controllerChange(controllerNumber, controllerValue, force = fals
         this.midiControllers[actualCCNum] = (this.midiControllers[actualCCNum] & 0x3F80) | (controllerValue & 0x7F);
         this.voices.forEach(v => computeModulators(v, this.midiControllers, 1, actualCCNum));
     }
+    if (this.lockedControllers[controllerNumber])
+    {
+        return;
+    }
     switch (controllerNumber)
     {
         case midiControllers.allNotesOff:
@@ -180,10 +184,6 @@ export function controllerChange(controllerNumber, controllerValue, force = fals
         
         // default: apply the controller to the table
         default:
-            if (this.lockedControllers[controllerNumber])
-            {
-                return;
-            }
             this.midiControllers[controllerNumber] = controllerValue << 7;
             this.voices.forEach(v => computeModulators(v, this.midiControllers, 1, controllerNumber));
             break;

package/synthetizer/worklet_system/worklet_methods/controller_control/reset_controllers.js

@@ -124,7 +124,7 @@ export function resetControllers()
     {
         if (this.lockedControllers[i])
         {
-            return;
+            continue;
         }
         const resetValue = resetArray[i];
         if (this.midiControllers[i] !== resetValue && i < 127)

package/synthetizer/worklet_system/worklet_methods/stopping_notes/kill_note.js

@@ -3,9 +3,10 @@ import { generatorTypes } from "../../../../soundfont/basic_soundfont/generator.
 /**
  * Stops a note nearly instantly
  * @param midiNote {number}
+ * @param releaseTime {number} ticks
  * @this {WorkletProcessorChannel}
  */
-export function killNote(midiNote)
+export function killNote(midiNote, releaseTime = -12000)
 {
     this.voices.forEach(v =>
     {
@@ -13,7 +14,7 @@ export function killNote(midiNote)
         {
             return;
         }
-        v.modulatedGenerators[generatorTypes.releaseVolEnv] = -12000; // set release to be very short
+        v.modulatedGenerators[generatorTypes.releaseVolEnv] = releaseTime; // set release to be very short
         v.release();
     });
 }

package/synthetizer/worklet_system/worklet_methods/stopping_notes/note_off.js

@@ -21,7 +21,11 @@ export function noteOff(midiNote)
         // if the channel is percussion channel, do not kill the notes
         if (!this.drumChannel)
         {
-            this.killNote(realKey);
+            this.killNote(realKey, -6950);
+            this.synth.callEvent("noteoff", {
+                midiNote: midiNote,
+                channel: this.channelNumber
+            });
             return;
         }
     }

package/synthetizer/worklet_system/worklet_utilities/lowpass_filter.js

@@ -146,55 +146,63 @@ export class WorkletLowpassFilter
         const cutoffCents = ~~filter.cutoffCents; // Math.floor
         const qCb = filter.reasonanceCb;
         // check if these coefficients were already cached
-        if (WorkletLowpassFilter.cachedCoefficients?.[qCb]?.[cutoffCents] === undefined)
+        const cached = WorkletLowpassFilter.cachedCoefficients?.[qCb]?.[cutoffCents];
+        if (cached !== undefined)
         {
-            let cutoffHz = absCentsToHz(cutoffCents);
-            
-            // fix cutoff on low frequencies (fluid_iir_filter.c line 392)
-            cutoffHz = Math.min(cutoffHz, 0.45 * sampleRate);
-            
-            const qDb = qCb / 10;
-            // correct the filter gain, like fluid does
-            const reasonanceGain = decibelAttenuationToGain(-1 * (qDb - 3.01)); // -1 because it's attenuation, and we don't want attenuation
-            
-            // reduce the gain by the Q factor (fluid_iir_filter.c line 250)
-            const qGain = 1 / Math.sqrt(decibelAttenuationToGain(-qDb));
-            
-            
-            // initial filtering code was ported from meltysynth created by sinshu.
-            let w = 2 * Math.PI * cutoffHz / sampleRate; // we're in the AudioWorkletGlobalScope so we can use sampleRate
-            let cosw = Math.cos(w);
-            let alpha = Math.sin(w) / (2 * reasonanceGain);
-            
-            let b1 = (1 - cosw) * qGain;
-            let b0 = b1 / 2;
-            let b2 = b0;
-            let a0 = 1 + alpha;
-            let a1 = -2 * cosw;
-            let a2 = 1 - alpha;
-            
-            /**
-             * set coefficients
-             * @type {CachedCoefficient}
-             */
-            const toCache = {};
-            toCache.a0 = b0 / a0;
-            toCache.a1 = b1 / a0;
-            toCache.a2 = b2 / a0;
-            toCache.a3 = a1 / a0;
-            toCache.a4 = a2 / a0;
-            
-            if (WorkletLowpassFilter.cachedCoefficients[qCb] === undefined)
-            {
-                WorkletLowpassFilter.cachedCoefficients[qCb] = [];
-            }
-            WorkletLowpassFilter.cachedCoefficients[qCb][cutoffCents] = toCache;
+            filter.a0 = cached.a0;
+            filter.a1 = cached.a1;
+            filter.a2 = cached.a2;
+            filter.a3 = cached.a3;
+            filter.a4 = cached.a4;
+            return;
+        }
+        let cutoffHz = absCentsToHz(cutoffCents);
+        
+        // fix cutoff on low frequencies (fluid_iir_filter.c line 392)
+        cutoffHz = Math.min(cutoffHz, 0.45 * sampleRate);
+        
+        const qDb = qCb / 10;
+        // correct the filter gain, like fluid does
+        const reasonanceGain = decibelAttenuationToGain(-1 * (qDb - 3.01)); // -1 because it's attenuation, and we don't want attenuation
+        
+        // reduce the gain by the Q factor (fluid_iir_filter.c line 250)
+        const qGain = 1 / Math.sqrt(decibelAttenuationToGain(-qDb));
+        
+        
+        // initial filtering code was ported from meltysynth created by sinshu.
+        let w = 2 * Math.PI * cutoffHz / sampleRate; // we're in the AudioWorkletGlobalScope so we can use sampleRate
+        let cosw = Math.cos(w);
+        let alpha = Math.sin(w) / (2 * reasonanceGain);
+        
+        let b1 = (1 - cosw) * qGain;
+        let b0 = b1 / 2;
+        let b2 = b0;
+        let a0 = 1 + alpha;
+        let a1 = -2 * cosw;
+        let a2 = 1 - alpha;
+        
+        /**
+         * set coefficients
+         * @type {CachedCoefficient}
+         */
+        const toCache = {};
+        toCache.a0 = b0 / a0;
+        toCache.a1 = b1 / a0;
+        toCache.a2 = b2 / a0;
+        toCache.a3 = a1 / a0;
+        toCache.a4 = a2 / a0;
+        filter.a0 = toCache.a0;
+        filter.a1 = toCache.a1;
+        filter.a2 = toCache.a2;
+        filter.a3 = toCache.a3;
+        filter.a4 = toCache.a4;
+        
+        if (WorkletLowpassFilter.cachedCoefficients[qCb] === undefined)
+        {
+            WorkletLowpassFilter.cachedCoefficients[qCb] = [];
         }
-        const cached = WorkletLowpassFilter.cachedCoefficients[qCb][cutoffCents];
-        filter.a0 = cached.a0;
-        filter.a1 = cached.a1;
-        filter.a2 = cached.a2;
-        filter.a3 = cached.a3;
-        filter.a4 = cached.a4;
+        WorkletLowpassFilter.cachedCoefficients[qCb][cutoffCents] = toCache;
+        
+        
     }
 }