spessasynth_lib 3.22.12 → 3.23.0

package/synthetizer/worklet_system/main_processor.js

@@ -62,6 +62,8 @@ import { panVoice } from "./worklet_utilities/stereo_panner.js";
 // if the note is released faster than that, it forced to last that long
 // this is used mostly for drum channels, where a lot of midis like to send instant note off after a note on
 export const MIN_NOTE_LENGTH = 0.03;
+// this sounds way nicer for instant hi-hat cutoff
+export const MIN_EXCLUSIVE_LENGTH = 0.07;
 
 export const SYNTHESIZER_GAIN = 1.0;
 

package/synthetizer/worklet_system/worklet_methods/note_on.js

@@ -2,6 +2,7 @@ import { computeModulators } from "../worklet_utilities/worklet_modulator.js";
 import { WorkletVolumeEnvelope } from "../worklet_utilities/volume_envelope.js";
 import { WorkletModulationEnvelope } from "../worklet_utilities/modulation_envelope.js";
 import { generatorTypes } from "../../../soundfont/basic_soundfont/generator.js";
+import { MIN_EXCLUSIVE_LENGTH } from "../main_processor.js";
 
 /**
  * Append the voices
@@ -80,7 +81,7 @@ export function noteOn(channel, midiNote, velocity, enableDebugging = false, sen
             {
                 if (v.generators[generatorTypes.exclusiveClass] === exclusive)
                 {
-                    this.releaseVoice(v);
+                    this.releaseVoice(v, MIN_EXCLUSIVE_LENGTH);
                     v.modulatedGenerators[generatorTypes.releaseVolEnv] = -7000; // make the release nearly instant
                     v.modulatedGenerators[generatorTypes.releaseModEnv] = -7000;
                     WorkletVolumeEnvelope.recalculate(v);

package/synthetizer/worklet_system/worklet_methods/reset_controllers.js

@@ -131,13 +131,6 @@ export function resetControllers(channel)
         return lockedCCs;
     }, []);
     // save excluded controllers as reset doesn't affect them
-    let excludedCCvalues = excludedCCs.map(ccNum =>
-    {
-        return {
-            ccNum: ccNum,
-            ccVal: channelObject.midiControllers[ccNum]
-        };
-    });
     
     channelObject.channelOctaveTuning.fill(0);
     channelObject.keyCentTuning.fill(0);
@@ -145,6 +138,10 @@ export function resetControllers(channel)
     // reset the array
     for (let i = 0; i < resetArray.length; i++)
     {
+        if (channelObject.lockedControllers[i])
+        {
+            return;
+        }
         const resetValue = resetArray[i];
         if (channelObject.midiControllers[i] !== resetValue && i < 127)
         {
@@ -160,11 +157,6 @@ export function resetControllers(channel)
     channelObject.channelVibrato = { rate: 0, depth: 0, delay: 0 };
     channelObject.holdPedal = false;
     
-    excludedCCvalues.forEach((cc) =>
-    {
-        channelObject.midiControllers[cc.ccNum] = cc.ccVal;
-    });
-    
     // reset custom controllers
     // special case: transpose does not get affected
     const transpose = channelObject.customControllers[customControllers.channelTransposeFine];

package/synthetizer/worklet_system/worklet_methods/voice_control.js

@@ -260,14 +260,15 @@ export function voiceKilling(amount)
 /**
  * Stops the voice
  * @param voice {WorkletVoice} the voice to stop
+ * @param minNoteLength {number} minimum note length in seconds
  * @this {SpessaSynthProcessor}
  */
-export function releaseVoice(voice)
+export function releaseVoice(voice, minNoteLength = MIN_NOTE_LENGTH)
 {
     voice.releaseStartTime = currentTime;
     // check if the note is shorter than the min note time, if so, extend it
-    if (voice.releaseStartTime - voice.startTime < MIN_NOTE_LENGTH)
+    if (voice.releaseStartTime - voice.startTime < minNoteLength)
     {
-        voice.releaseStartTime = voice.startTime + MIN_NOTE_LENGTH;
+        voice.releaseStartTime = voice.startTime + minNoteLength;
     }
 }

package/synthetizer/worklet_system/worklet_utilities/worklet_voice.js

@@ -332,7 +332,7 @@ export function getWorkletVoices(channel,
      */
     let workletVoices;
     
-    const cached = channelObject.cachedVoices[midiNote][velocity];
+    const cached = channelObject.cachedVoices[midiNote]?.[velocity];
     
     // override patch
     const overridePatch = this.keyModifierManager.hasOverridePatch(channel, midiNote);

package/utils/byte_functions/string.js

@@ -20,7 +20,7 @@ export function readBytesAsString(dataArray, bytes, encoding = undefined, trimEn
             {
                 continue;
             }
-            if (byte < 32 || byte > 127)
+            if ((byte < 32 || byte > 127) && byte !== 10) // 10 is "\n"
             {
                 if (trimEnd)
                 {