spessasynth_lib 3.21.7 → 3.21.9

package/@types/index.d.ts

@@ -6,7 +6,6 @@ import { BasicSoundFont } from "./soundfont/basic_soundfont/basic_soundfont.js";
 import { loadSoundFont } from "./soundfont/load_soundfont.js";
 import { trimSoundfont } from "./soundfont/basic_soundfont/write_sf2/soundfont_trimmer.js";
 import { modulatorSources } from "./soundfont/basic_soundfont/modulator.js";
-import { encodeVorbis } from "./utils/encode_vorbis.js";
 import { MIDI } from './midi_parser/midi_loader.js';
 import { MIDIBuilder } from "./midi_parser/midi_builder.js";
 import { IndexedByteArray } from './utils/indexed_array.js';
@@ -35,4 +34,4 @@ import { readBytesAsUintBigEndian } from './utils/byte_functions/big_endian.js';
 import { NON_CC_INDEX_OFFSET } from "./synthetizer/worklet_system/worklet_utilities/controller_tables.js";
 import { ALL_CHANNELS_OR_DIFFERENT_ACTION } from './synthetizer/worklet_system/message_protocol/worklet_message.js';
 import { WORKLET_URL_ABSOLUTE } from './synthetizer/worklet_url.js';
-export { Sequencer, Synthetizer, DEFAULT_PERCUSSION, VOICE_CAP, BasicSoundFont, loadSoundFont, trimSoundfont, modulatorSources, encodeVorbis, MIDI, MIDIBuilder, IndexedByteArray, writeMIDIFile, writeRMIDI, applySnapshotToMIDI, modifyMIDI, MIDIticksToSeconds, audioBufferToWav, SpessaSynthLogging, SpessaSynthGroup, SpessaSynthTable, SpessaSynthGroupEnd, SpessaSynthInfo, SpessaSynthWarn, SpessaSynthGroupCollapsed, midiControllers, messageTypes, MIDIDeviceHandler, WebMidiLinkHandler, arrayToHexString, consoleColors, formatTitle, formatTime, readBytesAsUintBigEndian, NON_CC_INDEX_OFFSET, ALL_CHANNELS_OR_DIFFERENT_ACTION, WORKLET_URL_ABSOLUTE };
+export { Sequencer, Synthetizer, DEFAULT_PERCUSSION, VOICE_CAP, BasicSoundFont, loadSoundFont, trimSoundfont, modulatorSources, MIDI, MIDIBuilder, IndexedByteArray, writeMIDIFile, writeRMIDI, applySnapshotToMIDI, modifyMIDI, MIDIticksToSeconds, audioBufferToWav, SpessaSynthLogging, SpessaSynthGroup, SpessaSynthTable, SpessaSynthGroupEnd, SpessaSynthInfo, SpessaSynthWarn, SpessaSynthGroupCollapsed, midiControllers, messageTypes, MIDIDeviceHandler, WebMidiLinkHandler, arrayToHexString, consoleColors, formatTitle, formatTime, readBytesAsUintBigEndian, NON_CC_INDEX_OFFSET, ALL_CHANNELS_OR_DIFFERENT_ACTION, WORKLET_URL_ABSOLUTE };

package/@types/soundfont/basic_soundfont/modulator.d.ts

@@ -62,6 +62,18 @@ export class Modulator {
     secSrcUsesCC: number;
     secSrcIndex: number;
     secSrcCurveType: number;
+    /**
+     * Indicates if the given modulator is chorus or reverb effects modulator.
+     * This is done to simulate BASSMIDI effects behavior:
+     * - defaults to 1000 transform amount rather than 200
+     * - values can be changed, but anything above 200 is 1000
+     * (except for values above 1000, they are copied directly)
+     * - all values below are multiplied by 5 (200 * 5 = 1000)
+     * - still can be disabled if the soundfont has its own modulator curve
+     * - this fixes the very low amount of reverb by default and doesn't break soundfonts
+     * @type {boolean}
+     */
+    isEffectModulator: boolean;
     /**
      * Sums transform and creates a NEW modulator
      * @param modulator {Modulator}

package/externals/NOTICE

@@ -2,8 +2,4 @@ LICENSE is for stbvorbis_sync.js which is licensed under Apache-2.0
 
 Modifications made to stbvorbis_sync.js
 1. minified the code
-2. added types declaration
-
-OggVorbisEncoder (https://github.com/higuma/ogg-vorbis-encoder-js)
-is licensed under MIT.
-The file provided is a slight modification to work with es6.
+2. added types declaration

package/index.js

@@ -29,8 +29,7 @@ import { modulatorSources } from "./soundfont/basic_soundfont/modulator.js";
 import { NON_CC_INDEX_OFFSET } from "./synthetizer/worklet_system/worklet_utilities/controller_tables.js";
 import { ALL_CHANNELS_OR_DIFFERENT_ACTION } from './synthetizer/worklet_system/message_protocol/worklet_message.js';
 import { trimSoundfont} from "./soundfont/basic_soundfont/write_sf2/soundfont_trimmer.js";
-import { WORKLET_URL_ABSOLUTE } from './synthetizer/worklet_url.js'
-import { encodeVorbis} from "./utils/encode_vorbis.js";
+import { WORKLET_URL_ABSOLUTE } from './synthetizer/worklet_url.js';
 
 // Export modules
 export {
@@ -45,7 +44,6 @@ export {
     loadSoundFont,
     trimSoundfont,
     modulatorSources,
-    encodeVorbis,
 
     // MIDI
     MIDI,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "spessasynth_lib",
-  "version": "3.21.7",
+  "version": "3.21.9",
   "description": "MIDI and SoundFont2/DLS library with no compromises",
   "browser": "index.js",
   "types": "@types/index.d.ts",

package/soundfont/basic_soundfont/modulator.js

@@ -67,7 +67,27 @@ export class Modulator
         this.secSrcIndex = this.secondarySourceEnum & 127;
         this.secSrcCurveType = this.secondarySourceEnum >> 10 & 3;
         
-        //this.precomputeModulatorTransform();
+        /**
+         * Indicates if the given modulator is chorus or reverb effects modulator.
+         * This is done to simulate BASSMIDI effects behavior:
+         * - defaults to 1000 transform amount rather than 200
+         * - values can be changed, but anything above 200 is 1000
+         * (except for values above 1000, they are copied directly)
+         * - all values below are multiplied by 5 (200 * 5 = 1000)
+         * - still can be disabled if the soundfont has its own modulator curve
+         * - this fixes the very low amount of reverb by default and doesn't break soundfonts
+         * @type {boolean}
+         */
+        this.isEffectModulator =
+            (
+                this.sourceEnum === 0x00DB
+                || this.sourceEnum === 0x00DD
+            )
+            && this.secondarySourceEnum === 0x0
+            && (
+                this.modulatorDestination === generatorTypes.reverbEffectsSend
+                || this.modulatorDestination === generatorTypes.chorusEffectsSend
+            );
     }
     
     /**
@@ -225,10 +245,10 @@ export const defaultModulators = [
     }),
     
     // reverb effects to send
-    new Modulator({ srcEnum: 0x00DB, dest: generatorTypes.reverbEffectsSend, amt: 750, secSrcEnum: 0x0, transform: 0 }),
+    new Modulator({ srcEnum: 0x00DB, dest: generatorTypes.reverbEffectsSend, amt: 200, secSrcEnum: 0x0, transform: 0 }),
     
     // chorus effects to send
-    new Modulator({ srcEnum: 0x00DD, dest: generatorTypes.chorusEffectsSend, amt: 750, secSrcEnum: 0x0, transform: 0 }),
+    new Modulator({ srcEnum: 0x00DD, dest: generatorTypes.chorusEffectsSend, amt: 200, secSrcEnum: 0x0, transform: 0 }),
     
     // custom modulators heck yeah
     // poly pressure to vibrato