spessasynth_lib 3.20.4 → 3.20.6

package/synthetizer/worklet_system/worklet_methods/controller_control.js

@@ -2,7 +2,7 @@ import { consoleColors } from '../../../utils/other.js'
 import { midiControllers } from '../../../midi_parser/midi_message.js'
 import { dataEntryStates } from '../worklet_utilities/worklet_processor_channel.js'
 import { computeModulators } from '../worklet_utilities/worklet_modulator.js'
-import { SpessaSynthInfo } from '../../../utils/loggin.js'
+import { SpessaSynthInfo, SpessaSynthWarn } from '../../../utils/loggin.js'
 import { SYNTHESIZER_GAIN } from '../main_processor.js'
 
 /**
@@ -18,6 +18,11 @@ export function controllerChange(channel, controllerNumber, controllerValue, for
      * @type {WorkletProcessorChannel}
      */
     const channelObject = this.workletProcessorChannels[channel];
+    if(channelObject === undefined)
+    {
+        SpessaSynthWarn(`Trying to access channel ${channel} which does not exist... ignoring!`);
+        return;
+    }
     // lsb controller values: append them as the lower nibble of the 14 bit value
     // excluding bank select and data entry as it's handled separately
     if(

package/synthetizer/worklet_system/worklet_methods/program_control.js

@@ -2,7 +2,7 @@ import { midiControllers } from '../../../midi_parser/midi_message.js'
 import { clearSamplesList } from '../worklet_utilities/worklet_voice.js'
 import { generatorTypes } from '../../../soundfont/read_sf2/generators.js'
 import { returnMessageType } from '../message_protocol/worklet_message.js'
-import { SpessaSynthInfo } from '../../../utils/loggin.js'
+import { SpessaSynthInfo, SpessaSynthWarn } from '../../../utils/loggin.js'
 import { consoleColors } from '../../../utils/other.js'
 import { loadSoundFont } from '../../../soundfont/load_soundfont.js'
 
@@ -19,6 +19,11 @@ export function programChange(channel, programNumber, userChange=false)
      * @type {WorkletProcessorChannel}
      */
     const channelObject = this.workletProcessorChannels[channel];
+    if(channelObject === undefined)
+    {
+        SpessaSynthWarn(`Trying to access channel ${channel} which does not exist... ignoring!`);
+        return;
+    }
     if(channelObject.lockPreset)
     {
         return;

package/synthetizer/worklet_system/worklet_methods/system_exclusive.js

@@ -463,6 +463,11 @@ export function systemExclusive(messageData, channelOffset = 0)
                         return;
                     }
                     const channel = messageData[4] + channelOffset;
+                    if(channel >= this.workletProcessorChannels.length)
+                    {
+                        // invalid channel
+                        return;
+                    }
                     const value = messageData[6];
                     switch (messageData[5])
                     {
@@ -481,6 +486,17 @@ export function systemExclusive(messageData, channelOffset = 0)
                             this.programChange(channel, value);
                             break;
 
+                        // note shift
+                        case 0x08:
+                            const chan = this.workletProcessorChannels[channel];
+                            if(chan.drumChannel)
+                            {
+                                return;
+                            }
+                            const semitones = value - 64;
+                            chan.channelTransposeKeyShift = semitones;
+                            break;
+
                         // volume
                         case 0x0B:
                             this.controllerChange(channel, midiControllers.mainVolume, value);

package/synthetizer/worklet_system/worklet_methods/voice_control.js

@@ -1,5 +1,5 @@
 import { generatorTypes } from '../../../soundfont/read_sf2/generators.js'
-import { absCentsToHz, decibelAttenuationToGain, timecentsToSeconds } from '../worklet_utilities/unit_converter.js'
+import { absCentsToHz, timecentsToSeconds } from '../worklet_utilities/unit_converter.js'
 import { getLFOValue } from '../worklet_utilities/lfo.js'
 import { customControllers } from '../worklet_utilities/worklet_processor_channel.js'
 import { WorkletModulationEnvelope } from '../worklet_utilities/modulation_envelope.js'

package/synthetizer/worklet_system/worklet_utilities/volume_envelope.js

@@ -249,6 +249,15 @@ export class WorkletVolumeEnvelope
             // as the instant notes don't end instantly when they should
             const releaseSmoothingFactor = smoothingFactor * 10;
             let elapsedRelease = env.currentSampleTime - env.releaseStartTimeSamples;
+            if(elapsedRelease >= env.releaseDuration)
+            {
+                for (let i = 0; i < audioBuffer.length; i++)
+                {
+                    audioBuffer[i] = 0;
+                }
+                voice.finished = true;
+                return;
+            }
             let dbDifference = DB_SILENCE - env.releaseStartDb;
             let db = 0;
             for (let i = 0; i < audioBuffer.length; i++)