spessasynth_lib 3.20.10 → 3.20.12

package/@types/synthetizer/synthetizer.d.ts

@@ -1,3 +1,13 @@
+/**
+ * synthesizer.js
+ * purpose: responds to midi messages and called functions, managing the channels and passing the messages to them
+ */
+/**
+ * @typedef {Object} StartRenderingDataConfig
+ * @property {BasicMIDI} parsedMIDI - the MIDI to render
+ * @property {SynthesizerSnapshot} snapshot - the snapshot to apply
+ * @property {boolean|undefined} oneOutput - if synth should use one output with 32 channels (2 audio channels for each midi channel). this disables chorus and reverb.
+ */
 export const WORKLET_PROCESSOR_NAME: "spessasynth-worklet-system";
 export const VOICE_CAP: 450;
 export const DEFAULT_PERCUSSION: 9;

package/midi_parser/midi_editor.js

@@ -296,7 +296,7 @@ export function modifyMIDI(
         /**
          * @type {{index: number, track: number}[]}
          */
-        const firstNoteOnForTrack = getFirstVoiceForChannel(midiChannel, port, offset > 0);
+        const firstNoteOnForTrack = getFirstVoiceForChannel(midiChannel, port, true);
         if(firstNoteOnForTrack.length === 0)
         {
             SpessaSynthWarn("Program change but no notes... ignoring!");

package/midi_parser/rmidi_writer.js

@@ -230,7 +230,8 @@ export function writeRMIDI(
                         consoleColors.info);
                 } else {
                     // there is a preset with this bank. add offset. For drums add the normal offset.
-                    const newBank = (bank === 128 ? 0 : realBank) + bankOffset;
+                    let drumBank = system === "xg" ? 127 : 0;
+                    const newBank = (bank === 128 ? drumBank : realBank) + bankOffset;
                     channel.lastBank.messageData[1] = newBank;
                     SpessaSynthInfo(`%cPreset %c${bank}:${e.messageData[0]}%c exists. Changing bank to ${newBank}.`,
                         consoleColors.info,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "spessasynth_lib",
-  "version": "3.20.10",
+  "version": "3.20.12",
   "description": "MIDI and SoundFont2 or DLS Synthesizer library with no compromises",
   "browser": "index.js",
   "types": "@types/index.d.ts",

package/sequencer/worklet_sequencer/song_control.js

@@ -57,11 +57,7 @@ export function loadNewSequence(parsedMidi)
     if(this.midiData.embeddedSoundFont !== undefined)
     {
         SpessaSynthInfo("%cEmbedded soundfont detected! Using it.", consoleColors.recognized);
-        // set offet
-        this.synth.soundfontBankOffset = this.midiData.bankOffset;
-        this.synth.reloadSoundFont(this.midiData.embeddedSoundFont, true);
-        // preload all samples
-        this.synth.overrideSoundfont.samples.forEach(s => s.getAudioData());
+        this.synth.setEmbeddedSoundFont(this.midiData.embeddedSoundFont, this.midiData.bankOffset);
     }
     else
     {

package/synthetizer/synthetizer.js

@@ -26,8 +26,6 @@ import { SoundfontManager } from './synth_soundfont_manager.js'
  * @property {boolean|undefined} oneOutput - if synth should use one output with 32 channels (2 audio channels for each midi channel). this disables chorus and reverb.
  */
 
-const CURRENT_SPESSASYNTH_VERSION = "3.20.10";
-
 export const WORKLET_PROCESSOR_NAME = "spessasynth-worklet-system";
 
 export const VOICE_CAP = 450;
@@ -325,14 +323,6 @@ export class Synthetizer {
                 SpessaSynthWarn(new Error(messageData));
                 this.eventHandler.callEvent("soundfonterror", messageData);
                 break;
-
-            case returnMessageType.identify:
-                if(messageData !== CURRENT_SPESSASYNTH_VERSION)
-                {
-                    this.stopAll(true);
-                    this.worklet.disconnect();
-                    throw new Error(`Outdated worklet_processor.min.js! version: ${messageData}. Please update it to ${CURRENT_SPESSASYNTH_VERSION}`);
-                }
         }
     }