spessasynth_core 4.3.17 → 4.3.19

package/dist/index.js

@@ -4615,10 +4615,12 @@ var BasicMIDI = class BasicMIDI {
 									if (e.data[1] === 0) loopStart = e.ticks;
 									break;
 								case MIDIControllers.undefinedCC116LSB:
+								case MIDIControllers.undefinedCC118LSB:
 									loopStart = e.ticks;
 									break;
 								case MIDIControllers.footController:
 								case MIDIControllers.undefinedCC117LSB:
+								case MIDIControllers.undefinedCC119LSB:
 									if (loopEnd === null && (e.data[0] !== 4 || e.data[0] === 4 && e.data[1] === 0)) {
 										loopType = "soft";
 										loopEnd = e.ticks;
@@ -6857,6 +6859,10 @@ var VolumeEnvelope = class {
 		this.state = 0;
 		this.sampleTime = 0;
 		this.outputGain = 0;
+		this.attenuationCb = CB_SILENCE;
+		this.releaseStartCb = CB_SILENCE;
+		this.releaseStartTimeSamples = 0;
+		this.releaseDuration = 0;
 		this.canEndOnSilentSustain = voice.modulatedGenerators[GeneratorTypes.sustainVolEnv] >= PERCEIVED_CB_SILENCE;
 		this.sustainCb = Math.min(CB_SILENCE, voice.modulatedGenerators[GeneratorTypes.sustainVolEnv]);
 		this.attackDuration = this.timecentsToSamples(voice.modulatedGenerators[GeneratorTypes.attackVolEnv]);
@@ -7240,9 +7246,9 @@ var HermiteOscillator = class extends WavetableOscillator {
 			let y2 = y0 + 2;
 			let y3 = y0 + 3;
 			const t = cursor - y0;
-			if (y1 >= loopEnd) y1 -= loopLength;
-			if (y2 >= loopEnd) y2 -= loopLength;
-			if (y3 >= loopEnd) y3 -= loopLength;
+			while (y1 >= loopEnd) y1 -= loopLength;
+			while (y2 >= loopEnd) y2 -= loopLength;
+			while (y3 >= loopEnd) y3 -= loopLength;
 			const xm1 = sampleData[y0];
 			const x0 = sampleData[y1];
 			const x1 = sampleData[y2];
@@ -7510,6 +7516,8 @@ var Voice = class {
 		this.overrideReleaseVolEnv = 0;
 		this.portamentoDuration = 0;
 		this.portamentoFromKey = -1;
+		this.tuningCents = 0;
+		this.tuningRatio = 1;
 		this.vibLfoPhase = .25;
 		this.modLfoPhase = .25;
 		this.startTime = currentTime;
@@ -12097,7 +12105,7 @@ function renderVoice(voice, timeNow, outputL, outputR, startIndex, sampleCount)
 	const index = Math.min(Math.max(-500, pan + this.currentPan), 500) + 500 | 0;
 	const gainLeft = panTableLeft[index] * outputGain;
 	const gainRight = panTableRight[index] * outputGain;
-	if (this._midiParameters.efxAssign) {
+	if (this._midiParameters.efxAssign && systemParameters.effectsEnabled && core.insertionActive) {
 		const insertionL = core.insertionInputL;
 		const insertionR = core.insertionInputR;
 		for (let i = 0; i < sampleCount; i++) {
@@ -14555,7 +14563,10 @@ function rolandSystemExclusive(syx, channelOffset = 0) {
 				if (a2 >> 4 === 1) {
 					const channel = MIDIUtils.syxToChannel(a2 & 15) + channelOffset;
 					const ch = this.midiChannels[channel];
-					if (!ch) SpessaLog.gsFail(`Patch Parameter for ${channel}`, syx, "Invalid channel number");
+					if (!ch) {
+						SpessaLog.gsFail(`Patch Parameter for ${channel}`, syx, "Invalid part number.");
+						return;
+					}
 					switch (a3) {
 						default:
 							SpessaLog.gsFail(`Patch Part Parameter for ${channel}`, [a3]);
@@ -14888,11 +14899,11 @@ function yamahaSystemExclusive(syx, channelOffset = 0) {
 		}
 		if (a1 === 8) {
 			const channel = a2 + channelOffset;
-			if (channel >= this.midiChannels.length) {
-				SpessaLog.xgFail("Part Setup", syx, `Invalid part number: ${channel}`);
+			const ch = this.midiChannels[channel];
+			if (!ch) {
+				SpessaLog.xgFail(`Part Setup for ${channel}`, syx, `Invalid part number.`);
 				return;
 			}
-			const ch = this.midiChannels[channel];
 			switch (a3) {
 				default:
 					SpessaLog.xgFail("Part Setup", [syx[5]]);
@@ -19604,6 +19615,10 @@ var SynthesizerCore = class {
 	*/
 	delayProcessor;
 	/**
+	* Insertion is not used outside SC-88Pro+ MIDIs, this is an optimization.
+	*/
+	insertionActive = false;
+	/**
 	* A sysEx may set a "Part" (channel) to receive on a different channel number.
 	* This slows down the access, so this toggle tracks if it's enabled or not.
 	*/
@@ -19628,10 +19643,6 @@ var SynthesizerCore = class {
 	*/
 	insertionEffects = /* @__PURE__ */ new Map();
 	/**
-	* Insertion is not used outside SC-88Pro+ MIDIs, this is an optimization.
-	*/
-	insertionActive = false;
-	/**
 	* For F5 system exclusive.
 	*/
 	portSelectChannelOffset = 0;