spessasynth_core 4.2.2 → 4.2.4

package/dist/index.d.ts

@@ -531,12 +531,39 @@ declare const dataEntryStates: {
 };
 type DataEntryState = (typeof dataEntryStates)[keyof typeof dataEntryStates];
 declare const customControllers: {
+    /**
+     * Cents, RPN for fine-tuning
+     */
     readonly channelTuning: 0;
+    /**
+     * Cents, only the decimal tuning, (e.g., transpose is 4.5,
+     * Then shift by 4 keys + tune by 50 cents)
+     */
     readonly channelTransposeFine: 1;
+    /**
+     * The MIDI specification assumes the default modulation depth is 50 cents,
+     * but it may vary for different sound banks.
+     * For example, if you want a modulation depth of 100 cents,
+     * the multiplier will be 2,
+     * which, for a preset with a depth of 50,
+     * will create a total modulation depth of 100 cents.
+     */
     readonly modulationMultiplier: 2;
+    /**
+     * Cents, set by system exclusive
+     */
     readonly masterTuning: 3;
+    /**
+     * Semitones, for RPN coarse tuning
+     */
     readonly channelTuningSemitones: 4;
+    /**
+     * Key shift: for system exclusive
+     */
     readonly channelKeyShift: 5;
+    /**
+     * Sf2 NPRN LSB for selecting a generator value
+     */
     readonly sf2NPRNGeneratorLSB: 6;
 };
 type CustomController = (typeof customControllers)[keyof typeof customControllers];

package/dist/index.js

@@ -1808,21 +1808,40 @@ var dataEntryStates = {
   DataFine: 6
 };
 var customControllers = {
+  /**
+   * Cents, RPN for fine-tuning
+   */
   channelTuning: 0,
-  // Cents, RPN for fine tuning
+  /**
+   * Cents, only the decimal tuning, (e.g., transpose is 4.5,
+   * Then shift by 4 keys + tune by 50 cents)
+   */
   channelTransposeFine: 1,
-  // Cents, only the decimal tuning, (e.g., transpose is 4.5,
-  // Then shift by 4 keys + tune by 50 cents)
+  /**
+   * The MIDI specification assumes the default modulation depth is 50 cents,
+   * but it may vary for different sound banks.
+   * For example, if you want a modulation depth of 100 cents,
+   * the multiplier will be 2,
+   * which, for a preset with a depth of 50,
+   * will create a total modulation depth of 100 cents.
+   */
   modulationMultiplier: 2,
-  // Cents, set by modulation depth RPN
+  /**
+   * Cents, set by system exclusive
+   */
   masterTuning: 3,
-  // Cents, set by system exclusive
+  /**
+   * Semitones, for RPN coarse tuning
+   */
   channelTuningSemitones: 4,
-  // Semitones, for RPN coarse tuning
+  /**
+   * Key shift: for system exclusive
+   */
   channelKeyShift: 5,
-  // Key shift: for system exclusive
+  /**
+   * Sf2 NPRN LSB for selecting a generator value
+   */
   sf2NPRNGeneratorLSB: 6
-  // Sf2 NPRN LSB for selecting a generator value
 };
 
 // src/midi/midi_tools/midi_editor.ts
@@ -4773,7 +4792,6 @@ setResetValue(midiControllers.vibratoDepth, 64);
 setResetValue(midiControllers.vibratoDelay, 64);
 setResetValue(midiControllers.generalPurposeController6, 64);
 setResetValue(midiControllers.generalPurposeController8, 64);
-setResetValue(midiControllers.reverbDepth, 40);
 setResetValue(midiControllers.registeredParameterLSB, 127);
 setResetValue(midiControllers.registeredParameterMSB, 127);
 setResetValue(midiControllers.nonRegisteredParameterLSB, 127);
@@ -9798,6 +9816,7 @@ function dataEntryCoarse(dataCoarse) {
       break;
     }
     // Process NRPNs
+    case dataEntryStates.NRPCoarse:
     case dataEntryStates.NRPFine: {
       const paramCoarse = this.midiControllers[midiControllers.nonRegisteredParameterMSB] >> 7;
       const paramFine = this.midiControllers[midiControllers.nonRegisteredParameterLSB] >> 7;
@@ -10571,7 +10590,14 @@ function portaTimeToRate(cc) {
       1.9030899869919435
     ];
     const thresholds = [2, 4, 8, 16, 32, 64, 80, 96, 112, 120, 124];
-    const s = thresholds.findLastIndex((t2) => t2 < cc) + 1;
+    let s = -1;
+    for (let i = thresholds.length - 1; i >= 0; i--) {
+      if (thresholds[i] < cc) {
+        s = i;
+        break;
+      }
+    }
+    s += 1;
     const t = (cc - x0[s]) * ih[s];
     return Math.exp(
       2.302585092994046 * (((a[s] * t + b[s]) * t + c[s]) * t + d[s])
@@ -13914,18 +13940,23 @@ function handleGS(syx, channelOffset = 0) {
                   }
                   // Rate control is ignored as it is in hertz
                   case 4: {
-                    channelObject.sysExModulators.setModulator(
-                      source,
-                      generatorTypes.vibLfoToPitch,
-                      normalizedNotCentered * 600,
-                      bipolar
-                    );
-                    sysExLogging(
-                      channel,
-                      normalizedNotCentered * 600,
-                      `${sourceName} LFO1 pitch depth`,
-                      "cents"
-                    );
+                    if (source === midiControllers.modulationWheel) {
+                      const cents = normalizedNotCentered * 600;
+                      channelObject.customControllers[customControllers.modulationMultiplier] = cents / 50;
+                    } else {
+                      channelObject.sysExModulators.setModulator(
+                        source,
+                        generatorTypes.vibLfoToPitch,
+                        normalizedNotCentered * 600,
+                        bipolar
+                      );
+                      sysExLogging(
+                        channel,
+                        normalizedNotCentered * 600,
+                        `${sourceName} LFO1 pitch depth`,
+                        "cents"
+                      );
+                    }
                     break;
                   }
                   case 5: {