spessasynth_core 4.0.18 → 4.0.19

package/dist/index.d.ts

@@ -1603,26 +1603,28 @@ declare class ProtectedSynthValues {
     midiVolume: number;
     /**
      * Set via system exclusive.
+     * Note: Remember to reset in system reset!
      */
     reverbSend: number;
     /**
      * Set via system exclusive.
+     * Note: Remember to reset in system reset!
      */
     chorusSend: number;
     /**
-     * The pan of the left channel
+     * The pan of the left channel.
      */
     panLeft: number;
     /**
-     * The pan of the right channel
+     * The pan of the right channel.
      */
     panRight: number;
     /**
-     * Synth's default (reset) preset
+     * Synth's default (reset) preset.
      */
     defaultPreset: BasicPreset | undefined;
     /**
-     * Synth's default (reset) drum preset
+     * Synth's default (reset) drum preset.
      */
     drumPreset: BasicPreset | undefined;
     readonly volumeEnvelopeSmoothingFactor: number;

package/dist/index.js

@@ -1042,10 +1042,10 @@ var BankSelectHacks = class {
     }
   }
   /**
-   * Checks if this bank number is XG drums
+   * Checks if this bank number is XG drums.
    */
   static isXGDrums(bankMSB) {
-    return bankMSB === 120 || bankMSB === 126 || bankMSB === 127;
+    return bankMSB === 120 || bankMSB === 127;
   }
   /**
    * Checks if this MSB is a valid XG MSB
@@ -4603,6 +4603,13 @@ function resetAllControllersInternal(log = true) {
   }
   this.privateProps.callEvent("allControllerReset", void 0);
   this.setMasterParameter("midiSystem", DEFAULT_SYNTH_MODE);
+  this.privateProps.tunings.length = 0;
+  for (let i = 0; i < 128; i++) {
+    this.privateProps.tunings.push([]);
+  }
+  this.setMIDIVolume(1);
+  this.privateProps.reverbSend = 1;
+  this.privateProps.chorusSend = 1;
   if (!this.privateProps.drumPreset || !this.privateProps.defaultPreset) {
     return;
   }
@@ -4634,12 +4641,6 @@ function resetAllControllersInternal(log = true) {
       });
     }
   }
-  this.privateProps.tunings.length = 0;
-  this.privateProps.tunings.length = 0;
-  for (let i = 0; i < 128; i++) {
-    this.privateProps.tunings.push([]);
-  }
-  this.setMIDIVolume(1);
 }
 function resetControllers(sendCCEvents = true) {
   this.channelOctaveTuning.fill(0);
@@ -7600,8 +7601,7 @@ var BasicPreset = class {
    */
   get isAnyDrums() {
     const xg = this.parentSoundBank.isXGBank;
-    return this.isGMGSDrum || xg && BankSelectHacks.isXGDrums(this.bankMSB) && // SFX is not a drum preset, only for exact match
-    this.bankMSB !== 126;
+    return this.isGMGSDrum || xg && BankSelectHacks.isXGDrums(this.bankMSB);
   }
   /**
    * Unlinks everything from this preset.
@@ -10187,26 +10187,28 @@ var ProtectedSynthValues = class {
   midiVolume = 1;
   /**
    * Set via system exclusive.
+   * Note: Remember to reset in system reset!
    */
   reverbSend = 1;
   /**
    * Set via system exclusive.
+   * Note: Remember to reset in system reset!
    */
   chorusSend = 1;
   /**
-   * The pan of the left channel
+   * The pan of the left channel.
    */
   panLeft = 0.5;
   /**
-   * The pan of the right channel
+   * The pan of the right channel.
    */
   panRight = 0.5;
   /**
-   * Synth's default (reset) preset
+   * Synth's default (reset) preset.
    */
   defaultPreset;
   /**
-   * Synth's default (reset) drum preset
+   * Synth's default (reset) drum preset.
    */
   drumPreset;
   // Volume envelope smoothing factor, adjusted to the sample rate.