spessasynth_core 3.26.6 → 3.26.8

package/README.md

@@ -21,6 +21,12 @@ npm install --save spessasynth_core
 
 > Note: This is the new heart of the SpessaSynth library, after the repository has been split.
 
+**Project index**
+
+- spessasynth_core (you are here) - SF2/DLS/MIDI library
+- [spessasynth_lib](https://github.com/spessasus/spessasynth_lib) - spessasynth_core wrapper optimized for browsers and WebAudioAPI
+- [SpessaSynth](https://github.com/spessasus/SpessaSynth) - online/local web player/editor application
+
 ## Current Features
 
 ### Easy Integration
@@ -87,7 +93,7 @@ npm install --save spessasynth_core
   - **Compression and trimming support:** Reduce a MIDI file with a 1GB soundfont to **as small as 5MB**!
   - **DLS Version support:** The original legacy format with bank offset detection!
   - **Automatic bank shifting and validation:** Every soundfont *just works!*
-  - **Metadata support:** Add title, artist, album name and cover and more! And of course read them too! *(In any encoding!)*
+  - **Metadata support:** Add title, artist, album name and cover and more! And of course, read them too! *(In any encoding!)*
   - **Compatible with [Falcosoft Midi Player 6!](https://falcosoft.hu/softwares.html#midiplayer)**
   - **Easy saving:** [As simple as saving a MIDI file!](https://github.com/spessasus/spessasynth_core/wiki/Writing-MIDI-Files#writermidi)
 
@@ -120,13 +126,9 @@ npm install --save spessasynth_core
   - **Loop multiple times:** *Render two (or more) loops into the file for seamless transitions!*
   - *That's right, saving as WAV is also [just one function!](https://github.com/spessasus/spessasynth_core/wiki/Writing-Wave-Files#audiobuffertowav)*
 
-## Limitations
-- Synth's performance may be suboptimal, especially on mobile devices.
-- [SF2 to DLS Conversion](https://github.com/spessasus/SpessaSynth/wiki/DLS-Conversion-Problem)
-- Audio may sometimes sound distorted in Chrome, Edge, Brave,
-  etc. due to a **[Chromium Bug](https://issues.chromium.org/issues/367304685).**
-  I can't do anything about it, only hope that it gets fixed.
-  Please consider voting for it on the bug tracker to get it fixed!
+### Limitations
+- Synth's performance may be questionable sometimes
+- [SF2 to DLS Conversion limits](https://github.com/spessasus/SpessaSynth/wiki/DLS-Conversion-Problem)
 
 #### TODO
 - Improve the performance of the engine

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "spessasynth_core",
-  "version": "3.26.6",
+  "version": "3.26.8",
   "description": "MIDI and SoundFont2/DLS library with no compromises",
   "main": "index.js",
   "type": "module",

package/src/midi/basic_midi.js

@@ -402,6 +402,9 @@ class BasicMIDI extends MIDISequenceData
             }
         }
         
+        // fix empty port channel offsets (do a copy to turn empty slots into undefined so map goes over them)
+        this.midiPortChannelOffsets = [...this.midiPortChannelOffsets].map(o => o ?? 0);
+        
         // fix midi ports:
         // midi tracks without ports will have a value of -1
         // if all ports have a value of -1, set it to 0,
@@ -426,7 +429,7 @@ class BasicMIDI extends MIDISequenceData
         {
             defaultPort = 0;
         }
-        this.midiPorts = this.midiPorts.map(port => port === -1 ? defaultPort : port);
+        this.midiPorts = this.midiPorts.map(port => port === -1 || port === undefined ? defaultPort : port);
         // add fake port if empty
         if (this.midiPortChannelOffsets.length === 0)
         {

package/src/sequencer/play.js

@@ -334,6 +334,10 @@ export function play(resetTime = false)
  */
 export function setTimeTicks(ticks)
 {
+    if (!this.midiData)
+    {
+        return;
+    }
     this.stop();
     this.playingNotes = [];
     this.pausedTime = undefined;

package/src/sequencer/sequencer_engine.js

@@ -208,6 +208,10 @@ class SpessaSynthSequencer
     
     set currentTime(time)
     {
+        if (!this.midiData)
+        {
+            return;
+        }
         if (time > this.duration || time < 0)
         {
             // time is 0