specweave 1.0.301 → 1.0.304

package/plugins/specweave-github/lib/github-feature-sync.js

@@ -1,4 +1,4 @@
-import { readdir, readFile, writeFile } from "fs/promises";
+import { readdir, readFile, writeFile, mkdir } from "fs/promises";
 import { existsSync } from "fs";
 import * as path from "path";
 import * as yaml from "yaml";
@@ -10,12 +10,39 @@ import { getGitHubAuthFromProject } from "../../../src/utils/auth-helpers.js";
 const _GitHubFeatureSync = class _GitHubFeatureSync {
   // 30 seconds
   constructor(client, specsDir, projectRoot) {
+    // Cached default branch for the sync session (one API call per session)
+    this.defaultBranch = null;
     this.client = client;
     this.specsDir = specsDir;
     this.projectRoot = projectRoot;
     this.calculator = new CompletionCalculator(projectRoot);
     this.token = getGitHubAuthFromProject(projectRoot).token;
   }
+  /**
+   * Detect the default branch from the GitHub API.
+   * Caches the result per sync session to avoid repeated API calls.
+   * Falls back to 'main' if API call fails.
+   */
+  async detectDefaultBranch() {
+    if (this.defaultBranch) {
+      return this.defaultBranch;
+    }
+    const owner = this.client.getOwner();
+    const repo = this.client.getRepo();
+    const result = await execFileNoThrow("gh", [
+      "api",
+      `repos/${owner}/${repo}`,
+      "--jq",
+      ".default_branch"
+    ], { env: this.getGhEnv() });
+    if (result.exitCode === 0 && result.stdout.trim()) {
+      this.defaultBranch = result.stdout.trim();
+    } else {
+      console.warn(`   \u26A0\uFE0F  Failed to detect default branch, falling back to 'main': ${result.stderr}`);
+      this.defaultBranch = "main";
+    }
+    return this.defaultBranch;
+  }
   /**
    * Get environment object with GH_TOKEN for gh CLI commands.
    * This ensures the token from .env is passed to all gh operations,
@@ -83,14 +110,15 @@ const _GitHubFeatureSync = class _GitHubFeatureSync {
    \u{1F4DD} Found ${userStories.length} User Stories to sync...`);
     let issuesCreated = 0;
     let issuesUpdated = 0;
+    const detectedBranch = await this.detectDefaultBranch();
+    console.log(`   \u{1F33F} Default branch: ${detectedBranch}`);
     for (const userStory of userStories) {
       console.log(`
    \u{1F539} Processing ${userStory.id}: ${userStory.title}`);
       const repoInfo = {
         owner: this.client.getOwner(),
         repo: this.client.getRepo(),
-        branch: "develop"
-        // TODO: detect from git
+        branch: detectedBranch
       };
       const builder = new UserStoryIssueBuilder(
         userStory.filePath,
@@ -160,7 +188,8 @@ const _GitHubFeatureSync = class _GitHubFeatureSync {
     };
   }
   /**
-   * Find Feature folder in specs directory
+   * Find Feature folder in specs directory.
+   * Falls back to auto-creating from increment spec.md if living docs don't exist.
    */
   async findFeatureFolder(featureId) {
     const projectFolders = await this.findProjectFolders();
@@ -175,8 +204,230 @@ const _GitHubFeatureSync = class _GitHubFeatureSync {
       console.log(`   \u26A0\uFE0F  Found feature in legacy _features folder - consider migrating to project folder`);
       return legacyFolder;
     }
+    console.log(`   \u2139\uFE0F  Feature folder not found in living docs, attempting auto-create from spec.md...`);
+    const created = await this.createFeatureFolderFromSpec(featureId, projectFolders);
+    if (created) {
+      return created;
+    }
     return null;
   }
+  /**
+   * Find the increment folder for a given feature ID.
+   * Converts FS-271 -> finds 0271-xxx-xxx/ in .specweave/increments/
+   */
+  async findIncrementFolder(featureId) {
+    const numMatch = featureId.match(/FS-0*(\d+)E?/i);
+    if (!numMatch) return null;
+    const num = parseInt(numMatch[1], 10);
+    const paddedNum = String(num).padStart(4, "0");
+    const incrementsDir = path.join(this.projectRoot, ".specweave/increments");
+    if (!existsSync(incrementsDir)) return null;
+    const entries = await readdir(incrementsDir);
+    const match = entries.find((e) => e.startsWith(paddedNum + "-"));
+    if (!match) return null;
+    return path.join(incrementsDir, match);
+  }
+  /**
+   * Auto-create a feature folder (FEATURE.md + us-NNN.md files) from an
+   * increment's spec.md. This enables GitHub sync even when the living docs
+   * builder hasn't run yet.
+   */
+  async createFeatureFolderFromSpec(featureId, projectFolders) {
+    try {
+      const incrementFolder = await this.findIncrementFolder(featureId);
+      if (!incrementFolder) {
+        console.log(`   \u26A0\uFE0F  No increment folder found for ${featureId}`);
+        return null;
+      }
+      const specPath = path.join(incrementFolder, "spec.md");
+      if (!existsSync(specPath)) {
+        console.log(`   \u26A0\uFE0F  No spec.md found in ${path.basename(incrementFolder)}`);
+        return null;
+      }
+      const specContent = await readFile(specPath, "utf-8");
+      const fmMatch = specContent.match(/^---\n([\s\S]*?)\n---/);
+      if (!fmMatch) {
+        console.log(`   \u26A0\uFE0F  spec.md has no YAML frontmatter`);
+        return null;
+      }
+      const frontmatter = yaml.parse(fmMatch[1]);
+      const title = frontmatter.title || path.basename(incrementFolder).replace(/^\d+-/, "");
+      const status = frontmatter.status || "active";
+      const priority = frontmatter.priority || "P2";
+      const created = frontmatter.created || (/* @__PURE__ */ new Date()).toISOString().split("T")[0];
+      const incrementId = frontmatter.increment || path.basename(incrementFolder);
+      let targetProjectFolder = projectFolders[0];
+      const projectMatch = specContent.match(/\*\*Project\*\*:\s*(\S+)/);
+      if (projectMatch) {
+        const projectName = projectMatch[1];
+        const matchingFolder = projectFolders.find((f) => path.basename(f) === projectName);
+        if (matchingFolder) {
+          targetProjectFolder = matchingFolder;
+        }
+      }
+      if (!targetProjectFolder) {
+        console.log(`   \u26A0\uFE0F  No project folder available for feature creation`);
+        return null;
+      }
+      const featureFolder = path.join(targetProjectFolder, featureId);
+      await mkdir(featureFolder, { recursive: true });
+      const userStories = this.parseUserStoriesFromSpec(specContent, featureId);
+      const featureMd = this.buildFeatureMd(featureId, title, status, priority, created, incrementId, userStories);
+      await writeFile(path.join(featureFolder, "FEATURE.md"), featureMd, "utf-8");
+      for (const us of userStories) {
+        const usFilename = `us-${us.id.replace("US-", "").padStart(3, "0")}-${this.slugify(us.title)}.md`;
+        const usMd = this.buildUserStoryMd(us, featureId, incrementId);
+        await writeFile(path.join(featureFolder, usFilename), usMd, "utf-8");
+      }
+      console.log(`   \u2705 Auto-created feature folder with ${userStories.length} user stories`);
+      return featureFolder;
+    } catch (error) {
+      console.log(`   \u26A0\uFE0F  Failed to auto-create feature folder: ${error.message}`);
+      return null;
+    }
+  }
+  /**
+   * Parse user stories from spec.md markdown content.
+   */
+  parseUserStoriesFromSpec(specContent, featureId) {
+    const stories = [];
+    const usRegex = /### (US-\d+):\s*(.+?)(?:\s*\((P\d)\))?\s*\n([\s\S]*?)(?=\n### US-|\n## |\n---\s*\n### US-|$)/g;
+    let match;
+    while ((match = usRegex.exec(specContent)) !== null) {
+      const usId = match[1];
+      const rawTitle = match[2].trim();
+      const priority = match[3] || "P2";
+      const body = match[4];
+      if (rawTitle === "[Story Title]") continue;
+      const projectMatch = body.match(/\*\*Project\*\*:\s*(\S+)/);
+      const project = projectMatch ? projectMatch[1] : "specweave";
+      const storyMatch = body.match(/\*\*As a\*\*\s+([\s\S]*?)(?=\n\*\*Acceptance Criteria|$)/);
+      const storyText = storyMatch ? storyMatch[1].trim() : "";
+      const acs = [];
+      const acRegex = /- \[[ x]\] \*\*AC-[^*]+\*\*:\s*(.+)/g;
+      let acMatch;
+      while ((acMatch = acRegex.exec(body)) !== null) {
+        acs.push(acMatch[0]);
+      }
+      const totalAcs = acs.length;
+      const completedAcs = acs.filter((ac) => ac.startsWith("- [x]")).length;
+      let status = "not-started";
+      if (totalAcs > 0 && completedAcs === totalAcs) status = "complete";
+      else if (completedAcs > 0) status = "active";
+      stories.push({
+        id: usId,
+        title: rawTitle,
+        priority,
+        project,
+        storyText,
+        acceptanceCriteria: acs,
+        status
+      });
+    }
+    return stories;
+  }
+  /**
+   * Build FEATURE.md content matching the living docs format.
+   */
+  buildFeatureMd(featureId, title, status, priority, created, incrementId, userStories) {
+    const now = (/* @__PURE__ */ new Date()).toISOString().split("T")[0];
+    const mappedStatus = status === "planned" ? "planning" : status === "completed" || status === "done" ? "complete" : status === "active" || status === "in-progress" ? "active" : "planning";
+    const fm = {
+      id: featureId,
+      title,
+      type: "feature",
+      status: mappedStatus,
+      priority,
+      created,
+      lastUpdated: now,
+      tldr: title,
+      complexity: "medium",
+      auto_created: true
+    };
+    const yamlFm = yaml.stringify(fm);
+    let body = `
+# ${title}
+
+## TL;DR
+
+**What**: ${title}
+**Status**: ${mappedStatus} | **Priority**: ${priority}
+**User Stories**: ${userStories.length}
+
+## Overview
+
+${title}
+
+## Implementation History
+
+| Increment | Status |
+|-----------|--------|
+| [${incrementId}](../../../../../increments/${incrementId}/spec.md) | ${mappedStatus} |
+
+## User Stories
+`;
+    for (const us of userStories) {
+      body += `
+- [${us.id}: ${us.title}](./${us.id.toLowerCase()}.md)`;
+    }
+    return `---
+${yamlFm}---${body}
+`;
+  }
+  /**
+   * Build us-NNN.md content matching the living docs format.
+   */
+  buildUserStoryMd(us, featureId, incrementId) {
+    const now = (/* @__PURE__ */ new Date()).toISOString().split("T")[0];
+    const fm = {
+      id: us.id,
+      feature: featureId,
+      title: us.title,
+      status: us.status,
+      priority: us.priority,
+      created: now,
+      project: us.project
+    };
+    const yamlFm = yaml.stringify(fm);
+    let body = `
+# ${us.id}: ${us.title}
+
+**Feature**: [${featureId}](./FEATURE.md)
+
+`;
+    if (us.storyText) {
+      body += `${us.storyText}
+
+`;
+    }
+    body += `---
+
+## Acceptance Criteria
+
+`;
+    if (us.acceptanceCriteria.length > 0) {
+      body += us.acceptanceCriteria.join("\n") + "\n";
+    } else {
+      body += `- [ ] **AC-${us.id.replace("US-", "US")}-01**: Pending specification
+`;
+    }
+    body += `
+---
+
+## Implementation
+
+**Increment**: [${incrementId}](../../../../../increments/${incrementId}/spec.md)
+`;
+    return `---
+${yamlFm}---${body}
+`;
+  }
+  /**
+   * Convert a title to a URL-safe slug.
+   */
+  slugify(text) {
+    return text.toLowerCase().replace(/[^a-z0-9]+/g, "-").replace(/^-+|-+$/g, "").substring(0, 60);
+  }
   /**
    * Backfill increment metadata.json with GitHub issue reference (v1.0.240)
    *
@@ -282,9 +533,11 @@ const _GitHubFeatureSync = class _GitHubFeatureSync {
    */
   async createMilestone(featureData) {
     const title = `${featureData.id}: ${featureData.title}`;
+    const owner = this.client.getOwner();
+    const repo = this.client.getRepo();
     const existingResult = await execFileNoThrow("gh", [
       "api",
-      "repos/:owner/:repo/milestones?per_page=100&state=all",
+      `repos/${owner}/${repo}/milestones?per_page=100&state=all`,
       "--jq",
       `.[] | select(.title == "${title}") | {number, html_url}`
     ], { env: this.getGhEnv() });
@@ -307,7 +560,7 @@ Status: ${featureData.status}
 Created: ${featureData.created}`;
     const result = await execFileNoThrow("gh", [
       "api",
-      "repos/:owner/:repo/milestones",
+      `repos/${owner}/${repo}/milestones`,
       "-X",
       "POST",
       "-f",
@@ -490,6 +743,21 @@ Created: ${featureData.created}`;
       } else {
         console.warn(`      \u26A0\uFE0F  Failed to add label ${newStatusLabel}: ${result.stderr}`);
       }
+      if (newStatusLabel === "status:complete" && issueData.state.toLowerCase() !== "closed") {
+        try {
+          const completionComment = this.calculator.buildCompletionComment(completion);
+          await execFileNoThrow("gh", [
+            "issue",
+            "close",
+            issueNumber.toString(),
+            "--comment",
+            completionComment
+          ], { env: this.getGhEnv() });
+          console.log(`      \u2705 Auto-closed issue #${issueNumber} (status:complete)`);
+        } catch (closeError) {
+          console.warn(`      \u26A0\uFE0F  Failed to auto-close issue #${issueNumber}: ${closeError.message}`);
+        }
+      }
     } catch (error) {
       console.warn(`      \u26A0\uFE0F  Failed to update status labels: ${error.message}`);
     }