specweave 0.26.4 → 0.26.9

package/plugins/specweave-github/lib/github-feature-sync.ts

@@ -57,6 +57,11 @@ export class GitHubFeatureSync {
   private projectRoot: string;
   private calculator: CompletionCalculator;
 
+  // SYNC LOCK: Prevent concurrent syncs of the same feature
+  // Maps featureId → last sync timestamp
+  private static syncLocks: Map<string, number> = new Map();
+  private static readonly LOCK_DURATION_MS = 30000; // 30 seconds
+
   constructor(client: GitHubClientV2, specsDir: string, projectRoot: string) {
     this.client = client;
     this.specsDir = specsDir;
@@ -80,6 +85,30 @@ export class GitHubFeatureSync {
     issuesUpdated: number;
     userStoriesProcessed: number;
   }> {
+    // SYNC LOCK CHECK: Prevent concurrent/rapid syncs of the same feature
+    // Root cause: Two sync paths (task completion + status change) can fire simultaneously
+    // Result: Duplicate GitHub comments due to race condition
+    const now = Date.now();
+    const lastSync = GitHubFeatureSync.syncLocks.get(featureId);
+
+    if (lastSync && (now - lastSync) < GitHubFeatureSync.LOCK_DURATION_MS) {
+      const secondsRemaining = Math.ceil((GitHubFeatureSync.LOCK_DURATION_MS - (now - lastSync)) / 1000);
+      console.log(`\n⏭️  Sync already in progress for ${featureId} (or completed ${Math.floor((now - lastSync) / 1000)}s ago)`);
+      console.log(`   ℹ️  Sync will be available in ${secondsRemaining}s to prevent duplicates`);
+      console.log(`   💡 This prevents race conditions between task completion and status change syncs`);
+
+      // Return placeholder result (sync was skipped, not failed)
+      return {
+        milestoneNumber: 0,
+        milestoneUrl: '',
+        issuesCreated: 0,
+        issuesUpdated: 0,
+        userStoriesProcessed: 0
+      };
+    }
+
+    // Acquire lock
+    GitHubFeatureSync.syncLocks.set(featureId, now);
     console.log(`\n🔄 Syncing Feature ${featureId} to GitHub...`);
 
     // 1. Load Feature FEATURE.md
@@ -216,13 +245,20 @@ export class GitHubFeatureSync {
       // Update User Story frontmatter with issue link
       await this.updateUserStoryFrontmatter(userStory.filePath, issueNumber);
 
+      // ✅ CRITICAL FIX (2025-11-24): Check completion for ALL issues (new AND reused)
+      // BUG: Previously only checked completion for reused issues, not new ones
+      // RESULT: New issues stayed OPEN even if status:complete
+      //
+      // Now we always call updateUserStoryIssue() which:
+      // 1. Calculates ACTUAL completion from [x] checkboxes
+      // 2. Closes issue if all ACs and tasks verified complete
+      // 3. Updates status labels automatically
+      await this.updateUserStoryIssue(issueNumber, issueContent, userStory.filePath);
+
       // Update completion tracking
       if (result.wasReused) {
-        // Update existing issue with latest content
-        await this.updateUserStoryIssue(issueNumber, issueContent, userStory.filePath);
         issuesUpdated++;
       } else {
-        // New issue created
         issuesCreated++;
       }
     }
@@ -336,13 +372,40 @@ export class GitHubFeatureSync {
   }
 
   /**
-   * Create GitHub Milestone for Feature
+   * Create GitHub Milestone for Feature (with duplicate detection)
    */
   private async createMilestone(featureData: FeatureFrontmatter): Promise<{
     number: number;
     url: string;
   }> {
     const title = `${featureData.id}: ${featureData.title}`;
+
+    // CRITICAL: Check if milestone already exists before creating
+    const existingResult = await execFileNoThrow('gh', [
+      'api',
+      'repos/:owner/:repo/milestones',
+      '--jq',
+      `.[] | select(.title == "${title}") | {number, html_url}`,
+    ]);
+
+    // DEBUG: Log detection result
+    console.log(`   🔍 Milestone detection: exitCode=${existingResult.exitCode}, stdout length=${existingResult.stdout.length}`);
+    if (existingResult.exitCode !== 0) {
+      console.log(`   ⚠️  Detection failed: ${existingResult.stderr}`);
+    }
+
+    if (existingResult.exitCode === 0 && existingResult.stdout.trim()) {
+      const existing = JSON.parse(existingResult.stdout);
+      console.log(`   ♻️  Reusing existing Milestone #${existing.number}`);
+      return {
+        number: existing.number,
+        url: existing.html_url,
+      };
+    }
+
+    console.log(`   ℹ️  No existing milestone found, creating new one...`);
+
+    // Milestone doesn't exist, create new one
     const description = `Feature ${featureData.id}\n\nStatus: ${featureData.status}\nCreated: ${featureData.created}`;
 
     const result = await execFileNoThrow('gh', [
@@ -428,17 +491,10 @@ export class GitHubFeatureSync {
         `      ✅ Created and verified complete: ${completion.acsCompleted}/${completion.acsTotal} ACs, ${completion.tasksCompleted}/${completion.tasksTotal} tasks`
       );
     } else {
-      // ⚠️ INCOMPLETE - Leave open with progress comment
-      await execFileNoThrow('gh', [
-        'issue',
-        'comment',
-        issueNumber.toString(),
-        '--body',
-        this.calculator.buildProgressComment(completion),
-      ]);
-      console.log(
-        `      📊 Created: ${completion.acsPercentage.toFixed(0)}% ACs, ${completion.tasksPercentage.toFixed(0)}% tasks`
-      );
+      // ⚠️ INCOMPLETE - Leave open with progress comment (with deduplication)
+      // Note: For newly created issues, this is the first comment so deduplication
+      // will likely pass through, but the logic is here for consistency
+      await this.postProgressCommentIfChanged(issueNumber, completion);
     }
 
     return issueNumber;
@@ -511,21 +567,168 @@ export class GitHubFeatureSync {
           `      ⚠️ Reopened: ${completion.blockingAcs.length + completion.blockingTasks.length} items incomplete`
         );
       } else {
-        // Update progress comment
+        // Update progress comment (with deduplication)
+        await this.postProgressCommentIfChanged(issueNumber, completion);
+      }
+    }
+
+    // **NEW (2025-11-24)**: Update status labels based on completion
+    await this.updateStatusLabels(issueNumber, completion);
+  }
+
+  /**
+   * Update status labels on GitHub issue based on completion state
+   *
+   * SMART LABEL MANAGEMENT:
+   * - Only manages status:* labels (status:not_started, status:in-progress, status:completed)
+   * - Preserves all other labels (priority, type, custom labels)
+   * - Ensures exactly one status label is present
+   */
+  private async updateStatusLabels(
+    issueNumber: number,
+    completion: {
+      overallComplete: boolean;
+      acsPercentage: number;
+      tasksPercentage: number;
+    }
+  ): Promise<void> {
+    try {
+      // Get current issue labels
+      const issueData = await this.client.getIssue(issueNumber);
+      const currentLabels = issueData.labels || [];
+
+      // Separate status labels from other labels
+      const statusLabels = currentLabels.filter((label: string) => label.startsWith('status:'));
+      const otherLabels = currentLabels.filter((label: string) => !label.startsWith('status:'));
+
+      // Determine correct status label based on completion
+      // NOTE: Label names must match repository labels exactly
+      let newStatusLabel: string;
+      if (completion.overallComplete) {
+        newStatusLabel = 'status:complete'; // Repository uses "complete" not "completed"
+      } else if (completion.acsPercentage > 0 || completion.tasksPercentage > 0) {
+        newStatusLabel = 'status:active'; // Repository uses "active" not "in-progress"
+      } else {
+        newStatusLabel = 'status:not_started';
+      }
+
+      // Check if update needed
+      const needsUpdate = statusLabels.length !== 1 || !statusLabels.includes(newStatusLabel);
+
+      if (!needsUpdate) {
+        return; // Status label already correct
+      }
+
+      // Update labels using gh CLI
+      // Strategy: Remove old status labels first (if any), then add new one
+
+      // Step 1: Remove old status labels (only if they exist)
+      if (statusLabels.length > 0) {
         await execFileNoThrow('gh', [
           'issue',
-          'comment',
+          'edit',
           issueNumber.toString(),
-          '--body',
-          this.calculator.buildProgressComment(completion),
+          '--remove-label',
+          ...statusLabels,
         ]);
+      }
+
+      // Step 2: Add new status label
+      const result = await execFileNoThrow('gh', [
+        'issue',
+        'edit',
+        issueNumber.toString(),
+        '--add-label',
+        newStatusLabel,
+      ]);
+
+      if (result.exitCode === 0) {
+        console.log(`      🏷️  Updated label: ${newStatusLabel}`);
+      } else {
+        console.warn(`      ⚠️  Failed to add label ${newStatusLabel}: ${result.stderr}`);
+      }
+    } catch (error) {
+      // Non-blocking: Label update failure shouldn't break sync
+      console.warn(`      ⚠️  Failed to update status labels: ${(error as Error).message}`);
+    }
+  }
+
+  /**
+   * Post progress comment only if it differs from the last comment
+   *
+   * DEDUPLICATION FIX (2025-11-24):
+   * - Prevents posting identical consecutive comments
+   * - Fetches last comment from issue
+   * - Compares content (ignoring timestamps)
+   * - Only posts if progress has changed
+   *
+   * Root Cause: updateUserStoryIssue() was posting progress comments on EVERY sync,
+   * even when progress hadn't changed, causing 4+ duplicate comments.
+   *
+   * @param issueNumber - GitHub issue number
+   * @param completion - Completion status with AC/task metrics
+   */
+  private async postProgressCommentIfChanged(
+    issueNumber: number,
+    completion: any
+  ): Promise<void> {
+    try {
+      // 1. Fetch last comment from the issue
+      const commentsResult = await execFileNoThrow('gh', [
+        'api',
+        'repos/:owner/:repo/issues/' + issueNumber + '/comments',
+        '--jq',
+        '.[-1] | {body: .body, created_at: .created_at}',  // Get last comment only
+      ]);
+
+      let lastCommentBody = '';
+      if (commentsResult.exitCode === 0 && commentsResult.stdout.trim()) {
+        try {
+          const lastComment = JSON.parse(commentsResult.stdout);
+          lastCommentBody = lastComment.body || '';
+        } catch {
+          // No valid last comment, proceed with posting
+        }
+      }
+
+      // 2. Build new progress comment
+      const newCommentBody = this.calculator.buildProgressComment(completion);
+
+      // 3. Normalize both comments for comparison (remove timestamps, whitespace differences)
+      const normalizeComment = (text: string): string => {
+        return text
+          .replace(/🤖 Auto-updated by SpecWeave AC Completion Gate/g, '')
+          .replace(/\s+/g, ' ')
+          .trim();
+      };
+
+      const normalizedLast = normalizeComment(lastCommentBody);
+      const normalizedNew = normalizeComment(newCommentBody);
+
+      // 4. Check if comments are identical (ignoring formatting differences)
+      if (normalizedLast === normalizedNew) {
         console.log(
-          `      📊 Progress: ${completion.acsPercentage.toFixed(0)}% ACs, ${completion.tasksPercentage.toFixed(0)}% tasks`
+          `      ⏭️  Progress unchanged (${completion.acsPercentage.toFixed(0)}% ACs, ${completion.tasksPercentage.toFixed(0)}% tasks) - skipping duplicate comment`
         );
+        return;
       }
-    }
 
-    // Note: Labels are not updated to avoid overwriting manually added labels
+      // 5. Post new comment only if progress has changed
+      await execFileNoThrow('gh', [
+        'issue',
+        'comment',
+        issueNumber.toString(),
+        '--body',
+        newCommentBody,
+      ]);
+      console.log(
+        `      📊 Progress: ${completion.acsPercentage.toFixed(0)}% ACs, ${completion.tasksPercentage.toFixed(0)}% tasks (updated)`
+      );
+
+    } catch (error) {
+      // Non-blocking: Log error but don't break sync
+      console.error(`      ⚠️  Failed to check/post progress comment: ${(error as Error).message}`);
+    }
   }
 
   /**

package/plugins/specweave-github/lib/user-story-issue-builder.js

@@ -349,11 +349,31 @@ User Story ID: ${frontmatter.id}`
   }
   /**
    * Build labels for the issue
+   *
+   * CRITICAL: Label names must match repository labels exactly!
+   * Repository uses: status:complete, status:active, status:not_started
    */
   buildLabels(frontmatter) {
     const labels = ["user-story", "specweave"];
     if (frontmatter.status) {
-      labels.push(`status:${frontmatter.status}`);
+      let statusLabel;
+      switch (frontmatter.status) {
+        case "completed":
+        case "complete":
+          statusLabel = "status:complete";
+          break;
+        case "active":
+        case "in-progress":
+          statusLabel = "status:active";
+          break;
+        case "planning":
+        case "not-started":
+          statusLabel = "status:not_started";
+          break;
+        default:
+          statusLabel = `status:${frontmatter.status}`;
+      }
+      labels.push(statusLabel);
     }
     if (frontmatter.priority) {
       labels.push(frontmatter.priority.toLowerCase());

package/plugins/specweave-github/lib/user-story-issue-builder.ts

@@ -23,7 +23,7 @@ interface UserStoryFrontmatter {
   id: string;
   feature: string;
   title: string;
-  status: 'complete' | 'active' | 'planning' | 'not-started';
+  status: 'complete' | 'completed' | 'active' | 'in-progress' | 'planning' | 'not-started';
   project?: string;  // ✅ Optional - not all user stories specify project
   priority?: string;
   created: string;
@@ -557,13 +557,41 @@ export class UserStoryIssueBuilder {
 
   /**
    * Build labels for the issue
+   *
+   * CRITICAL: Label names must match repository labels exactly!
+   * Repository uses: status:complete, status:active, status:not_started
    */
   private buildLabels(frontmatter: UserStoryFrontmatter): string[] {
     const labels: string[] = ['user-story', 'specweave'];
 
-    // Add status label
+    // Add status label with proper mapping
+    // Map living docs status values to GitHub repository label names
     if (frontmatter.status) {
-      labels.push(`status:${frontmatter.status}`);
+      let statusLabel: string;
+
+      // Map status values to correct GitHub labels
+      switch (frontmatter.status) {
+        case 'completed':
+        case 'complete':
+          statusLabel = 'status:complete'; // Repository uses "complete" not "completed"
+          break;
+
+        case 'active':
+        case 'in-progress':
+          statusLabel = 'status:active'; // Repository uses "active" not "in-progress"
+          break;
+
+        case 'planning':
+        case 'not-started':
+          statusLabel = 'status:not_started'; // Note: underscore, not dash!
+          break;
+
+        default:
+          // Defensive: Use original value if unknown
+          statusLabel = `status:${frontmatter.status}`;
+      }
+
+      labels.push(statusLabel);
     }
 
     // Add priority label

package/plugins/specweave-jira/hooks/post-task-completion.sh.backup

@@ -0,0 +1,172 @@
+#!/bin/bash
+
+# SpecWeave JIRA Sync Hook
+# Runs after task completion to sync progress to JIRA Issues
+#
+# This hook is part of the specweave-jira plugin and handles:
+# - Syncing task completion state to JIRA issues
+# - Updating JIRA issue status based on increment progress
+#
+# Dependencies:
+# - Node.js for running sync scripts
+# - jq for JSON parsing
+# - metadata.json must have .jira.issue field
+# - JIRA API credentials in .env
+
+set -e
+
+# ============================================================================
+# PROJECT ROOT DETECTION
+# ============================================================================
+
+# Find project root by searching upward for .specweave/ directory
+find_project_root() {
+  local dir="$1"
+  while [ "$dir" != "/" ]; do
+    if [ -d "$dir/.specweave" ]; then
+      echo "$dir"
+      return 0
+    fi
+    dir="$(dirname "$dir")"
+  done
+  # Fallback: try current directory
+  if [ -d "$(pwd)/.specweave" ]; then
+    pwd
+  else
+    echo "$(pwd)"
+  fi
+}
+
+PROJECT_ROOT="$(find_project_root "$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)")"
+cd "$PROJECT_ROOT" 2>/dev/null || true
+
+# ============================================================================
+# CONFIGURATION
+# ============================================================================
+
+LOGS_DIR=".specweave/logs"
+DEBUG_LOG="$LOGS_DIR/hooks-debug.log"
+
+mkdir -p "$LOGS_DIR" 2>/dev/null || true
+
+# ============================================================================
+# PRECONDITIONS CHECK
+# ============================================================================
+
+echo "[$(date)] [JIRA] 🔗 JIRA sync hook fired" >> "$DEBUG_LOG" 2>/dev/null || true
+
+# Detect current increment
+CURRENT_INCREMENT=$(ls -td .specweave/increments/*/ 2>/dev/null | xargs -n1 basename | grep -v "_backlog" | grep -v "_archive" | grep -v "_working" | head -1)
+
+if [ -z "$CURRENT_INCREMENT" ]; then
+  echo "[$(date)] [JIRA] ℹ️  No active increment, skipping JIRA sync" >> "$DEBUG_LOG" 2>/dev/null || true
+  cat <<EOF
+{
+  "continue": true
+}
+EOF
+  exit 0
+fi
+
+# Check for metadata.json
+METADATA_FILE=".specweave/increments/$CURRENT_INCREMENT/metadata.json"
+
+if [ ! -f "$METADATA_FILE" ]; then
+  echo "[$(date)] [JIRA] ℹ️  No metadata.json for $CURRENT_INCREMENT, skipping JIRA sync" >> "$DEBUG_LOG" 2>/dev/null || true
+  cat <<EOF
+{
+  "continue": true
+}
+EOF
+  exit 0
+fi
+
+# Check for JIRA issue link
+if ! command -v jq &> /dev/null; then
+  echo "[$(date)] [JIRA] ⚠️  jq not found, skipping JIRA sync" >> "$DEBUG_LOG" 2>/dev/null || true
+  cat <<EOF
+{
+  "continue": true
+}
+EOF
+  exit 0
+fi
+
+JIRA_ISSUE=$(jq -r '.jira.issue // empty' "$METADATA_FILE" 2>/dev/null)
+
+if [ -z "$JIRA_ISSUE" ]; then
+  echo "[$(date)] [JIRA] ℹ️  No JIRA issue linked to $CURRENT_INCREMENT, skipping sync" >> "$DEBUG_LOG" 2>/dev/null || true
+  cat <<EOF
+{
+  "continue": true
+}
+EOF
+  exit 0
+fi
+
+# Check for Node.js
+if ! command -v node &> /dev/null; then
+  echo "[$(date)] [JIRA] ⚠️  Node.js not found, skipping JIRA sync" >> "$DEBUG_LOG" 2>/dev/null || true
+  cat <<EOF
+{
+  "continue": true
+}
+EOF
+  exit 0
+fi
+
+# Check for JIRA sync script
+if [ ! -f "dist/commands/jira-sync.js" ]; then
+  echo "[$(date)] [JIRA] ⚠️  jira-sync.js not found, skipping JIRA sync" >> "$DEBUG_LOG" 2>/dev/null || true
+  cat <<EOF
+{
+  "continue": true
+}
+EOF
+  exit 0
+fi
+
+# ============================================================================
+# JIRA SYNC LOGIC
+# ============================================================================
+
+echo "[$(date)] [JIRA] 🔄 Syncing to JIRA issue $JIRA_ISSUE" >> "$DEBUG_LOG" 2>/dev/null || true
+
+# Run JIRA sync command (non-blocking)
+node dist/commands/jira-sync.js "$CURRENT_INCREMENT" 2>&1 | tee -a "$DEBUG_LOG" >/dev/null || {
+  echo "[$(date)] [JIRA] ⚠️  Failed to sync to JIRA (non-blocking)" >> "$DEBUG_LOG" 2>/dev/null || true
+}
+
+echo "[$(date)] [JIRA] ✅ JIRA sync complete" >> "$DEBUG_LOG" 2>/dev/null || true
+
+# ============================================================================
+# SPEC COMMIT SYNC (NEW!)
+# ============================================================================
+
+echo "[$(date)] [JIRA] 🔗 Checking for spec commit sync..." >> "$DEBUG_LOG" 2>/dev/null || true
+
+# Call TypeScript CLI to sync commits
+if command -v node &> /dev/null && [ -f "$PROJECT_ROOT/dist/cli/commands/sync-spec-commits.js" ]; then
+  echo "[$(date)] [JIRA] 🚀 Running spec commit sync..." >> "$DEBUG_LOG" 2>/dev/null || true
+
+  node "$PROJECT_ROOT/dist/cli/commands/sync-spec-commits.js" \
+    --increment "$PROJECT_ROOT/.specweave/increments/$CURRENT_INCREMENT" \
+    --provider jira \
+    2>&1 | tee -a "$DEBUG_LOG" >/dev/null || {
+      echo "[$(date)] [JIRA] ⚠️  Spec commit sync failed (non-blocking)" >> "$DEBUG_LOG" 2>/dev/null || true
+    }
+
+  echo "[$(date)] [JIRA] ✅ Spec commit sync complete" >> "$DEBUG_LOG" 2>/dev/null || true
+else
+  echo "[$(date)] [JIRA] ℹ️  Spec commit sync not available (node or script not found)" >> "$DEBUG_LOG" 2>/dev/null || true
+fi
+
+# ============================================================================
+# OUTPUT TO CLAUDE
+# ============================================================================
+
+cat <<EOF
+{
+  "continue": true
+}
+EOF

package/plugins/specweave-jira/lib/enhanced-jira-sync.js

@@ -1,6 +1,6 @@
-import { EnhancedContentBuilder } from "../../../src/core/sync/enhanced-content-builder.js";
-import { SpecIncrementMapper } from "../../../src/core/sync/spec-increment-mapper.js";
-import { parseSpecContent } from "../../../src/core/spec-content-sync.js";
+import { EnhancedContentBuilder } from "../../../dist/src/core/sync/enhanced-content-builder.js";
+import { SpecIncrementMapper } from "../../../dist/src/core/sync/spec-increment-mapper.js";
+import { parseSpecContent } from "../../../dist/src/core/spec-content-sync.js";
 import * as path from "path";
 import * as fs from "fs/promises";
 async function syncSpecToJiraWithEnhancedContent(options) {