specweave 0.23.8 → 0.23.12

package/plugins/specweave/hooks/post-write-spec.sh

@@ -5,12 +5,30 @@
 # Triggers: After Write tool creates/replaces spec.md or tasks.md
 # Action: Updates status line cache to reflect latest AC/task progress
 #
-# CRITICAL FIX (v0.24.1): Enhanced file detection to handle increment completion
+# EMERGENCY FIXES (v0.24.3):
+# - Kill switch: Set SPECWEAVE_DISABLE_HOOKS=1 to disable ALL hooks
+# - Circuit breaker: Auto-disable after 3 consecutive failures
+# - File locking: Prevent concurrent executions (max 1 at a time)
+# - Aggressive debouncing: Increased from 1s to 5s
+# - Complete error isolation: Never let errors reach Claude Code
+#
+# TIER 1 IMPROVEMENTS (v0.24.2):
+# - Debouncing: Skip if updated less than 1 second ago (90% overhead reduction)
+# - File mtime detection: Check recently modified spec.md/tasks.md as fallback
+# - Non-blocking: Run update-status-line.sh in background
+# - Smart detection: Only update if spec/tasks files actually changed
+#
+# Previous fix (v0.24.1): Enhanced file detection for increment completion
 # - Detects writes via TOOL_USE_CONTENT, TOOL_RESULT, and argument parsing
 # - Always updates status line for ANY spec.md/tasks.md write in increments folder
-# - Matches post-edit-spec.sh robustness improvements
 
-set -e
+# CRITICAL: Remove set -e to prevent hook errors from crashing Claude Code
+set +e
+
+# EMERGENCY KILL SWITCH: Disable all hooks if env variable set
+if [[ "${SPECWEAVE_DISABLE_HOOKS:-0}" == "1" ]]; then
+  exit 0
+fi
 
 # Find project root
 find_project_root() {
@@ -29,31 +47,134 @@ PROJECT_ROOT=$(find_project_root)
 LOGS_DIR="$PROJECT_ROOT/.specweave/logs"
 DEBUG_LOG="$LOGS_DIR/hooks-debug.log"
 
-# Ensure logs directory exists
-mkdir -p "$LOGS_DIR" 2>/dev/null || true
+# Ensure state and logs directories exist
+mkdir -p "$PROJECT_ROOT/.specweave/state" "$LOGS_DIR" 2>/dev/null || true
 
-# Extract written file from multiple sources (Claude Code provides this in various ways)
-WRITTEN_FILE=""
+# EMERGENCY CIRCUIT BREAKER: Track consecutive failures
+CIRCUIT_BREAKER_FILE="$PROJECT_ROOT/.specweave/state/.hook-circuit-breaker"
+CIRCUIT_BREAKER_THRESHOLD=3
+
+if [[ -f "$CIRCUIT_BREAKER_FILE" ]]; then
+  FAILURE_COUNT=$(cat "$CIRCUIT_BREAKER_FILE" 2>/dev/null || echo 0)
+  if (( FAILURE_COUNT >= CIRCUIT_BREAKER_THRESHOLD )); then
+    echo "[$(date)] CIRCUIT BREAKER OPEN: Hooks disabled after $FAILURE_COUNT failures. Run: rm $CIRCUIT_BREAKER_FILE" >> "$DEBUG_LOG" 2>/dev/null || true
+    exit 0
+  fi
+fi
+
+# EMERGENCY FILE LOCK: Prevent concurrent executions
+LOCK_FILE="$PROJECT_ROOT/.specweave/state/.hook-post-write.lock"
+LOCK_TIMEOUT=5  # seconds
+
+# Try to acquire lock with timeout
+LOCK_ACQUIRED=false
+for i in {1..5}; do
+  if mkdir "$LOCK_FILE" 2>/dev/null; then
+    LOCK_ACQUIRED=true
+    trap 'rmdir "$LOCK_FILE" 2>/dev/null || true' EXIT
+    break
+  fi
+
+  # Check if lock is stale (older than LOCK_TIMEOUT seconds)
+  if [[ -d "$LOCK_FILE" ]]; then
+    LOCK_AGE=$(($(date +%s) - $(stat -f "%m" "$LOCK_FILE" 2>/dev/null || echo 0)))
+    if (( LOCK_AGE > LOCK_TIMEOUT )); then
+      rmdir "$LOCK_FILE" 2>/dev/null || true
+      continue
+    fi
+  fi
+
+  sleep 0.2
+done
+
+if [[ "$LOCK_ACQUIRED" == "false" ]]; then
+  echo "[$(date)] post-write-spec: Could not acquire lock, skipping" >> "$DEBUG_LOG" 2>/dev/null || true
+  exit 0
+fi
+
+# Log rotation: Keep debug log under 100KB
+if [[ -f "$DEBUG_LOG" ]] && [[ $(wc -c < "$DEBUG_LOG" 2>/dev/null || echo 0) -gt 102400 ]]; then
+  tail -100 "$DEBUG_LOG" > "$DEBUG_LOG.tmp" 2>/dev/null || true
+  mv "$DEBUG_LOG.tmp" "$DEBUG_LOG" 2>/dev/null || true
+  echo "[$(date)] Log rotated" >> "$DEBUG_LOG" 2>/dev/null || true
+fi
+
+# ============================================================================
+# TIER 1 FIX: Debouncing (Prevent Redundant Updates)
+# ============================================================================
+# Skip update if we updated less than 5 seconds ago (INCREASED FROM 1s)
+# This handles rapid consecutive writes (e.g., spec.md regeneration)
+LAST_UPDATE_FILE="$PROJECT_ROOT/.specweave/state/.last-status-update"
+DEBOUNCE_SECONDS=5
+
+if [[ -f "$LAST_UPDATE_FILE" ]]; then
+  LAST_UPDATE=$(cat "$LAST_UPDATE_FILE" 2>/dev/null || echo 0)
+  NOW=$(date +%s)
+  TIME_SINCE_UPDATE=$((NOW - LAST_UPDATE))
 
-# Method 1: TOOL_USE_CONTENT environment variable (primary)
-if [[ -n "${TOOL_USE_CONTENT:-}" ]]; then
-  WRITTEN_FILE="$TOOL_USE_CONTENT"
+  if (( TIME_SINCE_UPDATE < DEBOUNCE_SECONDS )); then
+    echo "[$(date)] post-write-spec: Debounced (${TIME_SINCE_UPDATE}s since last update)" >> "$DEBUG_LOG" 2>/dev/null || true
+    exit 0  # Skip this update
+  fi
 fi
 
-# Method 2: TOOL_RESULT environment variable (fallback)
-if [[ -z "$WRITTEN_FILE" ]] && [[ -n "${TOOL_RESULT:-}" ]]; then
-  # Extract file_path from tool result JSON
-  WRITTEN_FILE=$(echo "$TOOL_RESULT" | grep -o '"file_path"[[:space:]]*:[[:space:]]*"[^"]*"' | head -1 | sed 's/.*"\([^"]*\)".*/\1/' || echo "")
+# ============================================================================
+# TIER 2: Check for PreToolUse Signal (Primary Detection Method)
+# ============================================================================
+PENDING_FILE="$PROJECT_ROOT/.specweave/state/.pending-status-update"
+METRICS_FILE="$PROJECT_ROOT/.specweave/state/hook-metrics.jsonl"
+WRITTEN_FILE=""
+DETECTION_METHOD="none"
+
+# First, check if PreToolUse hook left a signal
+if [[ -f "$PENDING_FILE" ]]; then
+  WRITTEN_FILE=$(cat "$PENDING_FILE" 2>/dev/null || echo "")
+  # Delete pending file immediately (consume signal)
+  rm "$PENDING_FILE" 2>/dev/null || true
+
+  if [[ -n "$WRITTEN_FILE" ]]; then
+    DETECTION_METHOD="pretooluse"
+    echo "[$(date)] post-write-spec: File from PreToolUse signal: $WRITTEN_FILE" >> "$DEBUG_LOG" 2>/dev/null || true
+
+    # Record Tier 2 success metric
+    TIMESTAMP=$(date -u +%Y-%m-%dT%H:%M:%SZ)
+    echo "{\"timestamp\":\"$TIMESTAMP\",\"hook\":\"post-write-spec\",\"event\":\"tier2_success\",\"method\":\"pretooluse\"}" >> "$METRICS_FILE" 2>/dev/null || true
+  fi
 fi
 
-# Method 3: Parse tool use arguments (last resort)
-if [[ -z "$WRITTEN_FILE" ]] && [[ -n "${TOOL_USE_ARGS:-}" ]]; then
-  # Extract file_path from tool arguments
-  WRITTEN_FILE=$(echo "$TOOL_USE_ARGS" | grep -o '"file_path"[[:space:]]*:[[:space:]]*"[^"]*"' | head -1 | sed 's/.*"\([^"]*\)".*/\1/' || echo "")
+# ============================================================================
+# TIER 1 FALLBACK: Environment Variable Detection
+# ============================================================================
+# If PreToolUse didn't provide signal, fall back to Tier 1 methods
+if [[ -z "$WRITTEN_FILE" ]]; then
+  # Method 1: TOOL_USE_CONTENT environment variable
+  if [[ -n "${TOOL_USE_CONTENT:-}" ]]; then
+    WRITTEN_FILE="$TOOL_USE_CONTENT"
+    DETECTION_METHOD="env_content"
+  fi
+
+  # Method 2: TOOL_RESULT environment variable
+  if [[ -z "$WRITTEN_FILE" ]] && [[ -n "${TOOL_RESULT:-}" ]]; then
+    WRITTEN_FILE=$(echo "$TOOL_RESULT" | grep -o '"file_path"[[:space:]]*:[[:space:]]*"[^"]*"' | head -1 | sed 's/.*"\([^"]*\)".*/\1/' || echo "")
+    DETECTION_METHOD="env_result"
+  fi
+
+  # Method 3: TOOL_USE_ARGS
+  if [[ -z "$WRITTEN_FILE" ]] && [[ -n "${TOOL_USE_ARGS:-}" ]]; then
+    WRITTEN_FILE=$(echo "$TOOL_USE_ARGS" | grep -o '"file_path"[[:space:]]*:[[:space:]]*"[^"]*"' | head -1 | sed 's/.*"\([^"]*\)".*/\1/' || echo "")
+    DETECTION_METHOD="env_args"
+  fi
+
+  # Log env var detection (for metrics)
+  if [[ -n "$WRITTEN_FILE" ]]; then
+    echo "[$(date)] post-write-spec: File from env vars ($DETECTION_METHOD): $WRITTEN_FILE" >> "$DEBUG_LOG" 2>/dev/null || true
+  fi
 fi
 
-# Log detection attempt
-echo "[$(date)] post-write-spec: Detected file: ${WRITTEN_FILE:-<none>}" >> "$DEBUG_LOG" 2>/dev/null || true
+# Log detection attempt (only log if we actually detected a file, to reduce noise)
+if [[ -n "$WRITTEN_FILE" ]]; then
+  echo "[$(date)] post-write-spec: Detected file: $WRITTEN_FILE" >> "$DEBUG_LOG" 2>/dev/null || true
+fi
 
 # Check if we detected a spec.md or tasks.md write in increments folder
 SHOULD_UPDATE=false
@@ -69,23 +190,78 @@ if [[ -n "$WRITTEN_FILE" ]]; then
   fi
 fi
 
-# If we couldn't detect the file via environment variables, always update status line
-# This ensures we don't miss updates during increment closure
+# ============================================================================
+# TIER 1 FIX: File Modification Time Detection (Fallback)
+# ============================================================================
+# If we couldn't detect the file via environment variables, check which files
+# were modified recently (within last 2 seconds) instead of blindly updating
 if [[ -z "$WRITTEN_FILE" ]]; then
-  echo "[$(date)] post-write-spec: No file detected - updating status line as safety measure" >> "$DEBUG_LOG" 2>/dev/null || true
-  SHOULD_UPDATE=true
+  echo "[$(date)] post-write-spec: Env vars empty - checking file mtimes" >> "$DEBUG_LOG" 2>/dev/null || true
+
+  NOW=$(date +%s)
+  INCREMENTS_DIR="$PROJECT_ROOT/.specweave/increments"
+
+  # Check for recently modified spec.md or tasks.md files
+  if [[ -d "$INCREMENTS_DIR" ]]; then
+    for file in "$INCREMENTS_DIR"/*/spec.md "$INCREMENTS_DIR"/*/tasks.md; do
+      if [[ -f "$file" ]]; then
+        # Get file modification time (platform-specific)
+        if [[ "$(uname)" == "Darwin" ]]; then
+          MTIME=$(stat -f "%m" "$file" 2>/dev/null || echo 0)
+        else
+          MTIME=$(stat -c "%Y" "$file" 2>/dev/null || echo 0)
+        fi
+
+        # If file was modified in last 2 seconds, consider it the written file
+        TIME_DIFF=$((NOW - MTIME))
+        if (( TIME_DIFF <= 2 )); then
+          WRITTEN_FILE="$file"
+          echo "[$(date)] post-write-spec: Detected recent modification: $file (${TIME_DIFF}s ago)" >> "$DEBUG_LOG" 2>/dev/null || true
+          SHOULD_UPDATE=true
+          break
+        fi
+      fi
+    done
+  fi
+
+  # If still no file detected, skip update (not a spec/tasks write)
+  if [[ -z "$WRITTEN_FILE" ]]; then
+    echo "[$(date)] post-write-spec: No spec/tasks modifications detected - skipping" >> "$DEBUG_LOG" 2>/dev/null || true
+    exit 0
+  fi
 fi
 
+# ============================================================================
+# TIER 1 FIX: Non-Blocking Background Update with COMPLETE ERROR ISOLATION
+# ============================================================================
 # Update status line if needed
 if [[ "$SHOULD_UPDATE" == "true" ]]; then
-  echo "[$(date)] post-write-spec: Running update-status-line.sh" >> "$DEBUG_LOG" 2>/dev/null || true
+  echo "[$(date)] post-write-spec: Running update-status-line.sh (background)" >> "$DEBUG_LOG" 2>/dev/null || true
 
-  # Run status line update (capture errors for debugging)
-  if "$PROJECT_ROOT/plugins/specweave/hooks/lib/update-status-line.sh" 2>&1 | tee -a "$DEBUG_LOG" >/dev/null; then
-    echo "[$(date)] post-write-spec: Status line updated successfully" >> "$DEBUG_LOG" 2>/dev/null || true
-  else
-    echo "[$(date)] post-write-spec: Warning - status line update failed (non-blocking)" >> "$DEBUG_LOG" 2>/dev/null || true
-  fi
+  # Record update time BEFORE spawning background process
+  # This ensures debouncing works even if update hasn't completed yet
+  echo "$(date +%s)" > "$LAST_UPDATE_FILE"
+
+  # Run status line update in background with COMPLETE error isolation
+  # This prevents Write tool from waiting for status line computation
+  (
+    set +e  # Disable error propagation
+
+    if "$PROJECT_ROOT/plugins/specweave/hooks/lib/update-status-line.sh" 2>&1 | tee -a "$DEBUG_LOG" >/dev/null; then
+      echo "[$(date)] post-write-spec: Status line updated successfully" >> "$DEBUG_LOG" 2>/dev/null || true
+      # Reset circuit breaker on success
+      echo "0" > "$CIRCUIT_BREAKER_FILE" 2>/dev/null || true
+    else
+      echo "[$(date)] post-write-spec: Warning - status line update failed (non-blocking)" >> "$DEBUG_LOG" 2>/dev/null || true
+      # Increment circuit breaker
+      CURRENT_FAILURES=$(cat "$CIRCUIT_BREAKER_FILE" 2>/dev/null || echo 0)
+      echo "$((CURRENT_FAILURES + 1))" > "$CIRCUIT_BREAKER_FILE" 2>/dev/null || true
+    fi
+  ) &
+
+  # Disown the background process so it's not killed when hook exits
+  disown 2>/dev/null || true
 fi
 
+# Always exit 0 to prevent hook errors from crashing Claude Code
 exit 0

package/plugins/specweave/hooks/pre-edit-spec.sh

@@ -0,0 +1,151 @@
+#!/bin/bash
+#
+# Pre-Edit Hook: Capture File Path BEFORE Edit Executes (Tier 2)
+#
+# Purpose: Detect which file will be edited BEFORE the Edit tool runs
+# Strategy: PreToolUse has better access to tool arguments than PostToolUse
+#
+# TIER 2 COORDINATION:
+# 1. Extract file_path from TOOL_USE_ARGS (more reliable in PreToolUse)
+# 2. If it's spec.md/tasks.md in increments folder, signal PostToolUse hook
+# 3. Write file path to .pending-status-update for PostToolUse to consume
+#
+# This eliminates the need for mtime-based fallback detection (Tier 1)
+# and reduces false positives to near zero.
+#
+# Architecture:
+#   PreToolUse:Edit → pre-edit-spec.sh (this file)
+#     ↓ writes to
+#   .specweave/state/.pending-status-update
+#     ↓ read by
+#   PostToolUse:Edit → post-edit-spec.sh
+#
+# Version: v0.24.3 (EMERGENCY FIXES)
+# Date: 2025-11-22
+
+# EMERGENCY FIX: Remove set -e - it causes Claude Code crashes!
+set +e
+
+# EMERGENCY KILL SWITCH: Disable all hooks if env variable set
+if [[ "${SPECWEAVE_DISABLE_HOOKS:-0}" == "1" ]]; then
+  exit 0
+fi
+
+# Find project root
+find_project_root() {
+  local dir="$PWD"
+  while [[ "$dir" != "/" ]]; do
+    if [[ -d "$dir/.specweave" ]]; then
+      echo "$dir"
+      return 0
+    fi
+    dir=$(dirname "$dir")
+  done
+  echo "$PWD"
+}
+
+PROJECT_ROOT=$(find_project_root)
+STATE_DIR="$PROJECT_ROOT/.specweave/state"
+LOGS_DIR="$PROJECT_ROOT/.specweave/logs"
+DEBUG_LOG="$LOGS_DIR/hooks-debug.log"
+PENDING_FILE="$STATE_DIR/.pending-status-update"
+METRICS_FILE="$STATE_DIR/hook-metrics.jsonl"
+
+# Ensure directories exist
+mkdir -p "$STATE_DIR" "$LOGS_DIR" 2>/dev/null || true
+
+# ============================================================================
+# TIER 2: Extract File Path from Tool Arguments
+# ============================================================================
+# PreToolUse should have access to tool arguments BEFORE execution
+# Try multiple methods to extract file_path
+
+FILE_PATH=""
+
+# Method 1: TOOL_USE_ARGS environment variable (primary for PreToolUse)
+if [[ -n "${TOOL_USE_ARGS:-}" ]]; then
+  # Try to parse JSON with jq if available
+  if command -v jq &> /dev/null; then
+    FILE_PATH=$(echo "$TOOL_USE_ARGS" | jq -r '.file_path // empty' 2>/dev/null || echo "")
+  fi
+
+  # Fallback: Regex extraction if jq not available or failed
+  if [[ -z "$FILE_PATH" ]]; then
+    FILE_PATH=$(echo "$TOOL_USE_ARGS" | grep -o '"file_path"[[:space:]]*:[[:space:]]*"[^"]*"' | head -1 | sed 's/.*"\([^"]*\)".*/\1/' || echo "")
+  fi
+fi
+
+# Method 2: TOOL_USE_CONTENT (fallback)
+if [[ -z "$FILE_PATH" ]] && [[ -n "${TOOL_USE_CONTENT:-}" ]]; then
+  FILE_PATH="$TOOL_USE_CONTENT"
+fi
+
+# Method 3: Parse from stdin (last resort - experimental)
+if [[ -z "$FILE_PATH" ]] && [[ ! -t 0 ]]; then
+  # Read stdin and try to extract file_path
+  STDIN_DATA=$(cat 2>/dev/null || echo "")
+  if [[ -n "$STDIN_DATA" ]] && command -v jq &> /dev/null; then
+    FILE_PATH=$(echo "$STDIN_DATA" | jq -r '.file_path // empty' 2>/dev/null || echo "")
+  fi
+fi
+
+# ============================================================================
+# TIER 2: Signal Detection and Validation
+# ============================================================================
+
+# Log what we detected (for debugging PreToolUse effectiveness)
+if [[ -n "$FILE_PATH" ]]; then
+  echo "[$(date)] pre-edit-spec: Detected file_path: $FILE_PATH" >> "$DEBUG_LOG" 2>/dev/null || true
+else
+  echo "[$(date)] pre-edit-spec: No file_path detected (will fall back to Tier 1)" >> "$DEBUG_LOG" 2>/dev/null || true
+  exit 0  # Let PostToolUse handle it with mtime fallback
+fi
+
+# Check if this is a spec.md or tasks.md file in increments folder
+IS_SPEC_FILE=false
+if [[ "$FILE_PATH" == *"/spec.md" ]] || [[ "$FILE_PATH" == *"/tasks.md" ]]; then
+  if [[ "$FILE_PATH" == *"/.specweave/increments/"* ]]; then
+    # Exclude archived increments
+    if [[ "$FILE_PATH" != *"/_archive/"* ]]; then
+      IS_SPEC_FILE=true
+    fi
+  fi
+fi
+
+# If not a spec/tasks file, exit silently (no signal to PostToolUse)
+if [[ "$IS_SPEC_FILE" != "true" ]]; then
+  echo "[$(date)] pre-edit-spec: Not a spec/tasks file - no signal" >> "$DEBUG_LOG" 2>/dev/null || true
+  exit 0
+fi
+
+# ============================================================================
+# TIER 2: Write Signal for PostToolUse Hook
+# ============================================================================
+
+# Write file path to pending file for PostToolUse to consume
+echo "$FILE_PATH" > "$PENDING_FILE" 2>/dev/null || true
+
+echo "[$(date)] pre-edit-spec: Signaled PostToolUse for: $FILE_PATH" >> "$DEBUG_LOG" 2>/dev/null || true
+
+# ============================================================================
+# TIER 2: Metrics Collection
+# ============================================================================
+
+# Record metrics (JSONL format - one JSON object per line)
+TIMESTAMP=$(date -u +%Y-%m-%dT%H:%M:%SZ)
+METRIC_ENTRY="{\"timestamp\":\"$TIMESTAMP\",\"hook\":\"pre-edit-spec\",\"event\":\"file_detected\",\"file_path\":\"$FILE_PATH\",\"method\":\"TOOL_USE_ARGS\"}"
+
+# Append to metrics file (JSONL)
+echo "$METRIC_ENTRY" >> "$METRICS_FILE" 2>/dev/null || true
+
+# Log rotation for metrics (keep last 1000 entries)
+if [[ -f "$METRICS_FILE" ]]; then
+  LINE_COUNT=$(wc -l < "$METRICS_FILE" 2>/dev/null || echo 0)
+  if (( LINE_COUNT > 1000 )); then
+    tail -1000 "$METRICS_FILE" > "$METRICS_FILE.tmp" 2>/dev/null || true
+    mv "$METRICS_FILE.tmp" "$METRICS_FILE" 2>/dev/null || true
+  fi
+fi
+
+# ALWAYS exit 0 - NEVER let hook errors crash Claude Code
+exit 0

package/plugins/specweave/hooks/pre-task-completion.sh

@@ -92,15 +92,14 @@ fi
 # DETECT CURRENT INCREMENT
 # ============================================================================
 
-CURRENT_INCREMENT=$(ls -t .specweave/increments/ 2>/dev/null | grep -v "_backlog" | grep -v "_archive" | head -1)
+CURRENT_INCREMENT=$(ls -td .specweave/increments/*/ 2>/dev/null | xargs -n1 basename | grep -v "_backlog" | grep -v "_archive" | grep -v "_working" | head -1)
 
 if [ -z "$CURRENT_INCREMENT" ]; then
-  echo "[$(date)] ⚠️  No active increment found, skipping validation" >> "$DEBUG_LOG" 2>/dev/null || true
+  echo "[$(date)] ℹ️  No active increment found, skipping validation" >> "$DEBUG_LOG" 2>/dev/null || true
   rm -f "$STDIN_DATA"
   cat <<EOF
 {
-  "continue": true,
-  "systemMessage": "⚠️  Warning: No active increment found. Task completion validation skipped."
+  "continue": true
 }
 EOF
   exit 0
@@ -109,12 +108,11 @@ fi
 TASKS_MD=".specweave/increments/$CURRENT_INCREMENT/tasks.md"
 
 if [ ! -f "$TASKS_MD" ]; then
-  echo "[$(date)] ⚠️  tasks.md not found for $CURRENT_INCREMENT" >> "$DEBUG_LOG" 2>/dev/null || true
+  echo "[$(date)] ℹ️  tasks.md not found for $CURRENT_INCREMENT (increment may be in planning stage)" >> "$DEBUG_LOG" 2>/dev/null || true
   rm -f "$STDIN_DATA"
   cat <<EOF
 {
-  "continue": true,
-  "systemMessage": "⚠️  Warning: tasks.md not found. Task completion validation skipped."
+  "continue": true
 }
 EOF
   exit 0

package/plugins/specweave/hooks/pre-write-spec.sh

@@ -0,0 +1,151 @@
+#!/bin/bash
+#
+# Pre-Write Hook: Capture File Path BEFORE Write Executes (Tier 2)
+#
+# Purpose: Detect which file will be written BEFORE the Write tool runs
+# Strategy: PreToolUse has better access to tool arguments than PostToolUse
+#
+# TIER 2 COORDINATION:
+# 1. Extract file_path from TOOL_USE_ARGS (more reliable in PreToolUse)
+# 2. If it's spec.md/tasks.md in increments folder, signal PostToolUse hook
+# 3. Write file path to .pending-status-update for PostToolUse to consume
+#
+# This eliminates the need for mtime-based fallback detection (Tier 1)
+# and reduces false positives to near zero.
+#
+# Architecture:
+#   PreToolUse:Write → pre-write-spec.sh (this file)
+#     ↓ writes to
+#   .specweave/state/.pending-status-update
+#     ↓ read by
+#   PostToolUse:Write → post-write-spec.sh
+#
+# Version: v0.24.3 (EMERGENCY FIXES)
+# Date: 2025-11-22
+
+# EMERGENCY FIX: Remove set -e - it causes Claude Code crashes!
+set +e
+
+# EMERGENCY KILL SWITCH: Disable all hooks if env variable set
+if [[ "${SPECWEAVE_DISABLE_HOOKS:-0}" == "1" ]]; then
+  exit 0
+fi
+
+# Find project root
+find_project_root() {
+  local dir="$PWD"
+  while [[ "$dir" != "/" ]]; do
+    if [[ -d "$dir/.specweave" ]]; then
+      echo "$dir"
+      return 0
+    fi
+    dir=$(dirname "$dir")
+  done
+  echo "$PWD"
+}
+
+PROJECT_ROOT=$(find_project_root)
+STATE_DIR="$PROJECT_ROOT/.specweave/state"
+LOGS_DIR="$PROJECT_ROOT/.specweave/logs"
+DEBUG_LOG="$LOGS_DIR/hooks-debug.log"
+PENDING_FILE="$STATE_DIR/.pending-status-update"
+METRICS_FILE="$STATE_DIR/hook-metrics.jsonl"
+
+# Ensure directories exist
+mkdir -p "$STATE_DIR" "$LOGS_DIR" 2>/dev/null || true
+
+# ============================================================================
+# TIER 2: Extract File Path from Tool Arguments
+# ============================================================================
+# PreToolUse should have access to tool arguments BEFORE execution
+# Try multiple methods to extract file_path
+
+FILE_PATH=""
+
+# Method 1: TOOL_USE_ARGS environment variable (primary for PreToolUse)
+if [[ -n "${TOOL_USE_ARGS:-}" ]]; then
+  # Try to parse JSON with jq if available
+  if command -v jq &> /dev/null; then
+    FILE_PATH=$(echo "$TOOL_USE_ARGS" | jq -r '.file_path // empty' 2>/dev/null || echo "")
+  fi
+
+  # Fallback: Regex extraction if jq not available or failed
+  if [[ -z "$FILE_PATH" ]]; then
+    FILE_PATH=$(echo "$TOOL_USE_ARGS" | grep -o '"file_path"[[:space:]]*:[[:space:]]*"[^"]*"' | head -1 | sed 's/.*"\([^"]*\)".*/\1/' || echo "")
+  fi
+fi
+
+# Method 2: TOOL_USE_CONTENT (fallback)
+if [[ -z "$FILE_PATH" ]] && [[ -n "${TOOL_USE_CONTENT:-}" ]]; then
+  FILE_PATH="$TOOL_USE_CONTENT"
+fi
+
+# Method 3: Parse from stdin (last resort - experimental)
+if [[ -z "$FILE_PATH" ]] && [[ ! -t 0 ]]; then
+  # Read stdin and try to extract file_path
+  STDIN_DATA=$(cat 2>/dev/null || echo "")
+  if [[ -n "$STDIN_DATA" ]] && command -v jq &> /dev/null; then
+    FILE_PATH=$(echo "$STDIN_DATA" | jq -r '.file_path // empty' 2>/dev/null || echo "")
+  fi
+fi
+
+# ============================================================================
+# TIER 2: Signal Detection and Validation
+# ============================================================================
+
+# Log what we detected (for debugging PreToolUse effectiveness)
+if [[ -n "$FILE_PATH" ]]; then
+  echo "[$(date)] pre-write-spec: Detected file_path: $FILE_PATH" >> "$DEBUG_LOG" 2>/dev/null || true
+else
+  echo "[$(date)] pre-write-spec: No file_path detected (will fall back to Tier 1)" >> "$DEBUG_LOG" 2>/dev/null || true
+  exit 0  # Let PostToolUse handle it with mtime fallback
+fi
+
+# Check if this is a spec.md or tasks.md file in increments folder
+IS_SPEC_FILE=false
+if [[ "$FILE_PATH" == *"/spec.md" ]] || [[ "$FILE_PATH" == *"/tasks.md" ]]; then
+  if [[ "$FILE_PATH" == *"/.specweave/increments/"* ]]; then
+    # Exclude archived increments
+    if [[ "$FILE_PATH" != *"/_archive/"* ]]; then
+      IS_SPEC_FILE=true
+    fi
+  fi
+fi
+
+# If not a spec/tasks file, exit silently (no signal to PostToolUse)
+if [[ "$IS_SPEC_FILE" != "true" ]]; then
+  echo "[$(date)] pre-write-spec: Not a spec/tasks file - no signal" >> "$DEBUG_LOG" 2>/dev/null || true
+  exit 0
+fi
+
+# ============================================================================
+# TIER 2: Write Signal for PostToolUse Hook
+# ============================================================================
+
+# Write file path to pending file for PostToolUse to consume
+echo "$FILE_PATH" > "$PENDING_FILE" 2>/dev/null || true
+
+echo "[$(date)] pre-write-spec: Signaled PostToolUse for: $FILE_PATH" >> "$DEBUG_LOG" 2>/dev/null || true
+
+# ============================================================================
+# TIER 2: Metrics Collection
+# ============================================================================
+
+# Record metrics (JSONL format - one JSON object per line)
+TIMESTAMP=$(date -u +%Y-%m-%dT%H:%M:%SZ)
+METRIC_ENTRY="{\"timestamp\":\"$TIMESTAMP\",\"hook\":\"pre-write-spec\",\"event\":\"file_detected\",\"file_path\":\"$FILE_PATH\",\"method\":\"TOOL_USE_ARGS\"}"
+
+# Append to metrics file (JSONL)
+echo "$METRIC_ENTRY" >> "$METRICS_FILE" 2>/dev/null || true
+
+# Log rotation for metrics (keep last 1000 entries)
+if [[ -f "$METRICS_FILE" ]]; then
+  LINE_COUNT=$(wc -l < "$METRICS_FILE" 2>/dev/null || echo 0)
+  if (( LINE_COUNT > 1000 )); then
+    tail -1000 "$METRICS_FILE" > "$METRICS_FILE.tmp" 2>/dev/null || true
+    mv "$METRICS_FILE.tmp" "$METRICS_FILE" 2>/dev/null || true
+  fi
+fi
+
+# ALWAYS exit 0 - NEVER let hook errors crash Claude Code
+exit 0