specweave 0.23.2 → 0.23.5

package/plugins/specweave/hooks/pre-task-completion.sh

@@ -0,0 +1,196 @@
+#!/bin/bash
+
+# SpecWeave Pre-Task-Completion Hook
+# CRITICAL QUALITY GATE: Validates AC tests before allowing task completion
+#
+# Runs automatically BEFORE any task is marked complete via TodoWrite
+#
+# WORKFLOW:
+# =========
+# 1. TodoWrite called with status="completed"
+# 2. This hook fires (pre-completion validation)
+# 3. Extract task ID from TodoWrite input
+# 4. Find task in tasks.md
+# 5. Run AC test validator
+# 6. If tests PASS → Allow completion (continue: true)
+# 7. If tests FAIL → Block completion (continue: false, show error)
+#
+# ENFORCEMENT:
+# ============
+# This is the ONLY way to mark tasks complete in SpecWeave.
+# Manual edits to tasks.md are detected and flagged by pre-commit hooks.
+
+set -e
+
+# Find project root
+find_project_root() {
+  local dir="$1"
+  while [ "$dir" != "/" ]; do
+    if [ -d "$dir/.specweave" ]; then
+      echo "$dir"
+      return 0
+    fi
+    dir="$(dirname "$dir")"
+  done
+  pwd
+}
+
+PROJECT_ROOT="$(find_project_root "$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)")"
+cd "$PROJECT_ROOT" 2>/dev/null || true
+
+# ============================================================================
+# CONFIGURATION
+# ============================================================================
+
+LOGS_DIR=".specweave/logs"
+DEBUG_LOG="$LOGS_DIR/hooks-debug.log"
+
+mkdir -p "$LOGS_DIR" 2>/dev/null || true
+
+echo "[$(date)] 🔒 Pre-task-completion hook fired" >> "$DEBUG_LOG" 2>/dev/null || true
+
+# ============================================================================
+# CAPTURE INPUT
+# ============================================================================
+
+STDIN_DATA=$(mktemp)
+cat > "$STDIN_DATA"
+
+echo "[$(date)] Input JSON:" >> "$DEBUG_LOG" 2>/dev/null || true
+cat "$STDIN_DATA" >> "$DEBUG_LOG" 2>/dev/null || true
+
+# ============================================================================
+# CHECK FOR TASK COMPLETION
+# ============================================================================
+
+# Only validate if a task is being marked complete
+COMPLETING_TASK=false
+
+if command -v jq >/dev/null 2>&1; then
+  # Check if any task is transitioning to "completed" status
+  COMPLETED_COUNT=$(jq -r '.tool_input.todos // [] | map(select(.status == "completed")) | length' "$STDIN_DATA" 2>/dev/null || echo "0")
+
+  if [ "$COMPLETED_COUNT" != "0" ]; then
+    COMPLETING_TASK=true
+    echo "[$(date)] ✓ Detected task completion (${COMPLETED_COUNT} tasks)" >> "$DEBUG_LOG" 2>/dev/null || true
+  fi
+fi
+
+# If no tasks being completed, allow without validation
+if [ "$COMPLETING_TASK" = "false" ]; then
+  echo "[$(date)] ⏭️  No tasks being completed, skipping validation" >> "$DEBUG_LOG" 2>/dev/null || true
+  rm -f "$STDIN_DATA"
+  cat <<EOF
+{
+  "continue": true
+}
+EOF
+  exit 0
+fi
+
+# ============================================================================
+# DETECT CURRENT INCREMENT
+# ============================================================================
+
+CURRENT_INCREMENT=$(ls -t .specweave/increments/ 2>/dev/null | grep -v "_backlog" | grep -v "_archive" | head -1)
+
+if [ -z "$CURRENT_INCREMENT" ]; then
+  echo "[$(date)] ⚠️  No active increment found, skipping validation" >> "$DEBUG_LOG" 2>/dev/null || true
+  rm -f "$STDIN_DATA"
+  cat <<EOF
+{
+  "continue": true,
+  "systemMessage": "⚠️  Warning: No active increment found. Task completion validation skipped."
+}
+EOF
+  exit 0
+fi
+
+TASKS_MD=".specweave/increments/$CURRENT_INCREMENT/tasks.md"
+
+if [ ! -f "$TASKS_MD" ]; then
+  echo "[$(date)] ⚠️  tasks.md not found for $CURRENT_INCREMENT" >> "$DEBUG_LOG" 2>/dev/null || true
+  rm -f "$STDIN_DATA"
+  cat <<EOF
+{
+  "continue": true,
+  "systemMessage": "⚠️  Warning: tasks.md not found. Task completion validation skipped."
+}
+EOF
+  exit 0
+fi
+
+# ============================================================================
+# RUN AC TEST VALIDATION
+# ============================================================================
+
+echo "[$(date)] 🧪 Running AC test validation for $CURRENT_INCREMENT" >> "$DEBUG_LOG" 2>/dev/null || true
+
+# Determine which validation script to use
+VALIDATOR_SCRIPT=""
+if [ -f "$PROJECT_ROOT/dist/src/core/ac-test-validator-cli.js" ]; then
+  VALIDATOR_SCRIPT="$PROJECT_ROOT/dist/src/core/ac-test-validator-cli.js"
+elif [ -f "$PROJECT_ROOT/node_modules/specweave/dist/src/core/ac-test-validator-cli.js" ]; then
+  VALIDATOR_SCRIPT="$PROJECT_ROOT/node_modules/specweave/dist/src/core/ac-test-validator-cli.js"
+elif [ -n "${CLAUDE_PLUGIN_ROOT}" ] && [ -f "${CLAUDE_PLUGIN_ROOT}/dist/src/core/ac-test-validator-cli.js" ]; then
+  VALIDATOR_SCRIPT="${CLAUDE_PLUGIN_ROOT}/dist/src/core/ac-test-validator-cli.js"
+fi
+
+if [ -z "$VALIDATOR_SCRIPT" ] || ! command -v node &> /dev/null; then
+  echo "[$(date)] ⚠️  AC test validator not found or Node.js missing" >> "$DEBUG_LOG" 2>/dev/null || true
+  rm -f "$STDIN_DATA"
+  cat <<EOF
+{
+  "continue": true,
+  "systemMessage": "⚠️  Warning: AC test validator not available. Task completion validation skipped. Install Node.js and rebuild SpecWeave to enable validation."
+}
+EOF
+  exit 0
+fi
+
+# Run validator (captures exit code)
+VALIDATION_OUTPUT=$(mktemp)
+VALIDATION_EXIT_CODE=0
+
+(cd "$PROJECT_ROOT" && node "$VALIDATOR_SCRIPT" "$CURRENT_INCREMENT") > "$VALIDATION_OUTPUT" 2>&1 || VALIDATION_EXIT_CODE=$?
+
+echo "[$(date)] Validator exit code: $VALIDATION_EXIT_CODE" >> "$DEBUG_LOG" 2>/dev/null || true
+cat "$VALIDATION_OUTPUT" >> "$DEBUG_LOG" 2>/dev/null || true
+
+rm -f "$STDIN_DATA"
+
+# ============================================================================
+# DECISION LOGIC
+# ============================================================================
+
+if [ "$VALIDATION_EXIT_CODE" = "0" ]; then
+  # Validation passed - allow completion
+  echo "[$(date)] ✅ AC test validation passed" >> "$DEBUG_LOG" 2>/dev/null || true
+
+  VALIDATION_SUMMARY=$(cat "$VALIDATION_OUTPUT" | tail -5 | tr '\n' ' ')
+
+  rm -f "$VALIDATION_OUTPUT"
+
+  cat <<EOF
+{
+  "continue": true,
+  "systemMessage": "✅ AC Test Validation Passed: All acceptance criteria have passing tests. Task completion allowed. ${VALIDATION_SUMMARY}"
+}
+EOF
+else
+  # Validation failed - block completion
+  echo "[$(date)] ❌ AC test validation failed" >> "$DEBUG_LOG" 2>/dev/null || true
+
+  VALIDATION_ERROR=$(cat "$VALIDATION_OUTPUT" | grep -A 10 "VALIDATION FAILED" | tr '\n' ' ' | cut -c 1-300)
+
+  rm -f "$VALIDATION_OUTPUT"
+
+  cat <<EOF
+{
+  "continue": false,
+  "systemMessage": "❌ AC TEST VALIDATION FAILED: Cannot mark task as complete until all acceptance criteria have passing tests. ${VALIDATION_ERROR}
+
+Fix the failing tests and try again. Run tests manually: npm test"
+}
+EOF
+fi

package/plugins/specweave/lib/hooks/git-diff-analyzer.js

@@ -1,5 +1,5 @@
 import { execSync } from "child_process";
-import fs from "fs-extra";
+import { existsSync, readFileSync } from "fs";
 import path from "path";
 function executeGitCommand(command, cwd) {
   try {
@@ -65,10 +65,10 @@ function getFileContent(file, cwd) {
   try {
     const workingDir = cwd || process.cwd();
     const absolutePath = path.isAbsolute(file) ? file : path.join(workingDir, file);
-    if (!fs.existsSync(absolutePath)) {
+    if (!existsSync(absolutePath)) {
       return "";
     }
-    return fs.readFileSync(absolutePath, "utf-8");
+    return readFileSync(absolutePath, "utf-8");
   } catch {
     return "";
   }

package/plugins/specweave/lib/hooks/git-diff-analyzer.ts

@@ -8,7 +8,7 @@
  */
 
 import { execSync } from 'child_process';
-import fs from 'fs-extra';
+import { existsSync, readFileSync } from 'fs';
 import path from 'path';
 import { GitDiffInfo } from './types/reflection-types';
 
@@ -136,11 +136,11 @@ export function getFileContent(file: string, cwd?: string): string {
     const workingDir = cwd || process.cwd();
     const absolutePath = path.isAbsolute(file) ? file : path.join(workingDir, file);
 
-    if (!fs.existsSync(absolutePath)) {
+    if (!existsSync(absolutePath)) {
       return '';
     }
 
-    return fs.readFileSync(absolutePath, 'utf-8');
+    return readFileSync(absolutePath, 'utf-8');
   } catch {
     return '';
   }

package/plugins/specweave/lib/hooks/invoke-translator-skill.js

@@ -1,4 +1,5 @@
-import fs from "fs-extra";
+import { existsSync } from "fs";
+import { promises as fs } from "fs";
 import {
   detectLanguage,
   prepareTranslation,
@@ -94,7 +95,7 @@ ${contentToTranslate}`,
   }
 }
 async function translateFile(filePath, targetLang = "en") {
-  if (!await fs.pathExists(filePath)) {
+  if (!existsSync(filePath)) {
     throw new Error(`File not found: ${filePath}`);
   }
   const content = await fs.readFile(filePath, "utf-8");

package/plugins/specweave/lib/hooks/invoke-translator-skill.ts

@@ -8,7 +8,8 @@
  * @see plugins/specweave/commands/translate.md
  */
 
-import fs from 'fs-extra';
+import { existsSync } from 'fs';
+import { promises as fs } from 'fs';
 import path from 'path';
 import {
   detectLanguage,
@@ -186,7 +187,7 @@ export async function translateFile(
   targetLang: SupportedLanguage = 'en'
 ): Promise<TranslationResult & { filePath: string }> {
   // Read file
-  if (!await fs.pathExists(filePath)) {
+  if (!existsSync(filePath)) {
     throw new Error(`File not found: ${filePath}`);
   }
 

package/plugins/specweave/lib/hooks/prepare-reflection-context.js

@@ -1,4 +1,4 @@
-import fs from "fs-extra";
+import { mkdirpSync, writeJsonSync } from "../utils/fs-native.js";
 import path from "path";
 import { createReflectionContext } from "./run-self-reflection";
 import { getModifiedFilesSummary } from "./git-diff-analyzer";
@@ -10,7 +10,7 @@ function prepareReflectionContext(incrementId, taskId, projectRoot) {
     }
     const rootDir = projectRoot || process.cwd();
     const tempDir = path.join(rootDir, ".specweave", "increments", incrementId, "logs", "reflections", ".temp");
-    fs.mkdirpSync(tempDir);
+    mkdirpSync(tempDir);
     const contextFile = path.join(tempDir, "reflection-context.json");
     const fileStats = getModifiedFilesSummary(context.modifiedFiles);
     const contextData = {
@@ -30,7 +30,7 @@ function prepareReflectionContext(incrementId, taskId, projectRoot) {
       config: context.config,
       timestamp: (/* @__PURE__ */ new Date()).toISOString()
     };
-    fs.writeJsonSync(contextFile, contextData, { spaces: 2 });
+    writeJsonSync(contextFile, contextData, { spaces: 2 });
     return contextFile;
   } catch (error) {
     console.error(`Failed to prepare reflection context: ${error.message}`);

package/plugins/specweave/lib/hooks/prepare-reflection-context.ts

@@ -7,7 +7,7 @@
  * @module prepare-reflection-context
  */
 
-import fs from 'fs-extra';
+import { mkdirpSync, writeJsonSync } from '../utils/fs-native.js';
 import path from 'path';
 import { createReflectionContext } from './run-self-reflection';
 import { getModifiedFilesSummary } from './git-diff-analyzer';
@@ -37,7 +37,7 @@ export function prepareReflectionContext(
     // Create temp directory for reflection context
     const rootDir = projectRoot || process.cwd();
     const tempDir = path.join(rootDir, '.specweave', 'increments', incrementId, 'logs', 'reflections', '.temp');
-    fs.mkdirpSync(tempDir);
+    mkdirpSync(tempDir);
 
     // Save context to temp file
     const contextFile = path.join(tempDir, 'reflection-context.json');
@@ -62,7 +62,7 @@ export function prepareReflectionContext(
       timestamp: new Date().toISOString()
     };
 
-    fs.writeJsonSync(contextFile, contextData, { spaces: 2 });
+    writeJsonSync(contextFile, contextData, { spaces: 2 });
 
     return contextFile;
   } catch (error: any) {

package/plugins/specweave/lib/hooks/reflection-config-loader.js

@@ -1,4 +1,4 @@
-import fs from "fs-extra";
+import { existsSync, readFileSync } from "fs";
 import path from "path";
 import { DEFAULT_REFLECTION_CONFIG } from "./types/reflection-types";
 function findSpecweaveRoot(startDir = process.cwd()) {
@@ -6,7 +6,7 @@ function findSpecweaveRoot(startDir = process.cwd()) {
   const root = path.parse(currentDir).root;
   while (currentDir !== root) {
     const specweavePath = path.join(currentDir, ".specweave");
-    if (fs.existsSync(specweavePath)) {
+    if (existsSync(specweavePath)) {
       return currentDir;
     }
     currentDir = path.dirname(currentDir);
@@ -19,11 +19,11 @@ function loadReflectionConfig(projectRoot) {
     return { ...DEFAULT_REFLECTION_CONFIG };
   }
   const configPath = path.join(rootDir, ".specweave", "config.json");
-  if (!fs.existsSync(configPath)) {
+  if (!existsSync(configPath)) {
     return { ...DEFAULT_REFLECTION_CONFIG };
   }
   try {
-    const configContent = fs.readFileSync(configPath, "utf-8");
+    const configContent = readFileSync(configPath, "utf-8");
     const config = JSON.parse(configContent);
     const userReflectionConfig = config.reflection || {};
     const mergedConfig = {

package/plugins/specweave/lib/hooks/reflection-config-loader.ts

@@ -7,7 +7,7 @@
  * @module reflection-config-loader
  */
 
-import fs from 'fs-extra';
+import { existsSync, readFileSync } from 'fs';
 import path from 'path';
 import { DEFAULT_REFLECTION_CONFIG, ReflectionConfig } from './types/reflection-types';
 
@@ -22,7 +22,7 @@ export function findSpecweaveRoot(startDir: string = process.cwd()): string | nu
 
   while (currentDir !== root) {
     const specweavePath = path.join(currentDir, '.specweave');
-    if (fs.existsSync(specweavePath)) {
+    if (existsSync(specweavePath)) {
       return currentDir;
     }
     currentDir = path.dirname(currentDir);
@@ -51,13 +51,13 @@ export function loadReflectionConfig(projectRoot?: string): ReflectionConfig {
   const configPath = path.join(rootDir, '.specweave', 'config.json');
 
   // Config file doesn't exist, return defaults
-  if (!fs.existsSync(configPath)) {
+  if (!existsSync(configPath)) {
     return { ...DEFAULT_REFLECTION_CONFIG };
   }
 
   try {
     // Read and parse config file
-    const configContent = fs.readFileSync(configPath, 'utf-8');
+    const configContent = readFileSync(configPath, 'utf-8');
     const config = JSON.parse(configContent);
 
     // Extract reflection section (may be undefined)

package/plugins/specweave/lib/hooks/reflection-storage.js

@@ -1,4 +1,4 @@
-import fs from "fs-extra";
+import { mkdirpSync, writeFileSync, existsSync, readdirSync, statSync, readFileSync, removeSync } from "../utils/fs-native.js";
 import path from "path";
 import { IssueSeverity } from "./types/reflection-types";
 function generateReflectionMarkdown(result) {
@@ -183,12 +183,12 @@ function getReflectionFilename(taskId, timestamp) {
 }
 function saveReflection(result, incrementId, taskId, projectRoot) {
   const logDir = getReflectionLogDir(incrementId, projectRoot);
-  fs.mkdirpSync(logDir);
+  mkdirpSync(logDir);
   const filename = getReflectionFilename(taskId);
   const filepath = path.join(logDir, filename);
   const markdown = generateReflectionMarkdown(result);
   try {
-    fs.writeFileSync(filepath, markdown, "utf-8");
+    writeFileSync(filepath, markdown, "utf-8");
     return filepath;
   } catch (error) {
     throw new Error(`Failed to save reflection: ${error.message}`);
@@ -196,26 +196,26 @@ function saveReflection(result, incrementId, taskId, projectRoot) {
 }
 function listReflections(incrementId, projectRoot) {
   const logDir = getReflectionLogDir(incrementId, projectRoot);
-  if (!fs.existsSync(logDir)) {
+  if (!existsSync(logDir)) {
     return [];
   }
-  const files = fs.readdirSync(logDir).filter((file) => file.endsWith(".md")).map((file) => path.join(logDir, file)).sort((a, b) => {
-    const statA = fs.statSync(a);
-    const statB = fs.statSync(b);
+  const files = readdirSync(logDir).filter((file) => file.endsWith(".md")).map((file) => path.join(logDir, file)).sort((a, b) => {
+    const statA = statSync(a);
+    const statB = statSync(b);
     return statB.mtime.getTime() - statA.mtime.getTime();
   });
   return files;
 }
 function readReflection(filepath) {
   try {
-    return fs.readFileSync(filepath, "utf-8");
+    return readFileSync(filepath, "utf-8");
   } catch (error) {
     throw new Error(`Failed to read reflection: ${error.message}`);
   }
 }
 function deleteReflection(filepath) {
   try {
-    fs.removeSync(filepath);
+    removeSync(filepath);
   } catch (error) {
     throw new Error(`Failed to delete reflection: ${error.message}`);
   }

package/plugins/specweave/lib/hooks/reflection-storage.ts

@@ -7,7 +7,7 @@
  * @module reflection-storage
  */
 
-import fs from 'fs-extra';
+import { mkdirpSync, writeFileSync, existsSync, readdirSync, statSync, readFileSync, removeSync } from '../utils/fs-native.js';
 import path from 'path';
 import { ReflectionResult, IssueSeverity } from './types/reflection-types';
 
@@ -294,7 +294,7 @@ export function saveReflection(
 ): string {
   // Ensure reflection logs directory exists
   const logDir = getReflectionLogDir(incrementId, projectRoot);
-  fs.mkdirpSync(logDir);
+  mkdirpSync(logDir);
 
   // Generate filename
   const filename = getReflectionFilename(taskId);
@@ -305,7 +305,7 @@ export function saveReflection(
 
   // Write to file
   try {
-    fs.writeFileSync(filepath, markdown, 'utf-8');
+    writeFileSync(filepath, markdown, 'utf-8');
     return filepath;
   } catch (error: any) {
     throw new Error(`Failed to save reflection: ${error.message}`);
@@ -324,17 +324,17 @@ export function listReflections(
 ): string[] {
   const logDir = getReflectionLogDir(incrementId, projectRoot);
 
-  if (!fs.existsSync(logDir)) {
+  if (!existsSync(logDir)) {
     return [];
   }
 
-  const files = fs.readdirSync(logDir)
+  const files = readdirSync(logDir)
     .filter(file => file.endsWith('.md'))
     .map(file => path.join(logDir, file))
     .sort((a, b) => {
       // Sort by modification time (newest first)
-      const statA = fs.statSync(a);
-      const statB = fs.statSync(b);
+      const statA = statSync(a);
+      const statB = statSync(b);
       return statB.mtime.getTime() - statA.mtime.getTime();
     });
 
@@ -349,7 +349,7 @@ export function listReflections(
  */
 export function readReflection(filepath: string): string {
   try {
-    return fs.readFileSync(filepath, 'utf-8');
+    return readFileSync(filepath, 'utf-8');
   } catch (error: any) {
     throw new Error(`Failed to read reflection: ${error.message}`);
   }
@@ -362,7 +362,7 @@ export function readReflection(filepath: string): string {
  */
 export function deleteReflection(filepath: string): void {
   try {
-    fs.removeSync(filepath);
+    removeSync(filepath);
   } catch (error: any) {
     throw new Error(`Failed to delete reflection: ${error.message}`);
   }

package/plugins/specweave/lib/hooks/sync-cache.js

@@ -11,9 +11,10 @@
  * Part of increment 0047-us-task-linkage (T-012).
  */
 
-import fs from 'fs-extra';
+import { readFileSync, statSync, existsSync, promises as fs } from 'fs';
 import path from 'path';
 import crypto from 'crypto';
+import { mkdirpSync } from '../utils/fs-native.js';
 
 /**
  * In-memory cache with TTL
@@ -97,7 +98,7 @@ const globalCache = new SyncCache();
  */
 export function getFileHash(filePath) {
   try {
-    const content = fs.readFileSync(filePath, 'utf-8');
+    const content = readFileSync(filePath, 'utf-8');
     return crypto.createHash('sha256').update(content).digest('hex');
   } catch (error) {
     return null;
@@ -145,7 +146,7 @@ export function getCachedTasks(tasksPath, parser) {
  */
 export function getCachedUSMetadata(usFilePath) {
   try {
-    const stats = fs.statSync(usFilePath);
+    const stats = statSync(usFilePath);
     const cacheKey = `us-metadata:${usFilePath}`;
 
     const cached = globalCache.get(cacheKey);
@@ -156,7 +157,7 @@ export function getCachedUSMetadata(usFilePath) {
     }
 
     // File changed or not in cache - read and cache
-    const content = fs.readFileSync(usFilePath, 'utf-8');
+    const content = readFileSync(usFilePath, 'utf-8');
     const metadata = {
       mtime: stats.mtimeMs,
       metadata: {
@@ -198,7 +199,7 @@ export async function batchFileUpdates(updates) {
   // Write files sequentially within same directory (better disk I/O)
   for (const [dir, fileUpdates] of updatesByDir.entries()) {
     // Ensure directory exists once per directory
-    await fs.ensureDir(dir);
+    await fs.mkdir(dir, { recursive: true });
 
     // Write all files in this directory
     await Promise.all(
@@ -220,13 +221,13 @@ export async function batchFileUpdates(updates) {
 export function needsSync(usFilePath, tasks, tasksPath) {
   try {
     // Check if US file exists
-    if (!fs.existsSync(usFilePath)) {
+    if (!existsSync(usFilePath)) {
       return false; // File doesn't exist, can't sync
     }
 
     // Get file modification times
-    const usStats = fs.statSync(usFilePath);
-    const tasksStats = fs.statSync(tasksPath);
+    const usStats = statSync(usFilePath);
+    const tasksStats = statSync(tasksPath);
 
     // If tasks.md is newer than US file, sync is needed
     if (tasksStats.mtimeMs > usStats.mtimeMs) {