specweave 0.23.1 → 0.23.4

package/plugins/specweave-github/lib/github-client-v2.js

@@ -247,7 +247,8 @@ ${body}`;
       "--json",
       "number,title,state,url,labels",
       "--limit",
-      "1"
+      "50"
+      // ✅ FIX: Increased from 1 to 50 to catch duplicates (Issue #0047)
     ]);
     if (result.exitCode !== 0) {
       return null;

package/plugins/specweave-github/lib/github-client-v2.ts

@@ -335,7 +335,7 @@ export class GitHubClientV2 {
       '--json',
       'number,title,state,url,labels',
       '--limit',
-      '1',
+      '50',  // ✅ FIX: Increased from 1 to 50 to catch duplicates (Issue #0047)
     ]);
 
     if (result.exitCode !== 0) {

package/plugins/specweave-github/lib/github-feature-sync.js

@@ -4,6 +4,7 @@ import * as path from "path";
 import * as yaml from "yaml";
 import { UserStoryIssueBuilder } from "./user-story-issue-builder.js";
 import { CompletionCalculator } from "./completion-calculator.js";
+import { DuplicateDetector } from "./duplicate-detector.js";
 import { execFileNoThrow } from "../../../src/utils/execFileNoThrow.js";
 class GitHubFeatureSync {
   constructor(client, specsDir, projectRoot) {
@@ -71,6 +72,8 @@ class GitHubFeatureSync {
       );
       const issueContent = await builder.buildIssueBody();
       issueContent.status = userStory.status;
+      let issueNumber;
+      let wasUpdated = false;
       if (userStory.existingIssue) {
         console.log(`      \u267B\uFE0F  Issue #${userStory.existingIssue} exists in frontmatter`);
         try {
@@ -83,25 +86,35 @@ class GitHubFeatureSync {
           console.log(`      \u26A0\uFE0F  Issue #${userStory.existingIssue} deleted on GitHub, creating new`);
         }
       }
-      const existingByTitle = await this.client.searchIssueByTitle(issueContent.title);
-      if (existingByTitle) {
-        console.log(`      \u267B\uFE0F  Found existing issue by title: #${existingByTitle.number}`);
-        await this.updateUserStoryFrontmatter(userStory.filePath, existingByTitle.number);
-        await this.updateUserStoryIssue(existingByTitle.number, issueContent, userStory.filePath);
-        issuesUpdated++;
-        console.log(`      \u2705 Linked and updated Issue #${existingByTitle.number}`);
-        continue;
-      }
-      console.log(`      \u{1F680} Creating new issue: ${issueContent.title}`);
+      const titlePattern = `[${featureId}][${userStory.id}]`;
       const milestoneTitle = `${featureData.id}: ${featureData.title}`;
-      const issueNumber = await this.createUserStoryIssue(
-        issueContent,
-        milestoneTitle,
-        userStory.filePath
-      );
-      issuesCreated++;
-      console.log(`      \u2705 Created Issue #${issueNumber}`);
+      console.log(`      \u{1F6E1}\uFE0F  Using DuplicateDetector (pattern: ${titlePattern})`);
+      const result = await DuplicateDetector.createWithProtection({
+        title: issueContent.title,
+        body: issueContent.body,
+        titlePattern,
+        incrementId: userStory.id,
+        labels: issueContent.labels,
+        milestone: milestoneTitle,
+        repo: `${this.client.getOwner()}/${this.client.getRepo()}`
+      });
+      issueNumber = result.issue.number;
+      if (result.wasReused) {
+        console.log(`      \u267B\uFE0F  Reused existing issue #${issueNumber} (duplicate prevented!)`);
+        wasUpdated = true;
+      } else {
+        console.log(`      \u2705 Created issue #${issueNumber}`);
+      }
+      if (result.duplicatesFound > 0) {
+        console.log(`      \u{1F6E1}\uFE0F  Duplicates detected: ${result.duplicatesFound}, auto-closed: ${result.duplicatesClosed}`);
+      }
       await this.updateUserStoryFrontmatter(userStory.filePath, issueNumber);
+      if (result.wasReused) {
+        await this.updateUserStoryIssue(issueNumber, issueContent, userStory.filePath);
+        issuesUpdated++;
+      } else {
+        issuesCreated++;
+      }
     }
     console.log(`
 \u2705 Feature sync complete!`);

package/plugins/specweave-github/lib/github-feature-sync.ts

@@ -22,6 +22,7 @@ import * as yaml from 'yaml';
 import { GitHubClientV2 } from './github-client-v2.js';
 import { UserStoryIssueBuilder } from './user-story-issue-builder.js';
 import { CompletionCalculator } from './completion-calculator.js';
+import { DuplicateDetector } from './duplicate-detector.js';
 import { execFileNoThrow } from '../../../src/utils/execFileNoThrow.js';
 
 interface FeatureFrontmatter {
@@ -145,8 +146,18 @@ export class GitHubFeatureSync {
       // ✅ FIX: Add status to issue content for sync
       issueContent.status = userStory.status;
 
-      // ✅ TRIPLE IDEMPOTENCY CHECK
-      // This ensures 100% safety when running sync multiple times
+      // ✅ DUPLICATE PROTECTION WITH GLOBAL DETECTOR
+      // Uses proven 3-phase protection: Detection → Verification → Reflection
+      //
+      // WHY THIS MATTERS:
+      // - Previous implementation had race conditions (--limit 1, eventual consistency)
+      // - DuplicateDetector handles all edge cases automatically
+      // - Auto-closes duplicates if they slip through
+      //
+      // @see .specweave/increments/0047-us-task-linkage/reports/DUPLICATE-GITHUB-ISSUES-ROOT-CAUSE.md
+
+      let issueNumber: number;
+      let wasUpdated = false;
 
       // Check 1: User Story frontmatter has issue number
       if (userStory.existingIssue) {
@@ -167,34 +178,53 @@ export class GitHubFeatureSync {
         }
       }
 
-      // Check 2: Search GitHub for issue by title
-      const existingByTitle = await this.client.searchIssueByTitle(issueContent.title);
-      if (existingByTitle) {
-        console.log(`      ♻️  Found existing issue by title: #${existingByTitle.number}`);
+      // Check 2 & 3: Use DuplicateDetector for robust duplicate prevention
+      // This handles:
+      // - Search with proper limits (not --limit 1)
+      // - Post-create verification
+      // - Auto-close duplicates
+      // - Eventual consistency race conditions
+      const titlePattern = `[${featureId}][${userStory.id}]`;
+      const milestoneTitle = `${featureData.id}: ${featureData.title}`;
 
-        // Link it in frontmatter
-        await this.updateUserStoryFrontmatter(userStory.filePath, existingByTitle.number);
+      console.log(`      🛡️  Using DuplicateDetector (pattern: ${titlePattern})`);
 
-        // Update content with verification
-        await this.updateUserStoryIssue(existingByTitle.number, issueContent, userStory.filePath);
-        issuesUpdated++;
-        console.log(`      ✅ Linked and updated Issue #${existingByTitle.number}`);
-        continue;
+      const result = await DuplicateDetector.createWithProtection({
+        title: issueContent.title,
+        body: issueContent.body,
+        titlePattern,
+        incrementId: userStory.id,
+        labels: issueContent.labels,
+        milestone: milestoneTitle,
+        repo: `${this.client.getOwner()}/${this.client.getRepo()}`
+      });
+
+      issueNumber = result.issue.number;
+
+      // Log duplicate protection results
+      if (result.wasReused) {
+        console.log(`      ♻️  Reused existing issue #${issueNumber} (duplicate prevented!)`);
+        wasUpdated = true;
+      } else {
+        console.log(`      ✅ Created issue #${issueNumber}`);
       }
 
-      // Check 3: No existing issue found, create new
-      console.log(`      🚀 Creating new issue: ${issueContent.title}`);
-      const milestoneTitle = `${featureData.id}: ${featureData.title}`;
-      const issueNumber = await this.createUserStoryIssue(
-        issueContent,
-        milestoneTitle,
-        userStory.filePath
-      );
-      issuesCreated++;
-      console.log(`      ✅ Created Issue #${issueNumber}`);
+      if (result.duplicatesFound > 0) {
+        console.log(`      🛡️  Duplicates detected: ${result.duplicatesFound}, auto-closed: ${result.duplicatesClosed}`);
+      }
 
-      // Update User Story frontmatter
+      // Update User Story frontmatter with issue link
       await this.updateUserStoryFrontmatter(userStory.filePath, issueNumber);
+
+      // Update completion tracking
+      if (result.wasReused) {
+        // Update existing issue with latest content
+        await this.updateUserStoryIssue(issueNumber, issueContent, userStory.filePath);
+        issuesUpdated++;
+      } else {
+        // New issue created
+        issuesCreated++;
+      }
     }
 
     console.log(`\n✅ Feature sync complete!`);

package/plugins/specweave-mobile/README.md

@@ -107,7 +107,7 @@ For architectural decisions and system design:
 Use the Task tool to invoke the mobile-architect agent:
 
 Task(
-  subagent_type: "mobile-architect",
+  subagent_type: "specweave-mobile:mobile-architect:mobile-architect",
   description: "Design architecture for social media app",
   prompt: "Design a scalable React Native architecture for a social media app
   with feed, messaging, and profile features. Include state management,

package/plugins/specweave-release/hooks/.specweave/logs/dora-tracking.log

@@ -6223,3 +6223,75 @@
 [2025-11-20 16:35:05] 🎯 Post-Increment-Completion Hook Triggered
 [2025-11-20 16:35:05] ⚠️  DORA calculator not found at /Users/antonabyzov/Projects/github/specweave/plugins/specweave-release/hooks/dist/src/metrics/dora-calculator.js
 [2025-11-20 16:35:05]    Run: npm run build
+[2025-11-20 17:12:16] 🎯 Post-Increment-Completion Hook Triggered
+[2025-11-20 17:12:16] ⚠️  DORA calculator not found at /Users/antonabyzov/Projects/github/specweave/plugins/specweave-release/hooks/dist/src/metrics/dora-calculator.js
+[2025-11-20 17:12:16]    Run: npm run build
+[2025-11-20 17:12:21] 🎯 Post-Increment-Completion Hook Triggered
+[2025-11-20 17:12:21] ⚠️  DORA calculator not found at /Users/antonabyzov/Projects/github/specweave/plugins/specweave-release/hooks/dist/src/metrics/dora-calculator.js
+[2025-11-20 17:12:21]    Run: npm run build
+[2025-11-20 17:12:27] 🎯 Post-Increment-Completion Hook Triggered
+[2025-11-20 17:12:27] ⚠️  DORA calculator not found at /Users/antonabyzov/Projects/github/specweave/plugins/specweave-release/hooks/dist/src/metrics/dora-calculator.js
+[2025-11-20 17:12:27]    Run: npm run build
+[2025-11-20 17:12:32] 🎯 Post-Increment-Completion Hook Triggered
+[2025-11-20 17:12:32] ⚠️  DORA calculator not found at /Users/antonabyzov/Projects/github/specweave/plugins/specweave-release/hooks/dist/src/metrics/dora-calculator.js
+[2025-11-20 17:12:32]    Run: npm run build
+[2025-11-20 18:11:17] 🎯 Post-Increment-Completion Hook Triggered
+[2025-11-20 18:11:17] ⚠️  DORA calculator not found at /Users/antonabyzov/Projects/github/specweave/plugins/specweave-release/hooks/dist/src/metrics/dora-calculator.js
+[2025-11-20 18:11:17]    Run: npm run build
+[2025-11-20 18:11:22] 🎯 Post-Increment-Completion Hook Triggered
+[2025-11-20 18:11:22] ⚠️  DORA calculator not found at /Users/antonabyzov/Projects/github/specweave/plugins/specweave-release/hooks/dist/src/metrics/dora-calculator.js
+[2025-11-20 18:11:22]    Run: npm run build
+[2025-11-20 18:11:27] 🎯 Post-Increment-Completion Hook Triggered
+[2025-11-20 18:11:27] ⚠️  DORA calculator not found at /Users/antonabyzov/Projects/github/specweave/plugins/specweave-release/hooks/dist/src/metrics/dora-calculator.js
+[2025-11-20 18:11:27]    Run: npm run build
+[2025-11-20 18:11:33] 🎯 Post-Increment-Completion Hook Triggered
+[2025-11-20 18:11:33] ⚠️  DORA calculator not found at /Users/antonabyzov/Projects/github/specweave/plugins/specweave-release/hooks/dist/src/metrics/dora-calculator.js
+[2025-11-20 18:11:33]    Run: npm run build
+[2025-11-20 18:35:45] 🎯 Post-Increment-Completion Hook Triggered
+[2025-11-20 18:35:45] ⚠️  DORA calculator not found at /Users/antonabyzov/Projects/github/specweave/plugins/specweave-release/hooks/dist/src/metrics/dora-calculator.js
+[2025-11-20 18:35:45]    Run: npm run build
+[2025-11-20 18:35:45] 🎯 Post-Increment-Completion Hook Triggered
+[2025-11-20 18:35:45] ⚠️  DORA calculator not found at /Users/antonabyzov/Projects/github/specweave/plugins/specweave-release/hooks/dist/src/metrics/dora-calculator.js
+[2025-11-20 18:35:45]    Run: npm run build
+[2025-11-20 18:35:45] 🎯 Post-Increment-Completion Hook Triggered
+[2025-11-20 18:35:45] ⚠️  DORA calculator not found at /Users/antonabyzov/Projects/github/specweave/plugins/specweave-release/hooks/dist/src/metrics/dora-calculator.js
+[2025-11-20 18:35:45]    Run: npm run build
+[2025-11-20 18:35:45] 🎯 Post-Increment-Completion Hook Triggered
+[2025-11-20 18:35:45] ⚠️  DORA calculator not found at /Users/antonabyzov/Projects/github/specweave/plugins/specweave-release/hooks/dist/src/metrics/dora-calculator.js
+[2025-11-20 18:35:45]    Run: npm run build
+[2025-11-20 18:35:51] 🎯 Post-Increment-Completion Hook Triggered
+[2025-11-20 18:35:51] ⚠️  DORA calculator not found at /Users/antonabyzov/Projects/github/specweave/plugins/specweave-release/hooks/dist/src/metrics/dora-calculator.js
+[2025-11-20 18:35:51]    Run: npm run build
+[2025-11-20 18:35:57] 🎯 Post-Increment-Completion Hook Triggered
+[2025-11-20 18:35:57] ⚠️  DORA calculator not found at /Users/antonabyzov/Projects/github/specweave/plugins/specweave-release/hooks/dist/src/metrics/dora-calculator.js
+[2025-11-20 18:35:57]    Run: npm run build
+[2025-11-20 18:36:03] 🎯 Post-Increment-Completion Hook Triggered
+[2025-11-20 18:36:03] ⚠️  DORA calculator not found at /Users/antonabyzov/Projects/github/specweave/plugins/specweave-release/hooks/dist/src/metrics/dora-calculator.js
+[2025-11-20 18:36:03]    Run: npm run build
+[2025-11-20 18:36:09] 🎯 Post-Increment-Completion Hook Triggered
+[2025-11-20 18:36:09] ⚠️  DORA calculator not found at /Users/antonabyzov/Projects/github/specweave/plugins/specweave-release/hooks/dist/src/metrics/dora-calculator.js
+[2025-11-20 18:36:09]    Run: npm run build
+[2025-11-20 18:50:14] 🎯 Post-Increment-Completion Hook Triggered
+[2025-11-20 18:50:14] ⚠️  DORA calculator not found at /Users/antonabyzov/Projects/github/specweave/plugins/specweave-release/hooks/dist/src/metrics/dora-calculator.js
+[2025-11-20 18:50:14]    Run: npm run build
+[2025-11-20 18:50:14] 🎯 Post-Increment-Completion Hook Triggered
+[2025-11-20 18:50:14] ⚠️  DORA calculator not found at /Users/antonabyzov/Projects/github/specweave/plugins/specweave-release/hooks/dist/src/metrics/dora-calculator.js
+[2025-11-20 18:50:14]    Run: npm run build
+[2025-11-20 18:50:14] 🎯 Post-Increment-Completion Hook Triggered
+[2025-11-20 18:50:14] ⚠️  DORA calculator not found at /Users/antonabyzov/Projects/github/specweave/plugins/specweave-release/hooks/dist/src/metrics/dora-calculator.js
+[2025-11-20 18:50:14]    Run: npm run build
+[2025-11-20 18:50:15] 🎯 Post-Increment-Completion Hook Triggered
+[2025-11-20 18:50:15] ⚠️  DORA calculator not found at /Users/antonabyzov/Projects/github/specweave/plugins/specweave-release/hooks/dist/src/metrics/dora-calculator.js
+[2025-11-20 18:50:15]    Run: npm run build
+[2025-11-20 18:50:20] 🎯 Post-Increment-Completion Hook Triggered
+[2025-11-20 18:50:20] ⚠️  DORA calculator not found at /Users/antonabyzov/Projects/github/specweave/plugins/specweave-release/hooks/dist/src/metrics/dora-calculator.js
+[2025-11-20 18:50:20]    Run: npm run build
+[2025-11-20 18:50:26] 🎯 Post-Increment-Completion Hook Triggered
+[2025-11-20 18:50:26] ⚠️  DORA calculator not found at /Users/antonabyzov/Projects/github/specweave/plugins/specweave-release/hooks/dist/src/metrics/dora-calculator.js
+[2025-11-20 18:50:26]    Run: npm run build
+[2025-11-20 18:50:32] 🎯 Post-Increment-Completion Hook Triggered
+[2025-11-20 18:50:32] ⚠️  DORA calculator not found at /Users/antonabyzov/Projects/github/specweave/plugins/specweave-release/hooks/dist/src/metrics/dora-calculator.js
+[2025-11-20 18:50:32]    Run: npm run build
+[2025-11-20 18:50:38] 🎯 Post-Increment-Completion Hook Triggered
+[2025-11-20 18:50:38] ⚠️  DORA calculator not found at /Users/antonabyzov/Projects/github/specweave/plugins/specweave-release/hooks/dist/src/metrics/dora-calculator.js
+[2025-11-20 18:50:38]    Run: npm run build

package/plugins/specweave/skills/task-builder/README.md

@@ -1,84 +0,0 @@
-# task-builder Skill
-
-**Status**: To be developed
-**Priority**: High
-
-## Purpose
-
-Converts high-level spec.md (user stories, epics, capabilities) into detailed tasks.md with:
-- Technical implementation details
-- File paths and code snippets
-- Acceptance criteria per task
-- Agent/skill references (which agent to use for each task)
-- Documentation update requirements
-
-## When It Activates
-
-- After increment-planner creates increment
-- After spec.md is created
-- User says "create tasks for this feature"
-- User says "break down implementation"
-
-## What It Does
-
-1. **Reads spec.md**: Understands user stories, acceptance tests
-2. **Creates tasks.md**:
-   - Maps user stories → tasks
-   - Adds technical details (file paths, code)
-   - Adds acceptance criteria per task
-   - Specifies which agent/skills to use
-   - Links to documentation
-3. **Updates docs**: Marks sections as [DRAFT] that need updates
-4. **Understands structure**: Adapts to JIRA, ADO, or simple user stories
-
-## Task vs User Story
-
-- **User Story**: Has acceptance TESTS (verify feature works)
-- **Task**: Has acceptance CRITERIA (verify task complete)
-
-## Example Output
-
-```markdown
-# tasks.md
-
-## Task T001: Create StripeService
-
-**Agent**: nodejs-backend
-**Skills**: stripe-integration, api-design
-
-**Description**: Create Stripe service class for payment processing
-
-**File**: src/services/stripe-service.ts
-
-**Implementation**:
-```typescript
-export class StripeService {
-  async createSubscription(params) {
-    // Implementation
-  }
-}
-```
-
-**Acceptance Criteria**:
-- [ ] StripeService class exists in src/services/stripe-service.ts
-- [ ] createSubscription method implemented
-- [ ] Error handling added
-- [ ] Unit tests passing
-
-**Documentation Updates**:
-- [ ] .specweave/docs/api/payments.md [DRAFT]
-```
-
-## Integration
-
-- Called by: increment-planner (after spec.md created)
-- Calls: docs-updater (to update documentation)
-- Output: tasks.md in .specweave/increments/####-feature/
-
-## Configuration
-
-
-
----
-
-**To implement**: See task in .specweave/increments/