specweave 0.18.1 → 0.20.1

package/plugins/specweave-github/lib/duplicate-detector.js

@@ -6,7 +6,7 @@ class DuplicateDetector {
    * Searches GitHub for existing issues matching the title pattern.
    * This is the PRIMARY defense against duplicates.
    *
-   * @param titlePattern - Pattern to search (e.g., "[FS-031]" or "[INC-0031]")
+   * @param titlePattern - Pattern to search (e.g., "[FS-031]" current, "[INC-0031]" deprecated)
    * @param incrementId - Optional increment ID for more precise matching
    * @param repo - Optional repo (format: "owner/repo")
    * @returns Existing issue if found, null otherwise
@@ -341,8 +341,8 @@ The original issue (#${keepIssueNumber}) should be used for tracking instead.
    * Utility: Extract title pattern from full title
    *
    * Examples:
-   * - "[FS-031] Feature Title" → "[FS-031]"
-   * - "[INC-0031] Increment Title" → "[INC-0031]"
+   * - "[FS-031] Feature Title" → "[FS-031]" (current format)
+   * - "[INC-0031] Increment Title" → "[INC-0031]" (deprecated, legacy support only)
    *
    * @param title - Full issue title
    * @returns Extracted pattern or null

package/plugins/specweave-github/lib/duplicate-detector.ts

@@ -63,7 +63,7 @@ export interface CorrectionResult {
 export interface CreateOptions {
   title: string;
   body: string;
-  titlePattern: string;  // e.g., "[FS-031]" or "[INC-0031]"
+  titlePattern: string;  // e.g., "[FS-031]" (current) or "[INC-0031]" (deprecated, legacy only)
   incrementId?: string;  // e.g., "0031-feature-name"
   labels?: string[];
   milestone?: string;
@@ -89,7 +89,7 @@ export class DuplicateDetector {
    * Searches GitHub for existing issues matching the title pattern.
    * This is the PRIMARY defense against duplicates.
    *
-   * @param titlePattern - Pattern to search (e.g., "[FS-031]" or "[INC-0031]")
+   * @param titlePattern - Pattern to search (e.g., "[FS-031]" current, "[INC-0031]" deprecated)
    * @param incrementId - Optional increment ID for more precise matching
    * @param repo - Optional repo (format: "owner/repo")
    * @returns Existing issue if found, null otherwise
@@ -498,8 +498,8 @@ The original issue (#${keepIssueNumber}) should be used for tracking instead.
    * Utility: Extract title pattern from full title
    *
    * Examples:
-   * - "[FS-031] Feature Title" → "[FS-031]"
-   * - "[INC-0031] Increment Title" → "[INC-0031]"
+   * - "[FS-031] Feature Title" → "[FS-031]" (current format)
+   * - "[INC-0031] Increment Title" → "[INC-0031]" (deprecated, legacy support only)
    *
    * @param title - Full issue title
    * @returns Extracted pattern or null

package/plugins/specweave-github/lib/epic-content-builder.js

@@ -66,6 +66,7 @@ ${tasksSection}
       const bodyContent = content.slice(match[0].length).trim();
       const incrementMatch = bodyContent.match(/\*\*Increment\*\*:\s*\[([^\]]+)\]/);
       const increment = incrementMatch ? incrementMatch[1] : null;
+      const acceptanceCriteria = this.extractAcceptanceCriteria(bodyContent);
       const tasks = await this.extractTasksForUserStory(
         frontmatter.id,
         increment,
@@ -76,6 +77,7 @@ ${tasksSection}
         title: frontmatter.title,
         status: this.normalizeStatus(frontmatter.status),
         increment,
+        acceptanceCriteria,
         tasks
       });
     }
@@ -131,6 +133,33 @@ ${tasksSection}
     }
     return tasks;
   }
+  /**
+   * Extract acceptance criteria from user story content
+   *
+   * Parses the "## Acceptance Criteria" section and extracts all checkable items.
+   * Format: - [x] **AC-US2-01**: Description...
+   */
+  extractAcceptanceCriteria(content) {
+    const acceptanceCriteria = [];
+    const acSectionMatch = content.match(/##\s+Acceptance Criteria\s*\n([\s\S]*?)(?=\n##|\n---|\n$)/i);
+    if (!acSectionMatch) {
+      return acceptanceCriteria;
+    }
+    const acSection = acSectionMatch[1];
+    const acPattern = /^-\s+\[([x\s])\]\s+\*\*([^*]+)\*\*:\s*(.+)$/gm;
+    let match;
+    while ((match = acPattern.exec(acSection)) !== null) {
+      const completed = match[1].trim().toLowerCase() === "x";
+      const acId = match[2].trim();
+      const description = match[3].trim();
+      acceptanceCriteria.push({
+        id: acId,
+        description,
+        completed
+      });
+    }
+    return acceptanceCriteria;
+  }
   /**
    * Build overview section
    */
@@ -159,6 +188,15 @@ Progress: ${completed}/${total} user stories complete (${percentage}%)
       const incrementLink = us.increment ? `[${us.increment}](../../increments/${us.increment}/)` : "TBD";
       section += `- ${checkbox} **${us.id}: ${us.title}** (${statusEmoji} ${us.status} | Increment: ${incrementLink})
 `;
+      if (us.acceptanceCriteria.length > 0) {
+        section += "\n  **Acceptance Criteria**:\n";
+        for (const ac of us.acceptanceCriteria) {
+          const acCheckbox = ac.completed ? "[x]" : "[ ]";
+          section += `  - ${acCheckbox} **${ac.id}**: ${ac.description}
+`;
+        }
+        section += "\n";
+      }
     }
     return section;
   }

package/plugins/specweave-github/lib/epic-content-builder.ts

@@ -25,9 +25,16 @@ interface UserStory {
   title: string;
   status: 'complete' | 'active' | 'planning' | 'not-started';
   increment: string | null; // e.g., "0031-external-tool-status-sync"
+  acceptanceCriteria: AcceptanceCriteria[];
   tasks: Task[];
 }
 
+interface AcceptanceCriteria {
+  id: string; // e.g., "AC-US2-01"
+  description: string;
+  completed: boolean; // true = [x], false = [ ]
+}
+
 interface Task {
   id: string;
   title: string;
@@ -126,6 +133,9 @@ export class EpicContentBuilder {
       const incrementMatch = bodyContent.match(/\*\*Increment\*\*:\s*\[([^\]]+)\]/);
       const increment = incrementMatch ? incrementMatch[1] : null;
 
+      // Extract acceptance criteria from AC section
+      const acceptanceCriteria = this.extractAcceptanceCriteria(bodyContent);
+
       // Extract tasks from Implementation section
       const tasks = await this.extractTasksForUserStory(
         frontmatter.id,
@@ -138,6 +148,7 @@ export class EpicContentBuilder {
         title: frontmatter.title,
         status: this.normalizeStatus(frontmatter.status),
         increment,
+        acceptanceCriteria,
         tasks,
       });
     }
@@ -216,6 +227,44 @@ export class EpicContentBuilder {
     return tasks;
   }
 
+  /**
+   * Extract acceptance criteria from user story content
+   *
+   * Parses the "## Acceptance Criteria" section and extracts all checkable items.
+   * Format: - [x] **AC-US2-01**: Description...
+   */
+  private extractAcceptanceCriteria(content: string): AcceptanceCriteria[] {
+    const acceptanceCriteria: AcceptanceCriteria[] = [];
+
+    // Find Acceptance Criteria section
+    const acSectionMatch = content.match(/##\s+Acceptance Criteria\s*\n([\s\S]*?)(?=\n##|\n---|\n$)/i);
+
+    if (!acSectionMatch) {
+      return acceptanceCriteria; // No AC section found
+    }
+
+    const acSection = acSectionMatch[1];
+
+    // Parse each AC line: - [x] **AC-US2-01**: Description (P1, testable)
+    // Pattern matches both checked [x] and unchecked [ ] boxes
+    const acPattern = /^-\s+\[([x\s])\]\s+\*\*([^*]+)\*\*:\s*(.+)$/gm;
+
+    let match;
+    while ((match = acPattern.exec(acSection)) !== null) {
+      const completed = match[1].trim().toLowerCase() === 'x';
+      const acId = match[2].trim(); // e.g., "AC-US2-01"
+      const description = match[3].trim(); // e.g., "Spec frontmatter includes linked_increments mapping (P1, testable)"
+
+      acceptanceCriteria.push({
+        id: acId,
+        description,
+        completed,
+      });
+    }
+
+    return acceptanceCriteria;
+  }
+
   /**
    * Build overview section
    */
@@ -241,6 +290,16 @@ export class EpicContentBuilder {
         : 'TBD';
 
       section += `- ${checkbox} **${us.id}: ${us.title}** (${statusEmoji} ${us.status} | Increment: ${incrementLink})\n`;
+
+      // Add Acceptance Criteria checkboxes under each user story
+      if (us.acceptanceCriteria.length > 0) {
+        section += '\n  **Acceptance Criteria**:\n';
+        for (const ac of us.acceptanceCriteria) {
+          const acCheckbox = ac.completed ? '[x]' : '[ ]';
+          section += `  - ${acCheckbox} **${ac.id}**: ${ac.description}\n`;
+        }
+        section += '\n';
+      }
     }
 
     return section;

package/plugins/specweave-github/lib/github-client-v2.js

@@ -24,6 +24,18 @@ class GitHubClientV2 {
     };
     return new GitHubClientV2(profile);
   }
+  /**
+   * Get repository owner
+   */
+  getOwner() {
+    return this.owner;
+  }
+  /**
+   * Get repository name
+   */
+  getRepo() {
+    return this.repo;
+  }
   // ==========================================================================
   // Authentication & Setup
   // ==========================================================================
@@ -189,6 +201,43 @@ ${body}`;
       labels: issue.labels?.map((l) => l.name) || []
     };
   }
+  /**
+   * Search for issue by exact title match
+   *
+   * IDEMPOTENCY: Use this before creating issues to prevent duplicates
+   */
+  async searchIssueByTitle(title) {
+    const escapedTitle = title.replace(/"/g, '\\"');
+    const result = await execFileNoThrow("gh", [
+      "issue",
+      "list",
+      "--repo",
+      this.fullRepo,
+      "--search",
+      `"${escapedTitle}" in:title`,
+      "--json",
+      "number,title,state,url,labels",
+      "--limit",
+      "1"
+    ]);
+    if (result.exitCode !== 0) {
+      return null;
+    }
+    const issues = JSON.parse(result.stdout || "[]");
+    if (!issues || issues.length === 0) {
+      return null;
+    }
+    const issue = issues[0];
+    return {
+      number: issue.number,
+      title: issue.title,
+      body: "",
+      // Body not included in list view
+      state: issue.state,
+      html_url: issue.url,
+      labels: issue.labels?.map((l) => l.name) || []
+    };
+  }
   /**
    * Update issue body
    */

package/plugins/specweave-github/lib/github-client-v2.ts

@@ -44,6 +44,20 @@ export class GitHubClientV2 {
     return new GitHubClientV2(profile);
   }
 
+  /**
+   * Get repository owner
+   */
+  getOwner(): string {
+    return this.owner;
+  }
+
+  /**
+   * Get repository name
+   */
+  getRepo(): string {
+    return this.repo;
+  }
+
   // ==========================================================================
   // Authentication & Setup
   // ==========================================================================
@@ -272,6 +286,51 @@ export class GitHubClientV2 {
     };
   }
 
+  /**
+   * Search for issue by exact title match
+   *
+   * IDEMPOTENCY: Use this before creating issues to prevent duplicates
+   */
+  async searchIssueByTitle(title: string): Promise<GitHubIssue | null> {
+    // Escape double quotes in title for gh search
+    const escapedTitle = title.replace(/"/g, '\\"');
+
+    const result = await execFileNoThrow('gh', [
+      'issue',
+      'list',
+      '--repo',
+      this.fullRepo,
+      '--search',
+      `"${escapedTitle}" in:title`,
+      '--json',
+      'number,title,state,url,labels',
+      '--limit',
+      '1',
+    ]);
+
+    if (result.exitCode !== 0) {
+      // Search failed, return null (treat as not found)
+      return null;
+    }
+
+    const issues = JSON.parse(result.stdout || '[]');
+
+    if (!issues || issues.length === 0) {
+      return null;
+    }
+
+    // Return first exact match
+    const issue = issues[0];
+    return {
+      number: issue.number,
+      title: issue.title,
+      body: '', // Body not included in list view
+      state: issue.state,
+      html_url: issue.url,
+      labels: issue.labels?.map((l: any) => l.name) || [],
+    };
+  }
+
   /**
    * Update issue body
    */

package/plugins/specweave-github/lib/github-epic-sync.ts

@@ -318,7 +318,7 @@ export class GitHubEpicSync {
   ): Promise<number | null> {
     try {
       // Search GitHub for issues with Epic ID in title
-      // Pattern: "[FS-031] Title" or "[INC-0031] Title"
+      // Pattern: "[FS-031] Title" (new) or "[INC-0031] Title" (deprecated, legacy support only)
       const titlePattern = `[${epicId}]`;
 
       const result = await execFileNoThrow('gh', [