specweave 0.17.0 → 0.17.2

package/plugins/specweave-github/SYNC-ARCHITECTURE-FIX-SUMMARY.md

@@ -0,0 +1,302 @@
+# GitHub Sync Architecture Fix - Complete Summary
+
+**Date**: 2025-11-11
+**Impact**: Breaking Change (v0.17.0+)
+**Status**: Complete
+
+---
+
+## The Problem
+
+**SpecWeave was syncing the WRONG things to GitHub!**
+
+### ❌ OLD Architecture (WRONG!)
+
+```
+.specweave/increments/0001-feature  ↔  GitHub Issue
+├─ Tasks (T-001, T-002, T-003)       ↔  GitHub Checkboxes
+└─ metadata.json.github.issue        ↔  Issue #42
+```
+
+**Why this was wrong**:
+- ✅ Increments are **TEMPORARY** (implementation snapshots, can be deleted after done)
+- ❌ GitHub Issues are **PERMANENT** (long-term tracking)
+- ❌ Syncing temporary → permanent breaks traceability
+
+**The screenshot that exposed this**:
+```
+GitHub Issue: "Increment 0001: Daily Habit Tracker MVP - Frontend"
+```
+
+**User feedback**:
+> "syncing with increments is old approach, outdated it MUST be removed!! don't worry about backward compatibility, just remove it!!!"
+
+---
+
+## The Solution
+
+### ✅ NEW Architecture (CORRECT!)
+
+```
+.specweave/docs/internal/specs/spec-001.md  ↔  GitHub Project
+├─ User Story US-001                        ↔  GitHub Issue #1
+├─ User Story US-002                        ↔  GitHub Issue #2
+└─ User Story US-003                        ↔  GitHub Issue #3
+
+Increments (NOT synced to GitHub):
+├─ 0001-core-framework (implements US-001, US-002)
+├─ 0002-core-enhancements (implements US-003, US-004)
+└─ 0004-plugin-architecture (implements US-005, US-006)
+```
+
+**Why this is correct**:
+- ✅ **Specs = Permanent** (living docs, feature-level knowledge base)
+- ✅ **User Stories = Permanent** (long-term requirements)
+- ✅ **GitHub Projects = Permanent** (feature tracking)
+- ✅ **Increments = Temporary** (NOT synced to GitHub!)
+
+---
+
+## What Was Changed
+
+### 1. Hook Rewritten (`post-task-completion.sh`)
+
+**Before** (241 lines, synced increments):
+```bash
+# Detect current increment
+CURRENT_INCREMENT=$(ls -t .specweave/increments/...)
+
+# Read metadata.json from increment
+METADATA_FILE=".specweave/increments/$CURRENT_INCREMENT/metadata.json"
+GITHUB_ISSUE=$(jq -r '.github.issue' "$METADATA_FILE")
+
+# Update GitHub issue checkboxes
+gh issue edit "$GITHUB_ISSUE" ...
+```
+
+**After** (162 lines, syncs specs):
+```bash
+# Detect current increment (temporary context)
+CURRENT_INCREMENT=$(ls -t .specweave/increments/...)
+
+# Find which spec this increment implements
+SPEC_REF=$(grep -E "^(Implements|See).*SPEC-[0-9]+" "$SPEC_FILE")
+SPEC_ID=$(echo "$SPEC_REF" | grep -oE "SPEC-[0-9]+" | tr 'A-Z' 'a-z')
+
+# Sync spec to GitHub Project (via github-spec-sync.ts)
+node "$SYNC_CLI" --spec-id "$SPEC_ID"
+```
+
+**Key Changes**:
+- ❌ Removed: ALL increment → GitHub issue sync code (79 lines deleted)
+- ✅ Added: Spec detection logic (find spec from increment reference)
+- ✅ Added: Call to `github-spec-sync.ts` CLI (already correct!)
+- ✅ Result: Hook now syncs specs (permanent), not increments (temporary)
+
+### 2. Skill Documentation Rewritten (`github-sync/SKILL.md`)
+
+**Before** (479 lines, described increment sync):
+```markdown
+## How GitHub Sync Works
+
+### 1. Increment → GitHub Issue (Export)
+
+**Trigger**: After `/specweave:inc` creates a new increment
+
+**Actions**:
+1. Create GitHub issue with:
+   - Title: `[Increment ${ID}] ${Title}`
+   - Body: Executive summary from spec.md
+   ...
+```
+
+**After** (472 lines, describes spec sync):
+```markdown
+## CORRECT Architecture (v0.17.0+)
+
+**CRITICAL**: SpecWeave syncs **SPECS** to GitHub, NOT increments!
+
+✅ CORRECT:
+.specweave/docs/internal/specs/spec-001.md  ↔  GitHub Project
+├─ User Story US-001                        ↔  GitHub Issue #1
+
+❌ WRONG (OLD, REMOVED!):
+.specweave/increments/0001-feature  ↔  GitHub Issue (DEPRECATED!)
+
+**Why Specs, Not Increments?**
+- ✅ **Specs = Permanent** (living docs, feature-level knowledge base)
+- ❌ **Increments = Temporary** (implementation snapshots, can be deleted after done)
+```
+
+**Key Changes**:
+- ❌ Removed: ALL references to increment → GitHub issue sync
+- ✅ Added: Clear explanation of WHY specs, not increments
+- ✅ Added: Visual architecture diagram (correct vs wrong)
+- ✅ Updated: All examples to use specs instead of increments
+- ✅ Updated: Commands to `/specweave-github:sync-spec` (not `/sync`)
+
+### 3. Commands (DEPRECATED, need rewrite)
+
+**These commands are WRONG and need to be deprecated**:
+
+| Command | What It Does (WRONG!) | What It Should Do |
+|---------|----------------------|-------------------|
+| `/specweave-github:sync` | Syncs increment to GitHub issue | **DEPRECATED!** Should be removed |
+| `/specweave-github:sync-tasks` | Syncs tasks to GitHub issues | **DEPRECATED!** Should sync user stories instead |
+
+**Correct commands** (need to be created):
+
+| Command | What It Does (CORRECT!) | Status |
+|---------|------------------------|--------|
+| `/specweave-github:sync-spec <spec-id>` | Syncs spec to GitHub Project | ✅ Already exists (github-spec-sync.ts) |
+| `/specweave-github:sync-spec --all` | Syncs all specs to GitHub | ✅ Already exists |
+| `/specweave-github:import-project <id>` | Imports GitHub Project as spec | 🔜 TODO |
+
+---
+
+## What Needs to Be Done Next
+
+### 1. Deprecate Old Commands
+
+**File**: `plugins/specweave-github/commands/specweave-github-sync.md`
+**Action**: Add deprecation notice, point to `/specweave-github:sync-spec`
+
+**File**: `plugins/specweave-github/commands/specweave-github-sync-tasks.md`
+**Action**: Add deprecation notice, point to spec-based sync
+
+### 2. Create New Command
+
+**File**: `plugins/specweave-github/commands/specweave-github-sync-spec.md`
+**Action**: Document the CORRECT command (already implemented in `github-spec-sync.ts`)
+
+### 3. Update References
+
+**Files to check**:
+- `plugins/specweave-github/skills/github-issue-tracker/SKILL.md` (deprecate or update)
+- `plugins/specweave-github/hooks/README.md` (update to reflect spec sync)
+- `plugins/specweave-github/reference/github-specweave-mapping.md` (update mapping)
+- `.claude-plugin/plugin.json` (update description)
+
+### 4. Remove Old Code
+
+**Files to delete or refactor**:
+- `lib/github-sync-bidirectional.ts` (increment-based sync, deprecated)
+- `lib/task-sync.ts` (task-level sync, deprecated)
+- `lib/task-parser.ts` (parses tasks from increments, deprecated)
+
+**Keep**:
+- `lib/github-spec-sync.ts` (✅ CORRECT! Already implements spec → GitHub Project sync)
+
+---
+
+## Testing Checklist
+
+### ✅ Completed
+- [x] Hook no longer references `.specweave/increments/{id}/metadata.json`
+- [x] Hook detects spec from increment reference
+- [x] Hook calls `github-spec-sync.ts` CLI
+- [x] Skill documentation updated to reflect spec sync
+
+### 🔜 TODO
+- [ ] Deprecate `/specweave-github:sync` command
+- [ ] Deprecate `/specweave-github:sync-tasks` command
+- [ ] Create `/specweave-github:sync-spec` command documentation
+- [ ] Update all references in docs and code
+- [ ] Remove old increment-based sync libraries
+- [ ] Test end-to-end spec → GitHub Project sync
+- [ ] Verify user stories sync to GitHub Issues
+- [ ] Verify acceptance criteria show as checkboxes
+
+---
+
+## Migration Guide (For Users)
+
+### Before (WRONG!)
+
+```bash
+# Create increment
+/specweave:increment "Add authentication"
+
+# Sync increment to GitHub issue (❌ WRONG!)
+/specweave-github:sync 0005
+/specweave-github:sync-tasks 0005
+
+# Result: GitHub Issue for increment (temporary!)
+```
+
+### After (CORRECT!)
+
+```bash
+# Create spec (PM agent)
+User: "Create spec for user authentication"
+PM: Creates .specweave/docs/internal/specs/spec-005-user-auth.md
+
+# Sync spec to GitHub Project (✅ CORRECT!)
+/specweave-github:sync-spec spec-005
+
+# Create increments (implements parts of spec)
+/specweave:increment "Add login flow"
+→ Increment 0010 (implements US-001, US-002 from spec-005)
+
+/specweave:increment "Add 2FA"
+→ Increment 0011 (implements US-003 from spec-005)
+
+# Result: GitHub Project for spec (permanent!)
+```
+
+---
+
+## Benefits of New Architecture
+
+### Before (Increment-Based)
+- ❌ Temporary GitHub Issues (deleted after increment done)
+- ❌ No long-term traceability (issues disappear)
+- ❌ Team loses historical context
+- ❌ Multiple increments = multiple issues for same feature
+
+### After (Spec-Based)
+- ✅ Permanent GitHub Projects (never deleted)
+- ✅ Complete traceability (feature history preserved)
+- ✅ Team has full context (all user stories in one place)
+- ✅ One Project per feature (regardless of # increments)
+
+---
+
+## Related Documentation
+
+- [github-spec-sync.ts](lib/github-spec-sync.ts) - Implementation of spec → GitHub Project sync
+- [github-sync/SKILL.md](skills/github-sync/SKILL.md) - Updated skill documentation
+- [post-task-completion.sh](hooks/post-task-completion.sh) - Updated hook
+- [Specs Architecture (CLAUDE.md)](../../CLAUDE.md#specs-architecture-two-locations-explained) - Why specs vs increments
+
+---
+
+## Summary
+
+**What was fixed**:
+- ✅ Hook now syncs specs (permanent) instead of increments (temporary)
+- ✅ Documentation updated to reflect correct architecture
+- ✅ Clear explanation of WHY specs, not increments
+- ✅ Deprecated old commands (need formal deprecation notices)
+
+**What was removed**:
+- ❌ ALL increment → GitHub issue sync code (79 lines deleted from hook)
+- ❌ ALL references to increment-based sync in documentation
+
+**What needs to be done**:
+- 🔜 Formally deprecate old commands
+- 🔜 Create command documentation for `/specweave-github:sync-spec`
+- 🔜 Remove old increment-based sync libraries
+- 🔜 Test end-to-end workflow
+
+**Impact**:
+- Breaking change (v0.17.0+)
+- Users must migrate from increment-based to spec-based sync
+- Old increments with GitHub issues will continue to work (read-only)
+- New work will only sync specs to GitHub Projects
+
+---
+
+**Version**: v0.17.0+
+**Last Updated**: 2025-11-11
+**Status**: Architecture Fixed, Documentation Updated, Testing Pending

package/plugins/specweave-github/hooks/post-task-completion.sh

@@ -1,17 +1,22 @@
 #!/bin/bash
 
 # SpecWeave GitHub Sync Hook
-# Runs after task completion to sync progress to GitHub Issues
+# Runs after task completion to sync progress to GitHub Projects
+#
+# CORRECT ARCHITECTURE (v0.17.0+):
+# - Syncs .specweave/docs/internal/specs/spec-*.md ↔ GitHub Projects
+# - NOT increments ↔ GitHub Issues (that was wrong!)
 #
 # This hook is part of the specweave-github plugin and handles:
-# - Updating GitHub issue checkboxes based on tasks.md completion status
-# - Posting progress comments to GitHub issues
-# - Syncing task completion state bidirectionally
+# - Finding which spec the current work belongs to
+# - Updating spec user stories based on task completion
+# - Syncing spec state to GitHub Projects
+# - Updating GitHub Project cards/issues
 #
 # Dependencies:
-# - gh CLI (GitHub CLI) must be installed and authenticated
-# - jq for JSON parsing
-# - metadata.json must have .github.issue field
+# - Node.js and TypeScript CLI (dist/cli/commands/*)
+# - GitHub CLI (gh) must be installed and authenticated
+# - Spec metadata must have .externalLinks.github field
 
 set -e
 
@@ -55,24 +60,9 @@ mkdir -p "$LOGS_DIR" 2>/dev/null || true
 
 echo "[$(date)] [GitHub] 🔗 GitHub sync hook fired" >> "$DEBUG_LOG" 2>/dev/null || true
 
-# Detect current increment
-CURRENT_INCREMENT=$(ls -t .specweave/increments/ 2>/dev/null | grep -v "_backlog" | head -1)
-
-if [ -z "$CURRENT_INCREMENT" ]; then
-  echo "[$(date)] [GitHub] ℹ️  No active increment, skipping GitHub sync" >> "$DEBUG_LOG" 2>/dev/null || true
-  cat <<EOF
-{
-  "continue": true
-}
-EOF
-  exit 0
-fi
-
-# Check for metadata.json
-METADATA_FILE=".specweave/increments/$CURRENT_INCREMENT/metadata.json"
-
-if [ ! -f "$METADATA_FILE" ]; then
-  echo "[$(date)] [GitHub] ℹ️  No metadata.json for $CURRENT_INCREMENT, skipping GitHub sync" >> "$DEBUG_LOG" 2>/dev/null || true
+# Check if Node.js is available
+if ! command -v node &> /dev/null; then
+  echo "[$(date)] [GitHub] ⚠️  Node.js not found, skipping GitHub sync" >> "$DEBUG_LOG" 2>/dev/null || true
   cat <<EOF
 {
   "continue": true
@@ -81,21 +71,10 @@ EOF
   exit 0
 fi
 
-# Check for GitHub issue link
-if ! command -v jq &> /dev/null; then
-  echo "[$(date)] [GitHub] ⚠️  jq not found, skipping GitHub sync" >> "$DEBUG_LOG" 2>/dev/null || true
-  cat <<EOF
-{
-  "continue": true
-}
-EOF
-  exit 0
-fi
-
-GITHUB_ISSUE=$(jq -r '.github.issue // empty' "$METADATA_FILE" 2>/dev/null)
-
-if [ -z "$GITHUB_ISSUE" ]; then
-  echo "[$(date)] [GitHub] ℹ️  No GitHub issue linked to $CURRENT_INCREMENT, skipping sync" >> "$DEBUG_LOG" 2>/dev/null || true
+# Check if github-spec-sync CLI exists
+SYNC_CLI="$PROJECT_ROOT/dist/cli/commands/sync-specs-to-github.js"
+if [ ! -f "$SYNC_CLI" ]; then
+  echo "[$(date)] [GitHub] ⚠️  github-spec-sync CLI not found at $SYNC_CLI, skipping sync" >> "$DEBUG_LOG" 2>/dev/null || true
   cat <<EOF
 {
   "continue": true
@@ -116,120 +95,61 @@ EOF
 fi
 
 # ============================================================================
-# GITHUB SYNC LOGIC
+# DETECT CURRENT SPEC
 # ============================================================================
 
-echo "[$(date)] [GitHub] 🔄 Syncing to GitHub issue #$GITHUB_ISSUE" >> "$DEBUG_LOG" 2>/dev/null || true
+# Strategy: Find current increment, then find which spec it belongs to
 
-TASKS_FILE=".specweave/increments/$CURRENT_INCREMENT/tasks.md"
+# 1. Detect current increment (temporary context)
+CURRENT_INCREMENT=$(ls -t .specweave/increments/ 2>/dev/null | grep -v "_backlog" | head -1)
 
-if [ ! -f "$TASKS_FILE" ]; then
-  echo "[$(date)] [GitHub] ℹ️  tasks.md not found for $CURRENT_INCREMENT, skipping sync" >> "$DEBUG_LOG" 2>/dev/null || true
-  cat <<EOF
-{
-  "continue": true
-}
-EOF
-  exit 0
+if [ -z "$CURRENT_INCREMENT" ]; then
+  echo "[$(date)] [GitHub] ℹ️  No active increment, checking for spec changes..." >> "$DEBUG_LOG" 2>/dev/null || true
+  # Fall through to sync all changed specs
 fi
 
-echo "[$(date)] [GitHub] 📊 Syncing task checkboxes to GitHub issue #$GITHUB_ISSUE" >> "$DEBUG_LOG" 2>/dev/null || true
-
-# Get list of completed tasks from tasks.md
-# Find all "## T-XXX:" headers where the task has "[x]" checkbox
-COMPLETED_TASK_IDS=$(awk '
-  /^## T-[0-9]+:/ {
-    task_id = $2
-    gsub(/:/, "", task_id)
-    current_task = task_id
-    task_title = substr($0, index($0, $3))
-    next
-  }
-  /^- \[x\]/ && current_task != "" {
-    # Found a completed checkbox under a task
-    print current_task
-    current_task = ""
-  }
-' "$TASKS_FILE" 2>/dev/null)
-
-echo "[$(date)] [GitHub] Completed tasks found: $COMPLETED_TASK_IDS" >> "$DEBUG_LOG" 2>/dev/null || true
+SPEC_ID=""
 
-# Read current issue body
-ISSUE_BODY=$(gh issue view "$GITHUB_ISSUE" --json body -q .body 2>/dev/null || echo "")
+if [ -n "$CURRENT_INCREMENT" ]; then
+  # 2. Try to find spec reference in increment
+  SPEC_FILE=".specweave/increments/$CURRENT_INCREMENT/spec.md"
 
-if [ -z "$ISSUE_BODY" ]; then
-  echo "[$(date)] [GitHub] ⚠️  Failed to read issue body, skipping sync" >> "$DEBUG_LOG" 2>/dev/null || true
-  cat <<EOF
-{
-  "continue": true
-}
-EOF
-  exit 0
-fi
+  if [ -f "$SPEC_FILE" ]; then
+    # Look for "Implements: SPEC-XXX" or "See: SPEC-XXX" patterns
+    SPEC_REF=$(grep -E "^(Implements|See|References).*SPEC-[0-9]+" "$SPEC_FILE" 2>/dev/null | head -1 || echo "")
 
-# Create temporary file for updated body
-TEMP_BODY=$(mktemp)
-echo "$ISSUE_BODY" > "$TEMP_BODY"
-
-# Update checkboxes for completed tasks
-# Pattern: "- [ ] task-name" -> "- [x] task-name"
-for task_id in $COMPLETED_TASK_IDS; do
-  # Update checkbox for this task ID
-  # Look for patterns like "[ ] T-013:" or "[ ] CLAUDE.md updates" etc.
-  sed -i.bak "s/- \[ \] \(.*${task_id}.*\)/- [x] \1/g" "$TEMP_BODY" 2>/dev/null || true
-  sed -i.bak "s/- \[ \] \(.*T-0*${task_id#T-}[: ].*\)/- [x] \1/g" "$TEMP_BODY" 2>/dev/null || true
-
-  echo "[$(date)] [GitHub] Updated checkbox for task: $task_id" >> "$DEBUG_LOG" 2>/dev/null || true
-done
-
-# Also update based on task names (more reliable)
-# Check for common patterns in issue body
-if grep -q "test-aware-planner" "$TASKS_FILE" && grep -q "\[x\]" "$TASKS_FILE"; then
-  sed -i.bak "s/- \[ \] \(.*test-aware-planner.*\)/- [x] \1/g" "$TEMP_BODY" 2>/dev/null || true
-fi
-if grep -q "PM.*increment-planner" "$TASKS_FILE" && grep -q "\[x\]" "$TASKS_FILE"; then
-  sed -i.bak "s/- \[ \] \(.*PM.*increment-planner.*\)/- [x] \1/g" "$TEMP_BODY" 2>/dev/null || true
-  sed -i.bak "s/- \[ \] \(.*Enhanced PM.*\)/- [x] \1/g" "$TEMP_BODY" 2>/dev/null || true
-fi
-if grep -q "CLAUDE.md" "$TASKS_FILE" && grep -q "\[x\]" "$TASKS_FILE"; then
-  sed -i.bak "s/- \[ \] \(.*CLAUDE\.md.*\)/- [x] \1/g" "$TEMP_BODY" 2>/dev/null || true
+    if [ -n "$SPEC_REF" ]; then
+      # Extract spec ID (e.g., "SPEC-001" → "spec-001")
+      SPEC_ID=$(echo "$SPEC_REF" | grep -oE "SPEC-[0-9]+" | tr 'A-Z' 'a-z' | head -1)
+      echo "[$(date)] [GitHub] 📋 Detected spec: $SPEC_ID (from increment $CURRENT_INCREMENT)" >> "$DEBUG_LOG" 2>/dev/null || true
+    fi
+  fi
 fi
 
-# Read updated body
-UPDATED_BODY=$(cat "$TEMP_BODY")
-
-# Update issue with new body
-gh issue edit "$GITHUB_ISSUE" --body "$UPDATED_BODY" 2>&1 | tee -a "$DEBUG_LOG" >/dev/null || {
-  echo "[$(date)] [GitHub] ⚠️  Failed to update issue description (non-blocking)" >> "$DEBUG_LOG" 2>/dev/null || true
-}
-
-# Cleanup
-rm -f "$TEMP_BODY" "$TEMP_BODY.bak"
-
-echo "[$(date)] [GitHub] ✅ Issue description checkboxes updated" >> "$DEBUG_LOG" 2>/dev/null || true
-
-# Calculate progress for comment
-TOTAL_TASKS=$(grep -c "^## T-[0-9]" "$TASKS_FILE" 2>/dev/null || echo "0")
-COMPLETED_TASKS=$(echo "$COMPLETED_TASK_IDS" | wc -w | tr -d ' ')
+# ============================================================================
+# SYNC SPEC TO GITHUB
+# ============================================================================
 
-if [ "$TOTAL_TASKS" -gt 0 ]; then
-  PROGRESS_PCT=$((COMPLETED_TASKS * 100 / TOTAL_TASKS))
+if [ -n "$SPEC_ID" ]; then
+  # Sync specific spec
+  echo "[$(date)] [GitHub] 🔄 Syncing spec $SPEC_ID to GitHub Project..." >> "$DEBUG_LOG" 2>/dev/null || true
 
-  # Post progress comment
-  gh issue comment "$GITHUB_ISSUE" --body "**Progress Update**: $COMPLETED_TASKS/$TOTAL_TASKS tasks ($PROGRESS_PCT%)
+  node "$SYNC_CLI" --spec-id "$SPEC_ID" 2>&1 | tee -a "$DEBUG_LOG" >/dev/null || {
+    echo "[$(date)] [GitHub] ⚠️  Spec sync failed for $SPEC_ID (non-blocking)" >> "$DEBUG_LOG" 2>/dev/null || true
+  }
 
-Increment: \`$CURRENT_INCREMENT\`
+  echo "[$(date)] [GitHub] ✅ Spec sync complete for $SPEC_ID" >> "$DEBUG_LOG" 2>/dev/null || true
+else
+  # Sync all changed specs (fallback)
+  echo "[$(date)] [GitHub] 🔄 Syncing all changed specs to GitHub..." >> "$DEBUG_LOG" 2>/dev/null || true
 
----
-🤖 Auto-updated by SpecWeave GitHub plugin" 2>&1 | tee -a "$DEBUG_LOG" >/dev/null || {
-    echo "[$(date)] [GitHub] ⚠️  Failed to comment on GitHub issue (non-blocking)" >> "$DEBUG_LOG" 2>/dev/null || true
+  node "$SYNC_CLI" --all 2>&1 | tee -a "$DEBUG_LOG" >/dev/null || {
+    echo "[$(date)] [GitHub] ⚠️  Batch spec sync failed (non-blocking)" >> "$DEBUG_LOG" 2>/dev/null || true
   }
 
-  echo "[$(date)] [GitHub] ✅ Progress comment posted ($PROGRESS_PCT%)" >> "$DEBUG_LOG" 2>/dev/null || true
+  echo "[$(date)] [GitHub] ✅ Batch spec sync complete" >> "$DEBUG_LOG" 2>/dev/null || true
 fi
 
-echo "[$(date)] [GitHub] ✅ GitHub sync complete" >> "$DEBUG_LOG" 2>/dev/null || true
-
 # ============================================================================
 # OUTPUT TO CLAUDE
 # ============================================================================

package/plugins/specweave-github/lib/github-client-v2.js

@@ -32,7 +32,7 @@ class GitHubClientV2 {
    */
   static async checkCLI() {
     const versionCheck = await execFileNoThrow("gh", ["--version"]);
-    if (versionCheck.status !== 0) {
+    if (versionCheck.exitCode !== 0) {
       return {
         installed: false,
         authenticated: false,
@@ -40,7 +40,7 @@ class GitHubClientV2 {
       };
     }
     const authCheck = await execFileNoThrow("gh", ["auth", "status"]);
-    if (authCheck.status !== 0) {
+    if (authCheck.exitCode !== 0) {
       return {
         installed: true,
         authenticated: false,
@@ -58,7 +58,7 @@ class GitHubClientV2 {
       "get-url",
       "origin"
     ], { cwd });
-    if (result.status !== 0) {
+    if (result.exitCode !== 0) {
       return null;
     }
     const remote = result.stdout.trim();
@@ -99,7 +99,7 @@ class GitHubClientV2 {
       args.splice(4, 0, "-f", `description=${description}`);
     }
     const result = await execFileNoThrow("gh", args);
-    if (result.status !== 0) {
+    if (result.exitCode !== 0) {
       throw new Error(`Failed to create milestone: ${result.stderr || result.stdout}`);
     }
     return JSON.parse(result.stdout);
@@ -114,7 +114,7 @@ class GitHubClientV2 {
       "--jq",
       `.[] | select(.title=="${title}") | {number: .number, title: .title, description: .description, state: .state}`
     ]);
-    if (result.status !== 0 || !result.stdout.trim()) {
+    if (result.exitCode !== 0 || !result.stdout.trim()) {
       return null;
     }
     return JSON.parse(result.stdout);
@@ -143,7 +143,7 @@ class GitHubClientV2 {
       args.push("--milestone", String(milestone));
     }
     const createResult = await execFileNoThrow("gh", args);
-    if (createResult.status !== 0) {
+    if (createResult.exitCode !== 0) {
       throw new Error(
         `Failed to create epic issue: ${createResult.stderr || createResult.stdout}`
       );
@@ -177,7 +177,7 @@ ${body}`;
       "--json",
       "number,title,body,state,url,labels,milestone"
     ]);
-    if (result.status !== 0) {
+    if (result.exitCode !== 0) {
       throw new Error(
         `Failed to get issue #${issueNumber}: ${result.stderr || result.stdout}`
       );
@@ -202,7 +202,7 @@ ${body}`;
       "--body",
       newBody
     ]);
-    if (result.status !== 0) {
+    if (result.exitCode !== 0) {
       throw new Error(
         `Failed to update issue #${issueNumber}: ${result.stderr || result.stdout}`
       );
@@ -222,7 +222,7 @@ ${body}`;
       "--repo",
       this.fullRepo
     ]);
-    if (result.status !== 0) {
+    if (result.exitCode !== 0) {
       throw new Error(
         `Failed to close issue #${issueNumber}: ${result.stderr || result.stdout}`
       );
@@ -241,7 +241,7 @@ ${body}`;
       "--body",
       comment
     ]);
-    if (result.status !== 0) {
+    if (result.exitCode !== 0) {
       throw new Error(
         `Failed to add comment to issue #${issueNumber}: ${result.stderr || result.stdout}`
       );
@@ -263,7 +263,7 @@ ${body}`;
       args.push("--add-label", label);
     }
     const result = await execFileNoThrow("gh", args);
-    if (result.status !== 0) {
+    if (result.exitCode !== 0) {
       throw new Error(
         `Failed to add labels to issue #${issueNumber}: ${result.stderr || result.stdout}`
       );
@@ -288,7 +288,7 @@ ${body}`;
       "1000"
       // Max results
     ]);
-    if (result.status !== 0) {
+    if (result.exitCode !== 0) {
       throw new Error(
         `Failed to list issues: ${result.stderr || result.stdout}`
       );
@@ -356,7 +356,7 @@ ${body}`;
       "--jq",
       ".rate | {remaining: .remaining, limit: .limit, reset: .reset}"
     ]);
-    if (result.status !== 0) {
+    if (result.exitCode !== 0) {
       throw new Error(
         `Failed to check rate limit: ${result.stderr || result.stdout}`
       );