specrails-desktop 2.64.1 → 2.65.0

package/server/dist/modules/browser/runtime/browser-capture-manager.js

@@ -10,7 +10,6 @@ const ids_1 = require("../../../ids");
 const attachment_manager_1 = require("../../../attachment-manager");
 const browser_capture_types_1 = require("./browser-capture-types");
 const browser_playwright_1 = require("./browser-playwright");
-const preview_origins_1 = require("../domain/preview-origins");
 const browser_viewport_1 = require("./browser-viewport");
 const WS_OPEN = 1;
 const DEFAULT_VIEWPORT = { width: 1280, height: 800 };
@@ -21,14 +20,6 @@ function isTargetClosedError(err) {
     return /target page, context or browser has been closed|target closed|has been closed/i.test(msg);
 }
 const MAX_SESSIONS_PER_PROJECT = 4;
-/** Companion app-preview sessions have their own budget so a phone can never
- *  take Desktop's sessions: one per device (a new one replaces it), two per
- *  project across devices. */
-const MAX_DEVICE_SESSIONS_PER_PROJECT = 2;
-/** The announced-origin set is consulted on every request of a preview page
- *  (a dev server loads hundreds of modules); re-derive it at most this often. */
-const PREVIEW_ORIGINS_TTL_MS = 1000;
-const DESKTOP_OWNER = { kind: 'desktop' };
 const DEFAULT_SESSION_IDLE_TTL_MS = 10 * 60_000;
 const DEFAULT_SESSION_SWEEP_INTERVAL_MS = 60_000;
 const DOM_HTML_BYTE_CAP = 100_000;
@@ -65,15 +56,13 @@ class BrowserCaptureManager {
     contextPool;
     now;
     sessionIdleTtlMs;
-    previewOrigins;
-    previewOriginsCache = null;
     idleSweepTimer = null;
     context = null;
     contextPromise = null;
     sessions = new Map();
     /** Count of in-flight `create()` calls that have reserved a slot but not yet
      *  committed their session — guards the cap against concurrent creates. */
-    _reserved = { desktop: 0, device: 0 };
+    _reserved = 0;
     disposed = false;
     constructor(opts) {
         this.projectId = opts.projectId;
@@ -83,7 +72,6 @@ class BrowserCaptureManager {
         this.attachments = opts.attachments ?? attachment_manager_1.attachmentManager;
         this.contextPool = opts.contextPool ?? null;
         this.now = opts.now ?? Date.now;
-        this.previewOrigins = opts.previewOrigins ?? (() => new Set());
         const requestedIdleTtlMs = opts.sessionIdleTtlMs;
         this.sessionIdleTtlMs = typeof requestedIdleTtlMs === 'number' && Number.isFinite(requestedIdleTtlMs) && requestedIdleTtlMs > 0
             ? requestedIdleTtlMs
@@ -156,7 +144,6 @@ class BrowserCaptureManager {
             viewportWidth: s.viewport.width,
             viewportHeight: s.viewport.height,
             createdAt: s.createdAt,
-            owner: s.owner,
         };
     }
     listSessions() {
@@ -180,46 +167,27 @@ class BrowserCaptureManager {
         s.activeOperations = Math.max(0, s.activeOperations - 1);
         s.lastActivityAt = this.now();
     }
-    liveCount(kind) {
-        return [...this.sessions.values()].filter((s) => !s.closed && s.owner.kind === kind).length;
-    }
     async create(opts) {
-        const owner = opts?.owner ?? DESKTOP_OWNER;
-        const kind = owner.kind;
-        const limit = kind === 'device' ? MAX_DEVICE_SESSIONS_PER_PROJECT : MAX_SESSIONS_PER_PROJECT;
-        if (owner.kind === 'device') {
-            // A phone may only type announced origins (never an arbitrary URL), and
-            // is validated BEFORE replacing its previous session so a bad request
-            // leaves the current preview alone.
-            const initialUrl = opts?.initialUrl?.trim() ?? '';
-            if (!initialUrl || !(0, preview_origins_1.isManualPreviewUrlAllowed)(initialUrl, this.currentPreviewOrigins(true))) {
-                throw new browser_capture_types_1.BrowserNavigationRejectedError();
-            }
-            for (const existing of [...this.sessions.values()]) {
-                if (!existing.closed && existing.owner.kind === 'device' && existing.owner.deviceId === owner.deviceId) {
-                    await this.kill(existing.id);
-                }
-            }
-        }
         // Reserve the slot SYNCHRONOUSLY before any await so N concurrent creates can't
         // all observe `< MAX` and race past the cap (BUG-BROWSER-02). `_reserved`
-        // counts in-flight (not-yet-inserted) sessions per budget; it's the only
-        // state that mutates synchronously here.
-        if (this.liveCount(kind) + this._reserved[kind] >= limit) {
-            throw new browser_capture_types_1.BrowserLimitExceededError(limit);
+        // counts in-flight (not-yet-inserted) sessions; it's the only state that
+        // mutates synchronously here.
+        const live = [...this.sessions.values()].filter((s) => !s.closed).length;
+        if (live + this._reserved >= MAX_SESSIONS_PER_PROJECT) {
+            throw new browser_capture_types_1.BrowserLimitExceededError(MAX_SESSIONS_PER_PROJECT);
         }
-        this._reserved[kind]++;
+        this._reserved++;
         let page;
         try {
             const ctx = await this.ensureContext();
             page = await ctx.newPage();
         }
         catch (err) {
-            this._reserved[kind]--;
+            this._reserved--;
             throw err;
         }
         if (this.disposed) {
-            this._reserved[kind]--;
+            this._reserved--;
             try {
                 await page.close();
             }
@@ -229,37 +197,20 @@ class BrowserCaptureManager {
         // Re-check AFTER the awaits: another create that started before us may have
         // committed its session in the meantime. If the cap is now exceeded, tear the
         // extra page down and reject rather than silently exceeding the limit.
-        if (this.liveCount(kind) >= limit) {
-            this._reserved[kind]--;
+        const liveNow = [...this.sessions.values()].filter((s) => !s.closed).length;
+        if (liveNow >= MAX_SESSIONS_PER_PROJECT) {
+            this._reserved--;
             try {
                 await page.close();
             }
             catch { /* ignore */ }
-            throw new browser_capture_types_1.BrowserLimitExceededError(limit);
-        }
-        if (kind === 'device') {
-            // Fail closed: a preview page without request interception could reach
-            // any loopback port of this machine.
-            try {
-                if (!page.setRequestGuard)
-                    throw new Error('request guard unsupported');
-                await page.setRequestGuard((url) => this.allowDeviceRequest(url));
-            }
-            catch (err) {
-                this._reserved[kind]--;
-                try {
-                    await page.close();
-                }
-                catch { /* ignore */ }
-                throw new browser_capture_types_1.BrowserLaunchError('failed to secure preview page', err);
-            }
+            throw new browser_capture_types_1.BrowserLimitExceededError(MAX_SESSIONS_PER_PROJECT);
         }
         const id = (0, ids_1.newId)();
         const activityAt = this.now();
         const session = {
             id,
             projectId: this.projectId,
-            owner,
             page,
             popups: [],
             popupView: false,
@@ -278,7 +229,7 @@ class BrowserCaptureManager {
         };
         this.sessions.set(id, session);
         // The reservation is now realised as a committed session — release it.
-        this._reserved[kind]--;
+        this._reserved--;
         // Adopt popups the page opens (OAuth login windows etc.) as secondary pages
         // of this session, and keep the client's URL bar live on in-page navigation
         // (link clicks / redirects the REST navigate path never sees).
@@ -288,7 +239,7 @@ class BrowserCaptureManager {
                 return;
             session.url = url;
             if (url && url !== 'about:blank')
-                this.rememberUrl(session, url);
+                this.setLastUrl(url);
             this.broadcastControl(session, { type: 'nav', url, title: session.title });
         });
         // Start capturing the page's network requests before the first navigation so
@@ -305,13 +256,7 @@ class BrowserCaptureManager {
         // away, so the user watches the page paint progressively instead of staring
         // at "opening…". The URL is set optimistically to the target; the resolved
         // URL/title land via the `nav` control broadcast every client already handles.
-        if (opts?.viewport) {
-            try {
-                await this.handleInput(id, { type: 'resize', ...opts.viewport });
-            }
-            catch { /* the default viewport still renders */ }
-        }
-        const target = opts?.initialUrl?.trim() || (kind === 'desktop' ? this.getLastUrl() : null) || 'about:blank';
+        const target = opts?.initialUrl?.trim() || this.getLastUrl() || 'about:blank';
         session.url = target;
         void this.runInitialNavigation(session, target);
         return this.toMeta(session);
@@ -331,34 +276,9 @@ class BrowserCaptureManager {
         s.url = result.url;
         s.title = result.title;
         if (result.url && result.url !== 'about:blank')
-            this.rememberUrl(s, result.url);
+            this.setLastUrl(result.url);
         this.broadcastControl(s, { type: 'nav', url: result.url, title: result.title });
     }
-    /** Desktop's "last URL" is a Desktop convenience; a phone's preview of a
-     *  loopback origin must never become the next Desktop session's start page. */
-    rememberUrl(s, url) {
-        if (s.owner.kind === 'desktop')
-            this.setLastUrl(url);
-    }
-    currentPreviewOrigins(fresh = false) {
-        const at = this.now();
-        if (!fresh && this.previewOriginsCache && at - this.previewOriginsCache.at < PREVIEW_ORIGINS_TTL_MS) {
-            return this.previewOriginsCache.origins;
-        }
-        let origins;
-        try {
-            origins = this.previewOrigins();
-        }
-        catch {
-            origins = new Set();
-        }
-        this.previewOriginsCache = { at, origins };
-        return origins;
-    }
-    /** The request guard of device-owned pages (documents + subresources). */
-    allowDeviceRequest(url) {
-        return (0, preview_origins_1.isPreviewRequestAllowed)(url, this.currentPreviewOrigins(), browser_playwright_1.isNavigableUrl);
-    }
     // ─── Popup support (OAuth login windows etc.) ───────────────────────────────
     topPopup(s) {
         return s.popups.length > 0 ? s.popups[s.popups.length - 1] : null;
@@ -379,22 +299,6 @@ class BrowserCaptureManager {
             void popup.close().catch(() => { });
             return;
         }
-        if (s.owner.kind === 'device') {
-            // A popup is a new page: install the same guard, and close one that was
-            // opened straight onto a forbidden URL before the guard could see it.
-            const opened = popup.currentUrl();
-            if (opened && opened !== 'about:blank' && !this.allowDeviceRequest(opened)) {
-                void popup.close().catch(() => { });
-                return;
-            }
-            if (!popup.setRequestGuard) {
-                void popup.close().catch(() => { });
-                return;
-            }
-            void popup.setRequestGuard((url) => this.allowDeviceRequest(url)).catch(() => {
-                void popup.close().catch(() => { });
-            });
-        }
         s.popups.push(popup);
         s.popupView = true;
         // Popups inherit the session viewport so coordinate mapping + screencast
@@ -649,7 +553,7 @@ class BrowserCaptureManager {
                 s.url = result.url;
                 s.title = result.title;
                 if (result.url && result.url !== 'about:blank')
-                    this.rememberUrl(s, result.url);
+                    this.setLastUrl(result.url);
                 this.broadcastControl(s, { type: 'nav', url: result.url, title: result.title });
             }
             return result;
@@ -971,33 +875,6 @@ class BrowserCaptureManager {
         this.context = null;
         this.contextPromise = null;
     }
-    /** Owner of a live session, or null when it does not exist. */
-    sessionOwner(sessionId) {
-        return this.getSession(sessionId)?.owner ?? null;
-    }
-    /**
-     * Manual navigation from a device: the session must belong to that device,
-     * and `goto` only accepts paths on announced origins (the page itself may
-     * still follow public links/redirects through the request guard).
-     */
-    async navigateAsDevice(sessionId, deviceId, action, url) {
-        const owner = this.sessionOwner(sessionId);
-        if (!owner || owner.kind !== 'device' || owner.deviceId !== deviceId)
-            return null;
-        if (action === 'goto' && !(url && (0, preview_origins_1.isManualPreviewUrlAllowed)(url, this.currentPreviewOrigins(true)))) {
-            throw new browser_capture_types_1.BrowserNavigationRejectedError();
-        }
-        return this.navigate(sessionId, action, url);
-    }
-    /** Kill every session a device owns (device revoked / unpaired). */
-    async killDeviceSessions(deviceId) {
-        let killed = 0;
-        for (const s of [...this.sessions.values()]) {
-            if (s.owner.kind === 'device' && s.owner.deviceId === deviceId && await this.kill(s.id))
-                killed += 1;
-        }
-        return killed;
-    }
     sessionCount() {
         return [...this.sessions.values()].filter((s) => !s.closed).length;
     }

package/server/dist/modules/browser/runtime/browser-capture-types.js

@@ -6,7 +6,7 @@
 // no real Chromium. The real Playwright/CDP implementation lives in
 // `browser-playwright.ts` and is the ONLY module that imports `playwright`.
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.BrowserLaunchError = exports.BrowserNavigationRejectedError = exports.BrowserLimitExceededError = void 0;
+exports.BrowserLaunchError = exports.BrowserLimitExceededError = void 0;
 // ─── Error classes (mirror terminal-manager's typed errors) ───────────────────
 class BrowserLimitExceededError extends Error {
     limit;
@@ -17,15 +17,6 @@ class BrowserLimitExceededError extends Error {
     }
 }
 exports.BrowserLimitExceededError = BrowserLimitExceededError;
-/** A device-owned preview session was asked to load a URL its origin policy
- *  rejects (an unannounced loopback port, or any manual non-announced URL). */
-class BrowserNavigationRejectedError extends Error {
-    constructor() {
-        super('browser_navigation_rejected');
-        this.name = 'BrowserNavigationRejectedError';
-    }
-}
-exports.BrowserNavigationRejectedError = BrowserNavigationRejectedError;
 class BrowserLaunchError extends Error {
     cause;
     constructor(message, cause) {

package/server/dist/modules/browser/runtime/browser-playwright.js

@@ -447,25 +447,6 @@ class PlaywrightPageHandle {
             return null;
         }
     }
-    async setRequestGuard(allow) {
-        // Page-scoped (not context-scoped): the shared global context also serves
-        // Desktop sessions, which must keep their own unchanged guard and must not
-        // pay for request interception.
-        await this.page.route('**/*', async (route) => {
-            let url = '';
-            try {
-                url = route.request().url();
-            }
-            catch { /* treat as rejected */ }
-            try {
-                if (url && allow(url))
-                    await route.fallback();
-                else
-                    await route.abort('blockedbyclient');
-            }
-            catch { /* the page or request went away */ }
-        });
-    }
     async enableNetwork() {
         if (this.netEnabled)
             return;

package/server/dist/modules/code/runtime/file-provenance.js

@@ -18,6 +18,7 @@ exports.listProvenanceByTicket = listProvenanceByTicket;
 exports.listProvenanceByPath = listProvenanceByPath;
 exports.broadcastProvenanceUpdated = broadcastProvenanceUpdated;
 const child_process_1 = require("child_process");
+const crypto_1 = require("crypto");
 const fs_1 = __importDefault(require("fs"));
 const path_1 = __importDefault(require("path"));
 const project_repository_provenance_1 = require("../../../project-repository-provenance");
@@ -381,6 +382,20 @@ function recordProvenanceForJob(db, projectId, jobId, ticketId, diff, atMs = Dat
     catch {
         insertContribution = null;
     }
+    // Agent actions audit (migration 73): every provenance row is a write the
+    // run made. Same transaction; guarded like insertPatch so a pre-migration DB
+    // (or an audit insert failure) never affects provenance itself. The hash is
+    // the sha256 of the recorded diff — the file content is never stored.
+    let insertAudit = null;
+    try {
+        insertAudit = db.prepare(`
+      INSERT INTO agent_actions (run_id, job_id, role, kind, target, hash, ts, source)
+      VALUES (?, ?, 'run', 'write', ?, ?, ?, 'file-provenance')
+    `);
+    }
+    catch {
+        insertAudit = null;
+    }
     const inserted = [];
     const tx = db.transaction((rows) => {
         for (const r of rows) {
@@ -395,6 +410,14 @@ function recordProvenanceForJob(db, projectId, jobId, ticketId, diff, atMs = Dat
                 at: atMs,
             });
             const storedPatch = patches?.get(r.file_path);
+            if (insertAudit) {
+                try {
+                    const target = repositoryId === undefined ? r.file_path : `${repositoryId}:${r.file_path}`;
+                    const hash = storedPatch ? (0, crypto_1.createHash)('sha256').update(storedPatch.patch).digest('hex') : null;
+                    insertAudit.run(jobId, jobId, target.slice(0, 512), hash, new Date(atMs).toISOString());
+                }
+                catch { /* audit is observing only */ }
+            }
             if (insertPatch && storedPatch) {
                 insertPatch.run(Number(result.lastInsertRowid), storedPatch.patch, storedPatch.truncated ? 1 : 0);
             }

package/server/dist/modules/conversations/runtime/chat-manager.js

@@ -21,6 +21,7 @@ const spec_draft_parser_1 = require("../../specs/runtime/spec-draft-parser");
 const attachment_manager_1 = require("../../../attachment-manager");
 const providers_1 = require("../../../providers");
 const runtime_1 = require("../../../providers/runtime");
+const project_env_1 = require("../../../project-env");
 const context_scope_1 = require("./context-scope");
 const user_mcp_config_1 = require("../../../user-mcp-config");
 const registry_1 = require("../../../providers/registry");
@@ -954,14 +955,16 @@ class ChatManager {
             // mcp=false keeps its explore-cwd path (no relocation env — it reaches the
             // repo via the explore-cwd `./project` link). Legacy ⇒ process.env
             // (byte-identical).
-            let spawnEnv = process.env;
+            // Agent environment mode: `inherit` keeps the Desktop environment
+            // untouched; `minimal` keeps only the allowlist + passthrough names.
+            let spawnEnv = (0, project_env_1.projectAgentSourceEnv)(this._db, (0, runtime_1.providerEnvAllowlist)(adapter));
             const exploreMcp = conversation.kind === 'explore' &&
                 !!conversationScope?.mcp &&
                 process.env.SPECRAILS_EXPLORE_LEGACY_CWD !== '1';
             if (conversation.kind !== 'explore' || exploreMcp) {
                 const exec = this._resolveNonExploreExecution();
                 if (exec?.relocated) {
-                    spawnEnv = { ...process.env, ...exec.env };
+                    spawnEnv = { ...spawnEnv, ...exec.env };
                     if (adapter.id === 'gemini')
                         spawnEnv = { ...spawnEnv, GEMINI_CLI_TRUST_WORKSPACE: 'true' };
                 }

package/server/dist/modules/delivery/adapters/decisions/chains.js

@@ -82,6 +82,7 @@ async function sweepMergedChainAncestors(deps, mergedRow) {
                 });
                 await (0, ownership_1.deleteOwnedBranchesIfUnchanged)(deps, claimed, snap, cleanupWarnings);
                 const conflict = (0, transitions_1.casTransitionWithTicketEffect)(deps, claimed, 'merged', {
+                    mergedAt: new Date().toISOString(),
                     deliveryOutcome: 'delivered',
                     statusCode: cleanupWarnings.length > 0 ? 'cleanup_incomplete' : 'merged',
                     statusDetail: `merged as part of ${mergedRow.rail_key}`,

package/server/dist/modules/delivery/adapters/decisions/create.js

@@ -6,7 +6,10 @@ const rail_pr_delivery_1 = require("../../runtime/rail-pr-delivery");
 const rail_worktree_release_1 = require("../../runtime/rail-worktree-release");
 const pr_naming_1 = require("../../runtime/pr-naming");
 const pr_body_1 = require("../../runtime/pr-body");
+const delivery_evidence_1 = require("../../runtime/delivery-evidence");
+const review_brief_1 = require("../../runtime/review-brief");
 const ai_invocations_1 = require("../../../accounting/runtime/ai-invocations");
+const review_packet_1 = require("../../runtime/review-packet");
 const rail_pr_store_1 = require("../../runtime/rail-pr-store");
 const retry_1 = require("./retry");
 const evidence_1 = require("./evidence");
@@ -49,6 +52,7 @@ async function runCreatePr(deps, row) {
         if (!sourceSha) {
             const detail = `the verified commit for branch '${unit.branch}' (ticket #${unit.ticketId}) is unavailable; refusing to deliver a mutable or unrelated ref`;
             const conflict = (0, transitions_1.casTransition)(deps, row, 'pr_failed', {
+                decidedAt: (0, transitions_1.decisionInstant)(row),
                 deliveryOutcome: 'blocked', statusCode: 'branch_verification_failed', statusDetail: detail,
             });
             if (conflict)
@@ -98,6 +102,17 @@ async function runCreatePr(deps, row) {
     catch {
         costUsd = null;
     }
+    // Reviewer risk brief (Core `reviewBrief: 1`), read from durable settle
+    // evidence only; absent for older Cores, so the body is unchanged there.
+    let reviewBrief = null;
+    try {
+        const evidence = (0, delivery_evidence_1.readSettleEvidence)(row.settle_evidence);
+        const merged = evidence ? (0, review_brief_1.buildWhatToLookAt)(evidence.units) : null;
+        reviewBrief = merged ? { risks: merged.risks, untested: merged.untested, humanChecks: merged.humanChecks.map((check) => check.text) } : null;
+    }
+    catch {
+        reviewBrief = null;
+    }
     const title = (0, pr_naming_1.buildPrTitle)(ticketData, { loopName: row.loop_name });
     const body = (0, pr_body_1.buildCanonicalPrBody)({
         loopName: row.loop_name,
@@ -105,12 +120,15 @@ async function runCreatePr(deps, row) {
         tickets: ticketData.map((t) => ({ ...t, branch: branchFor(t.ticketId) })),
         changes,
         costUsd,
+        reviewBrief,
+        derivation: (() => { const d = (0, review_packet_1.packetDerivation)(row, (0, delivery_evidence_1.readSettleEvidence)(row.settle_evidence)); return d?.status === 'available' ? d : null; })(),
     });
     let next;
     // Underlying git/gh failure detail for a degraded or failed delivery —
     // relayed on the response and persisted as bounded secondary diagnostics.
     let detail = null;
-    const patch = {};
+    // The click on Create PR is the human decision, whatever the outcome.
+    const patch = { decidedAt: (0, transitions_1.decisionInstant)(row) };
     if (branchEvidenceCaptured)
         patch.branches = effectiveBranches;
     try {

package/server/dist/modules/delivery/adapters/decisions/discard.js

@@ -154,6 +154,7 @@ async function runDiscard(deps, row, opts = { removeNeedsReview: true }) {
         }
     }
     const terminalPatch = {
+        decidedAt: (0, transitions_1.decisionInstant)(row),
         deliveryOutcome: 'not_started',
         statusCode: cleanupWarnings.length > 0 ? 'cleanup_incomplete' : 'discarded',
         cleanupWarnings,
@@ -225,6 +226,7 @@ async function runAcknowledgeNoChanges(deps, row) {
         }
     }
     const conflict = (0, transitions_1.casTransitionWithTicketEffect)(deps, row, 'completed', {
+        decidedAt: (0, transitions_1.decisionInstant)(row),
         deliveryOutcome: 'no_changes',
         statusCode: cleanupWarnings.length > 0 ? 'cleanup_incomplete' : 'no_changes',
         cleanupWarnings,